hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From git-site-r...@apache.org
Subject [04/23] hbase-site git commit: Published site at .
Date Sun, 24 Dec 2017 15:19:12 GMT
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c33bd58a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.html
index e484680..b327ea3 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.html
@@ -82,542 +82,523 @@
 <span class="sourceLineNo">074</span>  private static RSGroupBasedLoadBalancer loadBalancer;<a name="line.74"></a>
 <span class="sourceLineNo">075</span>  private static SecureRandom rand;<a name="line.75"></a>
 <span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span>  static String[]  groups = new String[] { RSGroupInfo.DEFAULT_GROUP, "dg2", "dg3",<a name="line.77"></a>
-<span class="sourceLineNo">078</span>      "dg4" };<a name="line.78"></a>
-<span class="sourceLineNo">079</span>  static TableName[] tables =<a name="line.79"></a>
-<span class="sourceLineNo">080</span>      new TableName[] { TableName.valueOf("dt1"),<a name="line.80"></a>
-<span class="sourceLineNo">081</span>          TableName.valueOf("dt2"),<a name="line.81"></a>
-<span class="sourceLineNo">082</span>          TableName.valueOf("dt3"),<a name="line.82"></a>
-<span class="sourceLineNo">083</span>          TableName.valueOf("dt4")};<a name="line.83"></a>
-<span class="sourceLineNo">084</span>  static List&lt;ServerName&gt; servers;<a name="line.84"></a>
-<span class="sourceLineNo">085</span>  static Map&lt;String, RSGroupInfo&gt; groupMap;<a name="line.85"></a>
-<span class="sourceLineNo">086</span>  static Map&lt;TableName, String&gt; tableMap;<a name="line.86"></a>
-<span class="sourceLineNo">087</span>  static List&lt;HTableDescriptor&gt; tableDescs;<a name="line.87"></a>
-<span class="sourceLineNo">088</span>  int[] regionAssignment = new int[] { 2, 5, 7, 10, 4, 3, 1 };<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  static int regionId = 0;<a name="line.89"></a>
-<span class="sourceLineNo">090</span><a name="line.90"></a>
-<span class="sourceLineNo">091</span>  @BeforeClass<a name="line.91"></a>
-<span class="sourceLineNo">092</span>  public static void beforeAllTests() throws Exception {<a name="line.92"></a>
-<span class="sourceLineNo">093</span>    rand = new SecureRandom();<a name="line.93"></a>
-<span class="sourceLineNo">094</span>    servers = generateServers(7);<a name="line.94"></a>
-<span class="sourceLineNo">095</span>    groupMap = constructGroupInfo(servers, groups);<a name="line.95"></a>
-<span class="sourceLineNo">096</span>    tableMap = new HashMap&lt;&gt;();<a name="line.96"></a>
-<span class="sourceLineNo">097</span>    tableDescs = constructTableDesc();<a name="line.97"></a>
-<span class="sourceLineNo">098</span>    Configuration conf = HBaseConfiguration.create();<a name="line.98"></a>
-<span class="sourceLineNo">099</span>    conf.set("hbase.regions.slop", "0");<a name="line.99"></a>
-<span class="sourceLineNo">100</span>    conf.set("hbase.rsgroup.grouploadbalancer.class", SimpleLoadBalancer.class.getCanonicalName());<a name="line.100"></a>
-<span class="sourceLineNo">101</span>    loadBalancer = new RSGroupBasedLoadBalancer();<a name="line.101"></a>
-<span class="sourceLineNo">102</span>    loadBalancer.setRsGroupInfoManager(getMockedGroupInfoManager());<a name="line.102"></a>
-<span class="sourceLineNo">103</span>    loadBalancer.setMasterServices(getMockedMaster());<a name="line.103"></a>
-<span class="sourceLineNo">104</span>    loadBalancer.setConf(conf);<a name="line.104"></a>
-<span class="sourceLineNo">105</span>    loadBalancer.initialize();<a name="line.105"></a>
-<span class="sourceLineNo">106</span>  }<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span>  /**<a name="line.108"></a>
-<span class="sourceLineNo">109</span>   * Test the load balancing algorithm.<a name="line.109"></a>
-<span class="sourceLineNo">110</span>   *<a name="line.110"></a>
-<span class="sourceLineNo">111</span>   * Invariant is that all servers of the group should be hosting either floor(average) or<a name="line.111"></a>
-<span class="sourceLineNo">112</span>   * ceiling(average)<a name="line.112"></a>
-<span class="sourceLineNo">113</span>   *<a name="line.113"></a>
-<span class="sourceLineNo">114</span>   * @throws Exception<a name="line.114"></a>
-<span class="sourceLineNo">115</span>   */<a name="line.115"></a>
-<span class="sourceLineNo">116</span>  @Test<a name="line.116"></a>
-<span class="sourceLineNo">117</span>  public void testBalanceCluster() throws Exception {<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; servers = mockClusterServers();<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; list = convertToGroupBasedMap(servers);<a name="line.119"></a>
-<span class="sourceLineNo">120</span>    LOG.info("Mock Cluster :  " + printStats(list));<a name="line.120"></a>
-<span class="sourceLineNo">121</span>    List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(servers);<a name="line.121"></a>
-<span class="sourceLineNo">122</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; balancedCluster = reconcile(<a name="line.122"></a>
-<span class="sourceLineNo">123</span>        list, plans);<a name="line.123"></a>
-<span class="sourceLineNo">124</span>    LOG.info("Mock Balance : " + printStats(balancedCluster));<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    assertClusterAsBalanced(balancedCluster);<a name="line.125"></a>
-<span class="sourceLineNo">126</span>  }<a name="line.126"></a>
-<span class="sourceLineNo">127</span><a name="line.127"></a>
-<span class="sourceLineNo">128</span>  /**<a name="line.128"></a>
-<span class="sourceLineNo">129</span>   * Invariant is that all servers of a group have load between floor(avg) and<a name="line.129"></a>
-<span class="sourceLineNo">130</span>   * ceiling(avg) number of regions.<a name="line.130"></a>
-<span class="sourceLineNo">131</span>   */<a name="line.131"></a>
-<span class="sourceLineNo">132</span>  private void assertClusterAsBalanced(<a name="line.132"></a>
-<span class="sourceLineNo">133</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; groupLoadMap) {<a name="line.133"></a>
-<span class="sourceLineNo">134</span>    for (String gName : groupLoadMap.keySet()) {<a name="line.134"></a>
-<span class="sourceLineNo">135</span>      List&lt;ServerAndLoad&gt; groupLoad = groupLoadMap.get(gName);<a name="line.135"></a>
-<span class="sourceLineNo">136</span>      int numServers = groupLoad.size();<a name="line.136"></a>
-<span class="sourceLineNo">137</span>      int numRegions = 0;<a name="line.137"></a>
-<span class="sourceLineNo">138</span>      int maxRegions = 0;<a name="line.138"></a>
-<span class="sourceLineNo">139</span>      int minRegions = Integer.MAX_VALUE;<a name="line.139"></a>
-<span class="sourceLineNo">140</span>      for (ServerAndLoad server : groupLoad) {<a name="line.140"></a>
-<span class="sourceLineNo">141</span>        int nr = server.getLoad();<a name="line.141"></a>
-<span class="sourceLineNo">142</span>        if (nr &gt; maxRegions) {<a name="line.142"></a>
-<span class="sourceLineNo">143</span>          maxRegions = nr;<a name="line.143"></a>
+<span class="sourceLineNo">077</span>  static String[]  groups = new String[] { RSGroupInfo.DEFAULT_GROUP, "dg2", "dg3", "dg4" };<a name="line.77"></a>
+<span class="sourceLineNo">078</span>  static TableName[] tables =<a name="line.78"></a>
+<span class="sourceLineNo">079</span>      new TableName[] { TableName.valueOf("dt1"),<a name="line.79"></a>
+<span class="sourceLineNo">080</span>          TableName.valueOf("dt2"),<a name="line.80"></a>
+<span class="sourceLineNo">081</span>          TableName.valueOf("dt3"),<a name="line.81"></a>
+<span class="sourceLineNo">082</span>          TableName.valueOf("dt4")};<a name="line.82"></a>
+<span class="sourceLineNo">083</span>  static List&lt;ServerName&gt; servers;<a name="line.83"></a>
+<span class="sourceLineNo">084</span>  static Map&lt;String, RSGroupInfo&gt; groupMap;<a name="line.84"></a>
+<span class="sourceLineNo">085</span>  static Map&lt;TableName, String&gt; tableMap;<a name="line.85"></a>
+<span class="sourceLineNo">086</span>  static List&lt;HTableDescriptor&gt; tableDescs;<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  int[] regionAssignment = new int[] { 2, 5, 7, 10, 4, 3, 1 };<a name="line.87"></a>
+<span class="sourceLineNo">088</span>  static int regionId = 0;<a name="line.88"></a>
+<span class="sourceLineNo">089</span><a name="line.89"></a>
+<span class="sourceLineNo">090</span>  @BeforeClass<a name="line.90"></a>
+<span class="sourceLineNo">091</span>  public static void beforeAllTests() throws Exception {<a name="line.91"></a>
+<span class="sourceLineNo">092</span>    rand = new SecureRandom();<a name="line.92"></a>
+<span class="sourceLineNo">093</span>    servers = generateServers(7);<a name="line.93"></a>
+<span class="sourceLineNo">094</span>    groupMap = constructGroupInfo(servers, groups);<a name="line.94"></a>
+<span class="sourceLineNo">095</span>    tableMap = new HashMap&lt;&gt;();<a name="line.95"></a>
+<span class="sourceLineNo">096</span>    tableDescs = constructTableDesc();<a name="line.96"></a>
+<span class="sourceLineNo">097</span>    Configuration conf = HBaseConfiguration.create();<a name="line.97"></a>
+<span class="sourceLineNo">098</span>    conf.set("hbase.regions.slop", "0");<a name="line.98"></a>
+<span class="sourceLineNo">099</span>    conf.set("hbase.rsgroup.grouploadbalancer.class", SimpleLoadBalancer.class.getCanonicalName());<a name="line.99"></a>
+<span class="sourceLineNo">100</span>    loadBalancer = new RSGroupBasedLoadBalancer();<a name="line.100"></a>
+<span class="sourceLineNo">101</span>    loadBalancer.setRsGroupInfoManager(getMockedGroupInfoManager());<a name="line.101"></a>
+<span class="sourceLineNo">102</span>    loadBalancer.setMasterServices(getMockedMaster());<a name="line.102"></a>
+<span class="sourceLineNo">103</span>    loadBalancer.setConf(conf);<a name="line.103"></a>
+<span class="sourceLineNo">104</span>    loadBalancer.initialize();<a name="line.104"></a>
+<span class="sourceLineNo">105</span>  }<a name="line.105"></a>
+<span class="sourceLineNo">106</span><a name="line.106"></a>
+<span class="sourceLineNo">107</span>  /**<a name="line.107"></a>
+<span class="sourceLineNo">108</span>   * Test the load balancing algorithm.<a name="line.108"></a>
+<span class="sourceLineNo">109</span>   *<a name="line.109"></a>
+<span class="sourceLineNo">110</span>   * Invariant is that all servers of the group should be hosting either floor(average) or<a name="line.110"></a>
+<span class="sourceLineNo">111</span>   * ceiling(average)<a name="line.111"></a>
+<span class="sourceLineNo">112</span>   */<a name="line.112"></a>
+<span class="sourceLineNo">113</span>  @Test<a name="line.113"></a>
+<span class="sourceLineNo">114</span>  public void testBalanceCluster() throws Exception {<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; servers = mockClusterServers();<a name="line.115"></a>
+<span class="sourceLineNo">116</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; list = convertToGroupBasedMap(servers);<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    LOG.info("Mock Cluster :  " + printStats(list));<a name="line.117"></a>
+<span class="sourceLineNo">118</span>    List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(servers);<a name="line.118"></a>
+<span class="sourceLineNo">119</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; balancedCluster = reconcile(<a name="line.119"></a>
+<span class="sourceLineNo">120</span>        list, plans);<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    LOG.info("Mock Balance : " + printStats(balancedCluster));<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    assertClusterAsBalanced(balancedCluster);<a name="line.122"></a>
+<span class="sourceLineNo">123</span>  }<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span>  /**<a name="line.125"></a>
+<span class="sourceLineNo">126</span>   * Invariant is that all servers of a group have load between floor(avg) and<a name="line.126"></a>
+<span class="sourceLineNo">127</span>   * ceiling(avg) number of regions.<a name="line.127"></a>
+<span class="sourceLineNo">128</span>   */<a name="line.128"></a>
+<span class="sourceLineNo">129</span>  private void assertClusterAsBalanced(<a name="line.129"></a>
+<span class="sourceLineNo">130</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; groupLoadMap) {<a name="line.130"></a>
+<span class="sourceLineNo">131</span>    for (String gName : groupLoadMap.keySet()) {<a name="line.131"></a>
+<span class="sourceLineNo">132</span>      List&lt;ServerAndLoad&gt; groupLoad = groupLoadMap.get(gName);<a name="line.132"></a>
+<span class="sourceLineNo">133</span>      int numServers = groupLoad.size();<a name="line.133"></a>
+<span class="sourceLineNo">134</span>      int numRegions = 0;<a name="line.134"></a>
+<span class="sourceLineNo">135</span>      int maxRegions = 0;<a name="line.135"></a>
+<span class="sourceLineNo">136</span>      int minRegions = Integer.MAX_VALUE;<a name="line.136"></a>
+<span class="sourceLineNo">137</span>      for (ServerAndLoad server : groupLoad) {<a name="line.137"></a>
+<span class="sourceLineNo">138</span>        int nr = server.getLoad();<a name="line.138"></a>
+<span class="sourceLineNo">139</span>        if (nr &gt; maxRegions) {<a name="line.139"></a>
+<span class="sourceLineNo">140</span>          maxRegions = nr;<a name="line.140"></a>
+<span class="sourceLineNo">141</span>        }<a name="line.141"></a>
+<span class="sourceLineNo">142</span>        if (nr &lt; minRegions) {<a name="line.142"></a>
+<span class="sourceLineNo">143</span>          minRegions = nr;<a name="line.143"></a>
 <span class="sourceLineNo">144</span>        }<a name="line.144"></a>
-<span class="sourceLineNo">145</span>        if (nr &lt; minRegions) {<a name="line.145"></a>
-<span class="sourceLineNo">146</span>          minRegions = nr;<a name="line.146"></a>
-<span class="sourceLineNo">147</span>        }<a name="line.147"></a>
-<span class="sourceLineNo">148</span>        numRegions += nr;<a name="line.148"></a>
-<span class="sourceLineNo">149</span>      }<a name="line.149"></a>
-<span class="sourceLineNo">150</span>      if (maxRegions - minRegions &lt; 2) {<a name="line.150"></a>
-<span class="sourceLineNo">151</span>        // less than 2 between max and min, can't balance<a name="line.151"></a>
-<span class="sourceLineNo">152</span>        return;<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      }<a name="line.153"></a>
-<span class="sourceLineNo">154</span>      int min = numRegions / numServers;<a name="line.154"></a>
-<span class="sourceLineNo">155</span>      int max = numRegions % numServers == 0 ? min : min + 1;<a name="line.155"></a>
-<span class="sourceLineNo">156</span><a name="line.156"></a>
-<span class="sourceLineNo">157</span>      for (ServerAndLoad server : groupLoad) {<a name="line.157"></a>
-<span class="sourceLineNo">158</span>        assertTrue(server.getLoad() &lt;= max);<a name="line.158"></a>
-<span class="sourceLineNo">159</span>        assertTrue(server.getLoad() &gt;= min);<a name="line.159"></a>
-<span class="sourceLineNo">160</span>      }<a name="line.160"></a>
-<span class="sourceLineNo">161</span>    }<a name="line.161"></a>
-<span class="sourceLineNo">162</span>  }<a name="line.162"></a>
-<span class="sourceLineNo">163</span><a name="line.163"></a>
-<span class="sourceLineNo">164</span>  /**<a name="line.164"></a>
-<span class="sourceLineNo">165</span>   * All regions have an assignment.<a name="line.165"></a>
-<span class="sourceLineNo">166</span>   *<a name="line.166"></a>
-<span class="sourceLineNo">167</span>   * @param regions<a name="line.167"></a>
-<span class="sourceLineNo">168</span>   * @param servers<a name="line.168"></a>
-<span class="sourceLineNo">169</span>   * @param assignments<a name="line.169"></a>
-<span class="sourceLineNo">170</span>   * @throws java.io.IOException<a name="line.170"></a>
-<span class="sourceLineNo">171</span>   * @throws java.io.FileNotFoundException<a name="line.171"></a>
-<span class="sourceLineNo">172</span>   */<a name="line.172"></a>
-<span class="sourceLineNo">173</span>  private void assertImmediateAssignment(List&lt;RegionInfo&gt; regions,<a name="line.173"></a>
-<span class="sourceLineNo">174</span>                                         List&lt;ServerName&gt; servers,<a name="line.174"></a>
-<span class="sourceLineNo">175</span>                                         Map&lt;RegionInfo, ServerName&gt; assignments)<a name="line.175"></a>
-<span class="sourceLineNo">176</span>      throws IOException {<a name="line.176"></a>
-<span class="sourceLineNo">177</span>    for (RegionInfo region : regions) {<a name="line.177"></a>
-<span class="sourceLineNo">178</span>      assertTrue(assignments.containsKey(region));<a name="line.178"></a>
-<span class="sourceLineNo">179</span>      ServerName server = assignments.get(region);<a name="line.179"></a>
-<span class="sourceLineNo">180</span>      TableName tableName = region.getTable();<a name="line.180"></a>
-<span class="sourceLineNo">181</span><a name="line.181"></a>
-<span class="sourceLineNo">182</span>      String groupName = getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.182"></a>
-<span class="sourceLineNo">183</span>      assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.183"></a>
-<span class="sourceLineNo">184</span>      RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(groupName);<a name="line.184"></a>
-<span class="sourceLineNo">185</span>      assertTrue("Region is not correctly assigned to group servers.",<a name="line.185"></a>
-<span class="sourceLineNo">186</span>          gInfo.containsServer(server.getAddress()));<a name="line.186"></a>
-<span class="sourceLineNo">187</span>    }<a name="line.187"></a>
-<span class="sourceLineNo">188</span>  }<a name="line.188"></a>
-<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span>  /**<a name="line.190"></a>
-<span class="sourceLineNo">191</span>   * Tests the bulk assignment used during cluster startup.<a name="line.191"></a>
-<span class="sourceLineNo">192</span>   *<a name="line.192"></a>
-<span class="sourceLineNo">193</span>   * Round-robin. Should yield a balanced cluster so same invariant as the<a name="line.193"></a>
-<span class="sourceLineNo">194</span>   * load balancer holds, all servers holding either floor(avg) or<a name="line.194"></a>
-<span class="sourceLineNo">195</span>   * ceiling(avg).<a name="line.195"></a>
-<span class="sourceLineNo">196</span>   *<a name="line.196"></a>
-<span class="sourceLineNo">197</span>   * @throws Exception<a name="line.197"></a>
-<span class="sourceLineNo">198</span>   */<a name="line.198"></a>
-<span class="sourceLineNo">199</span>  @Test<a name="line.199"></a>
-<span class="sourceLineNo">200</span>  public void testBulkAssignment() throws Exception {<a name="line.200"></a>
-<span class="sourceLineNo">201</span>    List&lt;RegionInfo&gt; regions = randomRegions(25);<a name="line.201"></a>
-<span class="sourceLineNo">202</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignments = loadBalancer<a name="line.202"></a>
-<span class="sourceLineNo">203</span>        .roundRobinAssignment(regions, servers);<a name="line.203"></a>
-<span class="sourceLineNo">204</span>    //test empty region/servers scenario<a name="line.204"></a>
-<span class="sourceLineNo">205</span>    //this should not throw an NPE<a name="line.205"></a>
-<span class="sourceLineNo">206</span>    loadBalancer.roundRobinAssignment(regions,<a name="line.206"></a>
-<span class="sourceLineNo">207</span>        Collections.EMPTY_LIST);<a name="line.207"></a>
-<span class="sourceLineNo">208</span>    //test regular scenario<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    assertTrue(assignments.keySet().size() == servers.size());<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    for (ServerName sn : assignments.keySet()) {<a name="line.210"></a>
-<span class="sourceLineNo">211</span>      List&lt;RegionInfo&gt; regionAssigned = assignments.get(sn);<a name="line.211"></a>
-<span class="sourceLineNo">212</span>      for (RegionInfo region : regionAssigned) {<a name="line.212"></a>
-<span class="sourceLineNo">213</span>        TableName tableName = region.getTable();<a name="line.213"></a>
-<span class="sourceLineNo">214</span>        String groupName =<a name="line.214"></a>
-<span class="sourceLineNo">215</span>            getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.215"></a>
-<span class="sourceLineNo">216</span>        assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.216"></a>
-<span class="sourceLineNo">217</span>        RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(<a name="line.217"></a>
-<span class="sourceLineNo">218</span>            groupName);<a name="line.218"></a>
-<span class="sourceLineNo">219</span>        assertTrue(<a name="line.219"></a>
-<span class="sourceLineNo">220</span>            "Region is not correctly assigned to group servers.",<a name="line.220"></a>
-<span class="sourceLineNo">221</span>            gInfo.containsServer(sn.getAddress()));<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      }<a name="line.222"></a>
-<span class="sourceLineNo">223</span>    }<a name="line.223"></a>
-<span class="sourceLineNo">224</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; loadMap = convertToGroupBasedMap(assignments);<a name="line.224"></a>
-<span class="sourceLineNo">225</span>    assertClusterAsBalanced(loadMap);<a name="line.225"></a>
-<span class="sourceLineNo">226</span>  }<a name="line.226"></a>
-<span class="sourceLineNo">227</span><a name="line.227"></a>
-<span class="sourceLineNo">228</span>  /**<a name="line.228"></a>
-<span class="sourceLineNo">229</span>   * Test the cluster startup bulk assignment which attempts to retain<a name="line.229"></a>
-<span class="sourceLineNo">230</span>   * assignment info.<a name="line.230"></a>
-<span class="sourceLineNo">231</span>   *<a name="line.231"></a>
-<span class="sourceLineNo">232</span>   * @throws Exception<a name="line.232"></a>
-<span class="sourceLineNo">233</span>   */<a name="line.233"></a>
-<span class="sourceLineNo">234</span>  @Test<a name="line.234"></a>
-<span class="sourceLineNo">235</span>  public void testRetainAssignment() throws Exception {<a name="line.235"></a>
-<span class="sourceLineNo">236</span>    // Test simple case where all same servers are there<a name="line.236"></a>
-<span class="sourceLineNo">237</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; currentAssignments = mockClusterServers();<a name="line.237"></a>
-<span class="sourceLineNo">238</span>    Map&lt;RegionInfo, ServerName&gt; inputForTest = new HashMap&lt;&gt;();<a name="line.238"></a>
-<span class="sourceLineNo">239</span>    for (ServerName sn : currentAssignments.keySet()) {<a name="line.239"></a>
-<span class="sourceLineNo">240</span>      for (RegionInfo region : currentAssignments.get(sn)) {<a name="line.240"></a>
-<span class="sourceLineNo">241</span>        inputForTest.put(region, sn);<a name="line.241"></a>
-<span class="sourceLineNo">242</span>      }<a name="line.242"></a>
-<span class="sourceLineNo">243</span>    }<a name="line.243"></a>
-<span class="sourceLineNo">244</span>    //verify region-&gt;null server assignment is handled<a name="line.244"></a>
-<span class="sourceLineNo">245</span>    inputForTest.put(randomRegions(1).get(0), null);<a name="line.245"></a>
-<span class="sourceLineNo">246</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; newAssignment = loadBalancer<a name="line.246"></a>
-<span class="sourceLineNo">247</span>        .retainAssignment(inputForTest, servers);<a name="line.247"></a>
-<span class="sourceLineNo">248</span>    assertRetainedAssignment(inputForTest, servers, newAssignment);<a name="line.248"></a>
-<span class="sourceLineNo">249</span>  }<a name="line.249"></a>
-<span class="sourceLineNo">250</span><a name="line.250"></a>
-<span class="sourceLineNo">251</span>  /**<a name="line.251"></a>
-<span class="sourceLineNo">252</span>   * Test BOGUS_SERVER_NAME among groups do not overwrite each other<a name="line.252"></a>
-<span class="sourceLineNo">253</span>   * @throws Exception<a name="line.253"></a>
-<span class="sourceLineNo">254</span>   */<a name="line.254"></a>
-<span class="sourceLineNo">255</span>  @Test<a name="line.255"></a>
-<span class="sourceLineNo">256</span>  public void testRoundRobinAssignment() throws Exception {<a name="line.256"></a>
-<span class="sourceLineNo">257</span>    List&lt;ServerName&gt; onlineServers = new ArrayList&lt;ServerName&gt;(servers.size());<a name="line.257"></a>
-<span class="sourceLineNo">258</span>    onlineServers.addAll(servers);<a name="line.258"></a>
-<span class="sourceLineNo">259</span>    List&lt;RegionInfo&gt; regions = randomRegions(25);<a name="line.259"></a>
-<span class="sourceLineNo">260</span>    int bogusRegion = 0;<a name="line.260"></a>
-<span class="sourceLineNo">261</span>    for(RegionInfo region : regions){<a name="line.261"></a>
-<span class="sourceLineNo">262</span>      String group = tableMap.get(region.getTable());<a name="line.262"></a>
-<span class="sourceLineNo">263</span>      if("dg3".equals(group) || "dg4".equals(group)){<a name="line.263"></a>
-<span class="sourceLineNo">264</span>        bogusRegion++;<a name="line.264"></a>
-<span class="sourceLineNo">265</span>      }<a name="line.265"></a>
-<span class="sourceLineNo">266</span>    }<a name="line.266"></a>
-<span class="sourceLineNo">267</span>    Set&lt;Address&gt; offlineServers = new HashSet&lt;Address&gt;();<a name="line.267"></a>
-<span class="sourceLineNo">268</span>    offlineServers.addAll(groupMap.get("dg3").getServers());<a name="line.268"></a>
-<span class="sourceLineNo">269</span>    offlineServers.addAll(groupMap.get("dg4").getServers());<a name="line.269"></a>
-<span class="sourceLineNo">270</span>    for(Iterator&lt;ServerName&gt; it =  onlineServers.iterator(); it.hasNext();){<a name="line.270"></a>
-<span class="sourceLineNo">271</span>      ServerName server = it.next();<a name="line.271"></a>
-<span class="sourceLineNo">272</span>      Address address = server.getAddress();<a name="line.272"></a>
-<span class="sourceLineNo">273</span>      if(offlineServers.contains(address)){<a name="line.273"></a>
-<span class="sourceLineNo">274</span>        it.remove();<a name="line.274"></a>
-<span class="sourceLineNo">275</span>      }<a name="line.275"></a>
-<span class="sourceLineNo">276</span>    }<a name="line.276"></a>
-<span class="sourceLineNo">277</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignments = loadBalancer<a name="line.277"></a>
-<span class="sourceLineNo">278</span>        .roundRobinAssignment(regions, onlineServers);<a name="line.278"></a>
-<span class="sourceLineNo">279</span>    assertEquals(bogusRegion, assignments.get(LoadBalancer.BOGUS_SERVER_NAME).size());<a name="line.279"></a>
-<span class="sourceLineNo">280</span>  }<a name="line.280"></a>
-<span class="sourceLineNo">281</span><a name="line.281"></a>
-<span class="sourceLineNo">282</span>  /**<a name="line.282"></a>
-<span class="sourceLineNo">283</span>   * Asserts a valid retained assignment plan.<a name="line.283"></a>
-<span class="sourceLineNo">284</span>   * &lt;p&gt;<a name="line.284"></a>
-<span class="sourceLineNo">285</span>   * Must meet the following conditions:<a name="line.285"></a>
-<span class="sourceLineNo">286</span>   * &lt;ul&gt;<a name="line.286"></a>
-<span class="sourceLineNo">287</span>   * &lt;li&gt;Every input region has an assignment, and to an online server<a name="line.287"></a>
-<span class="sourceLineNo">288</span>   * &lt;li&gt;If a region had an existing assignment to a server with the same<a name="line.288"></a>
-<span class="sourceLineNo">289</span>   * address a a currently online server, it will be assigned to it<a name="line.289"></a>
-<span class="sourceLineNo">290</span>   * &lt;/ul&gt;<a name="line.290"></a>
-<span class="sourceLineNo">291</span>   *<a name="line.291"></a>
-<span class="sourceLineNo">292</span>   * @param existing<a name="line.292"></a>
-<span class="sourceLineNo">293</span>   * @param assignment<a name="line.293"></a>
-<span class="sourceLineNo">294</span>   * @throws java.io.IOException<a name="line.294"></a>
-<span class="sourceLineNo">295</span>   * @throws java.io.FileNotFoundException<a name="line.295"></a>
-<span class="sourceLineNo">296</span>   */<a name="line.296"></a>
-<span class="sourceLineNo">297</span>  private void assertRetainedAssignment(<a name="line.297"></a>
-<span class="sourceLineNo">298</span>      Map&lt;RegionInfo, ServerName&gt; existing, List&lt;ServerName&gt; servers,<a name="line.298"></a>
-<span class="sourceLineNo">299</span>      Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignment)<a name="line.299"></a>
-<span class="sourceLineNo">300</span>      throws FileNotFoundException, IOException {<a name="line.300"></a>
-<span class="sourceLineNo">301</span>    // Verify condition 1, every region assigned, and to online server<a name="line.301"></a>
-<span class="sourceLineNo">302</span>    Set&lt;ServerName&gt; onlineServerSet = new TreeSet&lt;&gt;(servers);<a name="line.302"></a>
-<span class="sourceLineNo">303</span>    Set&lt;RegionInfo&gt; assignedRegions = new TreeSet&lt;&gt;(RegionInfo.COMPARATOR);<a name="line.303"></a>
-<span class="sourceLineNo">304</span>    for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; a : assignment.entrySet()) {<a name="line.304"></a>
-<span class="sourceLineNo">305</span>      assertTrue(<a name="line.305"></a>
-<span class="sourceLineNo">306</span>          "Region assigned to server that was not listed as online",<a name="line.306"></a>
-<span class="sourceLineNo">307</span>          onlineServerSet.contains(a.getKey()));<a name="line.307"></a>
-<span class="sourceLineNo">308</span>      for (RegionInfo r : a.getValue())<a name="line.308"></a>
-<span class="sourceLineNo">309</span>        assignedRegions.add(r);<a name="line.309"></a>
-<span class="sourceLineNo">310</span>    }<a name="line.310"></a>
-<span class="sourceLineNo">311</span>    assertEquals(existing.size(), assignedRegions.size());<a name="line.311"></a>
-<span class="sourceLineNo">312</span><a name="line.312"></a>
-<span class="sourceLineNo">313</span>    // Verify condition 2, every region must be assigned to correct server.<a name="line.313"></a>
-<span class="sourceLineNo">314</span>    Set&lt;String&gt; onlineHostNames = new TreeSet&lt;&gt;();<a name="line.314"></a>
-<span class="sourceLineNo">315</span>    for (ServerName s : servers) {<a name="line.315"></a>
-<span class="sourceLineNo">316</span>      onlineHostNames.add(s.getHostname());<a name="line.316"></a>
-<span class="sourceLineNo">317</span>    }<a name="line.317"></a>
-<span class="sourceLineNo">318</span><a name="line.318"></a>
-<span class="sourceLineNo">319</span>    for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; a : assignment.entrySet()) {<a name="line.319"></a>
-<span class="sourceLineNo">320</span>      ServerName currentServer = a.getKey();<a name="line.320"></a>
-<span class="sourceLineNo">321</span>      for (RegionInfo r : a.getValue()) {<a name="line.321"></a>
-<span class="sourceLineNo">322</span>        ServerName oldAssignedServer = existing.get(r);<a name="line.322"></a>
-<span class="sourceLineNo">323</span>        TableName tableName = r.getTable();<a name="line.323"></a>
-<span class="sourceLineNo">324</span>        String groupName =<a name="line.324"></a>
-<span class="sourceLineNo">325</span>            getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.325"></a>
-<span class="sourceLineNo">326</span>        assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.326"></a>
-<span class="sourceLineNo">327</span>        RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(<a name="line.327"></a>
-<span class="sourceLineNo">328</span>            groupName);<a name="line.328"></a>
-<span class="sourceLineNo">329</span>        assertTrue(<a name="line.329"></a>
-<span class="sourceLineNo">330</span>            "Region is not correctly assigned to group servers.",<a name="line.330"></a>
-<span class="sourceLineNo">331</span>            gInfo.containsServer(currentServer.getAddress()));<a name="line.331"></a>
-<span class="sourceLineNo">332</span>        if (oldAssignedServer != null<a name="line.332"></a>
-<span class="sourceLineNo">333</span>            &amp;&amp; onlineHostNames.contains(oldAssignedServer<a name="line.333"></a>
-<span class="sourceLineNo">334</span>            .getHostname())) {<a name="line.334"></a>
-<span class="sourceLineNo">335</span>          // this region was previously assigned somewhere, and that<a name="line.335"></a>
-<span class="sourceLineNo">336</span>          // host is still around, then the host must have been is a<a name="line.336"></a>
-<span class="sourceLineNo">337</span>          // different group.<a name="line.337"></a>
-<span class="sourceLineNo">338</span>          if (!oldAssignedServer.getAddress().equals(currentServer.getAddress())) {<a name="line.338"></a>
-<span class="sourceLineNo">339</span>            assertFalse(gInfo.containsServer(oldAssignedServer.getAddress()));<a name="line.339"></a>
-<span class="sourceLineNo">340</span>          }<a name="line.340"></a>
-<span class="sourceLineNo">341</span>        }<a name="line.341"></a>
-<span class="sourceLineNo">342</span>      }<a name="line.342"></a>
-<span class="sourceLineNo">343</span>    }<a name="line.343"></a>
-<span class="sourceLineNo">344</span>  }<a name="line.344"></a>
-<span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span>  private String printStats(<a name="line.346"></a>
-<span class="sourceLineNo">347</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; groupBasedLoad) {<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    StringBuffer sb = new StringBuffer();<a name="line.348"></a>
-<span class="sourceLineNo">349</span>    sb.append("\n");<a name="line.349"></a>
-<span class="sourceLineNo">350</span>    for (String groupName : groupBasedLoad.keySet()) {<a name="line.350"></a>
-<span class="sourceLineNo">351</span>      sb.append("Stats for group: " + groupName);<a name="line.351"></a>
-<span class="sourceLineNo">352</span>      sb.append("\n");<a name="line.352"></a>
-<span class="sourceLineNo">353</span>      sb.append(groupMap.get(groupName).getServers());<a name="line.353"></a>
-<span class="sourceLineNo">354</span>      sb.append("\n");<a name="line.354"></a>
-<span class="sourceLineNo">355</span>      List&lt;ServerAndLoad&gt; groupLoad = groupBasedLoad.get(groupName);<a name="line.355"></a>
-<span class="sourceLineNo">356</span>      int numServers = groupLoad.size();<a name="line.356"></a>
-<span class="sourceLineNo">357</span>      int totalRegions = 0;<a name="line.357"></a>
-<span class="sourceLineNo">358</span>      sb.append("Per Server Load: \n");<a name="line.358"></a>
-<span class="sourceLineNo">359</span>      for (ServerAndLoad sLoad : groupLoad) {<a name="line.359"></a>
-<span class="sourceLineNo">360</span>        sb.append("Server :" + sLoad.getServerName() + " Load : "<a name="line.360"></a>
-<span class="sourceLineNo">361</span>            + sLoad.getLoad() + "\n");<a name="line.361"></a>
-<span class="sourceLineNo">362</span>        totalRegions += sLoad.getLoad();<a name="line.362"></a>
-<span class="sourceLineNo">363</span>      }<a name="line.363"></a>
-<span class="sourceLineNo">364</span>      sb.append(" Group Statistics : \n");<a name="line.364"></a>
-<span class="sourceLineNo">365</span>      float average = (float) totalRegions / numServers;<a name="line.365"></a>
-<span class="sourceLineNo">366</span>      int max = (int) Math.ceil(average);<a name="line.366"></a>
-<span class="sourceLineNo">367</span>      int min = (int) Math.floor(average);<a name="line.367"></a>
-<span class="sourceLineNo">368</span>      sb.append("[srvr=" + numServers + " rgns=" + totalRegions + " avg="<a name="line.368"></a>
-<span class="sourceLineNo">369</span>          + average + " max=" + max + " min=" + min + "]");<a name="line.369"></a>
-<span class="sourceLineNo">370</span>      sb.append("\n");<a name="line.370"></a>
-<span class="sourceLineNo">371</span>      sb.append("===============================");<a name="line.371"></a>
-<span class="sourceLineNo">372</span>      sb.append("\n");<a name="line.372"></a>
-<span class="sourceLineNo">373</span>    }<a name="line.373"></a>
-<span class="sourceLineNo">374</span>    return sb.toString();<a name="line.374"></a>
-<span class="sourceLineNo">375</span>  }<a name="line.375"></a>
-<span class="sourceLineNo">376</span><a name="line.376"></a>
-<span class="sourceLineNo">377</span>  private ArrayListMultimap&lt;String, ServerAndLoad&gt; convertToGroupBasedMap(<a name="line.377"></a>
-<span class="sourceLineNo">378</span>      final Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serversMap) throws IOException {<a name="line.378"></a>
-<span class="sourceLineNo">379</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; loadMap = ArrayListMultimap<a name="line.379"></a>
-<span class="sourceLineNo">380</span>        .create();<a name="line.380"></a>
-<span class="sourceLineNo">381</span>    for (RSGroupInfo gInfo : getMockedGroupInfoManager().listRSGroups()) {<a name="line.381"></a>
-<span class="sourceLineNo">382</span>      Set&lt;Address&gt; groupServers = gInfo.getServers();<a name="line.382"></a>
-<span class="sourceLineNo">383</span>      for (Address hostPort : groupServers) {<a name="line.383"></a>
-<span class="sourceLineNo">384</span>        ServerName actual = null;<a name="line.384"></a>
-<span class="sourceLineNo">385</span>        for(ServerName entry: servers) {<a name="line.385"></a>
-<span class="sourceLineNo">386</span>          if(entry.getAddress().equals(hostPort)) {<a name="line.386"></a>
-<span class="sourceLineNo">387</span>            actual = entry;<a name="line.387"></a>
-<span class="sourceLineNo">388</span>            break;<a name="line.388"></a>
-<span class="sourceLineNo">389</span>          }<a name="line.389"></a>
-<span class="sourceLineNo">390</span>        }<a name="line.390"></a>
-<span class="sourceLineNo">391</span>        List&lt;RegionInfo&gt; regions = serversMap.get(actual);<a name="line.391"></a>
-<span class="sourceLineNo">392</span>        assertTrue("No load for " + actual, regions != null);<a name="line.392"></a>
-<span class="sourceLineNo">393</span>        loadMap.put(gInfo.getName(),<a name="line.393"></a>
-<span class="sourceLineNo">394</span>            new ServerAndLoad(actual, regions.size()));<a name="line.394"></a>
-<span class="sourceLineNo">395</span>      }<a name="line.395"></a>
-<span class="sourceLineNo">396</span>    }<a name="line.396"></a>
-<span class="sourceLineNo">397</span>    return loadMap;<a name="line.397"></a>
-<span class="sourceLineNo">398</span>  }<a name="line.398"></a>
-<span class="sourceLineNo">399</span><a name="line.399"></a>
-<span class="sourceLineNo">400</span>  private ArrayListMultimap&lt;String, ServerAndLoad&gt; reconcile(<a name="line.400"></a>
-<span class="sourceLineNo">401</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; previousLoad,<a name="line.401"></a>
-<span class="sourceLineNo">402</span>      List&lt;RegionPlan&gt; plans) {<a name="line.402"></a>
-<span class="sourceLineNo">403</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; result = ArrayListMultimap<a name="line.403"></a>
-<span class="sourceLineNo">404</span>        .create();<a name="line.404"></a>
-<span class="sourceLineNo">405</span>    result.putAll(previousLoad);<a name="line.405"></a>
-<span class="sourceLineNo">406</span>    if (plans != null) {<a name="line.406"></a>
-<span class="sourceLineNo">407</span>      for (RegionPlan plan : plans) {<a name="line.407"></a>
-<span class="sourceLineNo">408</span>        ServerName source = plan.getSource();<a name="line.408"></a>
-<span class="sourceLineNo">409</span>        updateLoad(result, source, -1);<a name="line.409"></a>
-<span class="sourceLineNo">410</span>        ServerName destination = plan.getDestination();<a name="line.410"></a>
-<span class="sourceLineNo">411</span>        updateLoad(result, destination, +1);<a name="line.411"></a>
-<span class="sourceLineNo">412</span>      }<a name="line.412"></a>
-<span class="sourceLineNo">413</span>    }<a name="line.413"></a>
-<span class="sourceLineNo">414</span>    return result;<a name="line.414"></a>
-<span class="sourceLineNo">415</span>  }<a name="line.415"></a>
-<span class="sourceLineNo">416</span><a name="line.416"></a>
-<span class="sourceLineNo">417</span>  private void updateLoad(<a name="line.417"></a>
-<span class="sourceLineNo">418</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; previousLoad,<a name="line.418"></a>
-<span class="sourceLineNo">419</span>      final ServerName sn, final int diff) {<a name="line.419"></a>
-<span class="sourceLineNo">420</span>    for (String groupName : previousLoad.keySet()) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span>      ServerAndLoad newSAL = null;<a name="line.421"></a>
-<span class="sourceLineNo">422</span>      ServerAndLoad oldSAL = null;<a name="line.422"></a>
-<span class="sourceLineNo">423</span>      for (ServerAndLoad sal : previousLoad.get(groupName)) {<a name="line.423"></a>
-<span class="sourceLineNo">424</span>        if (ServerName.isSameAddress(sn, sal.getServerName())) {<a name="line.424"></a>
-<span class="sourceLineNo">425</span>          oldSAL = sal;<a name="line.425"></a>
-<span class="sourceLineNo">426</span>          newSAL = new ServerAndLoad(sn, sal.getLoad() + diff);<a name="line.426"></a>
-<span class="sourceLineNo">427</span>          break;<a name="line.427"></a>
-<span class="sourceLineNo">428</span>        }<a name="line.428"></a>
-<span class="sourceLineNo">429</span>      }<a name="line.429"></a>
-<span class="sourceLineNo">430</span>      if (newSAL != null) {<a name="line.430"></a>
-<span class="sourceLineNo">431</span>        previousLoad.remove(groupName, oldSAL);<a name="line.431"></a>
-<span class="sourceLineNo">432</span>        previousLoad.put(groupName, newSAL);<a name="line.432"></a>
-<span class="sourceLineNo">433</span>        break;<a name="line.433"></a>
-<span class="sourceLineNo">434</span>      }<a name="line.434"></a>
-<span class="sourceLineNo">435</span>    }<a name="line.435"></a>
-<span class="sourceLineNo">436</span>  }<a name="line.436"></a>
-<span class="sourceLineNo">437</span><a name="line.437"></a>
-<span class="sourceLineNo">438</span>  private Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; mockClusterServers() throws IOException {<a name="line.438"></a>
-<span class="sourceLineNo">439</span>    assertTrue(servers.size() == regionAssignment.length);<a name="line.439"></a>
-<span class="sourceLineNo">440</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignment = new TreeMap&lt;&gt;();<a name="line.440"></a>
-<span class="sourceLineNo">441</span>    for (int i = 0; i &lt; servers.size(); i++) {<a name="line.441"></a>
-<span class="sourceLineNo">442</span>      int numRegions = regionAssignment[i];<a name="line.442"></a>
-<span class="sourceLineNo">443</span>      List&lt;RegionInfo&gt; regions = assignedRegions(numRegions, servers.get(i));<a name="line.443"></a>
-<span class="sourceLineNo">444</span>      assignment.put(servers.get(i), regions);<a name="line.444"></a>
-<span class="sourceLineNo">445</span>    }<a name="line.445"></a>
-<span class="sourceLineNo">446</span>    return assignment;<a name="line.446"></a>
-<span class="sourceLineNo">447</span>  }<a name="line.447"></a>
-<span class="sourceLineNo">448</span><a name="line.448"></a>
-<span class="sourceLineNo">449</span>  /**<a name="line.449"></a>
-<span class="sourceLineNo">450</span>   * Generate a list of regions evenly distributed between the tables.<a name="line.450"></a>
-<span class="sourceLineNo">451</span>   *<a name="line.451"></a>
-<span class="sourceLineNo">452</span>   * @param numRegions The number of regions to be generated.<a name="line.452"></a>
-<span class="sourceLineNo">453</span>   * @return List of RegionInfo.<a name="line.453"></a>
-<span class="sourceLineNo">454</span>   */<a name="line.454"></a>
-<span class="sourceLineNo">455</span>  private List&lt;RegionInfo&gt; randomRegions(int numRegions) {<a name="line.455"></a>
-<span class="sourceLineNo">456</span>    List&lt;RegionInfo&gt; regions = new ArrayList&lt;&gt;(numRegions);<a name="line.456"></a>
-<span class="sourceLineNo">457</span>    byte[] start = new byte[16];<a name="line.457"></a>
-<span class="sourceLineNo">458</span>    byte[] end = new byte[16];<a name="line.458"></a>
-<span class="sourceLineNo">459</span>    rand.nextBytes(start);<a name="line.459"></a>
-<span class="sourceLineNo">460</span>    rand.nextBytes(end);<a name="line.460"></a>
-<span class="sourceLineNo">461</span>    int regionIdx = rand.nextInt(tables.length);<a name="line.461"></a>
-<span class="sourceLineNo">462</span>    for (int i = 0; i &lt; numRegions; i++) {<a name="line.462"></a>
-<span class="sourceLineNo">463</span>      Bytes.putInt(start, 0, numRegions &lt;&lt; 1);<a name="line.463"></a>
-<span class="sourceLineNo">464</span>      Bytes.putInt(end, 0, (numRegions &lt;&lt; 1) + 1);<a name="line.464"></a>
-<span class="sourceLineNo">465</span>      int tableIndex = (i + regionIdx) % tables.length;<a name="line.465"></a>
-<span class="sourceLineNo">466</span>      regions.add(RegionInfoBuilder.newBuilder(tables[tableIndex])<a name="line.466"></a>
-<span class="sourceLineNo">467</span>          .setStartKey(start)<a name="line.467"></a>
-<span class="sourceLineNo">468</span>          .setEndKey(end)<a name="line.468"></a>
-<span class="sourceLineNo">469</span>          .setSplit(false)<a name="line.469"></a>
-<span class="sourceLineNo">470</span>          .setRegionId(regionId++)<a name="line.470"></a>
-<span class="sourceLineNo">471</span>          .build());<a name="line.471"></a>
-<span class="sourceLineNo">472</span>    }<a name="line.472"></a>
-<span class="sourceLineNo">473</span>    return regions;<a name="line.473"></a>
-<span class="sourceLineNo">474</span>  }<a name="line.474"></a>
-<span class="sourceLineNo">475</span><a name="line.475"></a>
-<span class="sourceLineNo">476</span>  /**<a name="line.476"></a>
-<span class="sourceLineNo">477</span>   * Generate assigned regions to a given server using group information.<a name="line.477"></a>
-<span class="sourceLineNo">478</span>   *<a name="line.478"></a>
-<span class="sourceLineNo">479</span>   * @param numRegions the num regions to generate<a name="line.479"></a>
-<span class="sourceLineNo">480</span>   * @param sn the servername<a name="line.480"></a>
-<span class="sourceLineNo">481</span>   * @return the list of regions<a name="line.481"></a>
-<span class="sourceLineNo">482</span>   * @throws java.io.IOException Signals that an I/O exception has occurred.<a name="line.482"></a>
-<span class="sourceLineNo">483</span>   */<a name="line.483"></a>
-<span class="sourceLineNo">484</span>  private List&lt;RegionInfo&gt; assignedRegions(int numRegions, ServerName sn) throws IOException {<a name="line.484"></a>
-<span class="sourceLineNo">485</span>    List&lt;RegionInfo&gt; regions = new ArrayList&lt;&gt;(numRegions);<a name="line.485"></a>
-<span class="sourceLineNo">486</span>    byte[] start = new byte[16];<a name="line.486"></a>
-<span class="sourceLineNo">487</span>    byte[] end = new byte[16];<a name="line.487"></a>
-<span class="sourceLineNo">488</span>    Bytes.putInt(start, 0, numRegions &lt;&lt; 1);<a name="line.488"></a>
-<span class="sourceLineNo">489</span>    Bytes.putInt(end, 0, (numRegions &lt;&lt; 1) + 1);<a name="line.489"></a>
-<span class="sourceLineNo">490</span>    for (int i = 0; i &lt; numRegions; i++) {<a name="line.490"></a>
-<span class="sourceLineNo">491</span>      TableName tableName = getTableName(sn);<a name="line.491"></a>
-<span class="sourceLineNo">492</span>      regions.add(RegionInfoBuilder.newBuilder(tableName)<a name="line.492"></a>
-<span class="sourceLineNo">493</span>          .setStartKey(start)<a name="line.493"></a>
-<span class="sourceLineNo">494</span>          .setEndKey(end)<a name="line.494"></a>
-<span class="sourceLineNo">495</span>          .setSplit(false)<a name="line.495"></a>
-<span class="sourceLineNo">496</span>          .setRegionId(regionId++)<a name="line.496"></a>
-<span class="sourceLineNo">497</span>          .build());<a name="line.497"></a>
-<span class="sourceLineNo">498</span>    }<a name="line.498"></a>
-<span class="sourceLineNo">499</span>    return regions;<a name="line.499"></a>
-<span class="sourceLineNo">500</span>  }<a name="line.500"></a>
-<span class="sourceLineNo">501</span><a name="line.501"></a>
-<span class="sourceLineNo">502</span>  private static List&lt;ServerName&gt; generateServers(int numServers) {<a name="line.502"></a>
-<span class="sourceLineNo">503</span>    List&lt;ServerName&gt; servers = new ArrayList&lt;&gt;(numServers);<a name="line.503"></a>
-<span class="sourceLineNo">504</span>    for (int i = 0; i &lt; numServers; i++) {<a name="line.504"></a>
-<span class="sourceLineNo">505</span>      String host = "server" + rand.nextInt(100000);<a name="line.505"></a>
-<span class="sourceLineNo">506</span>      int port = rand.nextInt(60000);<a name="line.506"></a>
-<span class="sourceLineNo">507</span>      servers.add(ServerName.valueOf(host, port, -1));<a name="line.507"></a>
-<span class="sourceLineNo">508</span>    }<a name="line.508"></a>
-<span class="sourceLineNo">509</span>    return servers;<a name="line.509"></a>
-<span class="sourceLineNo">510</span>  }<a name="line.510"></a>
-<span class="sourceLineNo">511</span><a name="line.511"></a>
-<span class="sourceLineNo">512</span>  /**<a name="line.512"></a>
-<span class="sourceLineNo">513</span>   * Construct group info, with each group having at least one server.<a name="line.513"></a>
-<span class="sourceLineNo">514</span>   *<a name="line.514"></a>
-<span class="sourceLineNo">515</span>   * @param servers the servers<a name="line.515"></a>
-<span class="sourceLineNo">516</span>   * @param groups the groups<a name="line.516"></a>
-<span class="sourceLineNo">517</span>   * @return the map<a name="line.517"></a>
-<span class="sourceLineNo">518</span>   */<a name="line.518"></a>
-<span class="sourceLineNo">519</span>  private static Map&lt;String, RSGroupInfo&gt; constructGroupInfo(<a name="line.519"></a>
-<span class="sourceLineNo">520</span>      List&lt;ServerName&gt; servers, String[] groups) {<a name="line.520"></a>
-<span class="sourceLineNo">521</span>    assertTrue(servers != null);<a name="line.521"></a>
-<span class="sourceLineNo">522</span>    assertTrue(servers.size() &gt;= groups.length);<a name="line.522"></a>
-<span class="sourceLineNo">523</span>    int index = 0;<a name="line.523"></a>
-<span class="sourceLineNo">524</span>    Map&lt;String, RSGroupInfo&gt; groupMap = new HashMap&lt;&gt;();<a name="line.524"></a>
-<span class="sourceLineNo">525</span>    for (String grpName : groups) {<a name="line.525"></a>
-<span class="sourceLineNo">526</span>      RSGroupInfo RSGroupInfo = new RSGroupInfo(grpName);<a name="line.526"></a>
-<span class="sourceLineNo">527</span>      RSGroupInfo.addServer(servers.get(index).getAddress());<a name="line.527"></a>
-<span class="sourceLineNo">528</span>      groupMap.put(grpName, RSGroupInfo);<a name="line.528"></a>
-<span class="sourceLineNo">529</span>      index++;<a name="line.529"></a>
-<span class="sourceLineNo">530</span>    }<a name="line.530"></a>
-<span class="sourceLineNo">531</span>    while (index &lt; servers.size()) {<a name="line.531"></a>
-<span class="sourceLineNo">532</span>      int grpIndex = rand.nextInt(groups.length);<a name="line.532"></a>
-<span class="sourceLineNo">533</span>      groupMap.get(groups[grpIndex]).addServer(<a name="line.533"></a>
-<span class="sourceLineNo">534</span>          servers.get(index).getAddress());<a name="line.534"></a>
-<span class="sourceLineNo">535</span>      index++;<a name="line.535"></a>
-<span class="sourceLineNo">536</span>    }<a name="line.536"></a>
-<span class="sourceLineNo">537</span>    return groupMap;<a name="line.537"></a>
-<span class="sourceLineNo">538</span>  }<a name="line.538"></a>
-<span class="sourceLineNo">539</span><a name="line.539"></a>
-<span class="sourceLineNo">540</span>  /**<a name="line.540"></a>
-<span class="sourceLineNo">541</span>   * Construct table descriptors evenly distributed between the groups.<a name="line.541"></a>
-<span class="sourceLineNo">542</span>   *<a name="line.542"></a>
-<span class="sourceLineNo">543</span>   * @return the list<a name="line.543"></a>
-<span class="sourceLineNo">544</span>   */<a name="line.544"></a>
-<span class="sourceLineNo">545</span>  private static List&lt;HTableDescriptor&gt; constructTableDesc() {<a name="line.545"></a>
-<span class="sourceLineNo">546</span>    List&lt;HTableDescriptor&gt; tds = Lists.newArrayList();<a name="line.546"></a>
-<span class="sourceLineNo">547</span>    int index = rand.nextInt(groups.length);<a name="line.547"></a>
-<span class="sourceLineNo">548</span>    for (int i = 0; i &lt; tables.length; i++) {<a name="line.548"></a>
-<span class="sourceLineNo">549</span>      HTableDescriptor htd = new HTableDescriptor(tables[i]);<a name="line.549"></a>
-<span class="sourceLineNo">550</span>      int grpIndex = (i + index) % groups.length ;<a name="line.550"></a>
-<span class="sourceLineNo">551</span>      String groupName = groups[grpIndex];<a name="line.551"></a>
-<span class="sourceLineNo">552</span>      tableMap.put(tables[i], groupName);<a name="line.552"></a>
-<span class="sourceLineNo">553</span>      tds.add(htd);<a name="line.553"></a>
-<span class="sourceLineNo">554</span>    }<a name="line.554"></a>
-<span class="sourceLineNo">555</span>    return tds;<a name="line.555"></a>
-<span class="sourceLineNo">556</span>  }<a name="line.556"></a>
-<span class="sourceLineNo">557</span><a name="line.557"></a>
-<span class="sourceLineNo">558</span>  private static MasterServices getMockedMaster() throws IOException {<a name="line.558"></a>
-<span class="sourceLineNo">559</span>    TableDescriptors tds = Mockito.mock(TableDescriptors.class);<a name="line.559"></a>
-<span class="sourceLineNo">560</span>    Mockito.when(tds.get(tables[0])).thenReturn(tableDescs.get(0));<a name="line.560"></a>
-<span class="sourceLineNo">561</span>    Mockito.when(tds.get(tables[1])).thenReturn(tableDescs.get(1));<a name="line.561"></a>
-<span class="sourceLineNo">562</span>    Mockito.when(tds.get(tables[2])).thenReturn(tableDescs.get(2));<a name="line.562"></a>
-<span class="sourceLineNo">563</span>    Mockito.when(tds.get(tables[3])).thenReturn(tableDescs.get(3));<a name="line.563"></a>
-<span class="sourceLineNo">564</span>    MasterServices services = Mockito.mock(HMaster.class);<a name="line.564"></a>
-<span class="sourceLineNo">565</span>    Mockito.when(services.getTableDescriptors()).thenReturn(tds);<a name="line.565"></a>
-<span class="sourceLineNo">566</span>    AssignmentManager am = Mockito.mock(AssignmentManager.class);<a name="line.566"></a>
-<span class="sourceLineNo">567</span>    Mockito.when(services.getAssignmentManager()).thenReturn(am);<a name="line.567"></a>
-<span class="sourceLineNo">568</span>    return services;<a name="line.568"></a>
-<span class="sourceLineNo">569</span>  }<a name="line.569"></a>
-<span class="sourceLineNo">570</span><a name="line.570"></a>
-<span class="sourceLineNo">571</span>  private static RSGroupInfoManager getMockedGroupInfoManager() throws IOException {<a name="line.571"></a>
-<span class="sourceLineNo">572</span>    RSGroupInfoManager gm = Mockito.mock(RSGroupInfoManager.class);<a name="line.572"></a>
-<span class="sourceLineNo">573</span>    Mockito.when(gm.getRSGroup(groups[0])).thenReturn(<a name="line.573"></a>
-<span class="sourceLineNo">574</span>        groupMap.get(groups[0]));<a name="line.574"></a>
-<span class="sourceLineNo">575</span>    Mockito.when(gm.getRSGroup(groups[1])).thenReturn(<a name="line.575"></a>
-<span class="sourceLineNo">576</span>        groupMap.get(groups[1]));<a name="line.576"></a>
-<span class="sourceLineNo">577</span>    Mockito.when(gm.getRSGroup(groups[2])).thenReturn(<a name="line.577"></a>
-<span class="sourceLineNo">578</span>        groupMap.get(groups[2]));<a name="line.578"></a>
-<span class="sourceLineNo">579</span>    Mockito.when(gm.getRSGroup(groups[3])).thenReturn(<a name="line.579"></a>
-<span class="sourceLineNo">580</span>        groupMap.get(groups[3]));<a name="line.580"></a>
-<span class="sourceLineNo">581</span>    Mockito.when(gm.listRSGroups()).thenReturn(<a name="line.581"></a>
-<span class="sourceLineNo">582</span>        Lists.newLinkedList(groupMap.values()));<a name="line.582"></a>
-<span class="sourceLineNo">583</span>    Mockito.when(gm.isOnline()).thenReturn(true);<a name="line.583"></a>
-<span class="sourceLineNo">584</span>    Mockito.when(gm.getRSGroupOfTable(Mockito.any()))<a name="line.584"></a>
-<span class="sourceLineNo">585</span>        .thenAnswer(new Answer&lt;String&gt;() {<a name="line.585"></a>
-<span class="sourceLineNo">586</span>          @Override<a name="line.586"></a>
-<span class="sourceLineNo">587</span>          public String answer(InvocationOnMock invocation) throws Throwable {<a name="line.587"></a>
-<span class="sourceLineNo">588</span>            return tableMap.get(invocation.getArgument(0));<a name="line.588"></a>
-<span class="sourceLineNo">589</span>          }<a name="line.589"></a>
-<span class="sourceLineNo">590</span>        });<a name="line.590"></a>
-<span class="sourceLineNo">591</span>    return gm;<a name="line.591"></a>
+<span class="sourceLineNo">145</span>        numRegions += nr;<a name="line.145"></a>
+<span class="sourceLineNo">146</span>      }<a name="line.146"></a>
+<span class="sourceLineNo">147</span>      if (maxRegions - minRegions &lt; 2) {<a name="line.147"></a>
+<span class="sourceLineNo">148</span>        // less than 2 between max and min, can't balance<a name="line.148"></a>
+<span class="sourceLineNo">149</span>        return;<a name="line.149"></a>
+<span class="sourceLineNo">150</span>      }<a name="line.150"></a>
+<span class="sourceLineNo">151</span>      int min = numRegions / numServers;<a name="line.151"></a>
+<span class="sourceLineNo">152</span>      int max = numRegions % numServers == 0 ? min : min + 1;<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span>      for (ServerAndLoad server : groupLoad) {<a name="line.154"></a>
+<span class="sourceLineNo">155</span>        assertTrue(server.getLoad() &lt;= max);<a name="line.155"></a>
+<span class="sourceLineNo">156</span>        assertTrue(server.getLoad() &gt;= min);<a name="line.156"></a>
+<span class="sourceLineNo">157</span>      }<a name="line.157"></a>
+<span class="sourceLineNo">158</span>    }<a name="line.158"></a>
+<span class="sourceLineNo">159</span>  }<a name="line.159"></a>
+<span class="sourceLineNo">160</span><a name="line.160"></a>
+<span class="sourceLineNo">161</span>  /**<a name="line.161"></a>
+<span class="sourceLineNo">162</span>   * All regions have an assignment.<a name="line.162"></a>
+<span class="sourceLineNo">163</span>   */<a name="line.163"></a>
+<span class="sourceLineNo">164</span>  private void assertImmediateAssignment(List&lt;RegionInfo&gt; regions,<a name="line.164"></a>
+<span class="sourceLineNo">165</span>                                         List&lt;ServerName&gt; servers,<a name="line.165"></a>
+<span class="sourceLineNo">166</span>                                         Map&lt;RegionInfo, ServerName&gt; assignments)<a name="line.166"></a>
+<span class="sourceLineNo">167</span>      throws IOException {<a name="line.167"></a>
+<span class="sourceLineNo">168</span>    for (RegionInfo region : regions) {<a name="line.168"></a>
+<span class="sourceLineNo">169</span>      assertTrue(assignments.containsKey(region));<a name="line.169"></a>
+<span class="sourceLineNo">170</span>      ServerName server = assignments.get(region);<a name="line.170"></a>
+<span class="sourceLineNo">171</span>      TableName tableName = region.getTable();<a name="line.171"></a>
+<span class="sourceLineNo">172</span><a name="line.172"></a>
+<span class="sourceLineNo">173</span>      String groupName = getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.173"></a>
+<span class="sourceLineNo">174</span>      assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.174"></a>
+<span class="sourceLineNo">175</span>      RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(groupName);<a name="line.175"></a>
+<span class="sourceLineNo">176</span>      assertTrue("Region is not correctly assigned to group servers.",<a name="line.176"></a>
+<span class="sourceLineNo">177</span>          gInfo.containsServer(server.getAddress()));<a name="line.177"></a>
+<span class="sourceLineNo">178</span>    }<a name="line.178"></a>
+<span class="sourceLineNo">179</span>  }<a name="line.179"></a>
+<span class="sourceLineNo">180</span><a name="line.180"></a>
+<span class="sourceLineNo">181</span>  /**<a name="line.181"></a>
+<span class="sourceLineNo">182</span>   * Tests the bulk assignment used during cluster startup.<a name="line.182"></a>
+<span class="sourceLineNo">183</span>   *<a name="line.183"></a>
+<span class="sourceLineNo">184</span>   * Round-robin. Should yield a balanced cluster so same invariant as the<a name="line.184"></a>
+<span class="sourceLineNo">185</span>   * load balancer holds, all servers holding either floor(avg) or<a name="line.185"></a>
+<span class="sourceLineNo">186</span>   * ceiling(avg).<a name="line.186"></a>
+<span class="sourceLineNo">187</span>   */<a name="line.187"></a>
+<span class="sourceLineNo">188</span>  @Test<a name="line.188"></a>
+<span class="sourceLineNo">189</span>  public void testBulkAssignment() throws Exception {<a name="line.189"></a>
+<span class="sourceLineNo">190</span>    List&lt;RegionInfo&gt; regions = randomRegions(25);<a name="line.190"></a>
+<span class="sourceLineNo">191</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignments = loadBalancer<a name="line.191"></a>
+<span class="sourceLineNo">192</span>        .roundRobinAssignment(regions, servers);<a name="line.192"></a>
+<span class="sourceLineNo">193</span>    //test empty region/servers scenario<a name="line.193"></a>
+<span class="sourceLineNo">194</span>    //this should not throw an NPE<a name="line.194"></a>
+<span class="sourceLineNo">195</span>    loadBalancer.roundRobinAssignment(regions,<a name="line.195"></a>
+<span class="sourceLineNo">196</span>        Collections.EMPTY_LIST);<a name="line.196"></a>
+<span class="sourceLineNo">197</span>    //test regular scenario<a name="line.197"></a>
+<span class="sourceLineNo">198</span>    assertTrue(assignments.keySet().size() == servers.size());<a name="line.198"></a>
+<span class="sourceLineNo">199</span>    for (ServerName sn : assignments.keySet()) {<a name="line.199"></a>
+<span class="sourceLineNo">200</span>      List&lt;RegionInfo&gt; regionAssigned = assignments.get(sn);<a name="line.200"></a>
+<span class="sourceLineNo">201</span>      for (RegionInfo region : regionAssigned) {<a name="line.201"></a>
+<span class="sourceLineNo">202</span>        TableName tableName = region.getTable();<a name="line.202"></a>
+<span class="sourceLineNo">203</span>        String groupName =<a name="line.203"></a>
+<span class="sourceLineNo">204</span>            getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.204"></a>
+<span class="sourceLineNo">205</span>        assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.205"></a>
+<span class="sourceLineNo">206</span>        RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(<a name="line.206"></a>
+<span class="sourceLineNo">207</span>            groupName);<a name="line.207"></a>
+<span class="sourceLineNo">208</span>        assertTrue(<a name="line.208"></a>
+<span class="sourceLineNo">209</span>            "Region is not correctly assigned to group servers.",<a name="line.209"></a>
+<span class="sourceLineNo">210</span>            gInfo.containsServer(sn.getAddress()));<a name="line.210"></a>
+<span class="sourceLineNo">211</span>      }<a name="line.211"></a>
+<span class="sourceLineNo">212</span>    }<a name="line.212"></a>
+<span class="sourceLineNo">213</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; loadMap = convertToGroupBasedMap(assignments);<a name="line.213"></a>
+<span class="sourceLineNo">214</span>    assertClusterAsBalanced(loadMap);<a name="line.214"></a>
+<span class="sourceLineNo">215</span>  }<a name="line.215"></a>
+<span class="sourceLineNo">216</span><a name="line.216"></a>
+<span class="sourceLineNo">217</span>  /**<a name="line.217"></a>
+<span class="sourceLineNo">218</span>   * Test the cluster startup bulk assignment which attempts to retain assignment info.<a name="line.218"></a>
+<span class="sourceLineNo">219</span>   */<a name="line.219"></a>
+<span class="sourceLineNo">220</span>  @Test<a name="line.220"></a>
+<span class="sourceLineNo">221</span>  public void testRetainAssignment() throws Exception {<a name="line.221"></a>
+<span class="sourceLineNo">222</span>    // Test simple case where all same servers are there<a name="line.222"></a>
+<span class="sourceLineNo">223</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; currentAssignments = mockClusterServers();<a name="line.223"></a>
+<span class="sourceLineNo">224</span>    Map&lt;RegionInfo, ServerName&gt; inputForTest = new HashMap&lt;&gt;();<a name="line.224"></a>
+<span class="sourceLineNo">225</span>    for (ServerName sn : currentAssignments.keySet()) {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      for (RegionInfo region : currentAssignments.get(sn)) {<a name="line.226"></a>
+<span class="sourceLineNo">227</span>        inputForTest.put(region, sn);<a name="line.227"></a>
+<span class="sourceLineNo">228</span>      }<a name="line.228"></a>
+<span class="sourceLineNo">229</span>    }<a name="line.229"></a>
+<span class="sourceLineNo">230</span>    //verify region-&gt;null server assignment is handled<a name="line.230"></a>
+<span class="sourceLineNo">231</span>    inputForTest.put(randomRegions(1).get(0), null);<a name="line.231"></a>
+<span class="sourceLineNo">232</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; newAssignment = loadBalancer<a name="line.232"></a>
+<span class="sourceLineNo">233</span>        .retainAssignment(inputForTest, servers);<a name="line.233"></a>
+<span class="sourceLineNo">234</span>    assertRetainedAssignment(inputForTest, servers, newAssignment);<a name="line.234"></a>
+<span class="sourceLineNo">235</span>  }<a name="line.235"></a>
+<span class="sourceLineNo">236</span><a name="line.236"></a>
+<span class="sourceLineNo">237</span>  /**<a name="line.237"></a>
+<span class="sourceLineNo">238</span>   * Test BOGUS_SERVER_NAME among groups do not overwrite each other.<a name="line.238"></a>
+<span class="sourceLineNo">239</span>   */<a name="line.239"></a>
+<span class="sourceLineNo">240</span>  @Test<a name="line.240"></a>
+<span class="sourceLineNo">241</span>  public void testRoundRobinAssignment() throws Exception {<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    List&lt;ServerName&gt; onlineServers = new ArrayList&lt;ServerName&gt;(servers.size());<a name="line.242"></a>
+<span class="sourceLineNo">243</span>    onlineServers.addAll(servers);<a name="line.243"></a>
+<span class="sourceLineNo">244</span>    List&lt;RegionInfo&gt; regions = randomRegions(25);<a name="line.244"></a>
+<span class="sourceLineNo">245</span>    int bogusRegion = 0;<a name="line.245"></a>
+<span class="sourceLineNo">246</span>    for(RegionInfo region : regions){<a name="line.246"></a>
+<span class="sourceLineNo">247</span>      String group = tableMap.get(region.getTable());<a name="line.247"></a>
+<span class="sourceLineNo">248</span>      if("dg3".equals(group) || "dg4".equals(group)){<a name="line.248"></a>
+<span class="sourceLineNo">249</span>        bogusRegion++;<a name="line.249"></a>
+<span class="sourceLineNo">250</span>      }<a name="line.250"></a>
+<span class="sourceLineNo">251</span>    }<a name="line.251"></a>
+<span class="sourceLineNo">252</span>    Set&lt;Address&gt; offlineServers = new HashSet&lt;Address&gt;();<a name="line.252"></a>
+<span class="sourceLineNo">253</span>    offlineServers.addAll(groupMap.get("dg3").getServers());<a name="line.253"></a>
+<span class="sourceLineNo">254</span>    offlineServers.addAll(groupMap.get("dg4").getServers());<a name="line.254"></a>
+<span class="sourceLineNo">255</span>    for(Iterator&lt;ServerName&gt; it =  onlineServers.iterator(); it.hasNext();){<a name="line.255"></a>
+<span class="sourceLineNo">256</span>      ServerName server = it.next();<a name="line.256"></a>
+<span class="sourceLineNo">257</span>      Address address = server.getAddress();<a name="line.257"></a>
+<span class="sourceLineNo">258</span>      if(offlineServers.contains(address)){<a name="line.258"></a>
+<span class="sourceLineNo">259</span>        it.remove();<a name="line.259"></a>
+<span class="sourceLineNo">260</span>      }<a name="line.260"></a>
+<span class="sourceLineNo">261</span>    }<a name="line.261"></a>
+<span class="sourceLineNo">262</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignments = loadBalancer<a name="line.262"></a>
+<span class="sourceLineNo">263</span>        .roundRobinAssignment(regions, onlineServers);<a name="line.263"></a>
+<span class="sourceLineNo">264</span>    assertEquals(bogusRegion, assignments.get(LoadBalancer.BOGUS_SERVER_NAME).size());<a name="line.264"></a>
+<span class="sourceLineNo">265</span>  }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span>  /**<a name="line.267"></a>
+<span class="sourceLineNo">268</span>   * Asserts a valid retained assignment plan.<a name="line.268"></a>
+<span class="sourceLineNo">269</span>   * &lt;p&gt;<a name="line.269"></a>
+<span class="sourceLineNo">270</span>   * Must meet the following conditions:<a name="line.270"></a>
+<span class="sourceLineNo">271</span>   * &lt;ul&gt;<a name="line.271"></a>
+<span class="sourceLineNo">272</span>   * &lt;li&gt;Every input region has an assignment, and to an online server<a name="line.272"></a>
+<span class="sourceLineNo">273</span>   * &lt;li&gt;If a region had an existing assignment to a server with the same<a name="line.273"></a>
+<span class="sourceLineNo">274</span>   * address a a currently online server, it will be assigned to it<a name="line.274"></a>
+<span class="sourceLineNo">275</span>   * &lt;/ul&gt;<a name="line.275"></a>
+<span class="sourceLineNo">276</span>   */<a name="line.276"></a>
+<span class="sourceLineNo">277</span>  private void assertRetainedAssignment(<a name="line.277"></a>
+<span class="sourceLineNo">278</span>      Map&lt;RegionInfo, ServerName&gt; existing, List&lt;ServerName&gt; servers,<a name="line.278"></a>
+<span class="sourceLineNo">279</span>      Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignment)<a name="line.279"></a>
+<span class="sourceLineNo">280</span>      throws FileNotFoundException, IOException {<a name="line.280"></a>
+<span class="sourceLineNo">281</span>    // Verify condition 1, every region assigned, and to online server<a name="line.281"></a>
+<span class="sourceLineNo">282</span>    Set&lt;ServerName&gt; onlineServerSet = new TreeSet&lt;&gt;(servers);<a name="line.282"></a>
+<span class="sourceLineNo">283</span>    Set&lt;RegionInfo&gt; assignedRegions = new TreeSet&lt;&gt;(RegionInfo.COMPARATOR);<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; a : assignment.entrySet()) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span>      assertTrue(<a name="line.285"></a>
+<span class="sourceLineNo">286</span>          "Region assigned to server that was not listed as online",<a name="line.286"></a>
+<span class="sourceLineNo">287</span>          onlineServerSet.contains(a.getKey()));<a name="line.287"></a>
+<span class="sourceLineNo">288</span>      for (RegionInfo r : a.getValue()) {<a name="line.288"></a>
+<span class="sourceLineNo">289</span>        assignedRegions.add(r);<a name="line.289"></a>
+<span class="sourceLineNo">290</span>      }<a name="line.290"></a>
+<span class="sourceLineNo">291</span>    }<a name="line.291"></a>
+<span class="sourceLineNo">292</span>    assertEquals(existing.size(), assignedRegions.size());<a name="line.292"></a>
+<span class="sourceLineNo">293</span><a name="line.293"></a>
+<span class="sourceLineNo">294</span>    // Verify condition 2, every region must be assigned to correct server.<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    Set&lt;String&gt; onlineHostNames = new TreeSet&lt;&gt;();<a name="line.295"></a>
+<span class="sourceLineNo">296</span>    for (ServerName s : servers) {<a name="line.296"></a>
+<span class="sourceLineNo">297</span>      onlineHostNames.add(s.getHostname());<a name="line.297"></a>
+<span class="sourceLineNo">298</span>    }<a name="line.298"></a>
+<span class="sourceLineNo">299</span><a name="line.299"></a>
+<span class="sourceLineNo">300</span>    for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; a : assignment.entrySet()) {<a name="line.300"></a>
+<span class="sourceLineNo">301</span>      ServerName currentServer = a.getKey();<a name="line.301"></a>
+<span class="sourceLineNo">302</span>      for (RegionInfo r : a.getValue()) {<a name="line.302"></a>
+<span class="sourceLineNo">303</span>        ServerName oldAssignedServer = existing.get(r);<a name="line.303"></a>
+<span class="sourceLineNo">304</span>        TableName tableName = r.getTable();<a name="line.304"></a>
+<span class="sourceLineNo">305</span>        String groupName =<a name="line.305"></a>
+<span class="sourceLineNo">306</span>            getMockedGroupInfoManager().getRSGroupOfTable(tableName);<a name="line.306"></a>
+<span class="sourceLineNo">307</span>        assertTrue(StringUtils.isNotEmpty(groupName));<a name="line.307"></a>
+<span class="sourceLineNo">308</span>        RSGroupInfo gInfo = getMockedGroupInfoManager().getRSGroup(<a name="line.308"></a>
+<span class="sourceLineNo">309</span>            groupName);<a name="line.309"></a>
+<span class="sourceLineNo">310</span>        assertTrue(<a name="line.310"></a>
+<span class="sourceLineNo">311</span>            "Region is not correctly assigned to group servers.",<a name="line.311"></a>
+<span class="sourceLineNo">312</span>            gInfo.containsServer(currentServer.getAddress()));<a name="line.312"></a>
+<span class="sourceLineNo">313</span>        if (oldAssignedServer != null<a name="line.313"></a>
+<span class="sourceLineNo">314</span>            &amp;&amp; onlineHostNames.contains(oldAssignedServer<a name="line.314"></a>
+<span class="sourceLineNo">315</span>            .getHostname())) {<a name="line.315"></a>
+<span class="sourceLineNo">316</span>          // this region was previously assigned somewhere, and that<a name="line.316"></a>
+<span class="sourceLineNo">317</span>          // host is still around, then the host must have been is a<a name="line.317"></a>
+<span class="sourceLineNo">318</span>          // different group.<a name="line.318"></a>
+<span class="sourceLineNo">319</span>          if (!oldAssignedServer.getAddress().equals(currentServer.getAddress())) {<a name="line.319"></a>
+<span class="sourceLineNo">320</span>            assertFalse(gInfo.containsServer(oldAssignedServer.getAddress()));<a name="line.320"></a>
+<span class="sourceLineNo">321</span>          }<a name="line.321"></a>
+<span class="sourceLineNo">322</span>        }<a name="line.322"></a>
+<span class="sourceLineNo">323</span>      }<a name="line.323"></a>
+<span class="sourceLineNo">324</span>    }<a name="line.324"></a>
+<span class="sourceLineNo">325</span>  }<a name="line.325"></a>
+<span class="sourceLineNo">326</span><a name="line.326"></a>
+<span class="sourceLineNo">327</span>  private String printStats(<a name="line.327"></a>
+<span class="sourceLineNo">328</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; groupBasedLoad) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span>    StringBuffer sb = new StringBuffer();<a name="line.329"></a>
+<span class="sourceLineNo">330</span>    sb.append("\n");<a name="line.330"></a>
+<span class="sourceLineNo">331</span>    for (String groupName : groupBasedLoad.keySet()) {<a name="line.331"></a>
+<span class="sourceLineNo">332</span>      sb.append("Stats for group: " + groupName);<a name="line.332"></a>
+<span class="sourceLineNo">333</span>      sb.append("\n");<a name="line.333"></a>
+<span class="sourceLineNo">334</span>      sb.append(groupMap.get(groupName).getServers());<a name="line.334"></a>
+<span class="sourceLineNo">335</span>      sb.append("\n");<a name="line.335"></a>
+<span class="sourceLineNo">336</span>      List&lt;ServerAndLoad&gt; groupLoad = groupBasedLoad.get(groupName);<a name="line.336"></a>
+<span class="sourceLineNo">337</span>      int numServers = groupLoad.size();<a name="line.337"></a>
+<span class="sourceLineNo">338</span>      int totalRegions = 0;<a name="line.338"></a>
+<span class="sourceLineNo">339</span>      sb.append("Per Server Load: \n");<a name="line.339"></a>
+<span class="sourceLineNo">340</span>      for (ServerAndLoad sLoad : groupLoad) {<a name="line.340"></a>
+<span class="sourceLineNo">341</span>        sb.append("Server :" + sLoad.getServerName() + " Load : "<a name="line.341"></a>
+<span class="sourceLineNo">342</span>            + sLoad.getLoad() + "\n");<a name="line.342"></a>
+<span class="sourceLineNo">343</span>        totalRegions += sLoad.getLoad();<a name="line.343"></a>
+<span class="sourceLineNo">344</span>      }<a name="line.344"></a>
+<span class="sourceLineNo">345</span>      sb.append(" Group Statistics : \n");<a name="line.345"></a>
+<span class="sourceLineNo">346</span>      float average = (float) totalRegions / numServers;<a name="line.346"></a>
+<span class="sourceLineNo">347</span>      int max = (int) Math.ceil(average);<a name="line.347"></a>
+<span class="sourceLineNo">348</span>      int min = (int) Math.floor(average);<a name="line.348"></a>
+<span class="sourceLineNo">349</span>      sb.append("[srvr=" + numServers + " rgns=" + totalRegions + " avg="<a name="line.349"></a>
+<span class="sourceLineNo">350</span>          + average + " max=" + max + " min=" + min + "]");<a name="line.350"></a>
+<span class="sourceLineNo">351</span>      sb.append("\n");<a name="line.351"></a>
+<span class="sourceLineNo">352</span>      sb.append("===============================");<a name="line.352"></a>
+<span class="sourceLineNo">353</span>      sb.append("\n");<a name="line.353"></a>
+<span class="sourceLineNo">354</span>    }<a name="line.354"></a>
+<span class="sourceLineNo">355</span>    return sb.toString();<a name="line.355"></a>
+<span class="sourceLineNo">356</span>  }<a name="line.356"></a>
+<span class="sourceLineNo">357</span><a name="line.357"></a>
+<span class="sourceLineNo">358</span>  private ArrayListMultimap&lt;String, ServerAndLoad&gt; convertToGroupBasedMap(<a name="line.358"></a>
+<span class="sourceLineNo">359</span>      final Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serversMap) throws IOException {<a name="line.359"></a>
+<span class="sourceLineNo">360</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; loadMap = ArrayListMultimap<a name="line.360"></a>
+<span class="sourceLineNo">361</span>        .create();<a name="line.361"></a>
+<span class="sourceLineNo">362</span>    for (RSGroupInfo gInfo : getMockedGroupInfoManager().listRSGroups()) {<a name="line.362"></a>
+<span class="sourceLineNo">363</span>      Set&lt;Address&gt; groupServers = gInfo.getServers();<a name="line.363"></a>
+<span class="sourceLineNo">364</span>      for (Address hostPort : groupServers) {<a name="line.364"></a>
+<span class="sourceLineNo">365</span>        ServerName actual = null;<a name="line.365"></a>
+<span class="sourceLineNo">366</span>        for(ServerName entry: servers) {<a name="line.366"></a>
+<span class="sourceLineNo">367</span>          if(entry.getAddress().equals(hostPort)) {<a name="line.367"></a>
+<span class="sourceLineNo">368</span>            actual = entry;<a name="line.368"></a>
+<span class="sourceLineNo">369</span>            break;<a name="line.369"></a>
+<span class="sourceLineNo">370</span>          }<a name="line.370"></a>
+<span class="sourceLineNo">371</span>        }<a name="line.371"></a>
+<span class="sourceLineNo">372</span>        List&lt;RegionInfo&gt; regions = serversMap.get(actual);<a name="line.372"></a>
+<span class="sourceLineNo">373</span>        assertTrue("No load for " + actual, regions != null);<a name="line.373"></a>
+<span class="sourceLineNo">374</span>        loadMap.put(gInfo.getName(),<a name="line.374"></a>
+<span class="sourceLineNo">375</span>            new ServerAndLoad(actual, regions.size()));<a name="line.375"></a>
+<span class="sourceLineNo">376</span>      }<a name="line.376"></a>
+<span class="sourceLineNo">377</span>    }<a name="line.377"></a>
+<span class="sourceLineNo">378</span>    return loadMap;<a name="line.378"></a>
+<span class="sourceLineNo">379</span>  }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span>  private ArrayListMultimap&lt;String, ServerAndLoad&gt; reconcile(<a name="line.381"></a>
+<span class="sourceLineNo">382</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; previousLoad,<a name="line.382"></a>
+<span class="sourceLineNo">383</span>      List&lt;RegionPlan&gt; plans) {<a name="line.383"></a>
+<span class="sourceLineNo">384</span>    ArrayListMultimap&lt;String, ServerAndLoad&gt; result = ArrayListMultimap<a name="line.384"></a>
+<span class="sourceLineNo">385</span>        .create();<a name="line.385"></a>
+<span class="sourceLineNo">386</span>    result.putAll(previousLoad);<a name="line.386"></a>
+<span class="sourceLineNo">387</span>    if (plans != null) {<a name="line.387"></a>
+<span class="sourceLineNo">388</span>      for (RegionPlan plan : plans) {<a name="line.388"></a>
+<span class="sourceLineNo">389</span>        ServerName source = plan.getSource();<a name="line.389"></a>
+<span class="sourceLineNo">390</span>        updateLoad(result, source, -1);<a name="line.390"></a>
+<span class="sourceLineNo">391</span>        ServerName destination = plan.getDestination();<a name="line.391"></a>
+<span class="sourceLineNo">392</span>        updateLoad(result, destination, +1);<a name="line.392"></a>
+<span class="sourceLineNo">393</span>      }<a name="line.393"></a>
+<span class="sourceLineNo">394</span>    }<a name="line.394"></a>
+<span class="sourceLineNo">395</span>    return result;<a name="line.395"></a>
+<span class="sourceLineNo">396</span>  }<a name="line.396"></a>
+<span class="sourceLineNo">397</span><a name="line.397"></a>
+<span class="sourceLineNo">398</span>  private void updateLoad(<a name="line.398"></a>
+<span class="sourceLineNo">399</span>      ArrayListMultimap&lt;String, ServerAndLoad&gt; previousLoad,<a name="line.399"></a>
+<span class="sourceLineNo">400</span>      final ServerName sn, final int diff) {<a name="line.400"></a>
+<span class="sourceLineNo">401</span>    for (String groupName : previousLoad.keySet()) {<a name="line.401"></a>
+<span class="sourceLineNo">402</span>      ServerAndLoad newSAL = null;<a name="line.402"></a>
+<span class="sourceLineNo">403</span>      ServerAndLoad oldSAL = null;<a name="line.403"></a>
+<span class="sourceLineNo">404</span>      for (ServerAndLoad sal : previousLoad.get(groupName)) {<a name="line.404"></a>
+<span class="sourceLineNo">405</span>        if (ServerName.isSameAddress(sn, sal.getServerName())) {<a name="line.405"></a>
+<span class="sourceLineNo">406</span>          oldSAL = sal;<a name="line.406"></a>
+<span class="sourceLineNo">407</span>          newSAL = new ServerAndLoad(sn, sal.getLoad() + diff);<a name="line.407"></a>
+<span class="sourceLineNo">408</span>          break;<a name="line.408"></a>
+<span class="sourceLineNo">409</span>        }<a name="line.409"></a>
+<span class="sourceLineNo">410</span>      }<a name="line.410"></a>
+<span class="sourceLineNo">411</span>      if (newSAL != null) {<a name="line.411"></a>
+<span class="sourceLineNo">412</span>        previousLoad.remove(groupName, oldSAL);<a name="line.412"></a>
+<span class="sourceLineNo">413</span>        previousLoad.put(groupName, newSAL);<a name="line.413"></a>
+<span class="sourceLineNo">414</span>        break;<a name="line.414"></a>
+<span class="sourceLineNo">415</span>      }<a name="line.415"></a>
+<span class="sourceLineNo">416</span>    }<a name="line.416"></a>
+<span class="sourceLineNo">417</span>  }<a name="line.417"></a>
+<span class="sourceLineNo">418</span><a name="line.418"></a>
+<span class="sourceLineNo">419</span>  private Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; mockClusterServers() throws IOException {<a name="line.419"></a>
+<span class="sourceLineNo">420</span>    assertTrue(servers.size() == regionAssignment.length);<a name="line.420"></a>
+<span class="sourceLineNo">421</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; assignment = new TreeMap&lt;&gt;();<a name="line.421"></a>
+<span class="sourceLineNo">422</span>    for (int i = 0; i &lt; servers.size(); i++) {<a name="line.422"></a>
+<span class="sourceLineNo">423</span>      int numRegions = regionAssignment[i];<a name="line.423"></a>
+<span class="sourceLineNo">424</span>      List&lt;RegionInfo&gt; regions = assignedRegions(numRegions, servers.get(i));<a name="line.424"></a>
+<span class="sourceLineNo">425</span>      assignment.put(servers.get(i), regions);<a name="line.425"></a>
+<span class="sourceLineNo">426</span>    }<a name="line.426"></a>
+<span class="sourceLineNo">427</span>    return assignment;<a name="line.427"></a>
+<span class="sourceLineNo">428</span>  }<a name="line.428"></a>
+<span class="sourceLineNo">429</span><a name="line.429"></a>
+<span class="sourceLineNo">430</span>  /**<a name="line.430"></a>
+<span class="sourceLineNo">431</span>   * Generate a list of regions evenly distributed between the tables.<a name="line.431"></a>
+<span class="sourceLineNo">432</span>   *<a name="line.432"></a>
+<span class="sourceLineNo">433</span>   * @param numRegions The number of regions to be generated.<a name="line.433"></a>
+<span class="sourceLineNo">434</span>   * @return List of RegionInfo.<a name="line.434"></a>
+<span class="sourceLineNo">435</span>   */<a name="line.435"></a>
+<span class="sourceLineNo">436</span>  private List&lt;RegionInfo&gt; randomRegions(int numRegions) {<a name="line.436"></a>
+<span class="sourceLineNo">437</span>    List&lt;RegionInfo&gt; regions = new ArrayList&lt;&gt;(numRegions);<a name="line.437"></a>
+<span class="sourceLineNo">438</span>    byte[] start = new byte[16];<a name="line.438"></a>
+<span class="sourceLineNo">439</span>    byte[] end = new byte[16];<a name="line.439"></a>
+<span class="sourceLineNo">440</span>    rand.nextBytes(start);<a name="line.440"></a>
+<span class="sourceLineNo">441</span>    rand.nextBytes(end);<a name="line.441"></a>
+<span class="sourceLineNo">442</span>    int regionIdx = rand.nextInt(tables.length);<a name="line.442"></a>
+<span class="sourceLineNo">443</span>    for (int i = 0; i &lt; numRegions; i++) {<a name="line.443"></a>
+<span class="sourceLineNo">444</span>      Bytes.putInt(start, 0, numRegions &lt;&lt; 1);<a name="line.444"></a>
+<span class="sourceLineNo">445</span>      Bytes.putInt(end, 0, (numRegions &lt;&lt; 1) + 1);<a name="line.445"></a>
+<span class="sourceLineNo">446</span>      int tableIndex = (i + regionIdx) % tables.length;<a name="line.446"></a>
+<span class="sourceLineNo">447</span>      regions.add(RegionInfoBuilder.newBuild

<TRUNCATED>

Mime
View raw message