hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject hbase git commit: HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense
Date Tue, 19 Dec 2017 21:55:11 GMT
Repository: hbase
Updated Branches:
  refs/heads/master 32f6fd41c -> 70608acf2


HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/70608acf
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/70608acf
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/70608acf

Branch: refs/heads/master
Commit: 70608acf289f6de4aeb8f159667a1f21397ec433
Parents: 32f6fd4
Author: Yi Liang <easyliangjob@gmail.com>
Authored: Tue Dec 19 11:31:44 2017 -0800
Committer: Michael Stack <stack@apache.org>
Committed: Tue Dec 19 13:55:05 2017 -0800

----------------------------------------------------------------------
 .../assignment/TestAssignmentManager.java       | 34 --------------------
 1 file changed, 34 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/70608acf/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
index 21f7ffb..f4365ea 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
@@ -169,36 +169,6 @@ public class TestAssignmentManager {
     if (this.am.waitServerReportEvent(null, null)) throw new UnexpectedStateException();
   }
 
-  @Ignore @Test // TODO
-  public void testGoodSplit() throws Exception {
-    TableName tableName = TableName.valueOf(this.name.getMethodName());
-    RegionInfo hri = RegionInfoBuilder.newBuilder(tableName)
-        .setStartKey(Bytes.toBytes(0))
-        .setEndKey(Bytes.toBytes(2))
-        .setSplit(false)
-        .setRegionId(0)
-        .build();
-    SplitTableRegionProcedure split =
-        new SplitTableRegionProcedure(this.master.getMasterProcedureExecutor().getEnvironment(),
-            hri, Bytes.toBytes(1));
-    rsDispatcher.setMockRsExecutor(new GoodSplitExecutor());
-    long st = System.currentTimeMillis();
-    Thread t = new Thread() {
-      public void run() {
-        try {
-          waitOnFuture(submitProcedure(split));
-        } catch (Exception e) {
-          e.printStackTrace();
-        }
-      }
-    };
-    t.start();
-    t.join();
-    long et = System.currentTimeMillis();
-    float sec = ((et - st) / 1000.0f);
-    LOG.info(String.format("[T] Splitting in %s", StringUtils.humanTimeDiff(et - st)));
-  }
-
   @Test
   public void testAssignWithGoodExec() throws Exception {
     // collect AM metrics before test
@@ -865,10 +835,6 @@ public class TestAssignmentManager {
     }
   }
 
-  private class GoodSplitExecutor extends NoopRsExecutor {
-
-  }
-
   private void collectAssignmentManagerMetrics() {
     assignSubmittedCount = assignProcMetrics.getSubmittedCounter().getCount();
     assignFailedCount = assignProcMetrics.getFailedCounter().getCount();


Mime
View raw message