hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From git-site-r...@apache.org
Subject [02/51] [partial] hbase-site git commit: Published site at .
Date Thu, 14 Dec 2017 15:18:18 GMT
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/dc4e5c85/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.WriterThread.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.WriterThread.html b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.WriterThread.html
index 219283e..2b5d70b 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.WriterThread.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.WriterThread.html
@@ -435,1198 +435,1203 @@
 <span class="sourceLineNo">427</span><a name="line.427"></a>
 <span class="sourceLineNo">428</span>    if (backingMap.containsKey(cacheKey)) {<a name="line.428"></a>
 <span class="sourceLineNo">429</span>      Cacheable existingBlock = getBlock(cacheKey, false, false, false);<a name="line.429"></a>
-<span class="sourceLineNo">430</span>      if (BlockCacheUtil.compareCacheBlock(cachedItem, existingBlock) != 0) {<a name="line.430"></a>
-<span class="sourceLineNo">431</span>        throw new RuntimeException("Cached block contents differ, which should not have happened."<a name="line.431"></a>
-<span class="sourceLineNo">432</span>            + "cacheKey:" + cacheKey);<a name="line.432"></a>
-<span class="sourceLineNo">433</span>      }<a name="line.433"></a>
-<span class="sourceLineNo">434</span>       String msg = "Caching an already cached block: " + cacheKey;<a name="line.434"></a>
-<span class="sourceLineNo">435</span>       msg += ". This is harmless and can happen in rare cases (see HBASE-8547)";<a name="line.435"></a>
-<span class="sourceLineNo">436</span>       LOG.warn(msg);<a name="line.436"></a>
-<span class="sourceLineNo">437</span>      return;<a name="line.437"></a>
-<span class="sourceLineNo">438</span>    }<a name="line.438"></a>
-<span class="sourceLineNo">439</span><a name="line.439"></a>
-<span class="sourceLineNo">440</span>    /*<a name="line.440"></a>
-<span class="sourceLineNo">441</span>     * Stuff the entry into the RAM cache so it can get drained to the persistent store<a name="line.441"></a>
-<span class="sourceLineNo">442</span>     */<a name="line.442"></a>
-<span class="sourceLineNo">443</span>    RAMQueueEntry re =<a name="line.443"></a>
-<span class="sourceLineNo">444</span>        new RAMQueueEntry(cacheKey, cachedItem, accessCount.incrementAndGet(), inMemory);<a name="line.444"></a>
-<span class="sourceLineNo">445</span>    if (ramCache.putIfAbsent(cacheKey, re) != null) {<a name="line.445"></a>
-<span class="sourceLineNo">446</span>      return;<a name="line.446"></a>
-<span class="sourceLineNo">447</span>    }<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    int queueNum = (cacheKey.hashCode() &amp; 0x7FFFFFFF) % writerQueues.size();<a name="line.448"></a>
-<span class="sourceLineNo">449</span>    BlockingQueue&lt;RAMQueueEntry&gt; bq = writerQueues.get(queueNum);<a name="line.449"></a>
-<span class="sourceLineNo">450</span>    boolean successfulAddition = false;<a name="line.450"></a>
-<span class="sourceLineNo">451</span>    if (wait) {<a name="line.451"></a>
-<span class="sourceLineNo">452</span>      try {<a name="line.452"></a>
-<span class="sourceLineNo">453</span>        successfulAddition = bq.offer(re, DEFAULT_CACHE_WAIT_TIME, TimeUnit.MILLISECONDS);<a name="line.453"></a>
-<span class="sourceLineNo">454</span>      } catch (InterruptedException e) {<a name="line.454"></a>
-<span class="sourceLineNo">455</span>        Thread.currentThread().interrupt();<a name="line.455"></a>
-<span class="sourceLineNo">456</span>      }<a name="line.456"></a>
-<span class="sourceLineNo">457</span>    } else {<a name="line.457"></a>
-<span class="sourceLineNo">458</span>      successfulAddition = bq.offer(re);<a name="line.458"></a>
-<span class="sourceLineNo">459</span>    }<a name="line.459"></a>
-<span class="sourceLineNo">460</span>    if (!successfulAddition) {<a name="line.460"></a>
-<span class="sourceLineNo">461</span>      ramCache.remove(cacheKey);<a name="line.461"></a>
-<span class="sourceLineNo">462</span>      cacheStats.failInsert();<a name="line.462"></a>
-<span class="sourceLineNo">463</span>    } else {<a name="line.463"></a>
-<span class="sourceLineNo">464</span>      this.blockNumber.increment();<a name="line.464"></a>
-<span class="sourceLineNo">465</span>      this.heapSize.add(cachedItem.heapSize());<a name="line.465"></a>
-<span class="sourceLineNo">466</span>      blocksByHFile.add(cacheKey);<a name="line.466"></a>
-<span class="sourceLineNo">467</span>    }<a name="line.467"></a>
-<span class="sourceLineNo">468</span>  }<a name="line.468"></a>
-<span class="sourceLineNo">469</span><a name="line.469"></a>
-<span class="sourceLineNo">470</span>  /**<a name="line.470"></a>
-<span class="sourceLineNo">471</span>   * Get the buffer of the block with the specified key.<a name="line.471"></a>
-<span class="sourceLineNo">472</span>   * @param key block's cache key<a name="line.472"></a>
-<span class="sourceLineNo">473</span>   * @param caching true if the caller caches blocks on cache misses<a name="line.473"></a>
-<span class="sourceLineNo">474</span>   * @param repeat Whether this is a repeat lookup for the same block<a name="line.474"></a>
-<span class="sourceLineNo">475</span>   * @param updateCacheMetrics Whether we should update cache metrics or not<a name="line.475"></a>
-<span class="sourceLineNo">476</span>   * @return buffer of specified cache key, or null if not in cache<a name="line.476"></a>
-<span class="sourceLineNo">477</span>   */<a name="line.477"></a>
-<span class="sourceLineNo">478</span>  @Override<a name="line.478"></a>
-<span class="sourceLineNo">479</span>  public Cacheable getBlock(BlockCacheKey key, boolean caching, boolean repeat,<a name="line.479"></a>
-<span class="sourceLineNo">480</span>      boolean updateCacheMetrics) {<a name="line.480"></a>
-<span class="sourceLineNo">481</span>    if (!cacheEnabled) {<a name="line.481"></a>
-<span class="sourceLineNo">482</span>      return null;<a name="line.482"></a>
-<span class="sourceLineNo">483</span>    }<a name="line.483"></a>
-<span class="sourceLineNo">484</span>    RAMQueueEntry re = ramCache.get(key);<a name="line.484"></a>
-<span class="sourceLineNo">485</span>    if (re != null) {<a name="line.485"></a>
-<span class="sourceLineNo">486</span>      if (updateCacheMetrics) {<a name="line.486"></a>
-<span class="sourceLineNo">487</span>        cacheStats.hit(caching, key.isPrimary(), key.getBlockType());<a name="line.487"></a>
-<span class="sourceLineNo">488</span>      }<a name="line.488"></a>
-<span class="sourceLineNo">489</span>      re.access(accessCount.incrementAndGet());<a name="line.489"></a>
-<span class="sourceLineNo">490</span>      return re.getData();<a name="line.490"></a>
-<span class="sourceLineNo">491</span>    }<a name="line.491"></a>
-<span class="sourceLineNo">492</span>    BucketEntry bucketEntry = backingMap.get(key);<a name="line.492"></a>
-<span class="sourceLineNo">493</span>    if (bucketEntry != null) {<a name="line.493"></a>
-<span class="sourceLineNo">494</span>      long start = System.nanoTime();<a name="line.494"></a>
-<span class="sourceLineNo">495</span>      ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.495"></a>
-<span class="sourceLineNo">496</span>      try {<a name="line.496"></a>
-<span class="sourceLineNo">497</span>        lock.readLock().lock();<a name="line.497"></a>
-<span class="sourceLineNo">498</span>        // We can not read here even if backingMap does contain the given key because its offset<a name="line.498"></a>
-<span class="sourceLineNo">499</span>        // maybe changed. If we lock BlockCacheKey instead of offset, then we can only check<a name="line.499"></a>
-<span class="sourceLineNo">500</span>        // existence here.<a name="line.500"></a>
-<span class="sourceLineNo">501</span>        if (bucketEntry.equals(backingMap.get(key))) {<a name="line.501"></a>
-<span class="sourceLineNo">502</span>          // TODO : change this area - should be removed after server cells and<a name="line.502"></a>
-<span class="sourceLineNo">503</span>          // 12295 are available<a name="line.503"></a>
-<span class="sourceLineNo">504</span>          int len = bucketEntry.getLength();<a name="line.504"></a>
-<span class="sourceLineNo">505</span>          if (LOG.isTraceEnabled()) {<a name="line.505"></a>
-<span class="sourceLineNo">506</span>            LOG.trace("Read offset=" + bucketEntry.offset() + ", len=" + len);<a name="line.506"></a>
-<span class="sourceLineNo">507</span>          }<a name="line.507"></a>
-<span class="sourceLineNo">508</span>          Cacheable cachedBlock = ioEngine.read(bucketEntry.offset(), len,<a name="line.508"></a>
-<span class="sourceLineNo">509</span>              bucketEntry.deserializerReference(this.deserialiserMap));<a name="line.509"></a>
-<span class="sourceLineNo">510</span>          long timeTaken = System.nanoTime() - start;<a name="line.510"></a>
-<span class="sourceLineNo">511</span>          if (updateCacheMetrics) {<a name="line.511"></a>
-<span class="sourceLineNo">512</span>            cacheStats.hit(caching, key.isPrimary(), key.getBlockType());<a name="line.512"></a>
-<span class="sourceLineNo">513</span>            cacheStats.ioHit(timeTaken);<a name="line.513"></a>
-<span class="sourceLineNo">514</span>          }<a name="line.514"></a>
-<span class="sourceLineNo">515</span>          if (cachedBlock.getMemoryType() == MemoryType.SHARED) {<a name="line.515"></a>
-<span class="sourceLineNo">516</span>            bucketEntry.refCount.incrementAndGet();<a name="line.516"></a>
-<span class="sourceLineNo">517</span>          }<a name="line.517"></a>
-<span class="sourceLineNo">518</span>          bucketEntry.access(accessCount.incrementAndGet());<a name="line.518"></a>
-<span class="sourceLineNo">519</span>          if (this.ioErrorStartTime &gt; 0) {<a name="line.519"></a>
-<span class="sourceLineNo">520</span>            ioErrorStartTime = -1;<a name="line.520"></a>
-<span class="sourceLineNo">521</span>          }<a name="line.521"></a>
-<span class="sourceLineNo">522</span>          return cachedBlock;<a name="line.522"></a>
-<span class="sourceLineNo">523</span>        }<a name="line.523"></a>
-<span class="sourceLineNo">524</span>      } catch (IOException ioex) {<a name="line.524"></a>
-<span class="sourceLineNo">525</span>        LOG.error("Failed reading block " + key + " from bucket cache", ioex);<a name="line.525"></a>
-<span class="sourceLineNo">526</span>        checkIOErrorIsTolerated();<a name="line.526"></a>
-<span class="sourceLineNo">527</span>      } finally {<a name="line.527"></a>
-<span class="sourceLineNo">528</span>        lock.readLock().unlock();<a name="line.528"></a>
-<span class="sourceLineNo">529</span>      }<a name="line.529"></a>
-<span class="sourceLineNo">530</span>    }<a name="line.530"></a>
-<span class="sourceLineNo">531</span>    if (!repeat &amp;&amp; updateCacheMetrics) {<a name="line.531"></a>
-<span class="sourceLineNo">532</span>      cacheStats.miss(caching, key.isPrimary(), key.getBlockType());<a name="line.532"></a>
-<span class="sourceLineNo">533</span>    }<a name="line.533"></a>
-<span class="sourceLineNo">534</span>    return null;<a name="line.534"></a>
-<span class="sourceLineNo">535</span>  }<a name="line.535"></a>
-<span class="sourceLineNo">536</span><a name="line.536"></a>
-<span class="sourceLineNo">537</span>  @VisibleForTesting<a name="line.537"></a>
-<span class="sourceLineNo">538</span>  void blockEvicted(BlockCacheKey cacheKey, BucketEntry bucketEntry, boolean decrementBlockNumber) {<a name="line.538"></a>
-<span class="sourceLineNo">539</span>    bucketAllocator.freeBlock(bucketEntry.offset());<a name="line.539"></a>
-<span class="sourceLineNo">540</span>    realCacheSize.add(-1 * bucketEntry.getLength());<a name="line.540"></a>
-<span class="sourceLineNo">541</span>    blocksByHFile.remove(cacheKey);<a name="line.541"></a>
-<span class="sourceLineNo">542</span>    if (decrementBlockNumber) {<a name="line.542"></a>
-<span class="sourceLineNo">543</span>      this.blockNumber.decrement();<a name="line.543"></a>
-<span class="sourceLineNo">544</span>    }<a name="line.544"></a>
-<span class="sourceLineNo">545</span>  }<a name="line.545"></a>
-<span class="sourceLineNo">546</span><a name="line.546"></a>
-<span class="sourceLineNo">547</span>  @Override<a name="line.547"></a>
-<span class="sourceLineNo">548</span>  public boolean evictBlock(BlockCacheKey cacheKey) {<a name="line.548"></a>
-<span class="sourceLineNo">549</span>    return evictBlock(cacheKey, true);<a name="line.549"></a>
+<span class="sourceLineNo">430</span>      try {<a name="line.430"></a>
+<span class="sourceLineNo">431</span>        if (BlockCacheUtil.compareCacheBlock(cachedItem, existingBlock) != 0) {<a name="line.431"></a>
+<span class="sourceLineNo">432</span>          throw new RuntimeException("Cached block contents differ, which should not have happened."<a name="line.432"></a>
+<span class="sourceLineNo">433</span>              + "cacheKey:" + cacheKey);<a name="line.433"></a>
+<span class="sourceLineNo">434</span>        }<a name="line.434"></a>
+<span class="sourceLineNo">435</span>        String msg = "Caching an already cached block: " + cacheKey;<a name="line.435"></a>
+<span class="sourceLineNo">436</span>        msg += ". This is harmless and can happen in rare cases (see HBASE-8547)";<a name="line.436"></a>
+<span class="sourceLineNo">437</span>        LOG.warn(msg);<a name="line.437"></a>
+<span class="sourceLineNo">438</span>      } finally {<a name="line.438"></a>
+<span class="sourceLineNo">439</span>        // return the block since we need to decrement the count<a name="line.439"></a>
+<span class="sourceLineNo">440</span>        returnBlock(cacheKey, existingBlock);<a name="line.440"></a>
+<span class="sourceLineNo">441</span>      }<a name="line.441"></a>
+<span class="sourceLineNo">442</span>      return;<a name="line.442"></a>
+<span class="sourceLineNo">443</span>    }<a name="line.443"></a>
+<span class="sourceLineNo">444</span><a name="line.444"></a>
+<span class="sourceLineNo">445</span>    /*<a name="line.445"></a>
+<span class="sourceLineNo">446</span>     * Stuff the entry into the RAM cache so it can get drained to the persistent store<a name="line.446"></a>
+<span class="sourceLineNo">447</span>     */<a name="line.447"></a>
+<span class="sourceLineNo">448</span>    RAMQueueEntry re =<a name="line.448"></a>
+<span class="sourceLineNo">449</span>        new RAMQueueEntry(cacheKey, cachedItem, accessCount.incrementAndGet(), inMemory);<a name="line.449"></a>
+<span class="sourceLineNo">450</span>    if (ramCache.putIfAbsent(cacheKey, re) != null) {<a name="line.450"></a>
+<span class="sourceLineNo">451</span>      return;<a name="line.451"></a>
+<span class="sourceLineNo">452</span>    }<a name="line.452"></a>
+<span class="sourceLineNo">453</span>    int queueNum = (cacheKey.hashCode() &amp; 0x7FFFFFFF) % writerQueues.size();<a name="line.453"></a>
+<span class="sourceLineNo">454</span>    BlockingQueue&lt;RAMQueueEntry&gt; bq = writerQueues.get(queueNum);<a name="line.454"></a>
+<span class="sourceLineNo">455</span>    boolean successfulAddition = false;<a name="line.455"></a>
+<span class="sourceLineNo">456</span>    if (wait) {<a name="line.456"></a>
+<span class="sourceLineNo">457</span>      try {<a name="line.457"></a>
+<span class="sourceLineNo">458</span>        successfulAddition = bq.offer(re, DEFAULT_CACHE_WAIT_TIME, TimeUnit.MILLISECONDS);<a name="line.458"></a>
+<span class="sourceLineNo">459</span>      } catch (InterruptedException e) {<a name="line.459"></a>
+<span class="sourceLineNo">460</span>        Thread.currentThread().interrupt();<a name="line.460"></a>
+<span class="sourceLineNo">461</span>      }<a name="line.461"></a>
+<span class="sourceLineNo">462</span>    } else {<a name="line.462"></a>
+<span class="sourceLineNo">463</span>      successfulAddition = bq.offer(re);<a name="line.463"></a>
+<span class="sourceLineNo">464</span>    }<a name="line.464"></a>
+<span class="sourceLineNo">465</span>    if (!successfulAddition) {<a name="line.465"></a>
+<span class="sourceLineNo">466</span>      ramCache.remove(cacheKey);<a name="line.466"></a>
+<span class="sourceLineNo">467</span>      cacheStats.failInsert();<a name="line.467"></a>
+<span class="sourceLineNo">468</span>    } else {<a name="line.468"></a>
+<span class="sourceLineNo">469</span>      this.blockNumber.increment();<a name="line.469"></a>
+<span class="sourceLineNo">470</span>      this.heapSize.add(cachedItem.heapSize());<a name="line.470"></a>
+<span class="sourceLineNo">471</span>      blocksByHFile.add(cacheKey);<a name="line.471"></a>
+<span class="sourceLineNo">472</span>    }<a name="line.472"></a>
+<span class="sourceLineNo">473</span>  }<a name="line.473"></a>
+<span class="sourceLineNo">474</span><a name="line.474"></a>
+<span class="sourceLineNo">475</span>  /**<a name="line.475"></a>
+<span class="sourceLineNo">476</span>   * Get the buffer of the block with the specified key.<a name="line.476"></a>
+<span class="sourceLineNo">477</span>   * @param key block's cache key<a name="line.477"></a>
+<span class="sourceLineNo">478</span>   * @param caching true if the caller caches blocks on cache misses<a name="line.478"></a>
+<span class="sourceLineNo">479</span>   * @param repeat Whether this is a repeat lookup for the same block<a name="line.479"></a>
+<span class="sourceLineNo">480</span>   * @param updateCacheMetrics Whether we should update cache metrics or not<a name="line.480"></a>
+<span class="sourceLineNo">481</span>   * @return buffer of specified cache key, or null if not in cache<a name="line.481"></a>
+<span class="sourceLineNo">482</span>   */<a name="line.482"></a>
+<span class="sourceLineNo">483</span>  @Override<a name="line.483"></a>
+<span class="sourceLineNo">484</span>  public Cacheable getBlock(BlockCacheKey key, boolean caching, boolean repeat,<a name="line.484"></a>
+<span class="sourceLineNo">485</span>      boolean updateCacheMetrics) {<a name="line.485"></a>
+<span class="sourceLineNo">486</span>    if (!cacheEnabled) {<a name="line.486"></a>
+<span class="sourceLineNo">487</span>      return null;<a name="line.487"></a>
+<span class="sourceLineNo">488</span>    }<a name="line.488"></a>
+<span class="sourceLineNo">489</span>    RAMQueueEntry re = ramCache.get(key);<a name="line.489"></a>
+<span class="sourceLineNo">490</span>    if (re != null) {<a name="line.490"></a>
+<span class="sourceLineNo">491</span>      if (updateCacheMetrics) {<a name="line.491"></a>
+<span class="sourceLineNo">492</span>        cacheStats.hit(caching, key.isPrimary(), key.getBlockType());<a name="line.492"></a>
+<span class="sourceLineNo">493</span>      }<a name="line.493"></a>
+<span class="sourceLineNo">494</span>      re.access(accessCount.incrementAndGet());<a name="line.494"></a>
+<span class="sourceLineNo">495</span>      return re.getData();<a name="line.495"></a>
+<span class="sourceLineNo">496</span>    }<a name="line.496"></a>
+<span class="sourceLineNo">497</span>    BucketEntry bucketEntry = backingMap.get(key);<a name="line.497"></a>
+<span class="sourceLineNo">498</span>    if (bucketEntry != null) {<a name="line.498"></a>
+<span class="sourceLineNo">499</span>      long start = System.nanoTime();<a name="line.499"></a>
+<span class="sourceLineNo">500</span>      ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.500"></a>
+<span class="sourceLineNo">501</span>      try {<a name="line.501"></a>
+<span class="sourceLineNo">502</span>        lock.readLock().lock();<a name="line.502"></a>
+<span class="sourceLineNo">503</span>        // We can not read here even if backingMap does contain the given key because its offset<a name="line.503"></a>
+<span class="sourceLineNo">504</span>        // maybe changed. If we lock BlockCacheKey instead of offset, then we can only check<a name="line.504"></a>
+<span class="sourceLineNo">505</span>        // existence here.<a name="line.505"></a>
+<span class="sourceLineNo">506</span>        if (bucketEntry.equals(backingMap.get(key))) {<a name="line.506"></a>
+<span class="sourceLineNo">507</span>          // TODO : change this area - should be removed after server cells and<a name="line.507"></a>
+<span class="sourceLineNo">508</span>          // 12295 are available<a name="line.508"></a>
+<span class="sourceLineNo">509</span>          int len = bucketEntry.getLength();<a name="line.509"></a>
+<span class="sourceLineNo">510</span>          if (LOG.isTraceEnabled()) {<a name="line.510"></a>
+<span class="sourceLineNo">511</span>            LOG.trace("Read offset=" + bucketEntry.offset() + ", len=" + len);<a name="line.511"></a>
+<span class="sourceLineNo">512</span>          }<a name="line.512"></a>
+<span class="sourceLineNo">513</span>          Cacheable cachedBlock = ioEngine.read(bucketEntry.offset(), len,<a name="line.513"></a>
+<span class="sourceLineNo">514</span>              bucketEntry.deserializerReference(this.deserialiserMap));<a name="line.514"></a>
+<span class="sourceLineNo">515</span>          long timeTaken = System.nanoTime() - start;<a name="line.515"></a>
+<span class="sourceLineNo">516</span>          if (updateCacheMetrics) {<a name="line.516"></a>
+<span class="sourceLineNo">517</span>            cacheStats.hit(caching, key.isPrimary(), key.getBlockType());<a name="line.517"></a>
+<span class="sourceLineNo">518</span>            cacheStats.ioHit(timeTaken);<a name="line.518"></a>
+<span class="sourceLineNo">519</span>          }<a name="line.519"></a>
+<span class="sourceLineNo">520</span>          if (cachedBlock.getMemoryType() == MemoryType.SHARED) {<a name="line.520"></a>
+<span class="sourceLineNo">521</span>            bucketEntry.refCount.incrementAndGet();<a name="line.521"></a>
+<span class="sourceLineNo">522</span>          }<a name="line.522"></a>
+<span class="sourceLineNo">523</span>          bucketEntry.access(accessCount.incrementAndGet());<a name="line.523"></a>
+<span class="sourceLineNo">524</span>          if (this.ioErrorStartTime &gt; 0) {<a name="line.524"></a>
+<span class="sourceLineNo">525</span>            ioErrorStartTime = -1;<a name="line.525"></a>
+<span class="sourceLineNo">526</span>          }<a name="line.526"></a>
+<span class="sourceLineNo">527</span>          return cachedBlock;<a name="line.527"></a>
+<span class="sourceLineNo">528</span>        }<a name="line.528"></a>
+<span class="sourceLineNo">529</span>      } catch (IOException ioex) {<a name="line.529"></a>
+<span class="sourceLineNo">530</span>        LOG.error("Failed reading block " + key + " from bucket cache", ioex);<a name="line.530"></a>
+<span class="sourceLineNo">531</span>        checkIOErrorIsTolerated();<a name="line.531"></a>
+<span class="sourceLineNo">532</span>      } finally {<a name="line.532"></a>
+<span class="sourceLineNo">533</span>        lock.readLock().unlock();<a name="line.533"></a>
+<span class="sourceLineNo">534</span>      }<a name="line.534"></a>
+<span class="sourceLineNo">535</span>    }<a name="line.535"></a>
+<span class="sourceLineNo">536</span>    if (!repeat &amp;&amp; updateCacheMetrics) {<a name="line.536"></a>
+<span class="sourceLineNo">537</span>      cacheStats.miss(caching, key.isPrimary(), key.getBlockType());<a name="line.537"></a>
+<span class="sourceLineNo">538</span>    }<a name="line.538"></a>
+<span class="sourceLineNo">539</span>    return null;<a name="line.539"></a>
+<span class="sourceLineNo">540</span>  }<a name="line.540"></a>
+<span class="sourceLineNo">541</span><a name="line.541"></a>
+<span class="sourceLineNo">542</span>  @VisibleForTesting<a name="line.542"></a>
+<span class="sourceLineNo">543</span>  void blockEvicted(BlockCacheKey cacheKey, BucketEntry bucketEntry, boolean decrementBlockNumber) {<a name="line.543"></a>
+<span class="sourceLineNo">544</span>    bucketAllocator.freeBlock(bucketEntry.offset());<a name="line.544"></a>
+<span class="sourceLineNo">545</span>    realCacheSize.add(-1 * bucketEntry.getLength());<a name="line.545"></a>
+<span class="sourceLineNo">546</span>    blocksByHFile.remove(cacheKey);<a name="line.546"></a>
+<span class="sourceLineNo">547</span>    if (decrementBlockNumber) {<a name="line.547"></a>
+<span class="sourceLineNo">548</span>      this.blockNumber.decrement();<a name="line.548"></a>
+<span class="sourceLineNo">549</span>    }<a name="line.549"></a>
 <span class="sourceLineNo">550</span>  }<a name="line.550"></a>
 <span class="sourceLineNo">551</span><a name="line.551"></a>
-<span class="sourceLineNo">552</span>  // does not check for the ref count. Just tries to evict it if found in the<a name="line.552"></a>
-<span class="sourceLineNo">553</span>  // bucket map<a name="line.553"></a>
-<span class="sourceLineNo">554</span>  private boolean forceEvict(BlockCacheKey cacheKey) {<a name="line.554"></a>
-<span class="sourceLineNo">555</span>    if (!cacheEnabled) {<a name="line.555"></a>
-<span class="sourceLineNo">556</span>      return false;<a name="line.556"></a>
-<span class="sourceLineNo">557</span>    }<a name="line.557"></a>
-<span class="sourceLineNo">558</span>    RAMQueueEntry removedBlock = checkRamCache(cacheKey);<a name="line.558"></a>
-<span class="sourceLineNo">559</span>    BucketEntry bucketEntry = backingMap.get(cacheKey);<a name="line.559"></a>
-<span class="sourceLineNo">560</span>    if (bucketEntry == null) {<a name="line.560"></a>
-<span class="sourceLineNo">561</span>      if (removedBlock != null) {<a name="line.561"></a>
-<span class="sourceLineNo">562</span>        cacheStats.evicted(0, cacheKey.isPrimary());<a name="line.562"></a>
-<span class="sourceLineNo">563</span>        return true;<a name="line.563"></a>
-<span class="sourceLineNo">564</span>      } else {<a name="line.564"></a>
-<span class="sourceLineNo">565</span>        return false;<a name="line.565"></a>
-<span class="sourceLineNo">566</span>      }<a name="line.566"></a>
-<span class="sourceLineNo">567</span>    }<a name="line.567"></a>
-<span class="sourceLineNo">568</span>    ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.568"></a>
-<span class="sourceLineNo">569</span>    try {<a name="line.569"></a>
-<span class="sourceLineNo">570</span>      lock.writeLock().lock();<a name="line.570"></a>
-<span class="sourceLineNo">571</span>      if (backingMap.remove(cacheKey, bucketEntry)) {<a name="line.571"></a>
-<span class="sourceLineNo">572</span>        blockEvicted(cacheKey, bucketEntry, removedBlock == null);<a name="line.572"></a>
-<span class="sourceLineNo">573</span>      } else {<a name="line.573"></a>
-<span class="sourceLineNo">574</span>        return false;<a name="line.574"></a>
-<span class="sourceLineNo">575</span>      }<a name="line.575"></a>
-<span class="sourceLineNo">576</span>    } finally {<a name="line.576"></a>
-<span class="sourceLineNo">577</span>      lock.writeLock().unlock();<a name="line.577"></a>
-<span class="sourceLineNo">578</span>    }<a name="line.578"></a>
-<span class="sourceLineNo">579</span>    cacheStats.evicted(bucketEntry.getCachedTime(), cacheKey.isPrimary());<a name="line.579"></a>
-<span class="sourceLineNo">580</span>    return true;<a name="line.580"></a>
-<span class="sourceLineNo">581</span>  }<a name="line.581"></a>
-<span class="sourceLineNo">582</span><a name="line.582"></a>
-<span class="sourceLineNo">583</span>  private RAMQueueEntry checkRamCache(BlockCacheKey cacheKey) {<a name="line.583"></a>
-<span class="sourceLineNo">584</span>    RAMQueueEntry removedBlock = ramCache.remove(cacheKey);<a name="line.584"></a>
-<span class="sourceLineNo">585</span>    if (removedBlock != null) {<a name="line.585"></a>
-<span class="sourceLineNo">586</span>      this.blockNumber.decrement();<a name="line.586"></a>
-<span class="sourceLineNo">587</span>      this.heapSize.add(-1 * removedBlock.getData().heapSize());<a name="line.587"></a>
-<span class="sourceLineNo">588</span>    }<a name="line.588"></a>
-<span class="sourceLineNo">589</span>    return removedBlock;<a name="line.589"></a>
-<span class="sourceLineNo">590</span>  }<a name="line.590"></a>
-<span class="sourceLineNo">591</span><a name="line.591"></a>
-<span class="sourceLineNo">592</span>  public boolean evictBlock(BlockCacheKey cacheKey, boolean deletedBlock) {<a name="line.592"></a>
-<span class="sourceLineNo">593</span>    if (!cacheEnabled) {<a name="line.593"></a>
-<span class="sourceLineNo">594</span>      return false;<a name="line.594"></a>
-<span class="sourceLineNo">595</span>    }<a name="line.595"></a>
-<span class="sourceLineNo">596</span>    RAMQueueEntry removedBlock = checkRamCache(cacheKey);<a name="line.596"></a>
-<span class="sourceLineNo">597</span>    BucketEntry bucketEntry = backingMap.get(cacheKey);<a name="line.597"></a>
-<span class="sourceLineNo">598</span>    if (bucketEntry == null) {<a name="line.598"></a>
-<span class="sourceLineNo">599</span>      if (removedBlock != null) {<a name="line.599"></a>
-<span class="sourceLineNo">600</span>        cacheStats.evicted(0, cacheKey.isPrimary());<a name="line.600"></a>
-<span class="sourceLineNo">601</span>        return true;<a name="line.601"></a>
-<span class="sourceLineNo">602</span>      } else {<a name="line.602"></a>
-<span class="sourceLineNo">603</span>        return false;<a name="line.603"></a>
-<span class="sourceLineNo">604</span>      }<a name="line.604"></a>
-<span class="sourceLineNo">605</span>    }<a name="line.605"></a>
-<span class="sourceLineNo">606</span>    ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.606"></a>
-<span class="sourceLineNo">607</span>    try {<a name="line.607"></a>
-<span class="sourceLineNo">608</span>      lock.writeLock().lock();<a name="line.608"></a>
-<span class="sourceLineNo">609</span>      int refCount = bucketEntry.refCount.get();<a name="line.609"></a>
-<span class="sourceLineNo">610</span>      if(refCount == 0) {<a name="line.610"></a>
-<span class="sourceLineNo">611</span>        if (backingMap.remove(cacheKey, bucketEntry)) {<a name="line.611"></a>
-<span class="sourceLineNo">612</span>          blockEvicted(cacheKey, bucketEntry, removedBlock == null);<a name="line.612"></a>
-<span class="sourceLineNo">613</span>        } else {<a name="line.613"></a>
-<span class="sourceLineNo">614</span>          return false;<a name="line.614"></a>
-<span class="sourceLineNo">615</span>        }<a name="line.615"></a>
-<span class="sourceLineNo">616</span>      } else {<a name="line.616"></a>
-<span class="sourceLineNo">617</span>        if(!deletedBlock) {<a name="line.617"></a>
-<span class="sourceLineNo">618</span>          if (LOG.isDebugEnabled()) {<a name="line.618"></a>
-<span class="sourceLineNo">619</span>            LOG.debug("This block " + cacheKey + " is still referred by " + refCount<a name="line.619"></a>
-<span class="sourceLineNo">620</span>                + " readers. Can not be freed now");<a name="line.620"></a>
-<span class="sourceLineNo">621</span>          }<a name="line.621"></a>
-<span class="sourceLineNo">622</span>          return false;<a name="line.622"></a>
-<span class="sourceLineNo">623</span>        } else {<a name="line.623"></a>
-<span class="sourceLineNo">624</span>          if (LOG.isDebugEnabled()) {<a name="line.624"></a>
-<span class="sourceLineNo">625</span>            LOG.debug("This block " + cacheKey + " is still referred by " + refCount<a name="line.625"></a>
-<span class="sourceLineNo">626</span>                + " readers. Can not be freed now. Hence will mark this"<a name="line.626"></a>
-<span class="sourceLineNo">627</span>                + " for evicting at a later point");<a name="line.627"></a>
-<span class="sourceLineNo">628</span>          }<a name="line.628"></a>
-<span class="sourceLineNo">629</span>          bucketEntry.markedForEvict = true;<a name="line.629"></a>
-<span class="sourceLineNo">630</span>        }<a name="line.630"></a>
-<span class="sourceLineNo">631</span>      }<a name="line.631"></a>
-<span class="sourceLineNo">632</span>    } finally {<a name="line.632"></a>
-<span class="sourceLineNo">633</span>      lock.writeLock().unlock();<a name="line.633"></a>
-<span class="sourceLineNo">634</span>    }<a name="line.634"></a>
-<span class="sourceLineNo">635</span>    cacheStats.evicted(bucketEntry.getCachedTime(), cacheKey.isPrimary());<a name="line.635"></a>
-<span class="sourceLineNo">636</span>    return true;<a name="line.636"></a>
-<span class="sourceLineNo">637</span>  }<a name="line.637"></a>
-<span class="sourceLineNo">638</span><a name="line.638"></a>
-<span class="sourceLineNo">639</span>  /*<a name="line.639"></a>
-<span class="sourceLineNo">640</span>   * Statistics thread.  Periodically output cache statistics to the log.<a name="line.640"></a>
-<span class="sourceLineNo">641</span>   */<a name="line.641"></a>
-<span class="sourceLineNo">642</span>  private static class StatisticsThread extends Thread {<a name="line.642"></a>
-<span class="sourceLineNo">643</span>    private final BucketCache bucketCache;<a name="line.643"></a>
-<span class="sourceLineNo">644</span><a name="line.644"></a>
-<span class="sourceLineNo">645</span>    public StatisticsThread(BucketCache bucketCache) {<a name="line.645"></a>
-<span class="sourceLineNo">646</span>      super("BucketCacheStatsThread");<a name="line.646"></a>
-<span class="sourceLineNo">647</span>      setDaemon(true);<a name="line.647"></a>
-<span class="sourceLineNo">648</span>      this.bucketCache = bucketCache;<a name="line.648"></a>
-<span class="sourceLineNo">649</span>    }<a name="line.649"></a>
-<span class="sourceLineNo">650</span><a name="line.650"></a>
-<span class="sourceLineNo">651</span>    @Override<a name="line.651"></a>
-<span class="sourceLineNo">652</span>    public void run() {<a name="line.652"></a>
-<span class="sourceLineNo">653</span>      bucketCache.logStats();<a name="line.653"></a>
+<span class="sourceLineNo">552</span>  @Override<a name="line.552"></a>
+<span class="sourceLineNo">553</span>  public boolean evictBlock(BlockCacheKey cacheKey) {<a name="line.553"></a>
+<span class="sourceLineNo">554</span>    return evictBlock(cacheKey, true);<a name="line.554"></a>
+<span class="sourceLineNo">555</span>  }<a name="line.555"></a>
+<span class="sourceLineNo">556</span><a name="line.556"></a>
+<span class="sourceLineNo">557</span>  // does not check for the ref count. Just tries to evict it if found in the<a name="line.557"></a>
+<span class="sourceLineNo">558</span>  // bucket map<a name="line.558"></a>
+<span class="sourceLineNo">559</span>  private boolean forceEvict(BlockCacheKey cacheKey) {<a name="line.559"></a>
+<span class="sourceLineNo">560</span>    if (!cacheEnabled) {<a name="line.560"></a>
+<span class="sourceLineNo">561</span>      return false;<a name="line.561"></a>
+<span class="sourceLineNo">562</span>    }<a name="line.562"></a>
+<span class="sourceLineNo">563</span>    RAMQueueEntry removedBlock = checkRamCache(cacheKey);<a name="line.563"></a>
+<span class="sourceLineNo">564</span>    BucketEntry bucketEntry = backingMap.get(cacheKey);<a name="line.564"></a>
+<span class="sourceLineNo">565</span>    if (bucketEntry == null) {<a name="line.565"></a>
+<span class="sourceLineNo">566</span>      if (removedBlock != null) {<a name="line.566"></a>
+<span class="sourceLineNo">567</span>        cacheStats.evicted(0, cacheKey.isPrimary());<a name="line.567"></a>
+<span class="sourceLineNo">568</span>        return true;<a name="line.568"></a>
+<span class="sourceLineNo">569</span>      } else {<a name="line.569"></a>
+<span class="sourceLineNo">570</span>        return false;<a name="line.570"></a>
+<span class="sourceLineNo">571</span>      }<a name="line.571"></a>
+<span class="sourceLineNo">572</span>    }<a name="line.572"></a>
+<span class="sourceLineNo">573</span>    ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.573"></a>
+<span class="sourceLineNo">574</span>    try {<a name="line.574"></a>
+<span class="sourceLineNo">575</span>      lock.writeLock().lock();<a name="line.575"></a>
+<span class="sourceLineNo">576</span>      if (backingMap.remove(cacheKey, bucketEntry)) {<a name="line.576"></a>
+<span class="sourceLineNo">577</span>        blockEvicted(cacheKey, bucketEntry, removedBlock == null);<a name="line.577"></a>
+<span class="sourceLineNo">578</span>      } else {<a name="line.578"></a>
+<span class="sourceLineNo">579</span>        return false;<a name="line.579"></a>
+<span class="sourceLineNo">580</span>      }<a name="line.580"></a>
+<span class="sourceLineNo">581</span>    } finally {<a name="line.581"></a>
+<span class="sourceLineNo">582</span>      lock.writeLock().unlock();<a name="line.582"></a>
+<span class="sourceLineNo">583</span>    }<a name="line.583"></a>
+<span class="sourceLineNo">584</span>    cacheStats.evicted(bucketEntry.getCachedTime(), cacheKey.isPrimary());<a name="line.584"></a>
+<span class="sourceLineNo">585</span>    return true;<a name="line.585"></a>
+<span class="sourceLineNo">586</span>  }<a name="line.586"></a>
+<span class="sourceLineNo">587</span><a name="line.587"></a>
+<span class="sourceLineNo">588</span>  private RAMQueueEntry checkRamCache(BlockCacheKey cacheKey) {<a name="line.588"></a>
+<span class="sourceLineNo">589</span>    RAMQueueEntry removedBlock = ramCache.remove(cacheKey);<a name="line.589"></a>
+<span class="sourceLineNo">590</span>    if (removedBlock != null) {<a name="line.590"></a>
+<span class="sourceLineNo">591</span>      this.blockNumber.decrement();<a name="line.591"></a>
+<span class="sourceLineNo">592</span>      this.heapSize.add(-1 * removedBlock.getData().heapSize());<a name="line.592"></a>
+<span class="sourceLineNo">593</span>    }<a name="line.593"></a>
+<span class="sourceLineNo">594</span>    return removedBlock;<a name="line.594"></a>
+<span class="sourceLineNo">595</span>  }<a name="line.595"></a>
+<span class="sourceLineNo">596</span><a name="line.596"></a>
+<span class="sourceLineNo">597</span>  public boolean evictBlock(BlockCacheKey cacheKey, boolean deletedBlock) {<a name="line.597"></a>
+<span class="sourceLineNo">598</span>    if (!cacheEnabled) {<a name="line.598"></a>
+<span class="sourceLineNo">599</span>      return false;<a name="line.599"></a>
+<span class="sourceLineNo">600</span>    }<a name="line.600"></a>
+<span class="sourceLineNo">601</span>    RAMQueueEntry removedBlock = checkRamCache(cacheKey);<a name="line.601"></a>
+<span class="sourceLineNo">602</span>    BucketEntry bucketEntry = backingMap.get(cacheKey);<a name="line.602"></a>
+<span class="sourceLineNo">603</span>    if (bucketEntry == null) {<a name="line.603"></a>
+<span class="sourceLineNo">604</span>      if (removedBlock != null) {<a name="line.604"></a>
+<span class="sourceLineNo">605</span>        cacheStats.evicted(0, cacheKey.isPrimary());<a name="line.605"></a>
+<span class="sourceLineNo">606</span>        return true;<a name="line.606"></a>
+<span class="sourceLineNo">607</span>      } else {<a name="line.607"></a>
+<span class="sourceLineNo">608</span>        return false;<a name="line.608"></a>
+<span class="sourceLineNo">609</span>      }<a name="line.609"></a>
+<span class="sourceLineNo">610</span>    }<a name="line.610"></a>
+<span class="sourceLineNo">611</span>    ReentrantReadWriteLock lock = offsetLock.getLock(bucketEntry.offset());<a name="line.611"></a>
+<span class="sourceLineNo">612</span>    try {<a name="line.612"></a>
+<span class="sourceLineNo">613</span>      lock.writeLock().lock();<a name="line.613"></a>
+<span class="sourceLineNo">614</span>      int refCount = bucketEntry.refCount.get();<a name="line.614"></a>
+<span class="sourceLineNo">615</span>      if(refCount == 0) {<a name="line.615"></a>
+<span class="sourceLineNo">616</span>        if (backingMap.remove(cacheKey, bucketEntry)) {<a name="line.616"></a>
+<span class="sourceLineNo">617</span>          blockEvicted(cacheKey, bucketEntry, removedBlock == null);<a name="line.617"></a>
+<span class="sourceLineNo">618</span>        } else {<a name="line.618"></a>
+<span class="sourceLineNo">619</span>          return false;<a name="line.619"></a>
+<span class="sourceLineNo">620</span>        }<a name="line.620"></a>
+<span class="sourceLineNo">621</span>      } else {<a name="line.621"></a>
+<span class="sourceLineNo">622</span>        if(!deletedBlock) {<a name="line.622"></a>
+<span class="sourceLineNo">623</span>          if (LOG.isDebugEnabled()) {<a name="line.623"></a>
+<span class="sourceLineNo">624</span>            LOG.debug("This block " + cacheKey + " is still referred by " + refCount<a name="line.624"></a>
+<span class="sourceLineNo">625</span>                + " readers. Can not be freed now");<a name="line.625"></a>
+<span class="sourceLineNo">626</span>          }<a name="line.626"></a>
+<span class="sourceLineNo">627</span>          return false;<a name="line.627"></a>
+<span class="sourceLineNo">628</span>        } else {<a name="line.628"></a>
+<span class="sourceLineNo">629</span>          if (LOG.isDebugEnabled()) {<a name="line.629"></a>
+<span class="sourceLineNo">630</span>            LOG.debug("This block " + cacheKey + " is still referred by " + refCount<a name="line.630"></a>
+<span class="sourceLineNo">631</span>                + " readers. Can not be freed now. Hence will mark this"<a name="line.631"></a>
+<span class="sourceLineNo">632</span>                + " for evicting at a later point");<a name="line.632"></a>
+<span class="sourceLineNo">633</span>          }<a name="line.633"></a>
+<span class="sourceLineNo">634</span>          bucketEntry.markedForEvict = true;<a name="line.634"></a>
+<span class="sourceLineNo">635</span>        }<a name="line.635"></a>
+<span class="sourceLineNo">636</span>      }<a name="line.636"></a>
+<span class="sourceLineNo">637</span>    } finally {<a name="line.637"></a>
+<span class="sourceLineNo">638</span>      lock.writeLock().unlock();<a name="line.638"></a>
+<span class="sourceLineNo">639</span>    }<a name="line.639"></a>
+<span class="sourceLineNo">640</span>    cacheStats.evicted(bucketEntry.getCachedTime(), cacheKey.isPrimary());<a name="line.640"></a>
+<span class="sourceLineNo">641</span>    return true;<a name="line.641"></a>
+<span class="sourceLineNo">642</span>  }<a name="line.642"></a>
+<span class="sourceLineNo">643</span><a name="line.643"></a>
+<span class="sourceLineNo">644</span>  /*<a name="line.644"></a>
+<span class="sourceLineNo">645</span>   * Statistics thread.  Periodically output cache statistics to the log.<a name="line.645"></a>
+<span class="sourceLineNo">646</span>   */<a name="line.646"></a>
+<span class="sourceLineNo">647</span>  private static class StatisticsThread extends Thread {<a name="line.647"></a>
+<span class="sourceLineNo">648</span>    private final BucketCache bucketCache;<a name="line.648"></a>
+<span class="sourceLineNo">649</span><a name="line.649"></a>
+<span class="sourceLineNo">650</span>    public StatisticsThread(BucketCache bucketCache) {<a name="line.650"></a>
+<span class="sourceLineNo">651</span>      super("BucketCacheStatsThread");<a name="line.651"></a>
+<span class="sourceLineNo">652</span>      setDaemon(true);<a name="line.652"></a>
+<span class="sourceLineNo">653</span>      this.bucketCache = bucketCache;<a name="line.653"></a>
 <span class="sourceLineNo">654</span>    }<a name="line.654"></a>
-<span class="sourceLineNo">655</span>  }<a name="line.655"></a>
-<span class="sourceLineNo">656</span><a name="line.656"></a>
-<span class="sourceLineNo">657</span>  public void logStats() {<a name="line.657"></a>
-<span class="sourceLineNo">658</span>    long totalSize = bucketAllocator.getTotalSize();<a name="line.658"></a>
-<span class="sourceLineNo">659</span>    long usedSize = bucketAllocator.getUsedSize();<a name="line.659"></a>
-<span class="sourceLineNo">660</span>    long freeSize = totalSize - usedSize;<a name="line.660"></a>
-<span class="sourceLineNo">661</span>    long cacheSize = getRealCacheSize();<a name="line.661"></a>
-<span class="sourceLineNo">662</span>    LOG.info("failedBlockAdditions=" + cacheStats.getFailedInserts() + ", " +<a name="line.662"></a>
-<span class="sourceLineNo">663</span>        "totalSize=" + StringUtils.byteDesc(totalSize) + ", " +<a name="line.663"></a>
-<span class="sourceLineNo">664</span>        "freeSize=" + StringUtils.byteDesc(freeSize) + ", " +<a name="line.664"></a>
-<span class="sourceLineNo">665</span>        "usedSize=" + StringUtils.byteDesc(usedSize) +", " +<a name="line.665"></a>
-<span class="sourceLineNo">666</span>        "cacheSize=" + StringUtils.byteDesc(cacheSize) +", " +<a name="line.666"></a>
-<span class="sourceLineNo">667</span>        "accesses=" + cacheStats.getRequestCount() + ", " +<a name="line.667"></a>
-<span class="sourceLineNo">668</span>        "hits=" + cacheStats.getHitCount() + ", " +<a name="line.668"></a>
-<span class="sourceLineNo">669</span>        "IOhitsPerSecond=" + cacheStats.getIOHitsPerSecond() + ", " +<a name="line.669"></a>
-<span class="sourceLineNo">670</span>        "IOTimePerHit=" + String.format("%.2f", cacheStats.getIOTimePerHit())+ ", " +<a name="line.670"></a>
-<span class="sourceLineNo">671</span>        "hitRatio=" + (cacheStats.getHitCount() == 0 ? "0," :<a name="line.671"></a>
-<span class="sourceLineNo">672</span>          (StringUtils.formatPercent(cacheStats.getHitRatio(), 2)+ ", ")) +<a name="line.672"></a>
-<span class="sourceLineNo">673</span>        "cachingAccesses=" + cacheStats.getRequestCachingCount() + ", " +<a name="line.673"></a>
-<span class="sourceLineNo">674</span>        "cachingHits=" + cacheStats.getHitCachingCount() + ", " +<a name="line.674"></a>
-<span class="sourceLineNo">675</span>        "cachingHitsRatio=" +(cacheStats.getHitCachingCount() == 0 ? "0," :<a name="line.675"></a>
-<span class="sourceLineNo">676</span>          (StringUtils.formatPercent(cacheStats.getHitCachingRatio(), 2)+ ", ")) +<a name="line.676"></a>
-<span class="sourceLineNo">677</span>        "evictions=" + cacheStats.getEvictionCount() + ", " +<a name="line.677"></a>
-<span class="sourceLineNo">678</span>        "evicted=" + cacheStats.getEvictedCount() + ", " +<a name="line.678"></a>
-<span class="sourceLineNo">679</span>        "evictedPerRun=" + cacheStats.evictedPerEviction());<a name="line.679"></a>
-<span class="sourceLineNo">680</span>    cacheStats.reset();<a name="line.680"></a>
-<span class="sourceLineNo">681</span>  }<a name="line.681"></a>
-<span class="sourceLineNo">682</span><a name="line.682"></a>
-<span class="sourceLineNo">683</span>  public long getRealCacheSize() {<a name="line.683"></a>
-<span class="sourceLineNo">684</span>    return this.realCacheSize.sum();<a name="line.684"></a>
-<span class="sourceLineNo">685</span>  }<a name="line.685"></a>
-<span class="sourceLineNo">686</span><a name="line.686"></a>
-<span class="sourceLineNo">687</span>  private long acceptableSize() {<a name="line.687"></a>
-<span class="sourceLineNo">688</span>    return (long) Math.floor(bucketAllocator.getTotalSize() * acceptableFactor);<a name="line.688"></a>
-<span class="sourceLineNo">689</span>  }<a name="line.689"></a>
-<span class="sourceLineNo">690</span><a name="line.690"></a>
-<span class="sourceLineNo">691</span>  @VisibleForTesting<a name="line.691"></a>
-<span class="sourceLineNo">692</span>  long getPartitionSize(float partitionFactor) {<a name="line.692"></a>
-<span class="sourceLineNo">693</span>    return (long) Math.floor(bucketAllocator.getTotalSize() * partitionFactor * minFactor);<a name="line.693"></a>
+<span class="sourceLineNo">655</span><a name="line.655"></a>
+<span class="sourceLineNo">656</span>    @Override<a name="line.656"></a>
+<span class="sourceLineNo">657</span>    public void run() {<a name="line.657"></a>
+<span class="sourceLineNo">658</span>      bucketCache.logStats();<a name="line.658"></a>
+<span class="sourceLineNo">659</span>    }<a name="line.659"></a>
+<span class="sourceLineNo">660</span>  }<a name="line.660"></a>
+<span class="sourceLineNo">661</span><a name="line.661"></a>
+<span class="sourceLineNo">662</span>  public void logStats() {<a name="line.662"></a>
+<span class="sourceLineNo">663</span>    long totalSize = bucketAllocator.getTotalSize();<a name="line.663"></a>
+<span class="sourceLineNo">664</span>    long usedSize = bucketAllocator.getUsedSize();<a name="line.664"></a>
+<span class="sourceLineNo">665</span>    long freeSize = totalSize - usedSize;<a name="line.665"></a>
+<span class="sourceLineNo">666</span>    long cacheSize = getRealCacheSize();<a name="line.666"></a>
+<span class="sourceLineNo">667</span>    LOG.info("failedBlockAdditions=" + cacheStats.getFailedInserts() + ", " +<a name="line.667"></a>
+<span class="sourceLineNo">668</span>        "totalSize=" + StringUtils.byteDesc(totalSize) + ", " +<a name="line.668"></a>
+<span class="sourceLineNo">669</span>        "freeSize=" + StringUtils.byteDesc(freeSize) + ", " +<a name="line.669"></a>
+<span class="sourceLineNo">670</span>        "usedSize=" + StringUtils.byteDesc(usedSize) +", " +<a name="line.670"></a>
+<span class="sourceLineNo">671</span>        "cacheSize=" + StringUtils.byteDesc(cacheSize) +", " +<a name="line.671"></a>
+<span class="sourceLineNo">672</span>        "accesses=" + cacheStats.getRequestCount() + ", " +<a name="line.672"></a>
+<span class="sourceLineNo">673</span>        "hits=" + cacheStats.getHitCount() + ", " +<a name="line.673"></a>
+<span class="sourceLineNo">674</span>        "IOhitsPerSecond=" + cacheStats.getIOHitsPerSecond() + ", " +<a name="line.674"></a>
+<span class="sourceLineNo">675</span>        "IOTimePerHit=" + String.format("%.2f", cacheStats.getIOTimePerHit())+ ", " +<a name="line.675"></a>
+<span class="sourceLineNo">676</span>        "hitRatio=" + (cacheStats.getHitCount() == 0 ? "0," :<a name="line.676"></a>
+<span class="sourceLineNo">677</span>          (StringUtils.formatPercent(cacheStats.getHitRatio(), 2)+ ", ")) +<a name="line.677"></a>
+<span class="sourceLineNo">678</span>        "cachingAccesses=" + cacheStats.getRequestCachingCount() + ", " +<a name="line.678"></a>
+<span class="sourceLineNo">679</span>        "cachingHits=" + cacheStats.getHitCachingCount() + ", " +<a name="line.679"></a>
+<span class="sourceLineNo">680</span>        "cachingHitsRatio=" +(cacheStats.getHitCachingCount() == 0 ? "0," :<a name="line.680"></a>
+<span class="sourceLineNo">681</span>          (StringUtils.formatPercent(cacheStats.getHitCachingRatio(), 2)+ ", ")) +<a name="line.681"></a>
+<span class="sourceLineNo">682</span>        "evictions=" + cacheStats.getEvictionCount() + ", " +<a name="line.682"></a>
+<span class="sourceLineNo">683</span>        "evicted=" + cacheStats.getEvictedCount() + ", " +<a name="line.683"></a>
+<span class="sourceLineNo">684</span>        "evictedPerRun=" + cacheStats.evictedPerEviction());<a name="line.684"></a>
+<span class="sourceLineNo">685</span>    cacheStats.reset();<a name="line.685"></a>
+<span class="sourceLineNo">686</span>  }<a name="line.686"></a>
+<span class="sourceLineNo">687</span><a name="line.687"></a>
+<span class="sourceLineNo">688</span>  public long getRealCacheSize() {<a name="line.688"></a>
+<span class="sourceLineNo">689</span>    return this.realCacheSize.sum();<a name="line.689"></a>
+<span class="sourceLineNo">690</span>  }<a name="line.690"></a>
+<span class="sourceLineNo">691</span><a name="line.691"></a>
+<span class="sourceLineNo">692</span>  private long acceptableSize() {<a name="line.692"></a>
+<span class="sourceLineNo">693</span>    return (long) Math.floor(bucketAllocator.getTotalSize() * acceptableFactor);<a name="line.693"></a>
 <span class="sourceLineNo">694</span>  }<a name="line.694"></a>
 <span class="sourceLineNo">695</span><a name="line.695"></a>
-<span class="sourceLineNo">696</span>  /**<a name="line.696"></a>
-<span class="sourceLineNo">697</span>   * Return the count of bucketSizeinfos still need free space<a name="line.697"></a>
-<span class="sourceLineNo">698</span>   */<a name="line.698"></a>
-<span class="sourceLineNo">699</span>  private int bucketSizesAboveThresholdCount(float minFactor) {<a name="line.699"></a>
-<span class="sourceLineNo">700</span>    BucketAllocator.IndexStatistics[] stats = bucketAllocator.getIndexStatistics();<a name="line.700"></a>
-<span class="sourceLineNo">701</span>    int fullCount = 0;<a name="line.701"></a>
-<span class="sourceLineNo">702</span>    for (int i = 0; i &lt; stats.length; i++) {<a name="line.702"></a>
-<span class="sourceLineNo">703</span>      long freeGoal = (long) Math.floor(stats[i].totalCount() * (1 - minFactor));<a name="line.703"></a>
-<span class="sourceLineNo">704</span>      freeGoal = Math.max(freeGoal, 1);<a name="line.704"></a>
-<span class="sourceLineNo">705</span>      if (stats[i].freeCount() &lt; freeGoal) {<a name="line.705"></a>
-<span class="sourceLineNo">706</span>        fullCount++;<a name="line.706"></a>
-<span class="sourceLineNo">707</span>      }<a name="line.707"></a>
-<span class="sourceLineNo">708</span>    }<a name="line.708"></a>
-<span class="sourceLineNo">709</span>    return fullCount;<a name="line.709"></a>
-<span class="sourceLineNo">710</span>  }<a name="line.710"></a>
-<span class="sourceLineNo">711</span><a name="line.711"></a>
-<span class="sourceLineNo">712</span>  /**<a name="line.712"></a>
-<span class="sourceLineNo">713</span>   * This method will find the buckets that are minimally occupied<a name="line.713"></a>
-<span class="sourceLineNo">714</span>   * and are not reference counted and will free them completely<a name="line.714"></a>
-<span class="sourceLineNo">715</span>   * without any constraint on the access times of the elements,<a name="line.715"></a>
-<span class="sourceLineNo">716</span>   * and as a process will completely free at most the number of buckets<a name="line.716"></a>
-<span class="sourceLineNo">717</span>   * passed, sometimes it might not due to changing refCounts<a name="line.717"></a>
-<span class="sourceLineNo">718</span>   *<a name="line.718"></a>
-<span class="sourceLineNo">719</span>   * @param completelyFreeBucketsNeeded number of buckets to free<a name="line.719"></a>
-<span class="sourceLineNo">720</span>   **/<a name="line.720"></a>
-<span class="sourceLineNo">721</span>  private void freeEntireBuckets(int completelyFreeBucketsNeeded) {<a name="line.721"></a>
-<span class="sourceLineNo">722</span>    if (completelyFreeBucketsNeeded != 0) {<a name="line.722"></a>
-<span class="sourceLineNo">723</span>      // First we will build a set where the offsets are reference counted, usually<a name="line.723"></a>
-<span class="sourceLineNo">724</span>      // this set is small around O(Handler Count) unless something else is wrong<a name="line.724"></a>
-<span class="sourceLineNo">725</span>      Set&lt;Integer&gt; inUseBuckets = new HashSet&lt;Integer&gt;();<a name="line.725"></a>
-<span class="sourceLineNo">726</span>      for (BucketEntry entry : backingMap.values()) {<a name="line.726"></a>
-<span class="sourceLineNo">727</span>        if (entry.refCount.get() != 0) {<a name="line.727"></a>
-<span class="sourceLineNo">728</span>          inUseBuckets.add(bucketAllocator.getBucketIndex(entry.offset()));<a name="line.728"></a>
-<span class="sourceLineNo">729</span>        }<a name="line.729"></a>
-<span class="sourceLineNo">730</span>      }<a name="line.730"></a>
-<span class="sourceLineNo">731</span><a name="line.731"></a>
-<span class="sourceLineNo">732</span>      Set&lt;Integer&gt; candidateBuckets = bucketAllocator.getLeastFilledBuckets(<a name="line.732"></a>
-<span class="sourceLineNo">733</span>          inUseBuckets, completelyFreeBucketsNeeded);<a name="line.733"></a>
-<span class="sourceLineNo">734</span>      for (Map.Entry&lt;BlockCacheKey, BucketEntry&gt; entry : backingMap.entrySet()) {<a name="line.734"></a>
-<span class="sourceLineNo">735</span>        if (candidateBuckets.contains(bucketAllocator<a name="line.735"></a>
-<span class="sourceLineNo">736</span>            .getBucketIndex(entry.getValue().offset()))) {<a name="line.736"></a>
-<span class="sourceLineNo">737</span>          evictBlock(entry.getKey(), false);<a name="line.737"></a>
-<span class="sourceLineNo">738</span>        }<a name="line.738"></a>
-<span class="sourceLineNo">739</span>      }<a name="line.739"></a>
-<span class="sourceLineNo">740</span>    }<a name="line.740"></a>
-<span class="sourceLineNo">741</span>  }<a name="line.741"></a>
-<span class="sourceLineNo">742</span><a name="line.742"></a>
-<span class="sourceLineNo">743</span>  /**<a name="line.743"></a>
-<span class="sourceLineNo">744</span>   * Free the space if the used size reaches acceptableSize() or one size block<a name="line.744"></a>
-<span class="sourceLineNo">745</span>   * couldn't be allocated. When freeing the space, we use the LRU algorithm and<a name="line.745"></a>
-<span class="sourceLineNo">746</span>   * ensure there must be some blocks evicted<a name="line.746"></a>
-<span class="sourceLineNo">747</span>   * @param why Why we are being called<a name="line.747"></a>
-<span class="sourceLineNo">748</span>   */<a name="line.748"></a>
-<span class="sourceLineNo">749</span>  private void freeSpace(final String why) {<a name="line.749"></a>
-<span class="sourceLineNo">750</span>    // Ensure only one freeSpace progress at a time<a name="line.750"></a>
-<span class="sourceLineNo">751</span>    if (!freeSpaceLock.tryLock()) {<a name="line.751"></a>
-<span class="sourceLineNo">752</span>      return;<a name="line.752"></a>
-<span class="sourceLineNo">753</span>    }<a name="line.753"></a>
-<span class="sourceLineNo">754</span>    try {<a name="line.754"></a>
-<span class="sourceLineNo">755</span>      freeInProgress = true;<a name="line.755"></a>
-<span class="sourceLineNo">756</span>      long bytesToFreeWithoutExtra = 0;<a name="line.756"></a>
-<span class="sourceLineNo">757</span>      // Calculate free byte for each bucketSizeinfo<a name="line.757"></a>
-<span class="sourceLineNo">758</span>      StringBuilder msgBuffer = LOG.isDebugEnabled()? new StringBuilder(): null;<a name="line.758"></a>
-<span class="sourceLineNo">759</span>      BucketAllocator.IndexStatistics[] stats = bucketAllocator.getIndexStatistics();<a name="line.759"></a>
-<span class="sourceLineNo">760</span>      long[] bytesToFreeForBucket = new long[stats.length];<a name="line.760"></a>
-<span class="sourceLineNo">761</span>      for (int i = 0; i &lt; stats.length; i++) {<a name="line.761"></a>
-<span class="sourceLineNo">762</span>        bytesToFreeForBucket[i] = 0;<a name="line.762"></a>
-<span class="sourceLineNo">763</span>        long freeGoal = (long) Math.floor(stats[i].totalCount() * (1 - minFactor));<a name="line.763"></a>
-<span class="sourceLineNo">764</span>        freeGoal = Math.max(freeGoal, 1);<a name="line.764"></a>
-<span class="sourceLineNo">765</span>        if (stats[i].freeCount() &lt; freeGoal) {<a name="line.765"></a>
-<span class="sourceLineNo">766</span>          bytesToFreeForBucket[i] = stats[i].itemSize() * (freeGoal - stats[i].freeCount());<a name="line.766"></a>
-<span class="sourceLineNo">767</span>          bytesToFreeWithoutExtra += bytesToFreeForBucket[i];<a name="line.767"></a>
-<span class="sourceLineNo">768</span>          if (msgBuffer != null) {<a name="line.768"></a>
-<span class="sourceLineNo">769</span>            msgBuffer.append("Free for bucketSize(" + stats[i].itemSize() + ")="<a name="line.769"></a>
-<span class="sourceLineNo">770</span>              + StringUtils.byteDesc(bytesToFreeForBucket[i]) + ", ");<a name="line.770"></a>
-<span class="sourceLineNo">771</span>          }<a name="line.771"></a>
-<span class="sourceLineNo">772</span>        }<a name="line.772"></a>
-<span class="sourceLineNo">773</span>      }<a name="line.773"></a>
-<span class="sourceLineNo">774</span>      if (msgBuffer != null) {<a name="line.774"></a>
-<span class="sourceLineNo">775</span>        msgBuffer.append("Free for total=" + StringUtils.byteDesc(bytesToFreeWithoutExtra) + ", ");<a name="line.775"></a>
-<span class="sourceLineNo">776</span>      }<a name="line.776"></a>
-<span class="sourceLineNo">777</span><a name="line.777"></a>
-<span class="sourceLineNo">778</span>      if (bytesToFreeWithoutExtra &lt;= 0) {<a name="line.778"></a>
-<span class="sourceLineNo">779</span>        return;<a name="line.779"></a>
-<span class="sourceLineNo">780</span>      }<a name="line.780"></a>
-<span class="sourceLineNo">781</span>      long currentSize = bucketAllocator.getUsedSize();<a name="line.781"></a>
-<span class="sourceLineNo">782</span>      long totalSize = bucketAllocator.getTotalSize();<a name="line.782"></a>
-<span class="sourceLineNo">783</span>      if (LOG.isDebugEnabled() &amp;&amp; msgBuffer != null) {<a name="line.783"></a>
-<span class="sourceLineNo">784</span>        LOG.debug("Free started because \"" + why + "\"; " + msgBuffer.toString() +<a name="line.784"></a>
-<span class="sourceLineNo">785</span>          " of current used=" + StringUtils.byteDesc(currentSize) + ", actual cacheSize=" +<a name="line.785"></a>
-<span class="sourceLineNo">786</span>          StringUtils.byteDesc(realCacheSize.sum()) + ", total=" + StringUtils.byteDesc(totalSize));<a name="line.786"></a>
-<span class="sourceLineNo">787</span>      }<a name="line.787"></a>
-<span class="sourceLineNo">788</span><a name="line.788"></a>
-<span class="sourceLineNo">789</span>      long bytesToFreeWithExtra = (long) Math.floor(bytesToFreeWithoutExtra<a name="line.789"></a>
-<span class="sourceLineNo">790</span>          * (1 + extraFreeFactor));<a name="line.790"></a>
-<span class="sourceLineNo">791</span><a name="line.791"></a>
-<span class="sourceLineNo">792</span>      // Instantiate priority buckets<a name="line.792"></a>
-<span class="sourceLineNo">793</span>      BucketEntryGroup bucketSingle = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.793"></a>
-<span class="sourceLineNo">794</span>          blockSize, getPartitionSize(singleFactor));<a name="line.794"></a>
-<span class="sourceLineNo">795</span>      BucketEntryGroup bucketMulti = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.795"></a>
-<span class="sourceLineNo">796</span>          blockSize, getPartitionSize(multiFactor));<a name="line.796"></a>
-<span class="sourceLineNo">797</span>      BucketEntryGroup bucketMemory = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.797"></a>
-<span class="sourceLineNo">798</span>          blockSize, getPartitionSize(memoryFactor));<a name="line.798"></a>
-<span class="sourceLineNo">799</span><a name="line.799"></a>
-<span class="sourceLineNo">800</span>      // Scan entire map putting bucket entry into appropriate bucket entry<a name="line.800"></a>
-<span class="sourceLineNo">801</span>      // group<a name="line.801"></a>
-<span class="sourceLineNo">802</span>      for (Map.Entry&lt;BlockCacheKey, BucketEntry&gt; bucketEntryWithKey : backingMap.entrySet()) {<a name="line.802"></a>
-<span class="sourceLineNo">803</span>        switch (bucketEntryWithKey.getValue().getPriority()) {<a name="line.803"></a>
-<span class="sourceLineNo">804</span>          case SINGLE: {<a name="line.804"></a>
-<span class="sourceLineNo">805</span>            bucketSingle.add(bucketEntryWithKey);<a name="line.805"></a>
-<span class="sourceLineNo">806</span>            break;<a name="line.806"></a>
-<span class="sourceLineNo">807</span>          }<a name="line.807"></a>
-<span class="sourceLineNo">808</span>          case MULTI: {<a name="line.808"></a>
-<span class="sourceLineNo">809</span>            bucketMulti.add(bucketEntryWithKey);<a name="line.809"></a>
-<span class="sourceLineNo">810</span>            break;<a name="line.810"></a>
-<span class="sourceLineNo">811</span>          }<a name="line.811"></a>
-<span class="sourceLineNo">812</span>          case MEMORY: {<a name="line.812"></a>
-<span class="sourceLineNo">813</span>            bucketMemory.add(bucketEntryWithKey);<a name="line.813"></a>
-<span class="sourceLineNo">814</span>            break;<a name="line.814"></a>
-<span class="sourceLineNo">815</span>          }<a name="line.815"></a>
-<span class="sourceLineNo">816</span>        }<a name="line.816"></a>
-<span class="sourceLineNo">817</span>      }<a name="line.817"></a>
-<span class="sourceLineNo">818</span><a name="line.818"></a>
-<span class="sourceLineNo">819</span>      PriorityQueue&lt;BucketEntryGroup&gt; bucketQueue = new PriorityQueue&lt;&gt;(3);<a name="line.819"></a>
-<span class="sourceLineNo">820</span><a name="line.820"></a>
-<span class="sourceLineNo">821</span>      bucketQueue.add(bucketSingle);<a name="line.821"></a>
-<span class="sourceLineNo">822</span>      bucketQueue.add(bucketMulti);<a name="line.822"></a>
-<span class="sourceLineNo">823</span>      bucketQueue.add(bucketMemory);<a name="line.823"></a>
-<span class="sourceLineNo">824</span><a name="line.824"></a>
-<span class="sourceLineNo">825</span>      int remainingBuckets = 3;<a name="line.825"></a>
-<span class="sourceLineNo">826</span>      long bytesFreed = 0;<a name="line.826"></a>
-<span class="sourceLineNo">827</span><a name="line.827"></a>
-<span class="sourceLineNo">828</span>      BucketEntryGroup bucketGroup;<a name="line.828"></a>
-<span class="sourceLineNo">829</span>      while ((bucketGroup = bucketQueue.poll()) != null) {<a name="line.829"></a>
-<span class="sourceLineNo">830</span>        long overflow = bucketGroup.overflow();<a name="line.830"></a>
-<span class="sourceLineNo">831</span>        if (overflow &gt; 0) {<a name="line.831"></a>
-<span class="sourceLineNo">832</span>          long bucketBytesToFree = Math.min(overflow,<a name="line.832"></a>
-<span class="sourceLineNo">833</span>              (bytesToFreeWithoutExtra - bytesFreed) / remainingBuckets);<a name="line.833"></a>
-<span class="sourceLineNo">834</span>          bytesFreed += bucketGroup.free(bucketBytesToFree);<a name="line.834"></a>
-<span class="sourceLineNo">835</span>        }<a name="line.835"></a>
-<span class="sourceLineNo">836</span>        remainingBuckets--;<a name="line.836"></a>
-<span class="sourceLineNo">837</span>      }<a name="line.837"></a>
-<span class="sourceLineNo">838</span><a name="line.838"></a>
-<span class="sourceLineNo">839</span>      // Check and free if there are buckets that still need freeing of space<a name="line.839"></a>
-<span class="sourceLineNo">840</span>      if (bucketSizesAboveThresholdCount(minFactor) &gt; 0) {<a name="line.840"></a>
-<span class="sourceLineNo">841</span>        bucketQueue.clear();<a name="line.841"></a>
-<span class="sourceLineNo">842</span>        remainingBuckets = 3;<a name="line.842"></a>
+<span class="sourceLineNo">696</span>  @VisibleForTesting<a name="line.696"></a>
+<span class="sourceLineNo">697</span>  long getPartitionSize(float partitionFactor) {<a name="line.697"></a>
+<span class="sourceLineNo">698</span>    return (long) Math.floor(bucketAllocator.getTotalSize() * partitionFactor * minFactor);<a name="line.698"></a>
+<span class="sourceLineNo">699</span>  }<a name="line.699"></a>
+<span class="sourceLineNo">700</span><a name="line.700"></a>
+<span class="sourceLineNo">701</span>  /**<a name="line.701"></a>
+<span class="sourceLineNo">702</span>   * Return the count of bucketSizeinfos still need free space<a name="line.702"></a>
+<span class="sourceLineNo">703</span>   */<a name="line.703"></a>
+<span class="sourceLineNo">704</span>  private int bucketSizesAboveThresholdCount(float minFactor) {<a name="line.704"></a>
+<span class="sourceLineNo">705</span>    BucketAllocator.IndexStatistics[] stats = bucketAllocator.getIndexStatistics();<a name="line.705"></a>
+<span class="sourceLineNo">706</span>    int fullCount = 0;<a name="line.706"></a>
+<span class="sourceLineNo">707</span>    for (int i = 0; i &lt; stats.length; i++) {<a name="line.707"></a>
+<span class="sourceLineNo">708</span>      long freeGoal = (long) Math.floor(stats[i].totalCount() * (1 - minFactor));<a name="line.708"></a>
+<span class="sourceLineNo">709</span>      freeGoal = Math.max(freeGoal, 1);<a name="line.709"></a>
+<span class="sourceLineNo">710</span>      if (stats[i].freeCount() &lt; freeGoal) {<a name="line.710"></a>
+<span class="sourceLineNo">711</span>        fullCount++;<a name="line.711"></a>
+<span class="sourceLineNo">712</span>      }<a name="line.712"></a>
+<span class="sourceLineNo">713</span>    }<a name="line.713"></a>
+<span class="sourceLineNo">714</span>    return fullCount;<a name="line.714"></a>
+<span class="sourceLineNo">715</span>  }<a name="line.715"></a>
+<span class="sourceLineNo">716</span><a name="line.716"></a>
+<span class="sourceLineNo">717</span>  /**<a name="line.717"></a>
+<span class="sourceLineNo">718</span>   * This method will find the buckets that are minimally occupied<a name="line.718"></a>
+<span class="sourceLineNo">719</span>   * and are not reference counted and will free them completely<a name="line.719"></a>
+<span class="sourceLineNo">720</span>   * without any constraint on the access times of the elements,<a name="line.720"></a>
+<span class="sourceLineNo">721</span>   * and as a process will completely free at most the number of buckets<a name="line.721"></a>
+<span class="sourceLineNo">722</span>   * passed, sometimes it might not due to changing refCounts<a name="line.722"></a>
+<span class="sourceLineNo">723</span>   *<a name="line.723"></a>
+<span class="sourceLineNo">724</span>   * @param completelyFreeBucketsNeeded number of buckets to free<a name="line.724"></a>
+<span class="sourceLineNo">725</span>   **/<a name="line.725"></a>
+<span class="sourceLineNo">726</span>  private void freeEntireBuckets(int completelyFreeBucketsNeeded) {<a name="line.726"></a>
+<span class="sourceLineNo">727</span>    if (completelyFreeBucketsNeeded != 0) {<a name="line.727"></a>
+<span class="sourceLineNo">728</span>      // First we will build a set where the offsets are reference counted, usually<a name="line.728"></a>
+<span class="sourceLineNo">729</span>      // this set is small around O(Handler Count) unless something else is wrong<a name="line.729"></a>
+<span class="sourceLineNo">730</span>      Set&lt;Integer&gt; inUseBuckets = new HashSet&lt;Integer&gt;();<a name="line.730"></a>
+<span class="sourceLineNo">731</span>      for (BucketEntry entry : backingMap.values()) {<a name="line.731"></a>
+<span class="sourceLineNo">732</span>        if (entry.refCount.get() != 0) {<a name="line.732"></a>
+<span class="sourceLineNo">733</span>          inUseBuckets.add(bucketAllocator.getBucketIndex(entry.offset()));<a name="line.733"></a>
+<span class="sourceLineNo">734</span>        }<a name="line.734"></a>
+<span class="sourceLineNo">735</span>      }<a name="line.735"></a>
+<span class="sourceLineNo">736</span><a name="line.736"></a>
+<span class="sourceLineNo">737</span>      Set&lt;Integer&gt; candidateBuckets = bucketAllocator.getLeastFilledBuckets(<a name="line.737"></a>
+<span class="sourceLineNo">738</span>          inUseBuckets, completelyFreeBucketsNeeded);<a name="line.738"></a>
+<span class="sourceLineNo">739</span>      for (Map.Entry&lt;BlockCacheKey, BucketEntry&gt; entry : backingMap.entrySet()) {<a name="line.739"></a>
+<span class="sourceLineNo">740</span>        if (candidateBuckets.contains(bucketAllocator<a name="line.740"></a>
+<span class="sourceLineNo">741</span>            .getBucketIndex(entry.getValue().offset()))) {<a name="line.741"></a>
+<span class="sourceLineNo">742</span>          evictBlock(entry.getKey(), false);<a name="line.742"></a>
+<span class="sourceLineNo">743</span>        }<a name="line.743"></a>
+<span class="sourceLineNo">744</span>      }<a name="line.744"></a>
+<span class="sourceLineNo">745</span>    }<a name="line.745"></a>
+<span class="sourceLineNo">746</span>  }<a name="line.746"></a>
+<span class="sourceLineNo">747</span><a name="line.747"></a>
+<span class="sourceLineNo">748</span>  /**<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   * Free the space if the used size reaches acceptableSize() or one size block<a name="line.749"></a>
+<span class="sourceLineNo">750</span>   * couldn't be allocated. When freeing the space, we use the LRU algorithm and<a name="line.750"></a>
+<span class="sourceLineNo">751</span>   * ensure there must be some blocks evicted<a name="line.751"></a>
+<span class="sourceLineNo">752</span>   * @param why Why we are being called<a name="line.752"></a>
+<span class="sourceLineNo">753</span>   */<a name="line.753"></a>
+<span class="sourceLineNo">754</span>  private void freeSpace(final String why) {<a name="line.754"></a>
+<span class="sourceLineNo">755</span>    // Ensure only one freeSpace progress at a time<a name="line.755"></a>
+<span class="sourceLineNo">756</span>    if (!freeSpaceLock.tryLock()) {<a name="line.756"></a>
+<span class="sourceLineNo">757</span>      return;<a name="line.757"></a>
+<span class="sourceLineNo">758</span>    }<a name="line.758"></a>
+<span class="sourceLineNo">759</span>    try {<a name="line.759"></a>
+<span class="sourceLineNo">760</span>      freeInProgress = true;<a name="line.760"></a>
+<span class="sourceLineNo">761</span>      long bytesToFreeWithoutExtra = 0;<a name="line.761"></a>
+<span class="sourceLineNo">762</span>      // Calculate free byte for each bucketSizeinfo<a name="line.762"></a>
+<span class="sourceLineNo">763</span>      StringBuilder msgBuffer = LOG.isDebugEnabled()? new StringBuilder(): null;<a name="line.763"></a>
+<span class="sourceLineNo">764</span>      BucketAllocator.IndexStatistics[] stats = bucketAllocator.getIndexStatistics();<a name="line.764"></a>
+<span class="sourceLineNo">765</span>      long[] bytesToFreeForBucket = new long[stats.length];<a name="line.765"></a>
+<span class="sourceLineNo">766</span>      for (int i = 0; i &lt; stats.length; i++) {<a name="line.766"></a>
+<span class="sourceLineNo">767</span>        bytesToFreeForBucket[i] = 0;<a name="line.767"></a>
+<span class="sourceLineNo">768</span>        long freeGoal = (long) Math.floor(stats[i].totalCount() * (1 - minFactor));<a name="line.768"></a>
+<span class="sourceLineNo">769</span>        freeGoal = Math.max(freeGoal, 1);<a name="line.769"></a>
+<span class="sourceLineNo">770</span>        if (stats[i].freeCount() &lt; freeGoal) {<a name="line.770"></a>
+<span class="sourceLineNo">771</span>          bytesToFreeForBucket[i] = stats[i].itemSize() * (freeGoal - stats[i].freeCount());<a name="line.771"></a>
+<span class="sourceLineNo">772</span>          bytesToFreeWithoutExtra += bytesToFreeForBucket[i];<a name="line.772"></a>
+<span class="sourceLineNo">773</span>          if (msgBuffer != null) {<a name="line.773"></a>
+<span class="sourceLineNo">774</span>            msgBuffer.append("Free for bucketSize(" + stats[i].itemSize() + ")="<a name="line.774"></a>
+<span class="sourceLineNo">775</span>              + StringUtils.byteDesc(bytesToFreeForBucket[i]) + ", ");<a name="line.775"></a>
+<span class="sourceLineNo">776</span>          }<a name="line.776"></a>
+<span class="sourceLineNo">777</span>        }<a name="line.777"></a>
+<span class="sourceLineNo">778</span>      }<a name="line.778"></a>
+<span class="sourceLineNo">779</span>      if (msgBuffer != null) {<a name="line.779"></a>
+<span class="sourceLineNo">780</span>        msgBuffer.append("Free for total=" + StringUtils.byteDesc(bytesToFreeWithoutExtra) + ", ");<a name="line.780"></a>
+<span class="sourceLineNo">781</span>      }<a name="line.781"></a>
+<span class="sourceLineNo">782</span><a name="line.782"></a>
+<span class="sourceLineNo">783</span>      if (bytesToFreeWithoutExtra &lt;= 0) {<a name="line.783"></a>
+<span class="sourceLineNo">784</span>        return;<a name="line.784"></a>
+<span class="sourceLineNo">785</span>      }<a name="line.785"></a>
+<span class="sourceLineNo">786</span>      long currentSize = bucketAllocator.getUsedSize();<a name="line.786"></a>
+<span class="sourceLineNo">787</span>      long totalSize = bucketAllocator.getTotalSize();<a name="line.787"></a>
+<span class="sourceLineNo">788</span>      if (LOG.isDebugEnabled() &amp;&amp; msgBuffer != null) {<a name="line.788"></a>
+<span class="sourceLineNo">789</span>        LOG.debug("Free started because \"" + why + "\"; " + msgBuffer.toString() +<a name="line.789"></a>
+<span class="sourceLineNo">790</span>          " of current used=" + StringUtils.byteDesc(currentSize) + ", actual cacheSize=" +<a name="line.790"></a>
+<span class="sourceLineNo">791</span>          StringUtils.byteDesc(realCacheSize.sum()) + ", total=" + StringUtils.byteDesc(totalSize));<a name="line.791"></a>
+<span class="sourceLineNo">792</span>      }<a name="line.792"></a>
+<span class="sourceLineNo">793</span><a name="line.793"></a>
+<span class="sourceLineNo">794</span>      long bytesToFreeWithExtra = (long) Math.floor(bytesToFreeWithoutExtra<a name="line.794"></a>
+<span class="sourceLineNo">795</span>          * (1 + extraFreeFactor));<a name="line.795"></a>
+<span class="sourceLineNo">796</span><a name="line.796"></a>
+<span class="sourceLineNo">797</span>      // Instantiate priority buckets<a name="line.797"></a>
+<span class="sourceLineNo">798</span>      BucketEntryGroup bucketSingle = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.798"></a>
+<span class="sourceLineNo">799</span>          blockSize, getPartitionSize(singleFactor));<a name="line.799"></a>
+<span class="sourceLineNo">800</span>      BucketEntryGroup bucketMulti = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.800"></a>
+<span class="sourceLineNo">801</span>          blockSize, getPartitionSize(multiFactor));<a name="line.801"></a>
+<span class="sourceLineNo">802</span>      BucketEntryGroup bucketMemory = new BucketEntryGroup(bytesToFreeWithExtra,<a name="line.802"></a>
+<span class="sourceLineNo">803</span>          blockSize, getPartitionSize(memoryFactor));<a name="line.803"></a>
+<span class="sourceLineNo">804</span><a name="line.804"></a>
+<span class="sourceLineNo">805</span>      // Scan entire map putting bucket entry into appropriate bucket entry<a name="line.805"></a>
+<span class="sourceLineNo">806</span>      // group<a name="line.806"></a>
+<span class="sourceLineNo">807</span>      for (Map.Entry&lt;BlockCacheKey, BucketEntry&gt; bucketEntryWithKey : backingMap.entrySet()) {<a name="line.807"></a>
+<span class="sourceLineNo">808</span>        switch (bucketEntryWithKey.getValue().getPriority()) {<a name="line.808"></a>
+<span class="sourceLineNo">809</span>          case SINGLE: {<a name="line.809"></a>
+<span class="sourceLineNo">810</span>            bucketSingle.add(bucketEntryWithKey);<a name="line.810"></a>
+<span class="sourceLineNo">811</span>            break;<a name="line.811"></a>
+<span class="sourceLineNo">812</span>          }<a name="line.812"></a>
+<span class="sourceLineNo">813</span>          case MULTI: {<a name="line.813"></a>
+<span class="sourceLineNo">814</span>            bucketMulti.add(bucketEntryWithKey);<a name="line.814"></a>
+<span class="sourceLineNo">815</span>            break;<a name="line.815"></a>
+<span class="sourceLineNo">816</span>          }<a name="line.816"></a>
+<span class="sourceLineNo">817</span>          case MEMORY: {<a name="line.817"></a>
+<span class="sourceLineNo">818</span>            bucketMemory.add(bucketEntryWithKey);<a name="line.818"></a>
+<span class="sourceLineNo">819</span>            break;<a name="line.819"></a>
+<span class="sourceLineNo">820</span>          }<a name="line.820"></a>
+<span class="sourceLineNo">821</span>        }<a name="line.821"></a>
+<span class="sourceLineNo">822</span>      }<a name="line.822"></a>
+<span class="sourceLineNo">823</span><a name="line.823"></a>
+<span class="sourceLineNo">824</span>      PriorityQueue&lt;BucketEntryGroup&gt; bucketQueue = new PriorityQueue&lt;&gt;(3);<a name="line.824"></a>
+<span class="sourceLineNo">825</span><a name="line.825"></a>
+<span class="sourceLineNo">826</span>      bucketQueue.add(bucketSingle);<a name="line.826"></a>
+<span class="sourceLineNo">827</span>      bucketQueue.add(bucketMulti);<a name="line.827"></a>
+<span class="sourceLineNo">828</span>      bucketQueue.add(bucketMemory);<a name="line.828"></a>
+<span class="sourceLineNo">829</span><a name="line.829"></a>
+<span class="sourceLineNo">830</span>      int remainingBuckets = 3;<a name="line.830"></a>
+<span class="sourceLineNo">831</span>      long bytesFreed = 0;<a name="line.831"></a>
+<span class="sourceLineNo">832</span><a name="line.832"></a>
+<span class="sourceLineNo">833</span>      BucketEntryGroup bucketGroup;<a name="line.833"></a>
+<span class="sourceLineNo">834</span>      while ((bucketGroup = bucketQueue.poll()) != null) {<a name="line.834"></a>
+<span class="sourceLineNo">835</span>        long overflow = bucketGroup.overflow();<a name="line.835"></a>
+<span class="sourceLineNo">836</span>        if (overflow &gt; 0) {<a name="line.836"></a>
+<span class="sourceLineNo">837</span>          long bucketBytesToFree = Math.min(overflow,<a name="line.837"></a>
+<span class="sourceLineNo">838</span>              (bytesToFreeWithoutExtra - bytesFreed) / remainingBuckets);<a name="line.838"></a>
+<span class="sourceLineNo">839</span>          bytesFreed += bucketGroup.free(bucketBytesToFree);<a name="line.839"></a>
+<span class="sourceLineNo">840</span>        }<a name="line.840"></a>
+<span class="sourceLineNo">841</span>        remainingBuckets--;<a name="line.841"></a>
+<span class="sourceLineNo">842</span>      }<a name="line.842"></a>
 <span class="sourceLineNo">843</span><a name="line.843"></a>
-<span class="sourceLineNo">844</span>        bucketQueue.add(bucketSingle);<a name="line.844"></a>
-<span class="sourceLineNo">845</span>        bucketQueue.add(bucketMulti);<a name="line.845"></a>
-<span class="sourceLineNo">846</span>        bucketQueue.add(bucketMemory);<a name="line.846"></a>
-<span class="sourceLineNo">847</span><a name="line.847"></a>
-<span class="sourceLineNo">848</span>        while ((bucketGroup = bucketQueue.poll()) != null) {<a name="line.848"></a>
-<span class="sourceLineNo">849</span>          long bucketBytesToFree = (bytesToFreeWithExtra - bytesFreed) / remainingBuckets;<a name="line.849"></a>
-<span class="sourceLineNo">850</span>          bytesFreed += bucketGroup.free(bucketBytesToFree);<a name="line.850"></a>
-<span class="sourceLineNo">851</span>          remainingBuckets--;<a name="line.851"></a>
-<span class="sourceLineNo">852</span>        }<a name="line.852"></a>
-<span class="sourceLineNo">853</span>      }<a name="line.853"></a>
-<span class="sourceLineNo">854</span><a name="line.854"></a>
-<span class="sourceLineNo">855</span>      // Even after the above free we might still need freeing because of the<a name="line.855"></a>
-<span class="sourceLineNo">856</span>      // De-fragmentation of the buckets (also called Slab Calcification problem), i.e<a name="line.856"></a>
-<span class="sourceLineNo">857</span>      // there might be some buckets where the occupancy is very sparse and thus are not<a name="line.857"></a>
-<span class="sourceLineNo">858</span>      // yielding the free for the other bucket sizes, the fix for this to evict some<a name="line.858"></a>
-<span class="sourceLineNo">859</span>      // of the buckets, we do this by evicting the buckets that are least fulled<a name="line.859"></a>
-<span class="sourceLineNo">860</span>      freeEntireBuckets(DEFAULT_FREE_ENTIRE_BLOCK_FACTOR *<a name="line.860"></a>
-<span class="sourceLineNo">861</span>          bucketSizesAboveThresholdCount(1.0f));<a name="line.861"></a>
-<span class="sourceLineNo">862</span><a name="line.862"></a>
-<span class="sourceLineNo">863</span>      if (LOG.isDebugEnabled()) {<a name="line.863"></a>
-<span class="sourceLineNo">864</span>        long single = bucketSingle.totalSize();<a name="line.864"></a>
-<span class="sourceLineNo">865</span>        long multi = bucketMulti.totalSize();<a name="line.865"></a>
-<span class="sourceLineNo">866</span>        long memory = bucketMemory.totalSize();<a name="line.866"></a>
-<span class="sourceLineNo">867</span>        if (LOG.isDebugEnabled()) {<a name="line.867"></a>
-<span class="sourceLineNo">868</span>          LOG.debug("Bucket cache free space completed; " + "freed="<a name="line.868"></a>
-<span class="sourceLineNo">869</span>            + StringUtils.byteDesc(bytesFreed) + ", " + "total="<a name="line.869"></a>
-<span class="sourceLineNo">870</span>            + StringUtils.byteDesc(totalSize) + ", " + "single="<a name="line.870"></a>
-<span class="sourceLineNo">871</span>            + StringUtils.byteDesc(single) + ", " + "multi="<a name="line.871"></a>
-<span class="sourceLineNo">872</span>            + StringUtils.byteDesc(multi) + ", " + "memory="<a name="line.872"></a>
-<span class="sourceLineNo">873</span>            + StringUtils.byteDesc(memory));<a name="line.873"></a>
-<span class="sourceLineNo">874</span>        }<a name="line.874"></a>
-<span class="sourceLineNo">875</span>      }<a name="line.875"></a>
-<span class="sourceLineNo">876</span><a name="line.876"></a>
-<span class="sourceLineNo">877</span>    } catch (Throwable t) {<a name="line.877"></a>
-<span class="sourceLineNo">878</span>      LOG.warn("Failed freeing space", t);<a name="line.878"></a>
-<span class="sourceLineNo">879</span>    } finally {<a name="line.879"></a>
-<span class="sourceLineNo">880</span>      cacheStats.evict();<a name="line.880"></a>
-<span class="sourceLineNo">881</span>      freeInProgress = false;<a name="line.881"></a>
-<span class="sourceLineNo">882</span>      freeSpaceLock.unlock();<a name="line.882"></a>
-<span class="sourceLineNo">883</span>    }<a name="line.883"></a>
-<span class="sourceLineNo">884</span>  }<a name="line.884"></a>
-<span class="sourceLineNo">885</span><a name="line.885"></a>
-<span class="sourceLineNo">886</span>  // This handles flushing the RAM cache to IOEngine.<a name="line.886"></a>
-<span class="sourceLineNo">887</span>  @VisibleForTesting<a name="line.887"></a>
-<span class="sourceLineNo">888</span>  class WriterThread extends HasThread {<a name="line.888"></a>
-<span class="sourceLineNo">889</span>    private final BlockingQueue&lt;RAMQueueEntry&gt; inputQueue;<a name="line.889"></a>
-<span class="sourceLineNo">890</span>    private volatile boolean writerEnabled = true;<a name="line.890"></a>
-<span class="sourceLineNo">891</span><a name="line.891"></a>
-<span class="sourceLineNo">892</span>    WriterThread(BlockingQueue&lt;RAMQueueEntry&gt; queue) {<a name="line.892"></a>
-<span class="sourceLineNo">893</span>      super("BucketCacheWriterThread");<a name="line.893"></a>
-<span class="sourceLineNo">894</span>      this.inputQueue = queue;<a name="line.894"></a>
-<span class="sourceLineNo">895</span>    }<a name="line.895"></a>
+<span class="sourceLineNo">844</span>      // Check and free if there are buckets that still need freeing of space<a name="line.844"></a>
+<span class="sourceLineNo">845</span>      if (bucketSizesAboveThresholdCount(minFactor) &gt; 0) {<a name="line.845"></a>
+<span class="sourceLineNo">846</span>        bucketQueue.clear();<a name="line.846"></a>
+<span class="sourceLineNo">847</span>        remainingBuckets = 3;<a name="line.847"></a>
+<span class="sourceLineNo">848</span><a name="line.848"></a>
+<span class="sourceLineNo">849</span>        bucketQueue.add(bucketSingle);<a name="line.849"></a>
+<span class="sourceLineNo">850</span>        bucketQueue.add(bucketMulti);<a name="line.850"></a>
+<span class="sourceLineNo">851</span>        bucketQueue.add(bucketMemory);<a name="line.851"></a>
+<span class="sourceLineNo">852</span><a name="line.852"></a>
+<span class="sourceLineNo">853</span>        while ((bucketGroup = bucketQueue.poll()) != null) {<a name="line.853"></a>
+<span class="sourceLineNo">854</span>          long bucketBytesToFree = (bytesToFreeWithExtra - bytesFreed) / remainingBuckets;<a name="line.854"></a>
+<span class="sourceLineNo">855</span>          bytesFreed += bucketGroup.free(bucketBytesToFree);<a name="line.855"></a>
+<span class="sourceLineNo">856</span>          remainingBuckets--;<a name="line.856"></a>
+<span class="sourceLineNo">857</span>        }<a name="line.857"></a>
+<span class="sourceLineNo">858</span>      }<a name="line.858"></a>
+<span class="sourceLineNo">859</span><a name="line.859"></a>
+<span class="sourceLineNo">860</span>      // Even after the above free we might still need freeing because of the<a name="line.860"></a>
+<span class="sourceLineNo">861</span>      // De-fragmentation of the buckets (also called Slab Calcification problem), i.e<a name="line.861"></a>
+<span class="sourceLineNo">862</span>      // there might be some buckets where the occupancy is very sparse and thus are not<a name="line.862"></a>
+<span class="sourceLineNo">863</span>      // yielding the free for the other bucket sizes, the fix for this to evict som

<TRUNCATED>

Mime
View raw message