Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BFA1200D50 for ; Mon, 20 Nov 2017 05:23:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4A57F160C0C; Mon, 20 Nov 2017 04:23:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FDD4160C0B for ; Mon, 20 Nov 2017 05:23:18 +0100 (CET) Received: (qmail 18124 invoked by uid 500); 20 Nov 2017 04:23:17 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 18115 invoked by uid 99); 20 Nov 2017 04:23:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 04:23:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 38F9BDFF73; Mon, 20 Nov 2017 04:23:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tedyu@apache.org To: commits@hbase.apache.org Message-Id: <67113592c5214ce087f54f34389035b9@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-19288 Intermittent test failure in TestHStore.testRunDoubleMemStoreCompactors Date: Mon, 20 Nov 2017 04:23:17 +0000 (UTC) archived-at: Mon, 20 Nov 2017 04:23:19 -0000 Repository: hbase Updated Branches: refs/heads/master b4fbf5fe1 -> 9b7b83d86 HBASE-19288 Intermittent test failure in TestHStore.testRunDoubleMemStoreCompactors Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/9b7b83d8 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/9b7b83d8 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/9b7b83d8 Branch: refs/heads/master Commit: 9b7b83d86208c30dbb83ea717e694c5389e71671 Parents: b4fbf5f Author: tedyu Authored: Sun Nov 19 20:23:12 2017 -0800 Committer: tedyu Committed: Sun Nov 19 20:23:12 2017 -0800 ---------------------------------------------------------------------- .../apache/hadoop/hbase/regionserver/CompactingMemStore.java | 3 +++ .../java/org/apache/hadoop/hbase/regionserver/TestHStore.java | 5 +++++ 2 files changed, 8 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/9b7b83d8/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java index d250252..f1232f8 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java @@ -429,6 +429,9 @@ public class CompactingMemStore extends AbstractMemStore { } } finally { inMemoryFlushInProgress.set(false); + if (LOG.isDebugEnabled()) { + LOG.debug("IN-MEMORY FLUSH: end"); + } } } http://git-wip-us.apache.org/repos/asf/hbase/blob/9b7b83d8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java index 6ec091a..39ed9df 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java @@ -1465,6 +1465,8 @@ public class TestHStore { int flushSize = 500; Configuration conf = HBaseConfiguration.create(); conf.set(HStore.MEMSTORE_CLASS_NAME, MyCompactingMemStoreWithCustomCompactor.class.getName()); + conf.setDouble(CompactingMemStore.IN_MEMORY_FLUSH_THRESHOLD_FACTOR_KEY, 0.25); + MyCompactingMemStoreWithCustomCompactor.RUNNER_COUNT.set(0); conf.set(HConstants.HREGION_MEMSTORE_FLUSH_SIZE, String.valueOf(flushSize)); // Set the lower threshold to invoke the "MERGE" policy conf.set(MemStoreCompactionStrategy.COMPACTING_MEMSTORE_THRESHOLD_KEY, String.valueOf(0)); @@ -1711,6 +1713,9 @@ public class TestHStore { boolean rval = super.shouldFlushInMemory(); if (rval) { RUNNER_COUNT.incrementAndGet(); + if (LOG.isDebugEnabled()) { + LOG.debug("runner count: " + RUNNER_COUNT.get()); + } } return rval; }