hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhang...@apache.org
Subject hbase git commit: HBASE-19262 Revisit checkstyle rules
Date Thu, 16 Nov 2017 01:46:00 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1.2 0cc34b8f6 -> cb7e60071


HBASE-19262 Revisit checkstyle rules


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/cb7e6007
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/cb7e6007
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/cb7e6007

Branch: refs/heads/branch-1.2
Commit: cb7e600716bd5807c77852b1cbc8d86513b7a698
Parents: 0cc34b8
Author: zhangduo <zhangduo@apache.org>
Authored: Wed Nov 15 15:38:02 2017 +0800
Committer: zhangduo <zhangduo@apache.org>
Committed: Thu Nov 16 09:43:33 2017 +0800

----------------------------------------------------------------------
 .../src/main/resources/hbase/checkstyle-suppressions.xml          | 3 ++-
 hbase-checkstyle/src/main/resources/hbase/checkstyle.xml          | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/cb7e6007/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
index 46009e9..1ecae86 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
@@ -33,5 +33,6 @@
 <suppressions>
   <suppress checks="." files=".*/generated/.*\.java"/>
   <suppress checks="." files=".*/generated-jamon/.*\.java"/>
-  <suppress checks="MagicNumberCheck" files=".*Test\.java"/>
+  <suppress checks="MagicNumberCheck" files=".*/src/test/.*\.java"/>
+  <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/>
 </suppressions>

http://git-wip-us.apache.org/repos/asf/hbase/blob/cb7e6007/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
index b423095..2240096 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
@@ -67,6 +67,7 @@
     http://checkstyle.sourceforge.net/config_imports.html -->
     <module name="AvoidStarImport"/>
     <module name="ImportOrder">
+      <property name="groups" value="*,org.apache.hadoop.hbase.shaded"/>
       <property name="option" value="top" />
       <property name="ordered" value="true"/>
       <property name="sortStaticImportsAlphabetically" value="true"/>


Mime
View raw message