Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 941AA200D31 for ; Sat, 21 Oct 2017 03:09:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 927F9160BCB; Sat, 21 Oct 2017 01:09:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D90EC160BED for ; Sat, 21 Oct 2017 03:09:17 +0200 (CEST) Received: (qmail 80204 invoked by uid 500); 21 Oct 2017 01:09:17 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 80195 invoked by uid 99); 21 Oct 2017 01:09:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Oct 2017 01:09:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 73D73DF9C2; Sat, 21 Oct 2017 01:09:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: busbey@apache.org To: commits@hbase.apache.org Date: Sat, 21 Oct 2017 01:09:14 -0000 Message-Id: In-Reply-To: <13a6d4ba693a456a8b661ab587762409@git.apache.org> References: <13a6d4ba693a456a8b661ab587762409@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] hbase git commit: HBASE-19039 refactor shadedjars test to only run on java changes. archived-at: Sat, 21 Oct 2017 01:09:18 -0000 HBASE-19039 refactor shadedjars test to only run on java changes. Signed-off-by: Mike Drob Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/122fceb5 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/122fceb5 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/122fceb5 Branch: refs/heads/branch-1.4 Commit: 122fceb53431e664848943829dbb66d52fd1cceb Parents: bb1fd4a Author: Sean Busbey Authored: Fri Oct 20 14:39:03 2017 -0500 Committer: Sean Busbey Committed: Fri Oct 20 20:08:44 2017 -0500 ---------------------------------------------------------------------- dev-support/hbase-personality.sh | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/122fceb5/dev-support/hbase-personality.sh ---------------------------------------------------------------------- diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh index 01c3d85..24f2ef5 100755 --- a/dev-support/hbase-personality.sh +++ b/dev-support/hbase-personality.sh @@ -171,12 +171,19 @@ function shadedjars_initialize { yetus_debug "initializing shaded client checks." maven_add_install shadedjars - add_test shadedjars } -function shadedjars_clean +## @description only run the test if java changes. +## @audience private +## @stability evolving +## @param filename +function shadedjars_filefilter { - "${MAVEN}" "${MAVEN_ARGS[@]}" clean -fae -pl hbase_shaded/hbase-shaded-check-invariants -am -Prelease + local filename=$1 + + if [[ ${filename} =~ \.java$ ]] || [[ ${filename} =~ pom.xml$ ]]; then + add_test shadedjars + fi } ## @description test the shaded client artifacts @@ -188,6 +195,10 @@ function shadedjars_rebuild local repostatus=$1 local logfile="${PATCH_DIR}/${repostatus}-shadedjars.txt" + if ! verify_needed_test shadedjars; then + return 0 + fi + big_console_header "Checking shaded client builds on ${repostatus}" echo_and_redirect "${logfile}" \