hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chia7...@apache.org
Subject hbase git commit: HBASE-18602 rsgroup cleanup unassign code
Date Mon, 30 Oct 2017 19:54:24 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1.4 7e6e3f8bc -> 57e6dd035


HBASE-18602 rsgroup cleanup unassign code

Signed-off-by: Chia-Ping Tsai <chia7712@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/57e6dd03
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/57e6dd03
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/57e6dd03

Branch: refs/heads/branch-1.4
Commit: 57e6dd035b14dfc79c8ead16cb00610f8038e739
Parents: 7e6e3f8
Author: Wang, Xinglong <suxingfate@163.com>
Authored: Tue Oct 31 03:04:34 2017 +0800
Committer: Chia-Ping Tsai <chia7712@gmail.com>
Committed: Tue Oct 31 03:48:34 2017 +0800

----------------------------------------------------------------------
 .../hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java    | 10 ----------
 1 file changed, 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/57e6dd03/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
----------------------------------------------------------------------
diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
index d7f9498..e1bcb25 100644
--- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
+++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
@@ -25,7 +25,6 @@ import com.google.common.collect.LinkedListMultimap;
 import com.google.common.collect.ListMultimap;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -37,10 +36,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.TreeMap;
-
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.hbase.ClusterStatus;
 import org.apache.hadoop.hbase.HBaseIOException;
@@ -350,7 +347,6 @@ public class RSGroupBasedLoadBalancer implements RSGroupableBalancer,
LoadBalanc
        Map<ServerName, List<HRegionInfo>> existingAssignments){
     Map<ServerName, List<HRegionInfo>> correctAssignments =
         new TreeMap<ServerName, List<HRegionInfo>>();
-    List<HRegionInfo> misplacedRegions = new LinkedList<HRegionInfo>();
     correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new LinkedList<HRegionInfo>());
     for (Map.Entry<ServerName, List<HRegionInfo>> assignments : existingAssignments.entrySet()){
       ServerName sName = assignments.getKey();
@@ -372,12 +368,6 @@ public class RSGroupBasedLoadBalancer implements RSGroupableBalancer,
LoadBalanc
         }
       }
     }
-
-    //TODO bulk unassign?
-    //unassign misplaced regions, so that they are assigned to correct groups.
-    for(HRegionInfo info: misplacedRegions) {
-      this.masterServices.getAssignmentManager().unassign(info);
-    }
     return correctAssignments;
   }
 


Mime
View raw message