hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bus...@apache.org
Subject [23/47] hbase git commit: HBASE-18834 fix shellcheck warning on hbase personality
Date Sun, 24 Sep 2017 00:34:23 GMT
HBASE-18834 fix shellcheck warning on hbase personality

Signed-off-by: Dima Spivak <dimaspivak@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/efb95a17
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/efb95a17
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/efb95a17

Branch: refs/heads/HBASE-18467
Commit: efb95a17945cc91aa639396f6f6c528b52c71fcb
Parents: 2a8fb7a
Author: Sean Busbey <busbey@apache.org>
Authored: Sun Sep 17 23:54:37 2017 -0500
Committer: Sean Busbey <busbey@apache.org>
Committed: Mon Sep 18 08:54:37 2017 -0500

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/efb95a17/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index cf7c6b9..b7a2f97 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -119,8 +119,7 @@ function personality_modules
     yetus_debug "EXCLUDE_TESTS_URL = ${EXCLUDE_TESTS_URL}"
     yetus_debug "INCLUDE_TESTS_URL = ${INCLUDE_TESTS_URL}"
     if [[ -n "$EXCLUDE_TESTS_URL" ]]; then
-        wget "$EXCLUDE_TESTS_URL" -O "excludes"
-        if [[ $? -eq 0 ]]; then
+        if wget "$EXCLUDE_TESTS_URL" -O "excludes"; then
           excludes=$(cat excludes)
           yetus_debug "excludes=${excludes}"
           if [[ -n "${excludes}" ]]; then
@@ -132,8 +131,7 @@ function personality_modules
                "${EXCLUDE_TESTS_URL}. Ignoring and proceeding."
         fi
     elif [[ -n "$INCLUDE_TESTS_URL" ]]; then
-        wget "$INCLUDE_TESTS_URL" -O "includes"
-        if [[ $? -eq 0 ]]; then
+        if wget "$INCLUDE_TESTS_URL" -O "includes"; then
           includes=$(cat includes)
           yetus_debug "includes=${includes}"
           if [[ -n "${includes}" ]]; then


Mime
View raw message