Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 23002200D13 for ; Sat, 26 Aug 2017 01:14:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 21ABE16D7E3; Fri, 25 Aug 2017 23:14:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 957E016D7E4 for ; Sat, 26 Aug 2017 01:14:51 +0200 (CEST) Received: (qmail 59949 invoked by uid 500); 25 Aug 2017 23:14:50 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 59934 invoked by uid 99); 25 Aug 2017 23:14:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 23:14:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 24144F5658; Fri, 25 Aug 2017 23:14:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@hbase.apache.org Date: Fri, 25 Aug 2017 23:14:49 -0000 Message-Id: <8bba720ac76d4918a642349c67e0674e@git.apache.org> In-Reply-To: <90f0b56dac7643ad88b656a410080412@git.apache.org> References: <90f0b56dac7643ad88b656a410080412@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/7] hbase git commit: HBASE-18679 Add a null check around the result of getCounters() in ITBLL archived-at: Fri, 25 Aug 2017 23:14:52 -0000 HBASE-18679 Add a null check around the result of getCounters() in ITBLL Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b55b952d Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b55b952d Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b55b952d Branch: refs/heads/branch-2 Commit: b55b952d5c5e90bde03f454500e867b7909fea75 Parents: 005693f Author: Josh Elser Authored: Thu Aug 24 17:52:13 2017 -0400 Committer: Josh Elser Committed: Fri Aug 25 18:45:12 2017 -0400 ---------------------------------------------------------------------- .../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/b55b952d/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java ---------------------------------------------------------------------- diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java index 2fdfab6..f05ef66 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java @@ -820,6 +820,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { public boolean verify() { try { Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, Generator verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } if (counters.findCounter(Counts.TERMINATING).getValue() > 0 || counters.findCounter(Counts.UNDEFINED).getValue() > 0 || @@ -1315,7 +1320,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { if (success) { Counters counters = job.getCounters(); if (null == counters) { - LOG.warn("Counters were null, cannot verify Job completion"); + LOG.warn("Counters were null, cannot verify Job completion." + + " This is commonly a result of insufficient YARN configuration."); // We don't have access to the counters to know if we have "bad" counts return 0; } @@ -1337,6 +1343,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { } Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, write verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } // Run through each check, even if we fail one early boolean success = verifyExpectedValues(expectedReferenced, counters);