Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 34CC2200D13 for ; Sat, 26 Aug 2017 01:14:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3361616D7E8; Fri, 25 Aug 2017 23:14:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7AA4416D7E9 for ; Sat, 26 Aug 2017 01:14:53 +0200 (CEST) Received: (qmail 60830 invoked by uid 500); 25 Aug 2017 23:14:52 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 59962 invoked by uid 99); 25 Aug 2017 23:14:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 23:14:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 24727F32DC; Fri, 25 Aug 2017 23:14:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: elserj@apache.org To: commits@hbase.apache.org Date: Fri, 25 Aug 2017 23:14:54 -0000 Message-Id: <5f1c6fba653e45cfbe9000c9ff13c547@git.apache.org> In-Reply-To: <90f0b56dac7643ad88b656a410080412@git.apache.org> References: <90f0b56dac7643ad88b656a410080412@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [7/7] hbase git commit: HBASE-18679 Add a null check around the result of getCounters() in ITBLL archived-at: Fri, 25 Aug 2017 23:14:54 -0000 HBASE-18679 Add a null check around the result of getCounters() in ITBLL Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8d6e37bb Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8d6e37bb Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8d6e37bb Branch: refs/heads/branch-1.1 Commit: 8d6e37bb260a787e7d5d97495f5cc1ca260695d7 Parents: 43b0a66 Author: Josh Elser Authored: Thu Aug 24 17:52:13 2017 -0400 Committer: Josh Elser Committed: Fri Aug 25 19:11:49 2017 -0400 ---------------------------------------------------------------------- .../hadoop/hbase/test/IntegrationTestBigLinkedList.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/8d6e37bb/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java ---------------------------------------------------------------------- diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java index 849efa4..7aed9de 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java @@ -1104,7 +1104,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { if (success) { Counters counters = job.getCounters(); if (null == counters) { - LOG.warn("Counters were null, cannot verify Job completion"); + LOG.warn("Counters were null, cannot verify Job completion." + + " This is commonly a result of insufficient YARN configuration."); // We don't have access to the counters to know if we have "bad" counts return 0; } @@ -1126,6 +1127,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { } Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, write verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } // Run through each check, even if we fail one early boolean success = verifyExpectedValues(expectedReferenced, counters);