hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [7/7] hbase git commit: HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Date Fri, 25 Aug 2017 23:14:54 GMT
HBASE-18679 Add a null check around the result of getCounters() in ITBLL


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8d6e37bb
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8d6e37bb
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8d6e37bb

Branch: refs/heads/branch-1.1
Commit: 8d6e37bb260a787e7d5d97495f5cc1ca260695d7
Parents: 43b0a66
Author: Josh Elser <elserj@apache.org>
Authored: Thu Aug 24 17:52:13 2017 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Fri Aug 25 19:11:49 2017 -0400

----------------------------------------------------------------------
 .../hadoop/hbase/test/IntegrationTestBigLinkedList.java      | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/8d6e37bb/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
index 849efa4..7aed9de 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
@@ -1104,7 +1104,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase
{
       if (success) {
         Counters counters = job.getCounters();
         if (null == counters) {
-          LOG.warn("Counters were null, cannot verify Job completion");
+          LOG.warn("Counters were null, cannot verify Job completion."
+              + " This is commonly a result of insufficient YARN configuration.");
           // We don't have access to the counters to know if we have "bad" counts
           return 0;
         }
@@ -1126,6 +1127,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase
{
       }
 
       Counters counters = job.getCounters();
+      if (counters == null) {
+        LOG.info("Counters object was null, write verification cannot be performed."
+              + " This is commonly a result of insufficient YARN configuration.");
+        return false;
+      }
 
       // Run through each check, even if we fail one early
       boolean success = verifyExpectedValues(expectedReferenced, counters);


Mime
View raw message