hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bus...@apache.org
Subject hbase git commit: HBASE-18467 remove for-each loops since that does CPS which breaks.
Date Sun, 27 Aug 2017 15:47:13 GMT
Repository: hbase
Updated Branches:
  refs/heads/HBASE-18467 fe61f0da8 -> 6a94d74c8


HBASE-18467 remove for-each loops since that does CPS which breaks.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6a94d74c
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6a94d74c
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6a94d74c

Branch: refs/heads/HBASE-18467
Commit: 6a94d74c8755bc7c3c58e449109b192856ba551d
Parents: fe61f0d
Author: Sean Busbey <busbey@apache.org>
Authored: Sun Aug 27 10:46:51 2017 -0500
Committer: Sean Busbey <busbey@apache.org>
Committed: Sun Aug 27 10:46:51 2017 -0500

----------------------------------------------------------------------
 dev-support/Jenkinsfile | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/6a94d74c/dev-support/Jenkinsfile
----------------------------------------------------------------------
diff --git a/dev-support/Jenkinsfile b/dev-support/Jenkinsfile
index 50142bf..5b6bb9e 100644
--- a/dev-support/Jenkinsfile
+++ b/dev-support/Jenkinsfile
@@ -394,13 +394,16 @@ END
            echo ""
            echo "[INFO] There are ${currentBuild.changeSets.size()} change sets."
            def seenJiras = []
-           for ( changelist in currentBuild.changeSets ) {
+           for (int i = 0; i < currentBuild.changeSets.size(); i++) {
+             def changelist = currentBuild.changeSets.get(i)
              if ( changelist.isEmptySet() ) {
                echo "[DEBUG] change set was empty, skipping JIRA comments."
              } else {
                echo "[DEBUG] there are changes in the change set. Attempting to post comments."
              }
-             for ( change in changelist ) {
+             def changes = changelist.getLogs()
+             for (int j = 0; j < changes.size(); j++) {
+               def change = changes.get(j)
                CharSequence msg = change.msg
                echo "[DEBUG] msg is of class ${msg.class}"
                echo "change: ${change}"
@@ -417,7 +420,8 @@ END
                if (jiras.length == 0) {
                  echo "[WARN] no JIRA key found in message, TODO email committer"
                }
-               for (currentIssue in jiras) {
+               for (int k = 0; k < jiras.length; k++) {
+                 def currentIssue = jiras[k]
                  echo "[DEBUG] found jira key: ${currentIssue}"
                  if ( currentIssue in seenJiras ) {
                    echo "[DEBUG] already commented on ${currentIssue}."


Mime
View raw message