Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 19F0B200CF3 for ; Thu, 20 Jul 2017 00:32:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 188CF1621A1; Wed, 19 Jul 2017 22:32:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 60DE1162ADA for ; Thu, 20 Jul 2017 00:32:55 +0200 (CEST) Received: (qmail 36509 invoked by uid 500); 19 Jul 2017 22:32:52 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 36171 invoked by uid 99); 19 Jul 2017 22:32:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jul 2017 22:32:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E0D99F5591; Wed, 19 Jul 2017 22:32:50 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: apurtell@apache.org To: commits@hbase.apache.org Date: Wed, 19 Jul 2017 22:32:51 -0000 Message-Id: <5e425a191a564f82bcbd6245c869593f@git.apache.org> In-Reply-To: <3a85ba2351374748af88e5f4010b9280@git.apache.org> References: <3a85ba2351374748af88e5f4010b9280@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [03/23] hbase git commit: HBASE-18235 LoadBalancer.BOGUS_SERVER_NAME should not have a bogus hostname archived-at: Wed, 19 Jul 2017 22:32:56 -0000 HBASE-18235 LoadBalancer.BOGUS_SERVER_NAME should not have a bogus hostname Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a98bc190 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a98bc190 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a98bc190 Branch: refs/heads/HBASE-15631-branch-1 Commit: a98bc190d6126dc68abc89153d17778432b3c7d1 Parents: a1cf043 Author: Andrew Purtell Authored: Mon Jul 3 17:54:36 2017 -0700 Committer: Andrew Purtell Committed: Wed Jul 19 15:32:37 2017 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/master/LoadBalancer.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/a98bc190/hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java index 937b32f..a80cdc3 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java @@ -52,8 +52,9 @@ import org.apache.hadoop.hbase.TableName; @InterfaceAudience.Private public interface LoadBalancer extends Configurable, Stoppable, ConfigurationObserver { - //used to signal to the caller that the region(s) cannot be assigned - ServerName BOGUS_SERVER_NAME = ServerName.parseServerName("localhost,1,1"); + // Used to signal to the caller that the region(s) cannot be assigned + // We deliberately use 'localhost' so the operation will fail fast + ServerName BOGUS_SERVER_NAME = ServerName.valueOf("localhost,1,1"); /** * Set the current cluster status. This allows a LoadBalancer to map host name to a server