hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject hbase git commit: HBASE-18406 Remove NO-OP Method
Date Sun, 30 Jul 2017 13:01:49 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-2 d776a3caa -> dbc8ea648


HBASE-18406 Remove NO-OP Method

This patch removes start(MasterProcedureEnv) from
ServerCrashProcedure.java which was a misnomer as a no-op. It
did not start anything.

Change-Id: I4e91864ace912e137471bfce03516746c4aff83e

Signed-off-by: Michael Stack <stack@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/dbc8ea64
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/dbc8ea64
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/dbc8ea64

Branch: refs/heads/branch-2
Commit: dbc8ea64862935c27414beaae73f12c25b56431c
Parents: d776a3c
Author: Alex Leblang <alex.leblang@cloudera.com>
Authored: Tue Jul 18 15:01:55 2017 -0700
Committer: Michael Stack <stack@apache.org>
Committed: Sun Jul 30 14:01:13 2017 +0100

----------------------------------------------------------------------
 .../hadoop/hbase/master/procedure/ServerCrashProcedure.java  | 8 --------
 1 file changed, 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/dbc8ea64/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
index db4ac32..4fb8c07 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
@@ -139,7 +139,6 @@ implements ServerProcedureInterface {
       switch (state) {
       case SERVER_CRASH_START:
         LOG.info("Start " + this);
-        start(env);
         // If carrying meta, process it first. Else, get list of regions on crashed server.
         if (this.carryingMeta) {
           setNextState(ServerCrashState.SERVER_CRASH_PROCESS_META);
@@ -207,13 +206,6 @@ implements ServerProcedureInterface {
   }
 
   /**
-   * Start processing of crashed server. In here we'll just set configs. and return.
-   * @param env
-   * @throws IOException
-   */
-  private void start(final MasterProcedureEnv env) throws IOException {}
-
-  /**
    * @param env
    * @throws IOException
    * @throws InterruptedException


Mime
View raw message