hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bus...@apache.org
Subject [10/22] hbase git commit: HBASE-18341 (addendum) Replace '.' in test names with '_' when using them as html ids since dot have special significance in CSS selectors. Without it, we weren't able to select elements and add svg (trends columns) to them.
Date Wed, 12 Jul 2017 21:00:41 GMT
HBASE-18341 (addendum) Replace '.' in test names with '_' when using them as html ids since
dot have special significance in CSS selectors.
Without it, we weren't able to select elements and add svg (trends columns) to them.

Change-Id: Ia63ff0851f0a2fad0789a24edf2f0ad00060d578


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7d08c781
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7d08c781
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7d08c781

Branch: refs/heads/HBASE-18147
Commit: 7d08c78103792e599b0676c318da1aca54501289
Parents: 7d007ea
Author: Apekshit Sharma <appy@apache.org>
Authored: Mon Jul 10 12:01:02 2017 -0700
Committer: Apekshit Sharma <appy@apache.org>
Committed: Mon Jul 10 12:04:05 2017 -0700

----------------------------------------------------------------------
 dev-support/flaky-dashboard-template.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/7d08c781/dev-support/flaky-dashboard-template.html
----------------------------------------------------------------------
diff --git a/dev-support/flaky-dashboard-template.html b/dev-support/flaky-dashboard-template.html
index 49ab9b0..f37c7d5 100644
--- a/dev-support/flaky-dashboard-template.html
+++ b/dev-support/flaky-dashboard-template.html
@@ -156,7 +156,8 @@ Legend : green: success, red: failed, yellow: timeout, blue: hanging
         <td align="middle">
             {{ failed|length }} / {{ timeout|length }} / {{ hanging|length }}
         </td>
-        {% set sparkline_id = "sparkline_" ~ test ~ "_" ~ url_counter  %}
+        {# Replace '.' in test names with '_' because dots are part of css selectors.  #}
+        {% set sparkline_id = "sparkline_" ~ test|replace(".","_") ~ "_" ~ url_counter  %}
         <td id="{{ sparkline_id }}" align="middle">
         </td>
         <script>sparkline("{{ sparkline_id }}", "{{ failed|join(',') }}", "{{ timeout|join(',')
}}",


Mime
View raw message