Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 667AA200C7E for ; Tue, 23 May 2017 09:36:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65628160BDE; Tue, 23 May 2017 07:36:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3C7B160BDB for ; Tue, 23 May 2017 09:36:25 +0200 (CEST) Received: (qmail 87714 invoked by uid 500); 23 May 2017 07:36:21 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 81344 invoked by uid 99); 23 May 2017 07:36:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 07:36:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 57146F49D6; Tue, 23 May 2017 07:36:14 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: stack@apache.org To: commits@hbase.apache.org Date: Tue, 23 May 2017 07:36:40 -0000 Message-Id: In-Reply-To: <8d7438330077469cb61a79358dad91c6@git.apache.org> References: <8d7438330077469cb61a79358dad91c6@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [28/50] [abbrv] hbase git commit: Exceptions are not logging identifying details like region; makes it hard to debug who is problem archived-at: Tue, 23 May 2017 07:36:26 -0000 Exceptions are not logging identifying details like region; makes it hard to debug who is problem Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6a7d5183 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6a7d5183 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6a7d5183 Branch: refs/heads/HBASE-14614 Commit: 6a7d518364128c106d8d0738cac6adec344fddb0 Parents: dd7b565 Author: Michael Stack Authored: Sat May 6 11:22:57 2017 -0700 Committer: Michael Stack Committed: Tue May 23 00:33:02 2017 -0700 ---------------------------------------------------------------------- .../master/assignment/AssignmentManager.java | 18 ++++++++---------- .../hbase/master/assignment/RegionStates.java | 2 +- 2 files changed, 9 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/6a7d5183/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 2986868..ed55235 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -983,7 +983,7 @@ public class AssignmentManager implements ServerListener { } } catch (UnexpectedStateException e) { final ServerName serverName = serverNode.getServerName(); - LOG.warn("Killing " + serverName + ": " + e.getMessage()); + LOG.warn("KILLING " + serverName + ": " + e.getMessage()); killRegionServer(serverNode); } } @@ -1003,25 +1003,23 @@ public class AssignmentManager implements ServerListener { synchronized (regionNode) { if (regionNode.isInState(State.OPENING, State.OPEN)) { if (!regionNode.getRegionLocation().equals(serverName)) { - throw new UnexpectedStateException( - "Reported OPEN on server=" + serverName + - " but state found says server=" + regionNode.getRegionLocation()); + throw new UnexpectedStateException(regionNode.toString() + + "reported OPEN on server=" + serverName + + " but state has otherwise."); } else if (regionNode.isInState(State.OPENING)) { try { if (!reportTransition(regionNode, serverNode, TransitionCode.OPENED, 0)) { - LOG.warn("Reported OPEN on server=" + serverName + - " but state found says " + regionNode + " and NO procedure is running"); + LOG.warn(regionNode.toString() + " reported OPEN on server=" + serverName + + " but state has otherwise AND NO procedure is running"); } } catch (UnexpectedStateException e) { - LOG.warn("Unexpected exception while trying to report " + regionNode + - " as open: " + e.getMessage(), e); + LOG.warn(regionNode.toString() + " reported unexpteced OPEN: " + e.getMessage(), e); } } } else if (!regionNode.isInState(State.CLOSING, State.SPLITTING)) { // TODO: We end up killing the RS if we get a report while we already // transitioned to close or split. we should have a timeout/timestamp to compare - throw new UnexpectedStateException( - "Reported OPEN but state found says " + regionNode.getState()); + throw new UnexpectedStateException(regionNode.toString() + " reported unexpected OPEN"); } } } http://git-wip-us.apache.org/repos/asf/hbase/blob/6a7d5183/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java index aa2627c..1c852c9 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java @@ -173,7 +173,7 @@ public class RegionStates { public ServerName setRegionLocation(final ServerName serverName) { ServerName lastRegionLocation = this.regionLocation; if (serverName == null) { - LOG.debug("REMOVE tracking when we are set to null", new Throwable("DEBUG")); + LOG.debug("REMOVE tracking when we are set to null " + this, new Throwable("DEBUG")); } this.regionLocation = serverName; this.lastUpdate = EnvironmentEdgeManager.currentTime();