Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F2409200CA3 for ; Tue, 2 May 2017 20:38:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F111E160B9D; Tue, 2 May 2017 18:38:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BA05160BAB for ; Tue, 2 May 2017 20:38:50 +0200 (CEST) Received: (qmail 32371 invoked by uid 500); 2 May 2017 18:38:49 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 32362 invoked by uid 99); 2 May 2017 18:38:49 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 18:38:49 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EDB6CDFD43; Tue, 2 May 2017 18:38:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: apurtell@apache.org To: commits@hbase.apache.org Date: Tue, 02 May 2017 18:38:48 -0000 Message-Id: <1fb7999c80be475ab34e79ea573b40f4@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] hbase git commit: HBASE-12870 "Major compaction triggered" and "Skipping major compaction" messages lack the region information archived-at: Tue, 02 May 2017 18:38:51 -0000 Repository: hbase Updated Branches: refs/heads/branch-1 3a3cb48e2 -> d2fcfd74d refs/heads/master c0f265384 -> 30d0c3fdd HBASE-12870 "Major compaction triggered" and "Skipping major compaction" messages lack the region information Signed-off-by: Andrew Purtell Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/30d0c3fd Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/30d0c3fd Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/30d0c3fd Branch: refs/heads/master Commit: 30d0c3fdde39a351912af8484fe48035f4cd9189 Parents: c0f2653 Author: ckulkarni Authored: Tue Apr 11 14:32:55 2017 -0700 Committer: Andrew Purtell Committed: Tue May 2 10:54:15 2017 -0700 ---------------------------------------------------------------------- .../compactions/RatioBasedCompactionPolicy.java | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/30d0c3fd/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java index a3e10f8..ddc07cd 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java @@ -28,6 +28,7 @@ import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.classification.InterfaceAudience; +import org.apache.hadoop.hbase.regionserver.HStore; import org.apache.hadoop.hbase.regionserver.RSRpcServices; import org.apache.hadoop.hbase.regionserver.StoreConfigInformation; import org.apache.hadoop.hbase.regionserver.StoreFile; @@ -64,6 +65,12 @@ public class RatioBasedCompactionPolicy extends SortedCompactionPolicy { long lowTimestamp = StoreUtils.getLowestTimestamp(filesToCompact); long now = EnvironmentEdgeManager.currentTime(); if (lowTimestamp > 0L && lowTimestamp < (now - mcTime)) { + String regionInfo; + if (this.storeConfigInfo != null && this.storeConfigInfo instanceof HStore) { + regionInfo = ((HStore)this.storeConfigInfo).getRegionInfo().getRegionNameAsString(); + } else { + regionInfo = this.toString(); + } // Major compaction time has elapsed. long cfTTL = this.storeConfigInfo.getStoreFileTtl(); if (filesToCompact.size() == 1) { @@ -76,24 +83,24 @@ public class RatioBasedCompactionPolicy extends SortedCompactionPolicy { sf.getHDFSBlockDistribution().getBlockLocalityIndex( RSRpcServices.getHostname(comConf.conf, false)); if (blockLocalityIndex < comConf.getMinLocalityToForceCompact()) { - LOG.debug("Major compaction triggered on only store " + this + LOG.debug("Major compaction triggered on only store " + regionInfo + "; to make hdfs blocks local, current blockLocalityIndex is " + blockLocalityIndex + " (min " + comConf.getMinLocalityToForceCompact() + ")"); result = true; } else { - LOG.debug("Skipping major compaction of " + this + LOG.debug("Skipping major compaction of " + regionInfo + " because one (major) compacted file only, oldestTime " + oldest + "ms is < TTL=" + cfTTL + " and blockLocalityIndex is " + blockLocalityIndex + " (min " + comConf.getMinLocalityToForceCompact() + ")"); } } else if (cfTTL != HConstants.FOREVER && oldest > cfTTL) { - LOG.debug("Major compaction triggered on store " + this + LOG.debug("Major compaction triggered on store " + regionInfo + ", because keyvalues outdated; time since last major compaction " + (now - lowTimestamp) + "ms"); result = true; } } else { - LOG.debug("Major compaction triggered on store " + this + LOG.debug("Major compaction triggered on store " + regionInfo + "; time since last major compaction " + (now - lowTimestamp) + "ms"); } result = true;