hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From git-site-r...@apache.org
Subject [06/37] hbase-site git commit: Published site at 82d554e3783372cc6b05489452c815b57c06f6cd.
Date Thu, 25 May 2017 14:59:38 GMT
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.BulkLoadListener.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.BulkLoadListener.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.BulkLoadListener.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.BulkLoadListener.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.BulkLoadListener.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.Result.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.Result.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.Result.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.Result.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.Result.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.FlushResult.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.Operation.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.Operation.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.Operation.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.Operation.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.Operation.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.RowLock.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.RowLock.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.RowLock.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.RowLock.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.RowLock.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.html
index 51c3f2c..b060ede 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/Region.html
@@ -753,7 +753,10 @@
 <span class="sourceLineNo">745</span>  /** Wait for all current flushes and compactions of the region to complete */<a name="line.745"></a>
 <span class="sourceLineNo">746</span>  void waitForFlushesAndCompactions();<a name="line.746"></a>
 <span class="sourceLineNo">747</span><a name="line.747"></a>
-<span class="sourceLineNo">748</span>}<a name="line.748"></a>
+<span class="sourceLineNo">748</span>  /** Wait for all current flushes of the region to complete<a name="line.748"></a>
+<span class="sourceLineNo">749</span>   */<a name="line.749"></a>
+<span class="sourceLineNo">750</span>  void waitForFlushes();<a name="line.750"></a>
+<span class="sourceLineNo">751</span>}<a name="line.751"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.RegionSnapshotTask.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.RegionSnapshotTask.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.RegionSnapshotTask.html
index 7575174..238f4d6 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.RegionSnapshotTask.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.RegionSnapshotTask.html
@@ -38,158 +38,164 @@
 <span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.procedure.Subprocedure;<a name="line.30"></a>
 <span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.regionserver.HRegion;<a name="line.31"></a>
 <span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.regionserver.Region;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager.SnapshotSubprocedurePool;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.35"></a>
-<span class="sourceLineNo">036</span><a name="line.36"></a>
-<span class="sourceLineNo">037</span>/**<a name="line.37"></a>
-<span class="sourceLineNo">038</span> * This online snapshot implementation uses the distributed procedure framework to force a<a name="line.38"></a>
-<span class="sourceLineNo">039</span> * store flush and then records the hfiles.  Its enter stage does nothing.  Its leave stage then<a name="line.39"></a>
-<span class="sourceLineNo">040</span> * flushes the memstore, builds the region server's snapshot manifest from its hfiles list, and<a name="line.40"></a>
-<span class="sourceLineNo">041</span> * copies .regioninfos into the snapshot working directory.  At the master side, there is an atomic<a name="line.41"></a>
-<span class="sourceLineNo">042</span> * rename of the working dir into the proper snapshot directory.<a name="line.42"></a>
-<span class="sourceLineNo">043</span> */<a name="line.43"></a>
-<span class="sourceLineNo">044</span>@InterfaceAudience.Private<a name="line.44"></a>
-<span class="sourceLineNo">045</span>@InterfaceStability.Unstable<a name="line.45"></a>
-<span class="sourceLineNo">046</span>public class FlushSnapshotSubprocedure extends Subprocedure {<a name="line.46"></a>
-<span class="sourceLineNo">047</span>  private static final Log LOG = LogFactory.getLog(FlushSnapshotSubprocedure.class);<a name="line.47"></a>
-<span class="sourceLineNo">048</span><a name="line.48"></a>
-<span class="sourceLineNo">049</span>  private final List&lt;Region&gt; regions;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>  private final SnapshotDescription snapshot;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>  private final SnapshotSubprocedurePool taskManager;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>  private boolean snapshotSkipFlush = false;<a name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span>  public FlushSnapshotSubprocedure(ProcedureMember member,<a name="line.54"></a>
-<span class="sourceLineNo">055</span>      ForeignExceptionDispatcher errorListener, long wakeFrequency, long timeout,<a name="line.55"></a>
-<span class="sourceLineNo">056</span>      List&lt;Region&gt; regions, SnapshotDescription snapshot,<a name="line.56"></a>
-<span class="sourceLineNo">057</span>      SnapshotSubprocedurePool taskManager) {<a name="line.57"></a>
-<span class="sourceLineNo">058</span>    super(member, snapshot.getName(), errorListener, wakeFrequency, timeout);<a name="line.58"></a>
-<span class="sourceLineNo">059</span>    this.snapshot = snapshot;<a name="line.59"></a>
-<span class="sourceLineNo">060</span><a name="line.60"></a>
-<span class="sourceLineNo">061</span>    if (this.snapshot.getType() == SnapshotDescription.Type.SKIPFLUSH) {<a name="line.61"></a>
-<span class="sourceLineNo">062</span>      snapshotSkipFlush = true;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>    }<a name="line.63"></a>
-<span class="sourceLineNo">064</span>    this.regions = regions;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    this.taskManager = taskManager;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>  }<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span>  /**<a name="line.68"></a>
-<span class="sourceLineNo">069</span>   * Callable for adding files to snapshot manifest working dir.  Ready for multithreading.<a name="line.69"></a>
-<span class="sourceLineNo">070</span>   */<a name="line.70"></a>
-<span class="sourceLineNo">071</span>  private class RegionSnapshotTask implements Callable&lt;Void&gt; {<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    Region region;<a name="line.72"></a>
-<span class="sourceLineNo">073</span>    RegionSnapshotTask(Region region) {<a name="line.73"></a>
-<span class="sourceLineNo">074</span>      this.region = region;<a name="line.74"></a>
-<span class="sourceLineNo">075</span>    }<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span>    @Override<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    public Void call() throws Exception {<a name="line.78"></a>
-<span class="sourceLineNo">079</span>      // Taking the region read lock prevents the individual region from being closed while a<a name="line.79"></a>
-<span class="sourceLineNo">080</span>      // snapshot is in progress.  This is helpful but not sufficient for preventing races with<a name="line.80"></a>
-<span class="sourceLineNo">081</span>      // snapshots that involve multiple regions and regionservers.  It is still possible to have<a name="line.81"></a>
-<span class="sourceLineNo">082</span>      // an interleaving such that globally regions are missing, so we still need the verification<a name="line.82"></a>
-<span class="sourceLineNo">083</span>      // step.<a name="line.83"></a>
-<span class="sourceLineNo">084</span>      LOG.debug("Starting region operation on " + region);<a name="line.84"></a>
-<span class="sourceLineNo">085</span>      region.startRegionOperation();<a name="line.85"></a>
-<span class="sourceLineNo">086</span>      try {<a name="line.86"></a>
-<span class="sourceLineNo">087</span>        if (snapshotSkipFlush) {<a name="line.87"></a>
-<span class="sourceLineNo">088</span>        /*<a name="line.88"></a>
-<span class="sourceLineNo">089</span>         * This is to take an online-snapshot without force a coordinated flush to prevent pause<a name="line.89"></a>
-<span class="sourceLineNo">090</span>         * The snapshot type is defined inside the snapshot description. FlushSnapshotSubprocedure<a name="line.90"></a>
-<span class="sourceLineNo">091</span>         * should be renamed to distributedSnapshotSubprocedure, and the flush() behavior can be<a name="line.91"></a>
-<span class="sourceLineNo">092</span>         * turned on/off based on the flush type.<a name="line.92"></a>
-<span class="sourceLineNo">093</span>         * To minimized the code change, class name is not changed.<a name="line.93"></a>
-<span class="sourceLineNo">094</span>         */<a name="line.94"></a>
-<span class="sourceLineNo">095</span>          LOG.debug("take snapshot without flush memstore first");<a name="line.95"></a>
-<span class="sourceLineNo">096</span>        } else {<a name="line.96"></a>
-<span class="sourceLineNo">097</span>          LOG.debug("Flush Snapshotting region " + region.toString() + " started...");<a name="line.97"></a>
-<span class="sourceLineNo">098</span>          region.flush(true);<a name="line.98"></a>
-<span class="sourceLineNo">099</span>        }<a name="line.99"></a>
-<span class="sourceLineNo">100</span>        ((HRegion)region).addRegionToSnapshot(snapshot, monitor);<a name="line.100"></a>
-<span class="sourceLineNo">101</span>        if (snapshotSkipFlush) {<a name="line.101"></a>
-<span class="sourceLineNo">102</span>          LOG.debug("... SkipFlush Snapshotting region " + region.toString() + " completed.");<a name="line.102"></a>
-<span class="sourceLineNo">103</span>        } else {<a name="line.103"></a>
-<span class="sourceLineNo">104</span>          LOG.debug("... Flush Snapshotting region " + region.toString() + " completed.");<a name="line.104"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.regionserver.Region.FlushResult;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager.SnapshotSubprocedurePool;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.36"></a>
+<span class="sourceLineNo">037</span><a name="line.37"></a>
+<span class="sourceLineNo">038</span>/**<a name="line.38"></a>
+<span class="sourceLineNo">039</span> * This online snapshot implementation uses the distributed procedure framework to force a<a name="line.39"></a>
+<span class="sourceLineNo">040</span> * store flush and then records the hfiles.  Its enter stage does nothing.  Its leave stage then<a name="line.40"></a>
+<span class="sourceLineNo">041</span> * flushes the memstore, builds the region server's snapshot manifest from its hfiles list, and<a name="line.41"></a>
+<span class="sourceLineNo">042</span> * copies .regioninfos into the snapshot working directory.  At the master side, there is an atomic<a name="line.42"></a>
+<span class="sourceLineNo">043</span> * rename of the working dir into the proper snapshot directory.<a name="line.43"></a>
+<span class="sourceLineNo">044</span> */<a name="line.44"></a>
+<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a name="line.45"></a>
+<span class="sourceLineNo">046</span>@InterfaceStability.Unstable<a name="line.46"></a>
+<span class="sourceLineNo">047</span>public class FlushSnapshotSubprocedure extends Subprocedure {<a name="line.47"></a>
+<span class="sourceLineNo">048</span>  private static final Log LOG = LogFactory.getLog(FlushSnapshotSubprocedure.class);<a name="line.48"></a>
+<span class="sourceLineNo">049</span><a name="line.49"></a>
+<span class="sourceLineNo">050</span>  private final List&lt;Region&gt; regions;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>  private final SnapshotDescription snapshot;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>  private final SnapshotSubprocedurePool taskManager;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>  private boolean snapshotSkipFlush = false;<a name="line.53"></a>
+<span class="sourceLineNo">054</span><a name="line.54"></a>
+<span class="sourceLineNo">055</span>  public FlushSnapshotSubprocedure(ProcedureMember member,<a name="line.55"></a>
+<span class="sourceLineNo">056</span>      ForeignExceptionDispatcher errorListener, long wakeFrequency, long timeout,<a name="line.56"></a>
+<span class="sourceLineNo">057</span>      List&lt;Region&gt; regions, SnapshotDescription snapshot,<a name="line.57"></a>
+<span class="sourceLineNo">058</span>      SnapshotSubprocedurePool taskManager) {<a name="line.58"></a>
+<span class="sourceLineNo">059</span>    super(member, snapshot.getName(), errorListener, wakeFrequency, timeout);<a name="line.59"></a>
+<span class="sourceLineNo">060</span>    this.snapshot = snapshot;<a name="line.60"></a>
+<span class="sourceLineNo">061</span><a name="line.61"></a>
+<span class="sourceLineNo">062</span>    if (this.snapshot.getType() == SnapshotDescription.Type.SKIPFLUSH) {<a name="line.62"></a>
+<span class="sourceLineNo">063</span>      snapshotSkipFlush = true;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>    }<a name="line.64"></a>
+<span class="sourceLineNo">065</span>    this.regions = regions;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>    this.taskManager = taskManager;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>  }<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>  /**<a name="line.69"></a>
+<span class="sourceLineNo">070</span>   * Callable for adding files to snapshot manifest working dir.  Ready for multithreading.<a name="line.70"></a>
+<span class="sourceLineNo">071</span>   */<a name="line.71"></a>
+<span class="sourceLineNo">072</span>  private class RegionSnapshotTask implements Callable&lt;Void&gt; {<a name="line.72"></a>
+<span class="sourceLineNo">073</span>    Region region;<a name="line.73"></a>
+<span class="sourceLineNo">074</span>    RegionSnapshotTask(Region region) {<a name="line.74"></a>
+<span class="sourceLineNo">075</span>      this.region = region;<a name="line.75"></a>
+<span class="sourceLineNo">076</span>    }<a name="line.76"></a>
+<span class="sourceLineNo">077</span><a name="line.77"></a>
+<span class="sourceLineNo">078</span>    @Override<a name="line.78"></a>
+<span class="sourceLineNo">079</span>    public Void call() throws Exception {<a name="line.79"></a>
+<span class="sourceLineNo">080</span>      // Taking the region read lock prevents the individual region from being closed while a<a name="line.80"></a>
+<span class="sourceLineNo">081</span>      // snapshot is in progress.  This is helpful but not sufficient for preventing races with<a name="line.81"></a>
+<span class="sourceLineNo">082</span>      // snapshots that involve multiple regions and regionservers.  It is still possible to have<a name="line.82"></a>
+<span class="sourceLineNo">083</span>      // an interleaving such that globally regions are missing, so we still need the verification<a name="line.83"></a>
+<span class="sourceLineNo">084</span>      // step.<a name="line.84"></a>
+<span class="sourceLineNo">085</span>      LOG.debug("Starting region operation on " + region);<a name="line.85"></a>
+<span class="sourceLineNo">086</span>      region.startRegionOperation();<a name="line.86"></a>
+<span class="sourceLineNo">087</span>      try {<a name="line.87"></a>
+<span class="sourceLineNo">088</span>        if (snapshotSkipFlush) {<a name="line.88"></a>
+<span class="sourceLineNo">089</span>        /*<a name="line.89"></a>
+<span class="sourceLineNo">090</span>         * This is to take an online-snapshot without force a coordinated flush to prevent pause<a name="line.90"></a>
+<span class="sourceLineNo">091</span>         * The snapshot type is defined inside the snapshot description. FlushSnapshotSubprocedure<a name="line.91"></a>
+<span class="sourceLineNo">092</span>         * should be renamed to distributedSnapshotSubprocedure, and the flush() behavior can be<a name="line.92"></a>
+<span class="sourceLineNo">093</span>         * turned on/off based on the flush type.<a name="line.93"></a>
+<span class="sourceLineNo">094</span>         * To minimized the code change, class name is not changed.<a name="line.94"></a>
+<span class="sourceLineNo">095</span>         */<a name="line.95"></a>
+<span class="sourceLineNo">096</span>          LOG.debug("take snapshot without flush memstore first");<a name="line.96"></a>
+<span class="sourceLineNo">097</span>        } else {<a name="line.97"></a>
+<span class="sourceLineNo">098</span>          LOG.debug("Flush Snapshotting region " + region.toString() + " started...");<a name="line.98"></a>
+<span class="sourceLineNo">099</span>          FlushResult res = region.flush(true);<a name="line.99"></a>
+<span class="sourceLineNo">100</span>          if (res.getResult() == FlushResult.Result.CANNOT_FLUSH) {<a name="line.100"></a>
+<span class="sourceLineNo">101</span>            // CANNOT_FLUSH may mean that a flush is already on-going<a name="line.101"></a>
+<span class="sourceLineNo">102</span>            // we need to wait for that flush to complete<a name="line.102"></a>
+<span class="sourceLineNo">103</span>            region.waitForFlushes();<a name="line.103"></a>
+<span class="sourceLineNo">104</span>          }<a name="line.104"></a>
 <span class="sourceLineNo">105</span>        }<a name="line.105"></a>
-<span class="sourceLineNo">106</span>      } finally {<a name="line.106"></a>
-<span class="sourceLineNo">107</span>        LOG.debug("Closing region operation on " + region);<a name="line.107"></a>
-<span class="sourceLineNo">108</span>        region.closeRegionOperation();<a name="line.108"></a>
-<span class="sourceLineNo">109</span>      }<a name="line.109"></a>
-<span class="sourceLineNo">110</span>      return null;<a name="line.110"></a>
-<span class="sourceLineNo">111</span>    }<a name="line.111"></a>
-<span class="sourceLineNo">112</span>  }<a name="line.112"></a>
-<span class="sourceLineNo">113</span><a name="line.113"></a>
-<span class="sourceLineNo">114</span>  private void flushSnapshot() throws ForeignException {<a name="line.114"></a>
-<span class="sourceLineNo">115</span>    if (regions.isEmpty()) {<a name="line.115"></a>
-<span class="sourceLineNo">116</span>      // No regions on this RS, we are basically done.<a name="line.116"></a>
-<span class="sourceLineNo">117</span>      return;<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    }<a name="line.118"></a>
+<span class="sourceLineNo">106</span>        ((HRegion)region).addRegionToSnapshot(snapshot, monitor);<a name="line.106"></a>
+<span class="sourceLineNo">107</span>        if (snapshotSkipFlush) {<a name="line.107"></a>
+<span class="sourceLineNo">108</span>          LOG.debug("... SkipFlush Snapshotting region " + region.toString() + " completed.");<a name="line.108"></a>
+<span class="sourceLineNo">109</span>        } else {<a name="line.109"></a>
+<span class="sourceLineNo">110</span>          LOG.debug("... Flush Snapshotting region " + region.toString() + " completed.");<a name="line.110"></a>
+<span class="sourceLineNo">111</span>        }<a name="line.111"></a>
+<span class="sourceLineNo">112</span>      } finally {<a name="line.112"></a>
+<span class="sourceLineNo">113</span>        LOG.debug("Closing region operation on " + region);<a name="line.113"></a>
+<span class="sourceLineNo">114</span>        region.closeRegionOperation();<a name="line.114"></a>
+<span class="sourceLineNo">115</span>      }<a name="line.115"></a>
+<span class="sourceLineNo">116</span>      return null;<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    }<a name="line.117"></a>
+<span class="sourceLineNo">118</span>  }<a name="line.118"></a>
 <span class="sourceLineNo">119</span><a name="line.119"></a>
-<span class="sourceLineNo">120</span>    monitor.rethrowException();<a name="line.120"></a>
-<span class="sourceLineNo">121</span><a name="line.121"></a>
-<span class="sourceLineNo">122</span>    // assert that the taskManager is empty.<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    if (taskManager.hasTasks()) {<a name="line.123"></a>
-<span class="sourceLineNo">124</span>      throw new IllegalStateException("Attempting to take snapshot "<a name="line.124"></a>
-<span class="sourceLineNo">125</span>          + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.125"></a>
-<span class="sourceLineNo">126</span>          + " but we currently have outstanding tasks");<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    }<a name="line.127"></a>
-<span class="sourceLineNo">128</span><a name="line.128"></a>
-<span class="sourceLineNo">129</span>    // Add all hfiles already existing in region.<a name="line.129"></a>
-<span class="sourceLineNo">130</span>    for (Region region : regions) {<a name="line.130"></a>
-<span class="sourceLineNo">131</span>      // submit one task per region for parallelize by region.<a name="line.131"></a>
-<span class="sourceLineNo">132</span>      taskManager.submitTask(new RegionSnapshotTask(region));<a name="line.132"></a>
-<span class="sourceLineNo">133</span>      monitor.rethrowException();<a name="line.133"></a>
-<span class="sourceLineNo">134</span>    }<a name="line.134"></a>
-<span class="sourceLineNo">135</span><a name="line.135"></a>
-<span class="sourceLineNo">136</span>    // wait for everything to complete.<a name="line.136"></a>
-<span class="sourceLineNo">137</span>    LOG.debug("Flush Snapshot Tasks submitted for " + regions.size() + " regions");<a name="line.137"></a>
-<span class="sourceLineNo">138</span>    try {<a name="line.138"></a>
-<span class="sourceLineNo">139</span>      taskManager.waitForOutstandingTasks();<a name="line.139"></a>
-<span class="sourceLineNo">140</span>    } catch (InterruptedException e) {<a name="line.140"></a>
-<span class="sourceLineNo">141</span>      LOG.error("got interrupted exception for " + getMemberName());<a name="line.141"></a>
-<span class="sourceLineNo">142</span>      throw new ForeignException(getMemberName(), e);<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    }<a name="line.143"></a>
-<span class="sourceLineNo">144</span>  }<a name="line.144"></a>
-<span class="sourceLineNo">145</span><a name="line.145"></a>
-<span class="sourceLineNo">146</span>  /**<a name="line.146"></a>
-<span class="sourceLineNo">147</span>   * do nothing, core of snapshot is executed in {@link #insideBarrier} step.<a name="line.147"></a>
-<span class="sourceLineNo">148</span>   */<a name="line.148"></a>
-<span class="sourceLineNo">149</span>  @Override<a name="line.149"></a>
-<span class="sourceLineNo">150</span>  public void acquireBarrier() throws ForeignException {<a name="line.150"></a>
-<span class="sourceLineNo">151</span>    // NO OP<a name="line.151"></a>
-<span class="sourceLineNo">152</span>  }<a name="line.152"></a>
-<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span>  /**<a name="line.154"></a>
-<span class="sourceLineNo">155</span>   * do a flush snapshot of every region on this rs from the target table.<a name="line.155"></a>
-<span class="sourceLineNo">156</span>   */<a name="line.156"></a>
-<span class="sourceLineNo">157</span>  @Override<a name="line.157"></a>
-<span class="sourceLineNo">158</span>  public byte[] insideBarrier() throws ForeignException {<a name="line.158"></a>
-<span class="sourceLineNo">159</span>    flushSnapshot();<a name="line.159"></a>
-<span class="sourceLineNo">160</span>    return new byte[0];<a name="line.160"></a>
-<span class="sourceLineNo">161</span>  }<a name="line.161"></a>
-<span class="sourceLineNo">162</span><a name="line.162"></a>
-<span class="sourceLineNo">163</span>  /**<a name="line.163"></a>
-<span class="sourceLineNo">164</span>   * Cancel threads if they haven't finished.<a name="line.164"></a>
-<span class="sourceLineNo">165</span>   */<a name="line.165"></a>
-<span class="sourceLineNo">166</span>  @Override<a name="line.166"></a>
-<span class="sourceLineNo">167</span>  public void cleanup(Exception e) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span>    LOG.info("Aborting all online FLUSH snapshot subprocedure task threads for '"<a name="line.168"></a>
-<span class="sourceLineNo">169</span>        + snapshot.getName() + "' due to error", e);<a name="line.169"></a>
-<span class="sourceLineNo">170</span>    try {<a name="line.170"></a>
-<span class="sourceLineNo">171</span>      taskManager.cancelTasks();<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    } catch (InterruptedException e1) {<a name="line.172"></a>
-<span class="sourceLineNo">173</span>      Thread.currentThread().interrupt();<a name="line.173"></a>
-<span class="sourceLineNo">174</span>    }<a name="line.174"></a>
-<span class="sourceLineNo">175</span>  }<a name="line.175"></a>
-<span class="sourceLineNo">176</span><a name="line.176"></a>
-<span class="sourceLineNo">177</span>  /**<a name="line.177"></a>
-<span class="sourceLineNo">178</span>   * Hooray!<a name="line.178"></a>
-<span class="sourceLineNo">179</span>   */<a name="line.179"></a>
-<span class="sourceLineNo">180</span>  public void releaseBarrier() {<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    // NO OP<a name="line.181"></a>
-<span class="sourceLineNo">182</span>  }<a name="line.182"></a>
-<span class="sourceLineNo">183</span><a name="line.183"></a>
-<span class="sourceLineNo">184</span>}<a name="line.184"></a>
+<span class="sourceLineNo">120</span>  private void flushSnapshot() throws ForeignException {<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    if (regions.isEmpty()) {<a name="line.121"></a>
+<span class="sourceLineNo">122</span>      // No regions on this RS, we are basically done.<a name="line.122"></a>
+<span class="sourceLineNo">123</span>      return;<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    }<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>    monitor.rethrowException();<a name="line.126"></a>
+<span class="sourceLineNo">127</span><a name="line.127"></a>
+<span class="sourceLineNo">128</span>    // assert that the taskManager is empty.<a name="line.128"></a>
+<span class="sourceLineNo">129</span>    if (taskManager.hasTasks()) {<a name="line.129"></a>
+<span class="sourceLineNo">130</span>      throw new IllegalStateException("Attempting to take snapshot "<a name="line.130"></a>
+<span class="sourceLineNo">131</span>          + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.131"></a>
+<span class="sourceLineNo">132</span>          + " but we currently have outstanding tasks");<a name="line.132"></a>
+<span class="sourceLineNo">133</span>    }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span>    // Add all hfiles already existing in region.<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    for (Region region : regions) {<a name="line.136"></a>
+<span class="sourceLineNo">137</span>      // submit one task per region for parallelize by region.<a name="line.137"></a>
+<span class="sourceLineNo">138</span>      taskManager.submitTask(new RegionSnapshotTask(region));<a name="line.138"></a>
+<span class="sourceLineNo">139</span>      monitor.rethrowException();<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    }<a name="line.140"></a>
+<span class="sourceLineNo">141</span><a name="line.141"></a>
+<span class="sourceLineNo">142</span>    // wait for everything to complete.<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    LOG.debug("Flush Snapshot Tasks submitted for " + regions.size() + " regions");<a name="line.143"></a>
+<span class="sourceLineNo">144</span>    try {<a name="line.144"></a>
+<span class="sourceLineNo">145</span>      taskManager.waitForOutstandingTasks();<a name="line.145"></a>
+<span class="sourceLineNo">146</span>    } catch (InterruptedException e) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span>      LOG.error("got interrupted exception for " + getMemberName());<a name="line.147"></a>
+<span class="sourceLineNo">148</span>      throw new ForeignException(getMemberName(), e);<a name="line.148"></a>
+<span class="sourceLineNo">149</span>    }<a name="line.149"></a>
+<span class="sourceLineNo">150</span>  }<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span>  /**<a name="line.152"></a>
+<span class="sourceLineNo">153</span>   * do nothing, core of snapshot is executed in {@link #insideBarrier} step.<a name="line.153"></a>
+<span class="sourceLineNo">154</span>   */<a name="line.154"></a>
+<span class="sourceLineNo">155</span>  @Override<a name="line.155"></a>
+<span class="sourceLineNo">156</span>  public void acquireBarrier() throws ForeignException {<a name="line.156"></a>
+<span class="sourceLineNo">157</span>    // NO OP<a name="line.157"></a>
+<span class="sourceLineNo">158</span>  }<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span>  /**<a name="line.160"></a>
+<span class="sourceLineNo">161</span>   * do a flush snapshot of every region on this rs from the target table.<a name="line.161"></a>
+<span class="sourceLineNo">162</span>   */<a name="line.162"></a>
+<span class="sourceLineNo">163</span>  @Override<a name="line.163"></a>
+<span class="sourceLineNo">164</span>  public byte[] insideBarrier() throws ForeignException {<a name="line.164"></a>
+<span class="sourceLineNo">165</span>    flushSnapshot();<a name="line.165"></a>
+<span class="sourceLineNo">166</span>    return new byte[0];<a name="line.166"></a>
+<span class="sourceLineNo">167</span>  }<a name="line.167"></a>
+<span class="sourceLineNo">168</span><a name="line.168"></a>
+<span class="sourceLineNo">169</span>  /**<a name="line.169"></a>
+<span class="sourceLineNo">170</span>   * Cancel threads if they haven't finished.<a name="line.170"></a>
+<span class="sourceLineNo">171</span>   */<a name="line.171"></a>
+<span class="sourceLineNo">172</span>  @Override<a name="line.172"></a>
+<span class="sourceLineNo">173</span>  public void cleanup(Exception e) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    LOG.info("Aborting all online FLUSH snapshot subprocedure task threads for '"<a name="line.174"></a>
+<span class="sourceLineNo">175</span>        + snapshot.getName() + "' due to error", e);<a name="line.175"></a>
+<span class="sourceLineNo">176</span>    try {<a name="line.176"></a>
+<span class="sourceLineNo">177</span>      taskManager.cancelTasks();<a name="line.177"></a>
+<span class="sourceLineNo">178</span>    } catch (InterruptedException e1) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span>      Thread.currentThread().interrupt();<a name="line.179"></a>
+<span class="sourceLineNo">180</span>    }<a name="line.180"></a>
+<span class="sourceLineNo">181</span>  }<a name="line.181"></a>
+<span class="sourceLineNo">182</span><a name="line.182"></a>
+<span class="sourceLineNo">183</span>  /**<a name="line.183"></a>
+<span class="sourceLineNo">184</span>   * Hooray!<a name="line.184"></a>
+<span class="sourceLineNo">185</span>   */<a name="line.185"></a>
+<span class="sourceLineNo">186</span>  public void releaseBarrier() {<a name="line.186"></a>
+<span class="sourceLineNo">187</span>    // NO OP<a name="line.187"></a>
+<span class="sourceLineNo">188</span>  }<a name="line.188"></a>
+<span class="sourceLineNo">189</span><a name="line.189"></a>
+<span class="sourceLineNo">190</span>}<a name="line.190"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6cafca90/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.html
index 7575174..238f4d6 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/snapshot/FlushSnapshotSubprocedure.html
@@ -38,158 +38,164 @@
 <span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.procedure.Subprocedure;<a name="line.30"></a>
 <span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.regionserver.HRegion;<a name="line.31"></a>
 <span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.regionserver.Region;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager.SnapshotSubprocedurePool;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.35"></a>
-<span class="sourceLineNo">036</span><a name="line.36"></a>
-<span class="sourceLineNo">037</span>/**<a name="line.37"></a>
-<span class="sourceLineNo">038</span> * This online snapshot implementation uses the distributed procedure framework to force a<a name="line.38"></a>
-<span class="sourceLineNo">039</span> * store flush and then records the hfiles.  Its enter stage does nothing.  Its leave stage then<a name="line.39"></a>
-<span class="sourceLineNo">040</span> * flushes the memstore, builds the region server's snapshot manifest from its hfiles list, and<a name="line.40"></a>
-<span class="sourceLineNo">041</span> * copies .regioninfos into the snapshot working directory.  At the master side, there is an atomic<a name="line.41"></a>
-<span class="sourceLineNo">042</span> * rename of the working dir into the proper snapshot directory.<a name="line.42"></a>
-<span class="sourceLineNo">043</span> */<a name="line.43"></a>
-<span class="sourceLineNo">044</span>@InterfaceAudience.Private<a name="line.44"></a>
-<span class="sourceLineNo">045</span>@InterfaceStability.Unstable<a name="line.45"></a>
-<span class="sourceLineNo">046</span>public class FlushSnapshotSubprocedure extends Subprocedure {<a name="line.46"></a>
-<span class="sourceLineNo">047</span>  private static final Log LOG = LogFactory.getLog(FlushSnapshotSubprocedure.class);<a name="line.47"></a>
-<span class="sourceLineNo">048</span><a name="line.48"></a>
-<span class="sourceLineNo">049</span>  private final List&lt;Region&gt; regions;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>  private final SnapshotDescription snapshot;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>  private final SnapshotSubprocedurePool taskManager;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>  private boolean snapshotSkipFlush = false;<a name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span>  public FlushSnapshotSubprocedure(ProcedureMember member,<a name="line.54"></a>
-<span class="sourceLineNo">055</span>      ForeignExceptionDispatcher errorListener, long wakeFrequency, long timeout,<a name="line.55"></a>
-<span class="sourceLineNo">056</span>      List&lt;Region&gt; regions, SnapshotDescription snapshot,<a name="line.56"></a>
-<span class="sourceLineNo">057</span>      SnapshotSubprocedurePool taskManager) {<a name="line.57"></a>
-<span class="sourceLineNo">058</span>    super(member, snapshot.getName(), errorListener, wakeFrequency, timeout);<a name="line.58"></a>
-<span class="sourceLineNo">059</span>    this.snapshot = snapshot;<a name="line.59"></a>
-<span class="sourceLineNo">060</span><a name="line.60"></a>
-<span class="sourceLineNo">061</span>    if (this.snapshot.getType() == SnapshotDescription.Type.SKIPFLUSH) {<a name="line.61"></a>
-<span class="sourceLineNo">062</span>      snapshotSkipFlush = true;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>    }<a name="line.63"></a>
-<span class="sourceLineNo">064</span>    this.regions = regions;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    this.taskManager = taskManager;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>  }<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span>  /**<a name="line.68"></a>
-<span class="sourceLineNo">069</span>   * Callable for adding files to snapshot manifest working dir.  Ready for multithreading.<a name="line.69"></a>
-<span class="sourceLineNo">070</span>   */<a name="line.70"></a>
-<span class="sourceLineNo">071</span>  private class RegionSnapshotTask implements Callable&lt;Void&gt; {<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    Region region;<a name="line.72"></a>
-<span class="sourceLineNo">073</span>    RegionSnapshotTask(Region region) {<a name="line.73"></a>
-<span class="sourceLineNo">074</span>      this.region = region;<a name="line.74"></a>
-<span class="sourceLineNo">075</span>    }<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span>    @Override<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    public Void call() throws Exception {<a name="line.78"></a>
-<span class="sourceLineNo">079</span>      // Taking the region read lock prevents the individual region from being closed while a<a name="line.79"></a>
-<span class="sourceLineNo">080</span>      // snapshot is in progress.  This is helpful but not sufficient for preventing races with<a name="line.80"></a>
-<span class="sourceLineNo">081</span>      // snapshots that involve multiple regions and regionservers.  It is still possible to have<a name="line.81"></a>
-<span class="sourceLineNo">082</span>      // an interleaving such that globally regions are missing, so we still need the verification<a name="line.82"></a>
-<span class="sourceLineNo">083</span>      // step.<a name="line.83"></a>
-<span class="sourceLineNo">084</span>      LOG.debug("Starting region operation on " + region);<a name="line.84"></a>
-<span class="sourceLineNo">085</span>      region.startRegionOperation();<a name="line.85"></a>
-<span class="sourceLineNo">086</span>      try {<a name="line.86"></a>
-<span class="sourceLineNo">087</span>        if (snapshotSkipFlush) {<a name="line.87"></a>
-<span class="sourceLineNo">088</span>        /*<a name="line.88"></a>
-<span class="sourceLineNo">089</span>         * This is to take an online-snapshot without force a coordinated flush to prevent pause<a name="line.89"></a>
-<span class="sourceLineNo">090</span>         * The snapshot type is defined inside the snapshot description. FlushSnapshotSubprocedure<a name="line.90"></a>
-<span class="sourceLineNo">091</span>         * should be renamed to distributedSnapshotSubprocedure, and the flush() behavior can be<a name="line.91"></a>
-<span class="sourceLineNo">092</span>         * turned on/off based on the flush type.<a name="line.92"></a>
-<span class="sourceLineNo">093</span>         * To minimized the code change, class name is not changed.<a name="line.93"></a>
-<span class="sourceLineNo">094</span>         */<a name="line.94"></a>
-<span class="sourceLineNo">095</span>          LOG.debug("take snapshot without flush memstore first");<a name="line.95"></a>
-<span class="sourceLineNo">096</span>        } else {<a name="line.96"></a>
-<span class="sourceLineNo">097</span>          LOG.debug("Flush Snapshotting region " + region.toString() + " started...");<a name="line.97"></a>
-<span class="sourceLineNo">098</span>          region.flush(true);<a name="line.98"></a>
-<span class="sourceLineNo">099</span>        }<a name="line.99"></a>
-<span class="sourceLineNo">100</span>        ((HRegion)region).addRegionToSnapshot(snapshot, monitor);<a name="line.100"></a>
-<span class="sourceLineNo">101</span>        if (snapshotSkipFlush) {<a name="line.101"></a>
-<span class="sourceLineNo">102</span>          LOG.debug("... SkipFlush Snapshotting region " + region.toString() + " completed.");<a name="line.102"></a>
-<span class="sourceLineNo">103</span>        } else {<a name="line.103"></a>
-<span class="sourceLineNo">104</span>          LOG.debug("... Flush Snapshotting region " + region.toString() + " completed.");<a name="line.104"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.regionserver.Region.FlushResult;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager.SnapshotSubprocedurePool;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos.SnapshotDescription;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.snapshot.ClientSnapshotDescriptionUtils;<a name="line.36"></a>
+<span class="sourceLineNo">037</span><a name="line.37"></a>
+<span class="sourceLineNo">038</span>/**<a name="line.38"></a>
+<span class="sourceLineNo">039</span> * This online snapshot implementation uses the distributed procedure framework to force a<a name="line.39"></a>
+<span class="sourceLineNo">040</span> * store flush and then records the hfiles.  Its enter stage does nothing.  Its leave stage then<a name="line.40"></a>
+<span class="sourceLineNo">041</span> * flushes the memstore, builds the region server's snapshot manifest from its hfiles list, and<a name="line.41"></a>
+<span class="sourceLineNo">042</span> * copies .regioninfos into the snapshot working directory.  At the master side, there is an atomic<a name="line.42"></a>
+<span class="sourceLineNo">043</span> * rename of the working dir into the proper snapshot directory.<a name="line.43"></a>
+<span class="sourceLineNo">044</span> */<a name="line.44"></a>
+<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a name="line.45"></a>
+<span class="sourceLineNo">046</span>@InterfaceStability.Unstable<a name="line.46"></a>
+<span class="sourceLineNo">047</span>public class FlushSnapshotSubprocedure extends Subprocedure {<a name="line.47"></a>
+<span class="sourceLineNo">048</span>  private static final Log LOG = LogFactory.getLog(FlushSnapshotSubprocedure.class);<a name="line.48"></a>
+<span class="sourceLineNo">049</span><a name="line.49"></a>
+<span class="sourceLineNo">050</span>  private final List&lt;Region&gt; regions;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>  private final SnapshotDescription snapshot;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>  private final SnapshotSubprocedurePool taskManager;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>  private boolean snapshotSkipFlush = false;<a name="line.53"></a>
+<span class="sourceLineNo">054</span><a name="line.54"></a>
+<span class="sourceLineNo">055</span>  public FlushSnapshotSubprocedure(ProcedureMember member,<a name="line.55"></a>
+<span class="sourceLineNo">056</span>      ForeignExceptionDispatcher errorListener, long wakeFrequency, long timeout,<a name="line.56"></a>
+<span class="sourceLineNo">057</span>      List&lt;Region&gt; regions, SnapshotDescription snapshot,<a name="line.57"></a>
+<span class="sourceLineNo">058</span>      SnapshotSubprocedurePool taskManager) {<a name="line.58"></a>
+<span class="sourceLineNo">059</span>    super(member, snapshot.getName(), errorListener, wakeFrequency, timeout);<a name="line.59"></a>
+<span class="sourceLineNo">060</span>    this.snapshot = snapshot;<a name="line.60"></a>
+<span class="sourceLineNo">061</span><a name="line.61"></a>
+<span class="sourceLineNo">062</span>    if (this.snapshot.getType() == SnapshotDescription.Type.SKIPFLUSH) {<a name="line.62"></a>
+<span class="sourceLineNo">063</span>      snapshotSkipFlush = true;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>    }<a name="line.64"></a>
+<span class="sourceLineNo">065</span>    this.regions = regions;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>    this.taskManager = taskManager;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>  }<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>  /**<a name="line.69"></a>
+<span class="sourceLineNo">070</span>   * Callable for adding files to snapshot manifest working dir.  Ready for multithreading.<a name="line.70"></a>
+<span class="sourceLineNo">071</span>   */<a name="line.71"></a>
+<span class="sourceLineNo">072</span>  private class RegionSnapshotTask implements Callable&lt;Void&gt; {<a name="line.72"></a>
+<span class="sourceLineNo">073</span>    Region region;<a name="line.73"></a>
+<span class="sourceLineNo">074</span>    RegionSnapshotTask(Region region) {<a name="line.74"></a>
+<span class="sourceLineNo">075</span>      this.region = region;<a name="line.75"></a>
+<span class="sourceLineNo">076</span>    }<a name="line.76"></a>
+<span class="sourceLineNo">077</span><a name="line.77"></a>
+<span class="sourceLineNo">078</span>    @Override<a name="line.78"></a>
+<span class="sourceLineNo">079</span>    public Void call() throws Exception {<a name="line.79"></a>
+<span class="sourceLineNo">080</span>      // Taking the region read lock prevents the individual region from being closed while a<a name="line.80"></a>
+<span class="sourceLineNo">081</span>      // snapshot is in progress.  This is helpful but not sufficient for preventing races with<a name="line.81"></a>
+<span class="sourceLineNo">082</span>      // snapshots that involve multiple regions and regionservers.  It is still possible to have<a name="line.82"></a>
+<span class="sourceLineNo">083</span>      // an interleaving such that globally regions are missing, so we still need the verification<a name="line.83"></a>
+<span class="sourceLineNo">084</span>      // step.<a name="line.84"></a>
+<span class="sourceLineNo">085</span>      LOG.debug("Starting region operation on " + region);<a name="line.85"></a>
+<span class="sourceLineNo">086</span>      region.startRegionOperation();<a name="line.86"></a>
+<span class="sourceLineNo">087</span>      try {<a name="line.87"></a>
+<span class="sourceLineNo">088</span>        if (snapshotSkipFlush) {<a name="line.88"></a>
+<span class="sourceLineNo">089</span>        /*<a name="line.89"></a>
+<span class="sourceLineNo">090</span>         * This is to take an online-snapshot without force a coordinated flush to prevent pause<a name="line.90"></a>
+<span class="sourceLineNo">091</span>         * The snapshot type is defined inside the snapshot description. FlushSnapshotSubprocedure<a name="line.91"></a>
+<span class="sourceLineNo">092</span>         * should be renamed to distributedSnapshotSubprocedure, and the flush() behavior can be<a name="line.92"></a>
+<span class="sourceLineNo">093</span>         * turned on/off based on the flush type.<a name="line.93"></a>
+<span class="sourceLineNo">094</span>         * To minimized the code change, class name is not changed.<a name="line.94"></a>
+<span class="sourceLineNo">095</span>         */<a name="line.95"></a>
+<span class="sourceLineNo">096</span>          LOG.debug("take snapshot without flush memstore first");<a name="line.96"></a>
+<span class="sourceLineNo">097</span>        } else {<a name="line.97"></a>
+<span class="sourceLineNo">098</span>          LOG.debug("Flush Snapshotting region " + region.toString() + " started...");<a name="line.98"></a>
+<span class="sourceLineNo">099</span>          FlushResult res = region.flush(true);<a name="line.99"></a>
+<span class="sourceLineNo">100</span>          if (res.getResult() == FlushResult.Result.CANNOT_FLUSH) {<a name="line.100"></a>
+<span class="sourceLineNo">101</span>            // CANNOT_FLUSH may mean that a flush is already on-going<a name="line.101"></a>
+<span class="sourceLineNo">102</span>            // we need to wait for that flush to complete<a name="line.102"></a>
+<span class="sourceLineNo">103</span>            region.waitForFlushes();<a name="line.103"></a>
+<span class="sourceLineNo">104</span>          }<a name="line.104"></a>
 <span class="sourceLineNo">105</span>        }<a name="line.105"></a>
-<span class="sourceLineNo">106</span>      } finally {<a name="line.106"></a>
-<span class="sourceLineNo">107</span>        LOG.debug("Closing region operation on " + region);<a name="line.107"></a>
-<span class="sourceLineNo">108</span>        region.closeRegionOperation();<a name="line.108"></a>
-<span class="sourceLineNo">109</span>      }<a name="line.109"></a>
-<span class="sourceLineNo">110</span>      return null;<a name="line.110"></a>
-<span class="sourceLineNo">111</span>    }<a name="line.111"></a>
-<span class="sourceLineNo">112</span>  }<a name="line.112"></a>
-<span class="sourceLineNo">113</span><a name="line.113"></a>
-<span class="sourceLineNo">114</span>  private void flushSnapshot() throws ForeignException {<a name="line.114"></a>
-<span class="sourceLineNo">115</span>    if (regions.isEmpty()) {<a name="line.115"></a>
-<span class="sourceLineNo">116</span>      // No regions on this RS, we are basically done.<a name="line.116"></a>
-<span class="sourceLineNo">117</span>      return;<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    }<a name="line.118"></a>
+<span class="sourceLineNo">106</span>        ((HRegion)region).addRegionToSnapshot(snapshot, monitor);<a name="line.106"></a>
+<span class="sourceLineNo">107</span>        if (snapshotSkipFlush) {<a name="line.107"></a>
+<span class="sourceLineNo">108</span>          LOG.debug("... SkipFlush Snapshotting region " + region.toString() + " completed.");<a name="line.108"></a>
+<span class="sourceLineNo">109</span>        } else {<a name="line.109"></a>
+<span class="sourceLineNo">110</span>          LOG.debug("... Flush Snapshotting region " + region.toString() + " completed.");<a name="line.110"></a>
+<span class="sourceLineNo">111</span>        }<a name="line.111"></a>
+<span class="sourceLineNo">112</span>      } finally {<a name="line.112"></a>
+<span class="sourceLineNo">113</span>        LOG.debug("Closing region operation on " + region);<a name="line.113"></a>
+<span class="sourceLineNo">114</span>        region.closeRegionOperation();<a name="line.114"></a>
+<span class="sourceLineNo">115</span>      }<a name="line.115"></a>
+<span class="sourceLineNo">116</span>      return null;<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    }<a name="line.117"></a>
+<span class="sourceLineNo">118</span>  }<a name="line.118"></a>
 <span class="sourceLineNo">119</span><a name="line.119"></a>
-<span class="sourceLineNo">120</span>    monitor.rethrowException();<a name="line.120"></a>
-<span class="sourceLineNo">121</span><a name="line.121"></a>
-<span class="sourceLineNo">122</span>    // assert that the taskManager is empty.<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    if (taskManager.hasTasks()) {<a name="line.123"></a>
-<span class="sourceLineNo">124</span>      throw new IllegalStateException("Attempting to take snapshot "<a name="line.124"></a>
-<span class="sourceLineNo">125</span>          + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.125"></a>
-<span class="sourceLineNo">126</span>          + " but we currently have outstanding tasks");<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    }<a name="line.127"></a>
-<span class="sourceLineNo">128</span><a name="line.128"></a>
-<span class="sourceLineNo">129</span>    // Add all hfiles already existing in region.<a name="line.129"></a>
-<span class="sourceLineNo">130</span>    for (Region region : regions) {<a name="line.130"></a>
-<span class="sourceLineNo">131</span>      // submit one task per region for parallelize by region.<a name="line.131"></a>
-<span class="sourceLineNo">132</span>      taskManager.submitTask(new RegionSnapshotTask(region));<a name="line.132"></a>
-<span class="sourceLineNo">133</span>      monitor.rethrowException();<a name="line.133"></a>
-<span class="sourceLineNo">134</span>    }<a name="line.134"></a>
-<span class="sourceLineNo">135</span><a name="line.135"></a>
-<span class="sourceLineNo">136</span>    // wait for everything to complete.<a name="line.136"></a>
-<span class="sourceLineNo">137</span>    LOG.debug("Flush Snapshot Tasks submitted for " + regions.size() + " regions");<a name="line.137"></a>
-<span class="sourceLineNo">138</span>    try {<a name="line.138"></a>
-<span class="sourceLineNo">139</span>      taskManager.waitForOutstandingTasks();<a name="line.139"></a>
-<span class="sourceLineNo">140</span>    } catch (InterruptedException e) {<a name="line.140"></a>
-<span class="sourceLineNo">141</span>      LOG.error("got interrupted exception for " + getMemberName());<a name="line.141"></a>
-<span class="sourceLineNo">142</span>      throw new ForeignException(getMemberName(), e);<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    }<a name="line.143"></a>
-<span class="sourceLineNo">144</span>  }<a name="line.144"></a>
-<span class="sourceLineNo">145</span><a name="line.145"></a>
-<span class="sourceLineNo">146</span>  /**<a name="line.146"></a>
-<span class="sourceLineNo">147</span>   * do nothing, core of snapshot is executed in {@link #insideBarrier} step.<a name="line.147"></a>
-<span class="sourceLineNo">148</span>   */<a name="line.148"></a>
-<span class="sourceLineNo">149</span>  @Override<a name="line.149"></a>
-<span class="sourceLineNo">150</span>  public void acquireBarrier() throws ForeignException {<a name="line.150"></a>
-<span class="sourceLineNo">151</span>    // NO OP<a name="line.151"></a>
-<span class="sourceLineNo">152</span>  }<a name="line.152"></a>
-<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span>  /**<a name="line.154"></a>
-<span class="sourceLineNo">155</span>   * do a flush snapshot of every region on this rs from the target table.<a name="line.155"></a>
-<span class="sourceLineNo">156</span>   */<a name="line.156"></a>
-<span class="sourceLineNo">157</span>  @Override<a name="line.157"></a>
-<span class="sourceLineNo">158</span>  public byte[] insideBarrier() throws ForeignException {<a name="line.158"></a>
-<span class="sourceLineNo">159</span>    flushSnapshot();<a name="line.159"></a>
-<span class="sourceLineNo">160</span>    return new byte[0];<a name="line.160"></a>
-<span class="sourceLineNo">161</span>  }<a name="line.161"></a>
-<span class="sourceLineNo">162</span><a name="line.162"></a>
-<span class="sourceLineNo">163</span>  /**<a name="line.163"></a>
-<span class="sourceLineNo">164</span>   * Cancel threads if they haven't finished.<a name="line.164"></a>
-<span class="sourceLineNo">165</span>   */<a name="line.165"></a>
-<span class="sourceLineNo">166</span>  @Override<a name="line.166"></a>
-<span class="sourceLineNo">167</span>  public void cleanup(Exception e) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span>    LOG.info("Aborting all online FLUSH snapshot subprocedure task threads for '"<a name="line.168"></a>
-<span class="sourceLineNo">169</span>        + snapshot.getName() + "' due to error", e);<a name="line.169"></a>
-<span class="sourceLineNo">170</span>    try {<a name="line.170"></a>
-<span class="sourceLineNo">171</span>      taskManager.cancelTasks();<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    } catch (InterruptedException e1) {<a name="line.172"></a>
-<span class="sourceLineNo">173</span>      Thread.currentThread().interrupt();<a name="line.173"></a>
-<span class="sourceLineNo">174</span>    }<a name="line.174"></a>
-<span class="sourceLineNo">175</span>  }<a name="line.175"></a>
-<span class="sourceLineNo">176</span><a name="line.176"></a>
-<span class="sourceLineNo">177</span>  /**<a name="line.177"></a>
-<span class="sourceLineNo">178</span>   * Hooray!<a name="line.178"></a>
-<span class="sourceLineNo">179</span>   */<a name="line.179"></a>
-<span class="sourceLineNo">180</span>  public void releaseBarrier() {<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    // NO OP<a name="line.181"></a>
-<span class="sourceLineNo">182</span>  }<a name="line.182"></a>
-<span class="sourceLineNo">183</span><a name="line.183"></a>
-<span class="sourceLineNo">184</span>}<a name="line.184"></a>
+<span class="sourceLineNo">120</span>  private void flushSnapshot() throws ForeignException {<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    if (regions.isEmpty()) {<a name="line.121"></a>
+<span class="sourceLineNo">122</span>      // No regions on this RS, we are basically done.<a name="line.122"></a>
+<span class="sourceLineNo">123</span>      return;<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    }<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>    monitor.rethrowException();<a name="line.126"></a>
+<span class="sourceLineNo">127</span><a name="line.127"></a>
+<span class="sourceLineNo">128</span>    // assert that the taskManager is empty.<a name="line.128"></a>
+<span class="sourceLineNo">129</span>    if (taskManager.hasTasks()) {<a name="line.129"></a>
+<span class="sourceLineNo">130</span>      throw new IllegalStateException("Attempting to take snapshot "<a name="line.130"></a>
+<span class="sourceLineNo">131</span>          + ClientSnapshotDescriptionUtils.toString(snapshot)<a name="line.131"></a>
+<span class="sourceLineNo">132</span>          + " but we currently have outstanding tasks");<a name="line.132"></a>
+<span class="sourceLineNo">133</span>    }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span>    // Add all hfiles already existing in region.<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    for (Region region : regions) {<a name="line.136"></a>
+<span class="sourceLineNo">137</span>      // submit one task per region for parallelize by region.<a name="line.137"></a>
+<span class="sourceLineNo">138</span>      taskManager.submitTask(new RegionSnapshotTask(region));<a name="line.138"></a>
+<span class="sourceLineNo">139</span>      monitor.rethrowException();<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    }<a name="line.140"></a>
+<span class="sourceLineNo">141</span><a name="line.141"></a>
+<span class="sourceLineNo">142</span>    // wait for everything to complete.<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    LOG.debug("Flush Snapshot Tasks submitted for " + regions.size() + " regions");<a name="line.143"></a>
+<span class="sourceLineNo">144</span>    try {<a name="line.144"></a>
+<span class="sourceLineNo">145</span>      taskManager.waitForOutstandingTasks();<a name="line.145"></a>
+<span class="sourceLineNo">146</span>    } catch (InterruptedException e) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span>      LOG.error("got interrupted exception for " + getMemberName());<a name="line.147"></a>
+<span class="sourceLineNo">148</span>      throw new ForeignException(getMemberName(), e);<a name="line.148"></a>
+<span class="sourceLineNo">149</span>    }<a name="line.149"></a>
+<span class="sourceLineNo">150</span>  }<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span>  /**<a name="line.152"></a>
+<span class="sourceLineNo">153</span>   * do nothing, core of snapshot is executed in {@link #insideBarrier} step.<a name="line.153"></a>
+<span class="sourceLineNo">154</span>   */<a name="line.154"></a>
+<span class="sourceLineNo">155</span>  @Override<a name="line.155"></a>
+<span class="sourceLineNo">156</span>  public void acquireBarrier() throws ForeignException {<a name="line.156"></a>
+<span class="sourceLineNo">157</span>    // NO OP<a name="line.157"></a>
+<span class="sourceLineNo">158</span>  }<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span>  /**<a name="line.160"></a>
+<span class="sourceLineNo">161</span>   * do a flush snapshot of every region on this rs from the target table.<a name="line.161"></a>
+<span class="sourceLineNo">162</span>   */<a name="line.162"></a>
+<span class="sourceLineNo">163</span>  @Override<a name="line.163"></a>
+<span class="sourceLineNo">164</span>  public byte[] insideBarrier() throws ForeignException {<a name="line.164"></a>
+<span class="sourceLineNo">165</span>    flushSnapshot();<a name="line.165"></a>
+<span class="sourceLineNo">166</span>    return new byte[0];<a name="line.166"></a>
+<span class="sourceLineNo">167</span>  }<a name="line.167"></a>
+<span class="sourceLineNo">168</span><a name="line.168"></a>
+<span class="sourceLineNo">169</span>  /**<a name="line.169"></a>
+<span class="sourceLineNo">170</span>   * Cancel threads if they haven't finished.<a name="line.170"></a>
+<span class="sourceLineNo">171</span>   */<a name="line.171"></a>
+<span class="sourceLineNo">172</span>  @Override<a name="line.172"></a>
+<span class="sourceLineNo">173</span>  public void cleanup(Exception e) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    LOG.info("Aborting all online FLUSH snapshot subprocedure task threads for '"<a name="line.174"></a>
+<span class="sourceLineNo">175</span>        + snapshot.getName() + "' due to error", e);<a name="line.175"></a>
+<span class="sourceLineNo">176</span>    try {<a name="line.176"></a>
+<span class="sourceLineNo">177</span>      taskManager.cancelTasks();<a name="line.177"></a>
+<span class="sourceLineNo">178</span>    } catch (InterruptedException e1) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span>      Thread.currentThread().interrupt();<a name="line.179"></a>
+<span class="sourceLineNo">180</span>    }<a name="line.180"></a>
+<span class="sourceLineNo">181</span>  }<a name="line.181"></a>
+<span class="sourceLineNo">182</span><a name="line.182"></a>
+<span class="sourceLineNo">183</span>  /**<a name="line.183"></a>
+<span class="sourceLineNo">184</span>   * Hooray!<a name="line.184"></a>
+<span class="sourceLineNo">185</span>   */<a name="line.185"></a>
+<span class="sourceLineNo">186</span>  public void releaseBarrier() {<a name="line.186"></a>
+<span class="sourceLineNo">187</span>    // NO OP<a name="line.187"></a>
+<span class="sourceLineNo">188</span>  }<a name="line.188"></a>
+<span class="sourceLineNo">189</span><a name="line.189"></a>
+<span class="sourceLineNo">190</span>}<a name="line.190"></a>
 
 
 


Mime
View raw message