Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF302200BD2 for ; Sat, 3 Dec 2016 16:38:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D3C4C160B16; Sat, 3 Dec 2016 15:38:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 25D84160B0F for ; Sat, 3 Dec 2016 16:38:36 +0100 (CET) Received: (qmail 29631 invoked by uid 500); 3 Dec 2016 15:38:36 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 29622 invoked by uid 99); 3 Dec 2016 15:38:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 15:38:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F16C5E02E4; Sat, 3 Dec 2016 15:38:35 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: mbertozzi@apache.org To: commits@hbase.apache.org Message-Id: <216c3c118ef14e77861be59bb1cfcff8@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-17243 Reuse CompactionPartitionId and avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary new objects (addendum) Date: Sat, 3 Dec 2016 15:38:35 +0000 (UTC) archived-at: Sat, 03 Dec 2016 15:38:38 -0000 Repository: hbase Updated Branches: refs/heads/master efcd15bf6 -> 03423fec6 HBASE-17243 Reuse CompactionPartitionId and avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary new objects (addendum) Signed-off-by: Matteo Bertozzi Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/03423fec Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/03423fec Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/03423fec Branch: refs/heads/master Commit: 03423fec6bbb16e049bd1294ec439cf56fd0e785 Parents: efcd15b Author: Huaxiang Sun Authored: Sat Dec 3 07:18:36 2016 -0800 Committer: Matteo Bertozzi Committed: Sat Dec 3 07:19:02 2016 -0800 ---------------------------------------------------------------------- .../hadoop/hbase/mob/compactions/PartitionedMobCompactor.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/03423fec/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java index 6c8080c..33f5e71 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java @@ -176,10 +176,11 @@ public class PartitionedMobCompactor extends MobCompactor { id.setDate(MobFileName.getDateFromName(fileName)); CompactionPartition compactionPartition = filesToCompact.get(id); if (compactionPartition == null) { - compactionPartition = new CompactionPartition( - new CompactionPartitionId(id.getStartKey(), id.getDate())); + CompactionPartitionId newId = new CompactionPartitionId(id.getStartKey(), id.getDate()); + compactionPartition = new CompactionPartition(newId); + compactionPartition.addFile(file); - filesToCompact.put(id, compactionPartition); + filesToCompact.put(newId, compactionPartition); } else { compactionPartition.addFile(file); }