Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C508D200BC2 for ; Thu, 17 Nov 2016 21:30:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C36CC160B0B; Thu, 17 Nov 2016 20:30:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 198F0160AD8 for ; Thu, 17 Nov 2016 21:30:11 +0100 (CET) Received: (qmail 8308 invoked by uid 500); 17 Nov 2016 20:30:11 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 8297 invoked by uid 99); 17 Nov 2016 20:30:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 20:30:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2E875E0C0A; Thu, 17 Nov 2016 20:30:11 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: esteban@apache.org To: commits@hbase.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 Date: Thu, 17 Nov 2016 20:30:11 +0000 (UTC) archived-at: Thu, 17 Nov 2016 20:30:13 -0000 Repository: hbase Updated Branches: refs/heads/branch-1.2 e7b310e68 -> bb891c683 HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/bb891c68 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/bb891c68 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/bb891c68 Branch: refs/heads/branch-1.2 Commit: bb891c6834a0691302b958d78e0c009b3601c442 Parents: e7b310e Author: Esteban Gutierrez Authored: Thu Nov 17 11:11:30 2016 -0800 Committer: Esteban Gutierrez Committed: Thu Nov 17 12:30:03 2016 -0800 ---------------------------------------------------------------------- .../hbase/regionserver/ConstantSizeRegionSplitPolicy.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/bb891c68/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java index 836cec5..d915f2e 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java @@ -39,7 +39,6 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience; @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG) public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy { private static final Random RANDOM = new Random(); - private static final double EPSILON = 1E-6; private long desiredMaxFileSize; private double jitterRate; @@ -60,7 +59,7 @@ public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy { this.jitterRate = (RANDOM.nextFloat() - 0.5D) * jitter; long jitterValue = (long) (this.desiredMaxFileSize * this.jitterRate); // make sure the long value won't overflow with jitter - if (this.jitterRate > EPSILON && jitterValue > (Long.MAX_VALUE - this.desiredMaxFileSize)) { + if (this.jitterRate > 0 && jitterValue > (Long.MAX_VALUE - this.desiredMaxFileSize)) { this.desiredMaxFileSize = Long.MAX_VALUE; } else { this.desiredMaxFileSize += jitterValue; @@ -94,6 +93,6 @@ public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy { @VisibleForTesting public boolean positiveJitterRate() { - return this.jitterRate > EPSILON; + return this.jitterRate > 0; } }