Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: larsh@apache.org
To: commits@hbase.apache.org
Date: Tue, 01 Nov 2016 19:27:53 -0000
Message-Id: <7d13964b258c4aefb798920e926f8605@git.apache.org>
In-Reply-To: <ba4fd1fa11d24351ace7858c0ea053e1@git.apache.org>
References: <ba4fd1fa11d24351ace7858c0ea053e1@git.apache.org>
Subject: [2/4] hbase git commit: New SteppingRegionSplitPolicy,
 avoid too aggressive spread of regions for small tables.
archived-at: Tue, 01 Nov 2016 19:27:54 -0000

New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e1eb914f
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e1eb914f
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e1eb914f

Branch: refs/heads/branch-1.3
Commit: e1eb914f21305ea0e2e8a784a187efd11d0d8ca0
Parents: c542c49
Author: Lars Hofhansl <larsh@apache.org>
Authored: Tue Nov 1 12:21:27 2016 -0700
Committer: Lars Hofhansl <larsh@apache.org>
Committed: Tue Nov 1 12:23:30 2016 -0700

----------------------------------------------------------------------
 ...IncreasingToUpperBoundRegionSplitPolicy.java |  4 +--
 .../hbase/regionserver/SteppingSplitPolicy.java | 32 ++++++++++++++++++++
 2 files changed, 34 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/e1eb914f/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
index 7144cb8..ff68110 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
@@ -45,7 +45,7 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience;
 public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionSplitPolicy {
 
   private static final Log LOG = LogFactory.getLog(IncreasingToUpperBoundRegionSplitPolicy.class);
-  private long initialSize;
+  protected long initialSize;
 
   @Override
   protected void configureForRegion(HRegion region) {
@@ -116,7 +116,7 @@ public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionS
   }
 
   /**
-   * @return Region max size or {@code count of regions cubed * flushsize},
+   * @return Region max size or {@code count of regions cubed * 2 * flushsize},
    * which ever is smaller; guard against there being zero regions on this server.
    */
   protected long getSizeToCheck(final int tableRegionsCount) {

http://git-wip-us.apache.org/repos/asf/hbase/blob/e1eb914f/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
new file mode 100644
index 0000000..4f3e0f2
--- /dev/null
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+public class SteppingSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy {
+  /**
+   * @return flushSize * 2 if there's exactly one region of the table in question
+   * found on this regionserver. Otherwise max file size.
+   * This allows a table to spread quickly across servers, while avoiding creating
+   * too many regions.
+   */
+  protected long getSizeToCheck(final int tableRegionsCount) {
+    return tableRegionsCount == 1  ? this.initialSize : getDesiredMaxFileSize();
+  }
+
+
+}