Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B65F0200BB3 for ; Wed, 2 Nov 2016 08:31:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B4D85160AFB; Wed, 2 Nov 2016 07:31:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06281160AEA for ; Wed, 2 Nov 2016 08:31:46 +0100 (CET) Received: (qmail 29894 invoked by uid 500); 2 Nov 2016 07:31:46 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 29885 invoked by uid 99); 2 Nov 2016 07:31:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 07:31:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DF5D6E0BB1; Wed, 2 Nov 2016 07:31:45 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: liyu@apache.org To: commits@hbase.apache.org Message-Id: <700d1fc30a6443f98ec63022bfcb010d@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-16970 Clarify misleading Scan.java comment about caching Date: Wed, 2 Nov 2016 07:31:45 +0000 (UTC) archived-at: Wed, 02 Nov 2016 07:31:47 -0000 Repository: hbase Updated Branches: refs/heads/branch-1.3 84481361b -> 968fd4db9 HBASE-16970 Clarify misleading Scan.java comment about caching Signed-off-by: Yu Li Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/968fd4db Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/968fd4db Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/968fd4db Branch: refs/heads/branch-1.3 Commit: 968fd4db996f84a25263b276ab71b1c139874f39 Parents: 8448136 Author: Jim Kleckner Authored: Tue Nov 1 17:31:23 2016 +0800 Committer: Yu Li Committed: Wed Nov 2 15:31:17 2016 +0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/hbase/client/Scan.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/968fd4db/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java ---------------------------------------------------------------------- diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java index 1d9b130..6fcfe05 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java @@ -135,8 +135,9 @@ public class Scan extends Query { @Deprecated public static final String HINT_LOOKAHEAD = "_look_ahead_"; - /* - * -1 means no caching + /** + * -1 means no caching specified and the value of {@link HConstants#HBASE_CLIENT_SCANNER_CACHING} + * (default to {@link HConstants#DEFAULT_HBASE_CLIENT_SCANNER_CACHING}) will be used */ private int caching = -1; private long maxResultSize = -1;