hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From e...@apache.org
Subject [1/2] hbase git commit: HBASE-17033 LogRoller makes a lot of allocations unnecessarily
Date Mon, 07 Nov 2016 22:32:03 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1 2fdba6521 -> b99690ac6
  refs/heads/master 2182ca34a -> 59d7b47e6


HBASE-17033 LogRoller makes a lot of allocations unnecessarily


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/59d7b47e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/59d7b47e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/59d7b47e

Branch: refs/heads/master
Commit: 59d7b47e60da12e0de8da35f07921582ccdccd80
Parents: 2182ca3
Author: Enis Soztutar <enis@apache.org>
Authored: Mon Nov 7 14:18:00 2016 -0800
Committer: Enis Soztutar <enis@apache.org>
Committed: Mon Nov 7 14:18:00 2016 -0800

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/59d7b47e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
index edf698e..94dcd4b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
@@ -288,6 +288,7 @@ public class FSHLog extends AbstractFSWAL<Writer> {
    * methods like rollWriter().
    * @return Writer instance
    */
+  @Override
   protected Writer createWriterInstance(final Path path) throws IOException {
     Writer writer = FSHLogProvider.createWriter(conf, fs, path, false);
     if (writer instanceof ProtobufLogWriter) {
@@ -598,6 +599,7 @@ public class FSHLog extends AbstractFSWAL<Writer> {
           && takeSyncFuture == null;
     }
 
+    @Override
     public void run() {
       long currentSequence;
       while (!isInterrupted()) {
@@ -771,6 +773,7 @@ public class FSHLog extends AbstractFSWAL<Writer> {
    * Therefore, if this function returns 0, it means you are not properly running with the
HDFS-826
    * patch.
    */
+  @Override
   @VisibleForTesting
   int getLogReplication() {
     try {
@@ -882,7 +885,7 @@ public class FSHLog extends AbstractFSWAL<Writer> {
     SyncFuture waitSafePoint(final SyncFuture syncFuture) throws InterruptedException,
         FailedSyncBeforeLogCloseException {
       while (true) {
-        if (this.safePointAttainedLatch.await(1, TimeUnit.NANOSECONDS)) {
+        if (this.safePointAttainedLatch.await(1, TimeUnit.MILLISECONDS)) {
           break;
         }
         if (syncFuture.isThrowable()) {


Mime
View raw message