hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From la...@apache.org
Subject [1/2] hbase git commit: Revert "New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables."
Date Tue, 01 Nov 2016 20:12:46 GMT
Repository: hbase
Updated Branches:
  refs/heads/master 791052c50 -> b7293bf5a


Revert "New SteppingRegionSplitPolicy, avoid too aggressive spread of regions for small tables."

This reverts commit 791052c50a902bda35aed30d6421fb09538119fd.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1c07d1d5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1c07d1d5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1c07d1d5

Branch: refs/heads/master
Commit: 1c07d1d59187910dd74cfd62137754cb477bc98a
Parents: 791052c
Author: Lars Hofhansl <larsh@apache.org>
Authored: Tue Nov 1 13:11:31 2016 -0700
Committer: Lars Hofhansl <larsh@apache.org>
Committed: Tue Nov 1 13:11:31 2016 -0700

----------------------------------------------------------------------
 ...IncreasingToUpperBoundRegionSplitPolicy.java |  4 +--
 .../hbase/regionserver/SteppingSplitPolicy.java | 32 --------------------
 2 files changed, 2 insertions(+), 34 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/1c07d1d5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
index ff68110..7144cb8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
@@ -45,7 +45,7 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience;
 public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionSplitPolicy
{
 
   private static final Log LOG = LogFactory.getLog(IncreasingToUpperBoundRegionSplitPolicy.class);
-  protected long initialSize;
+  private long initialSize;
 
   @Override
   protected void configureForRegion(HRegion region) {
@@ -116,7 +116,7 @@ public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionS
   }
 
   /**
-   * @return Region max size or {@code count of regions cubed * 2 * flushsize},
+   * @return Region max size or {@code count of regions cubed * flushsize},
    * which ever is smaller; guard against there being zero regions on this server.
    */
   protected long getSizeToCheck(final int tableRegionsCount) {

http://git-wip-us.apache.org/repos/asf/hbase/blob/1c07d1d5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
deleted file mode 100644
index 4f3e0f2..0000000
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
+++ /dev/null
@@ -1,32 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.hadoop.hbase.regionserver;
-
-public class SteppingSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy {
-  /**
-   * @return flushSize * 2 if there's exactly one region of the table in question
-   * found on this regionserver. Otherwise max file size.
-   * This allows a table to spread quickly across servers, while avoiding creating
-   * too many regions.
-   */
-  protected long getSizeToCheck(final int tableRegionsCount) {
-    return tableRegionsCount == 1  ? this.initialSize : getDesiredMaxFileSize();
-  }
-
-
-}


Mime
View raw message