hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject hbase git commit: HBASE-16023 Fastpath for the FIFO rpcscheduler Adds an executor that does balanced queue and fast path handing off requests directly to waiting handlers if any present. Idea taken from Apace Kudu (incubating). See https://gerrit.clouder
Date Sat, 18 Jun 2016 00:10:25 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1.3 75fb789a7 -> 0f8debc4c


HBASE-16023 Fastpath for the FIFO rpcscheduler Adds an executor that does balanced queue and
fast path handing off requests directly to waiting handlers if any present. Idea taken from
Apace Kudu (incubating). See https://gerrit.cloudera.org/#/c/2938/7/src/kudu/rpc/service_queue.h

M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
 Refactor which makes a Handler type. Put all 'handler' stuff inside this
 new type. Also make it so subclass can provide its own Handler type.

M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
 Name the handler threads for their type so can tell if configs are
 having an effect.

Signed-off-by: stack <stack@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0f8debc4
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0f8debc4
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0f8debc4

Branch: refs/heads/branch-1.3
Commit: 0f8debc4c4b4403c5fff61e1ae7338d80831d988
Parents: 75fb789
Author: stack <stack@apache.org>
Authored: Tue Jun 14 11:18:34 2016 -0700
Committer: stack <stack@apache.org>
Committed: Fri Jun 17 17:10:14 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/0f8debc4/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
index 7337b92..5e68dc8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
@@ -222,11 +222,11 @@ public class SimpleRpcScheduler extends RpcScheduler implements ConfigurationObs
       if (isDeadlineQueueType(callQueueType)) {
         CallPriorityComparator callPriority = new CallPriorityComparator(conf, this.priority);
         callExecutor =
-          new BalancedQueueRpcExecutor("DeadlineBQ.default", handlerCount, numCallQueues,
+          new BalancedQueueRpcExecutor("BQDeadline.default", handlerCount, numCallQueues,
             conf, abortable, BoundedPriorityBlockingQueue.class, maxQueueLength, callPriority);
       } else if (isCodelQueueType(callQueueType)) {
         callExecutor =
-          new BalancedQueueRpcExecutor("CodelBQ.default", handlerCount, numCallQueues,
+          new BalancedQueueRpcExecutor("BQCodel.default", handlerCount, numCallQueues,
             conf, abortable, AdaptiveLifoCoDelCallQueue.class, maxQueueLength,
             codelTargetDelay, codelInterval, codelLifoThreshold,
             numGeneralCallsDropped, numLifoModeSwitches);
@@ -240,7 +240,7 @@ public class SimpleRpcScheduler extends RpcScheduler implements ConfigurationObs
     // Create 2 queues to help priorityExecutor be more scalable.
     this.priorityExecutor = priorityHandlerCount > 0?
       new FifoWithFastPathBalancedQueueRpcExecutor("FifoWFPBQ.priority", priorityHandlerCount,
-         2, maxPriorityQueueLength, conf, abortable): null;
+        2, maxPriorityQueueLength, conf, abortable): null;
     this.replicationExecutor = replicationHandlerCount > 0?
       new FifoWithFastPathBalancedQueueRpcExecutor("FifoWFPBQ.replication",
         replicationHandlerCount, 1, maxQueueLength, conf, abortable) : null;


Mime
View raw message