hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anto...@apache.org
Subject hbase git commit: HBASE-15908 Checksum verification is broken due to incorrect passing of ByteBuffers in DataChecksum (Mikhail Antonov and Appy)
Date Sat, 28 May 2016 10:15:41 GMT
Repository: hbase
Updated Branches:
  refs/heads/master 36bd7d03f -> 60c8f76a9


HBASE-15908 Checksum verification is broken due to incorrect passing of ByteBuffers in DataChecksum
(Mikhail Antonov and Appy)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/60c8f76a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/60c8f76a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/60c8f76a

Branch: refs/heads/master
Commit: 60c8f76a9d888bc93be7f25eeeb5623143efa794
Parents: 36bd7d0
Author: Mikhail Antonov <antonov@apache.org>
Authored: Sat May 28 03:14:03 2016 -0700
Committer: Mikhail Antonov <antonov@apache.org>
Committed: Sat May 28 03:14:52 2016 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/60c8f76a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
index efc9a30..14a5cd1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
@@ -1712,7 +1712,7 @@ public class HFileBlock implements Cacheable {
       ByteBuffer onDiskBlockByteBuffer = ByteBuffer.wrap(onDiskBlock, 0, onDiskSizeWithHeader);
       // Verify checksum of the data before using it for building HFileBlock.
       if (verifyChecksum &&
-          !validateChecksum(offset, onDiskBlockByteBuffer.asReadOnlyBuffer(), hdrSize)) {
+          !validateChecksum(offset, onDiskBlockByteBuffer, hdrSize)) {
         return null;
       }
       // The onDiskBlock will become the headerAndDataBuffer for this block.


Mime
View raw message