hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From te...@apache.org
Subject hbase git commit: HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan (Sergey Soldatov)
Date Thu, 26 May 2016 00:29:39 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1 2346b5e21 -> a049b5f79


HBASE-15884 NPE in StoreFileScanner#skipKVsNewerThanReadpoint during reverse scan (Sergey
Soldatov)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a049b5f7
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a049b5f7
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a049b5f7

Branch: refs/heads/branch-1
Commit: a049b5f799daa50bd658c8f11fd18275666e3927
Parents: 2346b5e
Author: tedyu <yuzhihong@gmail.com>
Authored: Wed May 25 17:29:32 2016 -0700
Committer: tedyu <yuzhihong@gmail.com>
Committed: Wed May 25 17:29:32 2016 -0700

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/regionserver/StoreFileScanner.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/a049b5f7/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
index 0608756..02a4cae 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
@@ -257,9 +257,9 @@ public class StoreFileScanner implements KeyValueScanner {
     while(enforceMVCC
         && cur != null
         && (cur.getMvccVersion() > readPt)) {
-      hfs.next();
+      boolean hasNext = hfs.next();
       setCurrentCell(hfs.getKeyValue());
-      if (this.stopSkippingKVsIfNextRow
+      if (hasNext && this.stopSkippingKVsIfNextRow
           && getComparator().compareRows(cur.getRowArray(), cur.getRowOffset(),
               cur.getRowLength(), startKV.getRowArray(), startKV.getRowOffset(),
               startKV.getRowLength()) > 0) {


Mime
View raw message