Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F417B19848 for ; Fri, 29 Apr 2016 17:25:53 +0000 (UTC) Received: (qmail 79519 invoked by uid 500); 29 Apr 2016 17:25:53 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 79480 invoked by uid 500); 29 Apr 2016 17:25:53 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 79471 invoked by uid 99); 29 Apr 2016 17:25:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 17:25:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A76D2DFD9F; Fri, 29 Apr 2016 17:25:53 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: antonov@apache.org To: commits@hbase.apache.org Message-Id: <56707073b70240f28ce0c200935b3601@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-15551 Make call queue too big exception use servername Date: Fri, 29 Apr 2016 17:25:53 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/master cd148b7ce -> 730b07766 HBASE-15551 Make call queue too big exception use servername Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/730b0776 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/730b0776 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/730b0776 Branch: refs/heads/master Commit: 730b077666ba3dc91f894ea3899fe854e6168777 Parents: cd148b7 Author: Mikhail Antonov Authored: Fri Apr 29 10:25:14 2016 -0700 Committer: Mikhail Antonov Committed: Fri Apr 29 10:25:29 2016 -0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/730b0776/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java index f0aed2e..b9a9b26 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java @@ -1877,9 +1877,8 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver { responder, totalRequestSize, null, null); ByteArrayOutputStream responseBuffer = new ByteArrayOutputStream(); metrics.exception(CALL_QUEUE_TOO_BIG_EXCEPTION); - InetSocketAddress address = getListenerAddress(); setupResponse(responseBuffer, callTooBig, CALL_QUEUE_TOO_BIG_EXCEPTION, - "Call queue is full on " + (address != null ? address : "(channel closed)") + + "Call queue is full on " + server.getServerName() + ", is hbase.ipc.server.max.callqueue.size too small?"); responder.doRespond(callTooBig); return; @@ -1943,9 +1942,8 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver { ByteArrayOutputStream responseBuffer = new ByteArrayOutputStream(); metrics.exception(CALL_QUEUE_TOO_BIG_EXCEPTION); - InetSocketAddress address = getListenerAddress(); setupResponse(responseBuffer, call, CALL_QUEUE_TOO_BIG_EXCEPTION, - "Call queue is full on " + (address != null ? address : "(channel closed)") + + "Call queue is full on " + server.getServerName() + ", too many items queued ?"); responder.doRespond(call); }