hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhang...@apache.org
Subject hbase git commit: HBASE-15693 Reconsider the ImportOrder rule of checkstyle
Date Sun, 24 Apr 2016 08:08:12 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1.3 d5d931e5d -> 13629a859


HBASE-15693 Reconsider the ImportOrder rule of checkstyle


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/13629a85
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/13629a85
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/13629a85

Branch: refs/heads/branch-1.3
Commit: 13629a859dae481c61dfbd0d51a43e7dfaf3fb65
Parents: d5d931e
Author: zhangduo <zhangduo@apache.org>
Authored: Sun Apr 24 11:09:50 2016 +0800
Committer: zhangduo <zhangduo@apache.org>
Committed: Sun Apr 24 11:10:12 2016 +0800

----------------------------------------------------------------------
 .../src/main/resources/hbase/checkstyle.xml     | 82 ++++++++++++++++----
 1 file changed, 66 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/13629a85/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
index 34fe5ec..b423095 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
@@ -32,29 +32,79 @@
 <module name="Checker">
   <module name="FileTabCharacter"/>
   <module name="TreeWalker">
+
+    <!-- Annotations Checks
+    http://checkstyle.sourceforge.net/config_annotation.html -->
+    <module name="MissingDeprecated"/>
+
+    <!-- Block Checks
+    http://checkstyle.sourceforge.net/config_blocks.html -->
+    <module name="EmptyBlock"/>
+    <module name="LeftCurly"/>
+    <module name="NeedBraces"/>
+
+    <!-- Class Design Checks
+    http://checkstyle.sourceforge.net/config_design.html -->
+    <module name="FinalClass"/>
+    <module name="HideUtilityClassConstructor"/>
+    <module name="InterfaceIsType"/>
+    <module name="VisibilityModifier">
+      <property name="packageAllowed" value="true"/>
+      <property name="protectedAllowed" value="true"/>
+    </module>
+
+    <!-- Coding Checks
+    http://checkstyle.sourceforge.net/config_coding.html -->
+    <module name="ArrayTypeStyle"/>
+    <module name="EmptyStatement"/>
+    <module name="EqualsHashCode"/>
+    <module name="IllegalInstantiation"/>
+    <module name="InnerAssignment"/>
+    <module name="MissingSwitchDefault"/>
+    <module name="NoFinalizer"/>
+
+    <!-- Import Checks
+    http://checkstyle.sourceforge.net/config_imports.html -->
     <module name="AvoidStarImport"/>
+    <module name="ImportOrder">
+      <property name="option" value="top" />
+      <property name="ordered" value="true"/>
+      <property name="sortStaticImportsAlphabetically" value="true"/>
+    </module>
     <module name="RedundantImport"/>
-    <module name="UnusedImports"/>
+    <module name="UnusedImports">
+      <property name="processJavadoc" value="true"/>
+    </module>
+
+    <!-- Javadoc Checks
+    http://checkstyle.sourceforge.net/config_javadoc.html -->
+    <module name="JavadocTagContinuationIndentation">
+      <property name="offset" value="2"/>
+    </module>
+    <module name="NonEmptyAtclauseDescription"/>
+
+    <!-- Miscellaneous Checks
+    http://checkstyle.sourceforge.net/config_misc.html -->
+    <module name="UpperEll"/>
+    <module name="Indentation">
+      <property name="basicOffset" value="2"/>
+      <property name="caseIndent" value="2"/>
+      <property name="throwsIndent" value="2"/>
+      <property name="arrayInitIndent" value="2"/>
+      <property name="lineWrappingIndentation" value="2"/>
+    </module>
+
+    <!-- Size Violation Checks
+    http://checkstyle.sourceforge.net/config_sizes.html -->
     <module name="LineLength">
       <property name="max" value="100"/>
-      <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+      <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|org.apache.thrift.|com.google.protobuf.|hbase.protobuf.generated"/>
     </module>
     <module name="MethodLength"/>
+
+    <!-- Whitespace Checks
+    http://checkstyle.sourceforge.net/config_whitespace.html -->
     <module name="MethodParamPad"/>
     <module name="ParenPad"/>
-    <module name="EmptyStatement"/>
-    <module name="EmptyBlock"/>
-    <module name="EqualsHashCode"/>
-    <module name="IllegalInstantiation"/>
-    <module name="InnerAssignment"/>
-    <module name="MissingSwitchDefault"/>
-    <module name="FinalClass"/>
-    <module name="HideUtilityClassConstructor"/>
-    <module name="InterfaceIsType"/>
-    <module name="VisibilityModifier"/>
-    <module name="ArrayTypeStyle"/>
-    <module name="UpperEll"/>
-    <module name="NoFinalizer"/>
-    <module name="MissingDeprecated"/>
   </module>
 </module>


Mime
View raw message