Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 084D318BFA for ; Tue, 2 Feb 2016 17:49:06 +0000 (UTC) Received: (qmail 63504 invoked by uid 500); 2 Feb 2016 17:42:26 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 63464 invoked by uid 500); 2 Feb 2016 17:42:26 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 63455 invoked by uid 99); 2 Feb 2016 17:42:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 17:42:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4C80ADFFF4; Tue, 2 Feb 2016 17:42:26 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tedyu@apache.org To: commits@hbase.apache.org Message-Id: <50ffc3a368064c58b85e2f35626ab0dd@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-15192 TestRegionMergeTransactionOnCluster#testCleanMergeReference is flaky Date: Tue, 2 Feb 2016 17:42:26 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/master fc5e698c0 -> 243e6cc52 HBASE-15192 TestRegionMergeTransactionOnCluster#testCleanMergeReference is flaky Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/243e6cc5 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/243e6cc5 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/243e6cc5 Branch: refs/heads/master Commit: 243e6cc5293dc1e2a4dfd3af4ee29087c84184c8 Parents: fc5e698 Author: tedyu Authored: Tue Feb 2 09:42:15 2016 -0800 Committer: tedyu Committed: Tue Feb 2 09:42:15 2016 -0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/master/CatalogJanitor.java | 1 + .../TestRegionMergeTransactionOnCluster.java | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/243e6cc5/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java index ef2a005..d02e5ae 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java @@ -214,6 +214,7 @@ public class CatalogJanitor extends ScheduledChore { int scan() throws IOException { try { if (!alreadyRunning.compareAndSet(false, true)) { + LOG.debug("CatalogJanitor already running"); return 0; } Triple, Map> scanTriple = http://git-wip-us.apache.org/repos/asf/hbase/blob/243e6cc5/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java index 44b24ce..e3f6cc2 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java @@ -268,8 +268,8 @@ public class TestRegionMergeTransactionOnCluster { cleaner.chore(); Thread.sleep(1000); } - int newcount1 = 0; while (System.currentTimeMillis() < timeout) { + int newcount1 = 0; for(HColumnDescriptor colFamily : columnFamilies) { newcount1 += hrfs.getStoreFiles(colFamily.getName()).size(); } @@ -280,10 +280,15 @@ public class TestRegionMergeTransactionOnCluster { } // run CatalogJanitor to clean merge references in hbase:meta and archive the // files of merging regions - int cleaned = admin.runCatalogScan(); + int cleaned = 0; + while (cleaned == 0) { + cleaned = admin.runCatalogScan(); + LOG.debug("catalog janitor returned " + cleaned); + Thread.sleep(50); + } + assertFalse(regionAdir.toString(), fs.exists(regionAdir)); + assertFalse(regionBdir.toString(), fs.exists(regionBdir)); assertTrue(cleaned > 0); - assertFalse(fs.exists(regionAdir)); - assertFalse(fs.exists(regionBdir)); mergedRegionResult = MetaTableAccessor.getRegionResult( master.getConnection(), mergedRegionInfo.getRegionName());