hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mi...@apache.org
Subject [17/51] [partial] hbase-site git commit: Published site at 18eff3c1c337003b2a419490e621f931d16936fb.
Date Fri, 05 Feb 2016 04:32:27 GMT
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/a8725a46/devapidocs/src-html/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.html
index 8fc3dbd..efdc708 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.html
@@ -824,743 +824,747 @@
 <span class="sourceLineNo">816</span>          i++;<a name="line.816"></a>
 <span class="sourceLineNo">817</span>          lowestLocalityServerIndex = serverIndicesSortedByLocality[i];<a name="line.817"></a>
 <span class="sourceLineNo">818</span>        }<a name="line.818"></a>
-<span class="sourceLineNo">819</span>        LOG.debug("Lowest locality region server with non zero regions is "<a name="line.819"></a>
-<span class="sourceLineNo">820</span>            + servers[lowestLocalityServerIndex].getHostname() + " with locality "<a name="line.820"></a>
-<span class="sourceLineNo">821</span>            + localityPerServer[lowestLocalityServerIndex]);<a name="line.821"></a>
-<span class="sourceLineNo">822</span>        return lowestLocalityServerIndex;<a name="line.822"></a>
-<span class="sourceLineNo">823</span>      }<a name="line.823"></a>
-<span class="sourceLineNo">824</span>    }<a name="line.824"></a>
-<span class="sourceLineNo">825</span><a name="line.825"></a>
-<span class="sourceLineNo">826</span>    int getLowestLocalityRegionOnServer(int serverIndex) {<a name="line.826"></a>
-<span class="sourceLineNo">827</span>      if (regionFinder != null) {<a name="line.827"></a>
-<span class="sourceLineNo">828</span>        float lowestLocality = 1.0f;<a name="line.828"></a>
-<span class="sourceLineNo">829</span>        int lowestLocalityRegionIndex = 0;<a name="line.829"></a>
-<span class="sourceLineNo">830</span>        if (regionsPerServer[serverIndex].length == 0) {<a name="line.830"></a>
-<span class="sourceLineNo">831</span>          // No regions on that region server<a name="line.831"></a>
-<span class="sourceLineNo">832</span>          return -1;<a name="line.832"></a>
-<span class="sourceLineNo">833</span>        }<a name="line.833"></a>
-<span class="sourceLineNo">834</span>        for (int j = 0; j &lt; regionsPerServer[serverIndex].length; j++) {<a name="line.834"></a>
-<span class="sourceLineNo">835</span>          int regionIndex = regionsPerServer[serverIndex][j];<a name="line.835"></a>
-<span class="sourceLineNo">836</span>          HDFSBlocksDistribution distribution = regionFinder<a name="line.836"></a>
-<span class="sourceLineNo">837</span>              .getBlockDistribution(regions[regionIndex]);<a name="line.837"></a>
-<span class="sourceLineNo">838</span>          float locality = distribution.getBlockLocalityIndex(servers[serverIndex].getHostname());<a name="line.838"></a>
-<span class="sourceLineNo">839</span>          if (locality &lt; lowestLocality) {<a name="line.839"></a>
-<span class="sourceLineNo">840</span>            lowestLocality = locality;<a name="line.840"></a>
-<span class="sourceLineNo">841</span>            lowestLocalityRegionIndex = j;<a name="line.841"></a>
-<span class="sourceLineNo">842</span>          }<a name="line.842"></a>
-<span class="sourceLineNo">843</span>        }<a name="line.843"></a>
-<span class="sourceLineNo">844</span>        LOG.debug(" Lowest locality region index is " + lowestLocalityRegionIndex<a name="line.844"></a>
-<span class="sourceLineNo">845</span>            + " and its region server contains " + regionsPerServer[serverIndex].length<a name="line.845"></a>
-<span class="sourceLineNo">846</span>            + " regions");<a name="line.846"></a>
-<span class="sourceLineNo">847</span>        return regionsPerServer[serverIndex][lowestLocalityRegionIndex];<a name="line.847"></a>
-<span class="sourceLineNo">848</span>      } else {<a name="line.848"></a>
-<span class="sourceLineNo">849</span>        return -1;<a name="line.849"></a>
-<span class="sourceLineNo">850</span>      }<a name="line.850"></a>
-<span class="sourceLineNo">851</span>    }<a name="line.851"></a>
-<span class="sourceLineNo">852</span><a name="line.852"></a>
-<span class="sourceLineNo">853</span>    float getLocalityOfRegion(int region, int server) {<a name="line.853"></a>
-<span class="sourceLineNo">854</span>      if (regionFinder != null) {<a name="line.854"></a>
-<span class="sourceLineNo">855</span>        HDFSBlocksDistribution distribution = regionFinder.getBlockDistribution(regions[region]);<a name="line.855"></a>
-<span class="sourceLineNo">856</span>        return distribution.getBlockLocalityIndex(servers[server].getHostname());<a name="line.856"></a>
-<span class="sourceLineNo">857</span>      } else {<a name="line.857"></a>
-<span class="sourceLineNo">858</span>        return 0f;<a name="line.858"></a>
-<span class="sourceLineNo">859</span>      }<a name="line.859"></a>
-<span class="sourceLineNo">860</span>    }<a name="line.860"></a>
-<span class="sourceLineNo">861</span><a name="line.861"></a>
-<span class="sourceLineNo">862</span>    int getLeastLoadedTopServerForRegion(int region) {<a name="line.862"></a>
-<span class="sourceLineNo">863</span>      if (regionFinder != null) {<a name="line.863"></a>
-<span class="sourceLineNo">864</span>        List&lt;ServerName&gt; topLocalServers = regionFinder.getTopBlockLocations(regions[region]);<a name="line.864"></a>
-<span class="sourceLineNo">865</span>        int leastLoadedServerIndex = -1;<a name="line.865"></a>
-<span class="sourceLineNo">866</span>        int load = Integer.MAX_VALUE;<a name="line.866"></a>
-<span class="sourceLineNo">867</span>        for (ServerName sn : topLocalServers) {<a name="line.867"></a>
-<span class="sourceLineNo">868</span>          if (!serversToIndex.containsKey(sn.getHostAndPort())) {<a name="line.868"></a>
-<span class="sourceLineNo">869</span>            continue;<a name="line.869"></a>
-<span class="sourceLineNo">870</span>          }<a name="line.870"></a>
-<span class="sourceLineNo">871</span>          int index = serversToIndex.get(sn.getHostAndPort());<a name="line.871"></a>
-<span class="sourceLineNo">872</span>          if (regionsPerServer[index] == null) {<a name="line.872"></a>
+<span class="sourceLineNo">819</span>        if (LOG.isTraceEnabled()) {<a name="line.819"></a>
+<span class="sourceLineNo">820</span>          LOG.trace("Lowest locality region server with non zero regions is "<a name="line.820"></a>
+<span class="sourceLineNo">821</span>            + servers[lowestLocalityServerIndex].getHostname() + " with locality "<a name="line.821"></a>
+<span class="sourceLineNo">822</span>            + localityPerServer[lowestLocalityServerIndex]);<a name="line.822"></a>
+<span class="sourceLineNo">823</span>        }<a name="line.823"></a>
+<span class="sourceLineNo">824</span>        return lowestLocalityServerIndex;<a name="line.824"></a>
+<span class="sourceLineNo">825</span>      }<a name="line.825"></a>
+<span class="sourceLineNo">826</span>    }<a name="line.826"></a>
+<span class="sourceLineNo">827</span><a name="line.827"></a>
+<span class="sourceLineNo">828</span>    int getLowestLocalityRegionOnServer(int serverIndex) {<a name="line.828"></a>
+<span class="sourceLineNo">829</span>      if (regionFinder != null) {<a name="line.829"></a>
+<span class="sourceLineNo">830</span>        float lowestLocality = 1.0f;<a name="line.830"></a>
+<span class="sourceLineNo">831</span>        int lowestLocalityRegionIndex = 0;<a name="line.831"></a>
+<span class="sourceLineNo">832</span>        if (regionsPerServer[serverIndex].length == 0) {<a name="line.832"></a>
+<span class="sourceLineNo">833</span>          // No regions on that region server<a name="line.833"></a>
+<span class="sourceLineNo">834</span>          return -1;<a name="line.834"></a>
+<span class="sourceLineNo">835</span>        }<a name="line.835"></a>
+<span class="sourceLineNo">836</span>        for (int j = 0; j &lt; regionsPerServer[serverIndex].length; j++) {<a name="line.836"></a>
+<span class="sourceLineNo">837</span>          int regionIndex = regionsPerServer[serverIndex][j];<a name="line.837"></a>
+<span class="sourceLineNo">838</span>          HDFSBlocksDistribution distribution = regionFinder<a name="line.838"></a>
+<span class="sourceLineNo">839</span>              .getBlockDistribution(regions[regionIndex]);<a name="line.839"></a>
+<span class="sourceLineNo">840</span>          float locality = distribution.getBlockLocalityIndex(servers[serverIndex].getHostname());<a name="line.840"></a>
+<span class="sourceLineNo">841</span>          if (locality &lt; lowestLocality) {<a name="line.841"></a>
+<span class="sourceLineNo">842</span>            lowestLocality = locality;<a name="line.842"></a>
+<span class="sourceLineNo">843</span>            lowestLocalityRegionIndex = j;<a name="line.843"></a>
+<span class="sourceLineNo">844</span>          }<a name="line.844"></a>
+<span class="sourceLineNo">845</span>        }<a name="line.845"></a>
+<span class="sourceLineNo">846</span>        if (LOG.isTraceEnabled()) {<a name="line.846"></a>
+<span class="sourceLineNo">847</span>          LOG.debug(" Lowest locality region index is " + lowestLocalityRegionIndex<a name="line.847"></a>
+<span class="sourceLineNo">848</span>            + " and its region server contains " + regionsPerServer[serverIndex].length<a name="line.848"></a>
+<span class="sourceLineNo">849</span>            + " regions");<a name="line.849"></a>
+<span class="sourceLineNo">850</span>        }<a name="line.850"></a>
+<span class="sourceLineNo">851</span>        return regionsPerServer[serverIndex][lowestLocalityRegionIndex];<a name="line.851"></a>
+<span class="sourceLineNo">852</span>      } else {<a name="line.852"></a>
+<span class="sourceLineNo">853</span>        return -1;<a name="line.853"></a>
+<span class="sourceLineNo">854</span>      }<a name="line.854"></a>
+<span class="sourceLineNo">855</span>    }<a name="line.855"></a>
+<span class="sourceLineNo">856</span><a name="line.856"></a>
+<span class="sourceLineNo">857</span>    float getLocalityOfRegion(int region, int server) {<a name="line.857"></a>
+<span class="sourceLineNo">858</span>      if (regionFinder != null) {<a name="line.858"></a>
+<span class="sourceLineNo">859</span>        HDFSBlocksDistribution distribution = regionFinder.getBlockDistribution(regions[region]);<a name="line.859"></a>
+<span class="sourceLineNo">860</span>        return distribution.getBlockLocalityIndex(servers[server].getHostname());<a name="line.860"></a>
+<span class="sourceLineNo">861</span>      } else {<a name="line.861"></a>
+<span class="sourceLineNo">862</span>        return 0f;<a name="line.862"></a>
+<span class="sourceLineNo">863</span>      }<a name="line.863"></a>
+<span class="sourceLineNo">864</span>    }<a name="line.864"></a>
+<span class="sourceLineNo">865</span><a name="line.865"></a>
+<span class="sourceLineNo">866</span>    int getLeastLoadedTopServerForRegion(int region) {<a name="line.866"></a>
+<span class="sourceLineNo">867</span>      if (regionFinder != null) {<a name="line.867"></a>
+<span class="sourceLineNo">868</span>        List&lt;ServerName&gt; topLocalServers = regionFinder.getTopBlockLocations(regions[region]);<a name="line.868"></a>
+<span class="sourceLineNo">869</span>        int leastLoadedServerIndex = -1;<a name="line.869"></a>
+<span class="sourceLineNo">870</span>        int load = Integer.MAX_VALUE;<a name="line.870"></a>
+<span class="sourceLineNo">871</span>        for (ServerName sn : topLocalServers) {<a name="line.871"></a>
+<span class="sourceLineNo">872</span>          if (!serversToIndex.containsKey(sn.getHostAndPort())) {<a name="line.872"></a>
 <span class="sourceLineNo">873</span>            continue;<a name="line.873"></a>
 <span class="sourceLineNo">874</span>          }<a name="line.874"></a>
-<span class="sourceLineNo">875</span>          int tempLoad = regionsPerServer[index].length;<a name="line.875"></a>
-<span class="sourceLineNo">876</span>          if (tempLoad &lt;= load) {<a name="line.876"></a>
-<span class="sourceLineNo">877</span>            leastLoadedServerIndex = index;<a name="line.877"></a>
-<span class="sourceLineNo">878</span>            load = tempLoad;<a name="line.878"></a>
-<span class="sourceLineNo">879</span>          }<a name="line.879"></a>
-<span class="sourceLineNo">880</span>        }<a name="line.880"></a>
-<span class="sourceLineNo">881</span>        return leastLoadedServerIndex;<a name="line.881"></a>
-<span class="sourceLineNo">882</span>      } else {<a name="line.882"></a>
-<span class="sourceLineNo">883</span>        return -1;<a name="line.883"></a>
-<span class="sourceLineNo">884</span>      }<a name="line.884"></a>
-<span class="sourceLineNo">885</span>    }<a name="line.885"></a>
-<span class="sourceLineNo">886</span><a name="line.886"></a>
-<span class="sourceLineNo">887</span>    void calculateRegionServerLocalities() {<a name="line.887"></a>
-<span class="sourceLineNo">888</span>      if (regionFinder == null) {<a name="line.888"></a>
-<span class="sourceLineNo">889</span>        LOG.warn("Region location finder found null, skipping locality calculations.");<a name="line.889"></a>
-<span class="sourceLineNo">890</span>        return;<a name="line.890"></a>
-<span class="sourceLineNo">891</span>      }<a name="line.891"></a>
-<span class="sourceLineNo">892</span>      for (int i = 0; i &lt; regionsPerServer.length; i++) {<a name="line.892"></a>
-<span class="sourceLineNo">893</span>        HDFSBlocksDistribution distribution = new HDFSBlocksDistribution();<a name="line.893"></a>
-<span class="sourceLineNo">894</span>        if (regionsPerServer[i].length &gt; 0) {<a name="line.894"></a>
-<span class="sourceLineNo">895</span>          for (int j = 0; j &lt; regionsPerServer[i].length; j++) {<a name="line.895"></a>
-<span class="sourceLineNo">896</span>            int regionIndex = regionsPerServer[i][j];<a name="line.896"></a>
-<span class="sourceLineNo">897</span>            distribution.add(regionFinder.getBlockDistribution(regions[regionIndex]));<a name="line.897"></a>
-<span class="sourceLineNo">898</span>          }<a name="line.898"></a>
-<span class="sourceLineNo">899</span>        } else {<a name="line.899"></a>
-<span class="sourceLineNo">900</span>          LOG.debug("Server " + servers[i].getHostname() + " had 0 regions.");<a name="line.900"></a>
-<span class="sourceLineNo">901</span>        }<a name="line.901"></a>
-<span class="sourceLineNo">902</span>        localityPerServer[i] = distribution.getBlockLocalityIndex(servers[i].getHostname());<a name="line.902"></a>
-<span class="sourceLineNo">903</span>      }<a name="line.903"></a>
-<span class="sourceLineNo">904</span>    }<a name="line.904"></a>
-<span class="sourceLineNo">905</span><a name="line.905"></a>
-<span class="sourceLineNo">906</span>    @VisibleForTesting<a name="line.906"></a>
-<span class="sourceLineNo">907</span>    protected void setNumRegions(int numRegions) {<a name="line.907"></a>
-<span class="sourceLineNo">908</span>      this.numRegions = numRegions;<a name="line.908"></a>
-<span class="sourceLineNo">909</span>    }<a name="line.909"></a>
-<span class="sourceLineNo">910</span><a name="line.910"></a>
-<span class="sourceLineNo">911</span>    @VisibleForTesting<a name="line.911"></a>
-<span class="sourceLineNo">912</span>    protected void setNumMovedRegions(int numMovedRegions) {<a name="line.912"></a>
-<span class="sourceLineNo">913</span>      this.numMovedRegions = numMovedRegions;<a name="line.913"></a>
-<span class="sourceLineNo">914</span>    }<a name="line.914"></a>
-<span class="sourceLineNo">915</span><a name="line.915"></a>
-<span class="sourceLineNo">916</span>    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="SBSC_USE_STRINGBUFFER_CONCATENATION",<a name="line.916"></a>
-<span class="sourceLineNo">917</span>        justification="Not important but should be fixed")<a name="line.917"></a>
-<span class="sourceLineNo">918</span>    @Override<a name="line.918"></a>
-<span class="sourceLineNo">919</span>    public String toString() {<a name="line.919"></a>
-<span class="sourceLineNo">920</span>      String desc = "Cluster{" +<a name="line.920"></a>
-<span class="sourceLineNo">921</span>          "servers=[";<a name="line.921"></a>
-<span class="sourceLineNo">922</span>          for(ServerName sn:servers) {<a name="line.922"></a>
-<span class="sourceLineNo">923</span>             desc += sn.getHostAndPort() + ", ";<a name="line.923"></a>
-<span class="sourceLineNo">924</span>          }<a name="line.924"></a>
-<span class="sourceLineNo">925</span>          desc +=<a name="line.925"></a>
-<span class="sourceLineNo">926</span>          ", serverIndicesSortedByRegionCount="+<a name="line.926"></a>
-<span class="sourceLineNo">927</span>          Arrays.toString(serverIndicesSortedByRegionCount) +<a name="line.927"></a>
-<span class="sourceLineNo">928</span>          ", regionsPerServer=[";<a name="line.928"></a>
-<span class="sourceLineNo">929</span><a name="line.929"></a>
-<span class="sourceLineNo">930</span>          for (int[]r:regionsPerServer) {<a name="line.930"></a>
-<span class="sourceLineNo">931</span>            desc += Arrays.toString(r);<a name="line.931"></a>
-<span class="sourceLineNo">932</span>          }<a name="line.932"></a>
-<span class="sourceLineNo">933</span>          desc += "]" +<a name="line.933"></a>
-<span class="sourceLineNo">934</span>          ", numMaxRegionsPerTable=" +<a name="line.934"></a>
-<span class="sourceLineNo">935</span>          Arrays.toString(numMaxRegionsPerTable) +<a name="line.935"></a>
-<span class="sourceLineNo">936</span>          ", numRegions=" +<a name="line.936"></a>
-<span class="sourceLineNo">937</span>          numRegions +<a name="line.937"></a>
-<span class="sourceLineNo">938</span>          ", numServers=" +<a name="line.938"></a>
-<span class="sourceLineNo">939</span>          numServers +<a name="line.939"></a>
-<span class="sourceLineNo">940</span>          ", numTables=" +<a name="line.940"></a>
-<span class="sourceLineNo">941</span>          numTables +<a name="line.941"></a>
-<span class="sourceLineNo">942</span>          ", numMovedRegions=" +<a name="line.942"></a>
-<span class="sourceLineNo">943</span>          numMovedRegions +<a name="line.943"></a>
-<span class="sourceLineNo">944</span>          '}';<a name="line.944"></a>
-<span class="sourceLineNo">945</span>      return desc;<a name="line.945"></a>
-<span class="sourceLineNo">946</span>    }<a name="line.946"></a>
-<span class="sourceLineNo">947</span>  }<a name="line.947"></a>
-<span class="sourceLineNo">948</span><a name="line.948"></a>
-<span class="sourceLineNo">949</span>  // slop for regions<a name="line.949"></a>
-<span class="sourceLineNo">950</span>  protected float slop;<a name="line.950"></a>
-<span class="sourceLineNo">951</span>  protected Configuration config;<a name="line.951"></a>
-<span class="sourceLineNo">952</span>  protected RackManager rackManager;<a name="line.952"></a>
-<span class="sourceLineNo">953</span>  private static final Random RANDOM = new Random(System.currentTimeMillis());<a name="line.953"></a>
-<span class="sourceLineNo">954</span>  private static final Log LOG = LogFactory.getLog(BaseLoadBalancer.class);<a name="line.954"></a>
-<span class="sourceLineNo">955</span><a name="line.955"></a>
-<span class="sourceLineNo">956</span>  // Regions of these tables are put on the master by default.<a name="line.956"></a>
-<span class="sourceLineNo">957</span>  private static final String[] DEFAULT_TABLES_ON_MASTER =<a name="line.957"></a>
-<span class="sourceLineNo">958</span>    new String[] {AccessControlLists.ACL_TABLE_NAME.getNameAsString(),<a name="line.958"></a>
-<span class="sourceLineNo">959</span>      TableName.NAMESPACE_TABLE_NAME.getNameAsString(),<a name="line.959"></a>
-<span class="sourceLineNo">960</span>      TableName.META_TABLE_NAME.getNameAsString()};<a name="line.960"></a>
-<span class="sourceLineNo">961</span><a name="line.961"></a>
-<span class="sourceLineNo">962</span>  public static final String TABLES_ON_MASTER =<a name="line.962"></a>
-<span class="sourceLineNo">963</span>    "hbase.balancer.tablesOnMaster";<a name="line.963"></a>
-<span class="sourceLineNo">964</span><a name="line.964"></a>
-<span class="sourceLineNo">965</span>  protected final Set&lt;String&gt; tablesOnMaster = new HashSet&lt;String&gt;();<a name="line.965"></a>
-<span class="sourceLineNo">966</span>  protected MetricsBalancer metricsBalancer = null;<a name="line.966"></a>
-<span class="sourceLineNo">967</span>  protected ClusterStatus clusterStatus = null;<a name="line.967"></a>
-<span class="sourceLineNo">968</span>  protected ServerName masterServerName;<a name="line.968"></a>
-<span class="sourceLineNo">969</span>  protected MasterServices services;<a name="line.969"></a>
-<span class="sourceLineNo">970</span><a name="line.970"></a>
-<span class="sourceLineNo">971</span>  /**<a name="line.971"></a>
-<span class="sourceLineNo">972</span>   * By default, regions of some small system tables such as meta,<a name="line.972"></a>
-<span class="sourceLineNo">973</span>   * namespace, and acl are assigned to the active master. If you don't<a name="line.973"></a>
-<span class="sourceLineNo">974</span>   * want to assign any region to the active master, you need to<a name="line.974"></a>
-<span class="sourceLineNo">975</span>   * configure "hbase.balancer.tablesOnMaster" to "none".<a name="line.975"></a>
-<span class="sourceLineNo">976</span>   */<a name="line.976"></a>
-<span class="sourceLineNo">977</span>  protected static String[] getTablesOnMaster(Configuration conf) {<a name="line.977"></a>
-<span class="sourceLineNo">978</span>    String valueString = conf.get(TABLES_ON_MASTER);<a name="line.978"></a>
-<span class="sourceLineNo">979</span>    if (valueString == null) {<a name="line.979"></a>
-<span class="sourceLineNo">980</span>      return DEFAULT_TABLES_ON_MASTER;<a name="line.980"></a>
-<span class="sourceLineNo">981</span>    }<a name="line.981"></a>
-<span class="sourceLineNo">982</span>    valueString = valueString.trim();<a name="line.982"></a>
-<span class="sourceLineNo">983</span>    if (valueString.equalsIgnoreCase("none")) {<a name="line.983"></a>
-<span class="sourceLineNo">984</span>      return null;<a name="line.984"></a>
+<span class="sourceLineNo">875</span>          int index = serversToIndex.get(sn.getHostAndPort());<a name="line.875"></a>
+<span class="sourceLineNo">876</span>          if (regionsPerServer[index] == null) {<a name="line.876"></a>
+<span class="sourceLineNo">877</span>            continue;<a name="line.877"></a>
+<span class="sourceLineNo">878</span>          }<a name="line.878"></a>
+<span class="sourceLineNo">879</span>          int tempLoad = regionsPerServer[index].length;<a name="line.879"></a>
+<span class="sourceLineNo">880</span>          if (tempLoad &lt;= load) {<a name="line.880"></a>
+<span class="sourceLineNo">881</span>            leastLoadedServerIndex = index;<a name="line.881"></a>
+<span class="sourceLineNo">882</span>            load = tempLoad;<a name="line.882"></a>
+<span class="sourceLineNo">883</span>          }<a name="line.883"></a>
+<span class="sourceLineNo">884</span>        }<a name="line.884"></a>
+<span class="sourceLineNo">885</span>        return leastLoadedServerIndex;<a name="line.885"></a>
+<span class="sourceLineNo">886</span>      } else {<a name="line.886"></a>
+<span class="sourceLineNo">887</span>        return -1;<a name="line.887"></a>
+<span class="sourceLineNo">888</span>      }<a name="line.888"></a>
+<span class="sourceLineNo">889</span>    }<a name="line.889"></a>
+<span class="sourceLineNo">890</span><a name="line.890"></a>
+<span class="sourceLineNo">891</span>    void calculateRegionServerLocalities() {<a name="line.891"></a>
+<span class="sourceLineNo">892</span>      if (regionFinder == null) {<a name="line.892"></a>
+<span class="sourceLineNo">893</span>        LOG.warn("Region location finder found null, skipping locality calculations.");<a name="line.893"></a>
+<span class="sourceLineNo">894</span>        return;<a name="line.894"></a>
+<span class="sourceLineNo">895</span>      }<a name="line.895"></a>
+<span class="sourceLineNo">896</span>      for (int i = 0; i &lt; regionsPerServer.length; i++) {<a name="line.896"></a>
+<span class="sourceLineNo">897</span>        HDFSBlocksDistribution distribution = new HDFSBlocksDistribution();<a name="line.897"></a>
+<span class="sourceLineNo">898</span>        if (regionsPerServer[i].length &gt; 0) {<a name="line.898"></a>
+<span class="sourceLineNo">899</span>          for (int j = 0; j &lt; regionsPerServer[i].length; j++) {<a name="line.899"></a>
+<span class="sourceLineNo">900</span>            int regionIndex = regionsPerServer[i][j];<a name="line.900"></a>
+<span class="sourceLineNo">901</span>            distribution.add(regionFinder.getBlockDistribution(regions[regionIndex]));<a name="line.901"></a>
+<span class="sourceLineNo">902</span>          }<a name="line.902"></a>
+<span class="sourceLineNo">903</span>        } else {<a name="line.903"></a>
+<span class="sourceLineNo">904</span>          LOG.debug("Server " + servers[i].getHostname() + " had 0 regions.");<a name="line.904"></a>
+<span class="sourceLineNo">905</span>        }<a name="line.905"></a>
+<span class="sourceLineNo">906</span>        localityPerServer[i] = distribution.getBlockLocalityIndex(servers[i].getHostname());<a name="line.906"></a>
+<span class="sourceLineNo">907</span>      }<a name="line.907"></a>
+<span class="sourceLineNo">908</span>    }<a name="line.908"></a>
+<span class="sourceLineNo">909</span><a name="line.909"></a>
+<span class="sourceLineNo">910</span>    @VisibleForTesting<a name="line.910"></a>
+<span class="sourceLineNo">911</span>    protected void setNumRegions(int numRegions) {<a name="line.911"></a>
+<span class="sourceLineNo">912</span>      this.numRegions = numRegions;<a name="line.912"></a>
+<span class="sourceLineNo">913</span>    }<a name="line.913"></a>
+<span class="sourceLineNo">914</span><a name="line.914"></a>
+<span class="sourceLineNo">915</span>    @VisibleForTesting<a name="line.915"></a>
+<span class="sourceLineNo">916</span>    protected void setNumMovedRegions(int numMovedRegions) {<a name="line.916"></a>
+<span class="sourceLineNo">917</span>      this.numMovedRegions = numMovedRegions;<a name="line.917"></a>
+<span class="sourceLineNo">918</span>    }<a name="line.918"></a>
+<span class="sourceLineNo">919</span><a name="line.919"></a>
+<span class="sourceLineNo">920</span>    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="SBSC_USE_STRINGBUFFER_CONCATENATION",<a name="line.920"></a>
+<span class="sourceLineNo">921</span>        justification="Not important but should be fixed")<a name="line.921"></a>
+<span class="sourceLineNo">922</span>    @Override<a name="line.922"></a>
+<span class="sourceLineNo">923</span>    public String toString() {<a name="line.923"></a>
+<span class="sourceLineNo">924</span>      String desc = "Cluster{" +<a name="line.924"></a>
+<span class="sourceLineNo">925</span>          "servers=[";<a name="line.925"></a>
+<span class="sourceLineNo">926</span>          for(ServerName sn:servers) {<a name="line.926"></a>
+<span class="sourceLineNo">927</span>             desc += sn.getHostAndPort() + ", ";<a name="line.927"></a>
+<span class="sourceLineNo">928</span>          }<a name="line.928"></a>
+<span class="sourceLineNo">929</span>          desc +=<a name="line.929"></a>
+<span class="sourceLineNo">930</span>          ", serverIndicesSortedByRegionCount="+<a name="line.930"></a>
+<span class="sourceLineNo">931</span>          Arrays.toString(serverIndicesSortedByRegionCount) +<a name="line.931"></a>
+<span class="sourceLineNo">932</span>          ", regionsPerServer=[";<a name="line.932"></a>
+<span class="sourceLineNo">933</span><a name="line.933"></a>
+<span class="sourceLineNo">934</span>          for (int[]r:regionsPerServer) {<a name="line.934"></a>
+<span class="sourceLineNo">935</span>            desc += Arrays.toString(r);<a name="line.935"></a>
+<span class="sourceLineNo">936</span>          }<a name="line.936"></a>
+<span class="sourceLineNo">937</span>          desc += "]" +<a name="line.937"></a>
+<span class="sourceLineNo">938</span>          ", numMaxRegionsPerTable=" +<a name="line.938"></a>
+<span class="sourceLineNo">939</span>          Arrays.toString(numMaxRegionsPerTable) +<a name="line.939"></a>
+<span class="sourceLineNo">940</span>          ", numRegions=" +<a name="line.940"></a>
+<span class="sourceLineNo">941</span>          numRegions +<a name="line.941"></a>
+<span class="sourceLineNo">942</span>          ", numServers=" +<a name="line.942"></a>
+<span class="sourceLineNo">943</span>          numServers +<a name="line.943"></a>
+<span class="sourceLineNo">944</span>          ", numTables=" +<a name="line.944"></a>
+<span class="sourceLineNo">945</span>          numTables +<a name="line.945"></a>
+<span class="sourceLineNo">946</span>          ", numMovedRegions=" +<a name="line.946"></a>
+<span class="sourceLineNo">947</span>          numMovedRegions +<a name="line.947"></a>
+<span class="sourceLineNo">948</span>          '}';<a name="line.948"></a>
+<span class="sourceLineNo">949</span>      return desc;<a name="line.949"></a>
+<span class="sourceLineNo">950</span>    }<a name="line.950"></a>
+<span class="sourceLineNo">951</span>  }<a name="line.951"></a>
+<span class="sourceLineNo">952</span><a name="line.952"></a>
+<span class="sourceLineNo">953</span>  // slop for regions<a name="line.953"></a>
+<span class="sourceLineNo">954</span>  protected float slop;<a name="line.954"></a>
+<span class="sourceLineNo">955</span>  protected Configuration config;<a name="line.955"></a>
+<span class="sourceLineNo">956</span>  protected RackManager rackManager;<a name="line.956"></a>
+<span class="sourceLineNo">957</span>  private static final Random RANDOM = new Random(System.currentTimeMillis());<a name="line.957"></a>
+<span class="sourceLineNo">958</span>  private static final Log LOG = LogFactory.getLog(BaseLoadBalancer.class);<a name="line.958"></a>
+<span class="sourceLineNo">959</span><a name="line.959"></a>
+<span class="sourceLineNo">960</span>  // Regions of these tables are put on the master by default.<a name="line.960"></a>
+<span class="sourceLineNo">961</span>  private static final String[] DEFAULT_TABLES_ON_MASTER =<a name="line.961"></a>
+<span class="sourceLineNo">962</span>    new String[] {AccessControlLists.ACL_TABLE_NAME.getNameAsString(),<a name="line.962"></a>
+<span class="sourceLineNo">963</span>      TableName.NAMESPACE_TABLE_NAME.getNameAsString(),<a name="line.963"></a>
+<span class="sourceLineNo">964</span>      TableName.META_TABLE_NAME.getNameAsString()};<a name="line.964"></a>
+<span class="sourceLineNo">965</span><a name="line.965"></a>
+<span class="sourceLineNo">966</span>  public static final String TABLES_ON_MASTER =<a name="line.966"></a>
+<span class="sourceLineNo">967</span>    "hbase.balancer.tablesOnMaster";<a name="line.967"></a>
+<span class="sourceLineNo">968</span><a name="line.968"></a>
+<span class="sourceLineNo">969</span>  protected final Set&lt;String&gt; tablesOnMaster = new HashSet&lt;String&gt;();<a name="line.969"></a>
+<span class="sourceLineNo">970</span>  protected MetricsBalancer metricsBalancer = null;<a name="line.970"></a>
+<span class="sourceLineNo">971</span>  protected ClusterStatus clusterStatus = null;<a name="line.971"></a>
+<span class="sourceLineNo">972</span>  protected ServerName masterServerName;<a name="line.972"></a>
+<span class="sourceLineNo">973</span>  protected MasterServices services;<a name="line.973"></a>
+<span class="sourceLineNo">974</span><a name="line.974"></a>
+<span class="sourceLineNo">975</span>  /**<a name="line.975"></a>
+<span class="sourceLineNo">976</span>   * By default, regions of some small system tables such as meta,<a name="line.976"></a>
+<span class="sourceLineNo">977</span>   * namespace, and acl are assigned to the active master. If you don't<a name="line.977"></a>
+<span class="sourceLineNo">978</span>   * want to assign any region to the active master, you need to<a name="line.978"></a>
+<span class="sourceLineNo">979</span>   * configure "hbase.balancer.tablesOnMaster" to "none".<a name="line.979"></a>
+<span class="sourceLineNo">980</span>   */<a name="line.980"></a>
+<span class="sourceLineNo">981</span>  protected static String[] getTablesOnMaster(Configuration conf) {<a name="line.981"></a>
+<span class="sourceLineNo">982</span>    String valueString = conf.get(TABLES_ON_MASTER);<a name="line.982"></a>
+<span class="sourceLineNo">983</span>    if (valueString == null) {<a name="line.983"></a>
+<span class="sourceLineNo">984</span>      return DEFAULT_TABLES_ON_MASTER;<a name="line.984"></a>
 <span class="sourceLineNo">985</span>    }<a name="line.985"></a>
-<span class="sourceLineNo">986</span>    return StringUtils.getStrings(valueString);<a name="line.986"></a>
-<span class="sourceLineNo">987</span>  }<a name="line.987"></a>
-<span class="sourceLineNo">988</span><a name="line.988"></a>
-<span class="sourceLineNo">989</span>  /**<a name="line.989"></a>
-<span class="sourceLineNo">990</span>   * Check if configured to put any tables on the active master<a name="line.990"></a>
-<span class="sourceLineNo">991</span>   */<a name="line.991"></a>
-<span class="sourceLineNo">992</span>  public static boolean tablesOnMaster(Configuration conf) {<a name="line.992"></a>
-<span class="sourceLineNo">993</span>    String[] tables = getTablesOnMaster(conf);<a name="line.993"></a>
-<span class="sourceLineNo">994</span>    return tables != null &amp;&amp; tables.length &gt; 0;<a name="line.994"></a>
-<span class="sourceLineNo">995</span>  }<a name="line.995"></a>
-<span class="sourceLineNo">996</span><a name="line.996"></a>
-<span class="sourceLineNo">997</span>  @Override<a name="line.997"></a>
-<span class="sourceLineNo">998</span>  public void setConf(Configuration conf) {<a name="line.998"></a>
-<span class="sourceLineNo">999</span>    setSlop(conf);<a name="line.999"></a>
-<span class="sourceLineNo">1000</span>    if (slop &lt; 0) slop = 0;<a name="line.1000"></a>
-<span class="sourceLineNo">1001</span>    else if (slop &gt; 1) slop = 1;<a name="line.1001"></a>
-<span class="sourceLineNo">1002</span><a name="line.1002"></a>
-<span class="sourceLineNo">1003</span>    this.config = conf;<a name="line.1003"></a>
-<span class="sourceLineNo">1004</span>    String[] tables = getTablesOnMaster(conf);<a name="line.1004"></a>
-<span class="sourceLineNo">1005</span>    if (tables != null &amp;&amp; tables.length &gt; 0) {<a name="line.1005"></a>
-<span class="sourceLineNo">1006</span>      Collections.addAll(tablesOnMaster, tables);<a name="line.1006"></a>
-<span class="sourceLineNo">1007</span>    }<a name="line.1007"></a>
-<span class="sourceLineNo">1008</span>    this.rackManager = new RackManager(getConf());<a name="line.1008"></a>
-<span class="sourceLineNo">1009</span>    regionFinder.setConf(conf);<a name="line.1009"></a>
-<span class="sourceLineNo">1010</span>  }<a name="line.1010"></a>
-<span class="sourceLineNo">1011</span><a name="line.1011"></a>
-<span class="sourceLineNo">1012</span>  protected void setSlop(Configuration conf) {<a name="line.1012"></a>
-<span class="sourceLineNo">1013</span>    this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2);<a name="line.1013"></a>
+<span class="sourceLineNo">986</span>    valueString = valueString.trim();<a name="line.986"></a>
+<span class="sourceLineNo">987</span>    if (valueString.equalsIgnoreCase("none")) {<a name="line.987"></a>
+<span class="sourceLineNo">988</span>      return null;<a name="line.988"></a>
+<span class="sourceLineNo">989</span>    }<a name="line.989"></a>
+<span class="sourceLineNo">990</span>    return StringUtils.getStrings(valueString);<a name="line.990"></a>
+<span class="sourceLineNo">991</span>  }<a name="line.991"></a>
+<span class="sourceLineNo">992</span><a name="line.992"></a>
+<span class="sourceLineNo">993</span>  /**<a name="line.993"></a>
+<span class="sourceLineNo">994</span>   * Check if configured to put any tables on the active master<a name="line.994"></a>
+<span class="sourceLineNo">995</span>   */<a name="line.995"></a>
+<span class="sourceLineNo">996</span>  public static boolean tablesOnMaster(Configuration conf) {<a name="line.996"></a>
+<span class="sourceLineNo">997</span>    String[] tables = getTablesOnMaster(conf);<a name="line.997"></a>
+<span class="sourceLineNo">998</span>    return tables != null &amp;&amp; tables.length &gt; 0;<a name="line.998"></a>
+<span class="sourceLineNo">999</span>  }<a name="line.999"></a>
+<span class="sourceLineNo">1000</span><a name="line.1000"></a>
+<span class="sourceLineNo">1001</span>  @Override<a name="line.1001"></a>
+<span class="sourceLineNo">1002</span>  public void setConf(Configuration conf) {<a name="line.1002"></a>
+<span class="sourceLineNo">1003</span>    setSlop(conf);<a name="line.1003"></a>
+<span class="sourceLineNo">1004</span>    if (slop &lt; 0) slop = 0;<a name="line.1004"></a>
+<span class="sourceLineNo">1005</span>    else if (slop &gt; 1) slop = 1;<a name="line.1005"></a>
+<span class="sourceLineNo">1006</span><a name="line.1006"></a>
+<span class="sourceLineNo">1007</span>    this.config = conf;<a name="line.1007"></a>
+<span class="sourceLineNo">1008</span>    String[] tables = getTablesOnMaster(conf);<a name="line.1008"></a>
+<span class="sourceLineNo">1009</span>    if (tables != null &amp;&amp; tables.length &gt; 0) {<a name="line.1009"></a>
+<span class="sourceLineNo">1010</span>      Collections.addAll(tablesOnMaster, tables);<a name="line.1010"></a>
+<span class="sourceLineNo">1011</span>    }<a name="line.1011"></a>
+<span class="sourceLineNo">1012</span>    this.rackManager = new RackManager(getConf());<a name="line.1012"></a>
+<span class="sourceLineNo">1013</span>    regionFinder.setConf(conf);<a name="line.1013"></a>
 <span class="sourceLineNo">1014</span>  }<a name="line.1014"></a>
 <span class="sourceLineNo">1015</span><a name="line.1015"></a>
-<span class="sourceLineNo">1016</span>  /**<a name="line.1016"></a>
-<span class="sourceLineNo">1017</span>   * Check if a region belongs to some small system table.<a name="line.1017"></a>
-<span class="sourceLineNo">1018</span>   * If so, the primary replica may be expected to be put on the master regionserver.<a name="line.1018"></a>
-<span class="sourceLineNo">1019</span>   */<a name="line.1019"></a>
-<span class="sourceLineNo">1020</span>  public boolean shouldBeOnMaster(HRegionInfo region) {<a name="line.1020"></a>
-<span class="sourceLineNo">1021</span>    return tablesOnMaster.contains(region.getTable().getNameAsString())<a name="line.1021"></a>
-<span class="sourceLineNo">1022</span>        &amp;&amp; region.getReplicaId() == HRegionInfo.DEFAULT_REPLICA_ID;<a name="line.1022"></a>
-<span class="sourceLineNo">1023</span>  }<a name="line.1023"></a>
-<span class="sourceLineNo">1024</span><a name="line.1024"></a>
-<span class="sourceLineNo">1025</span>  /**<a name="line.1025"></a>
-<span class="sourceLineNo">1026</span>   * Balance the regions that should be on master regionserver.<a name="line.1026"></a>
-<span class="sourceLineNo">1027</span>   */<a name="line.1027"></a>
-<span class="sourceLineNo">1028</span>  protected List&lt;RegionPlan&gt; balanceMasterRegions(<a name="line.1028"></a>
-<span class="sourceLineNo">1029</span>      Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; clusterMap) {<a name="line.1029"></a>
-<span class="sourceLineNo">1030</span>    if (masterServerName == null<a name="line.1030"></a>
-<span class="sourceLineNo">1031</span>        || clusterMap == null || clusterMap.size() &lt;= 1) return null;<a name="line.1031"></a>
-<span class="sourceLineNo">1032</span>    List&lt;RegionPlan&gt; plans = null;<a name="line.1032"></a>
-<span class="sourceLineNo">1033</span>    List&lt;HRegionInfo&gt; regions = clusterMap.get(masterServerName);<a name="line.1033"></a>
-<span class="sourceLineNo">1034</span>    if (regions != null) {<a name="line.1034"></a>
-<span class="sourceLineNo">1035</span>      Iterator&lt;ServerName&gt; keyIt = null;<a name="line.1035"></a>
-<span class="sourceLineNo">1036</span>      for (HRegionInfo region: regions) {<a name="line.1036"></a>
-<span class="sourceLineNo">1037</span>        if (shouldBeOnMaster(region)) continue;<a name="line.1037"></a>
-<span class="sourceLineNo">1038</span><a name="line.1038"></a>
-<span class="sourceLineNo">1039</span>        // Find a non-master regionserver to host the region<a name="line.1039"></a>
-<span class="sourceLineNo">1040</span>        if (keyIt == null || !keyIt.hasNext()) {<a name="line.1040"></a>
-<span class="sourceLineNo">1041</span>          keyIt = clusterMap.keySet().iterator();<a name="line.1041"></a>
-<span class="sourceLineNo">1042</span>        }<a name="line.1042"></a>
-<span class="sourceLineNo">1043</span>        ServerName dest = keyIt.next();<a name="line.1043"></a>
-<span class="sourceLineNo">1044</span>        if (masterServerName.equals(dest)) {<a name="line.1044"></a>
-<span class="sourceLineNo">1045</span>          if (!keyIt.hasNext()) {<a name="line.1045"></a>
-<span class="sourceLineNo">1046</span>            keyIt = clusterMap.keySet().iterator();<a name="line.1046"></a>
-<span class="sourceLineNo">1047</span>          }<a name="line.1047"></a>
-<span class="sourceLineNo">1048</span>          dest = keyIt.next();<a name="line.1048"></a>
-<span class="sourceLineNo">1049</span>        }<a name="line.1049"></a>
-<span class="sourceLineNo">1050</span><a name="line.1050"></a>
-<span class="sourceLineNo">1051</span>        // Move this region away from the master regionserver<a name="line.1051"></a>
-<span class="sourceLineNo">1052</span>        RegionPlan plan = new RegionPlan(region, masterServerName, dest);<a name="line.1052"></a>
-<span class="sourceLineNo">1053</span>        if (plans == null) {<a name="line.1053"></a>
-<span class="sourceLineNo">1054</span>          plans = new ArrayList&lt;RegionPlan&gt;();<a name="line.1054"></a>
-<span class="sourceLineNo">1055</span>        }<a name="line.1055"></a>
-<span class="sourceLineNo">1056</span>        plans.add(plan);<a name="line.1056"></a>
-<span class="sourceLineNo">1057</span>      }<a name="line.1057"></a>
-<span class="sourceLineNo">1058</span>    }<a name="line.1058"></a>
-<span class="sourceLineNo">1059</span>    for (Map.Entry&lt;ServerName, List&lt;HRegionInfo&gt;&gt; server: clusterMap.entrySet()) {<a name="line.1059"></a>
-<span class="sourceLineNo">1060</span>      if (masterServerName.equals(server.getKey())) continue;<a name="line.1060"></a>
-<span class="sourceLineNo">1061</span>      for (HRegionInfo region: server.getValue()) {<a name="line.1061"></a>
-<span class="sourceLineNo">1062</span>        if (!shouldBeOnMaster(region)) continue;<a name="line.1062"></a>
-<span class="sourceLineNo">1063</span><a name="line.1063"></a>
-<span class="sourceLineNo">1064</span>        // Move this region to the master regionserver<a name="line.1064"></a>
-<span class="sourceLineNo">1065</span>        RegionPlan plan = new RegionPlan(region, server.getKey(), masterServerName);<a name="line.1065"></a>
-<span class="sourceLineNo">1066</span>        if (plans == null) {<a name="line.1066"></a>
-<span class="sourceLineNo">1067</span>          plans = new ArrayList&lt;RegionPlan&gt;();<a name="line.1067"></a>
-<span class="sourceLineNo">1068</span>        }<a name="line.1068"></a>
-<span class="sourceLineNo">1069</span>        plans.add(plan);<a name="line.1069"></a>
-<span class="sourceLineNo">1070</span>      }<a name="line.1070"></a>
-<span class="sourceLineNo">1071</span>    }<a name="line.1071"></a>
-<span class="sourceLineNo">1072</span>    return plans;<a name="line.1072"></a>
-<span class="sourceLineNo">1073</span>  }<a name="line.1073"></a>
-<span class="sourceLineNo">1074</span><a name="line.1074"></a>
-<span class="sourceLineNo">1075</span>  /**<a name="line.1075"></a>
-<span class="sourceLineNo">1076</span>   * Assign the regions that should be on master regionserver.<a name="line.1076"></a>
-<span class="sourceLineNo">1077</span>   */<a name="line.1077"></a>
-<span class="sourceLineNo">1078</span>  protected Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignMasterRegions(<a name="line.1078"></a>
-<span class="sourceLineNo">1079</span>      Collection&lt;HRegionInfo&gt; regions, List&lt;ServerName&gt; servers) {<a name="line.1079"></a>
-<span class="sourceLineNo">1080</span>    if (servers == null || regions == null || regions.isEmpty()) {<a name="line.1080"></a>
-<span class="sourceLineNo">1081</span>      return null;<a name="line.1081"></a>
-<span class="sourceLineNo">1082</span>    }<a name="line.1082"></a>
-<span class="sourceLineNo">1083</span>    Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignments<a name="line.1083"></a>
-<span class="sourceLineNo">1084</span>      = new TreeMap&lt;ServerName, List&lt;HRegionInfo&gt;&gt;();<a name="line.1084"></a>
-<span class="sourceLineNo">1085</span>    if (masterServerName != null &amp;&amp; servers.contains(masterServerName)) {<a name="line.1085"></a>
-<span class="sourceLineNo">1086</span>      assignments.put(masterServerName, new ArrayList&lt;HRegionInfo&gt;());<a name="line.1086"></a>
-<span class="sourceLineNo">1087</span>      for (HRegionInfo region: regions) {<a name="line.1087"></a>
-<span class="sourceLineNo">1088</span>        if (shouldBeOnMaster(region)) {<a name="line.1088"></a>
-<span class="sourceLineNo">1089</span>          assignments.get(masterServerName).add(region);<a name="line.1089"></a>
-<span class="sourceLineNo">1090</span>        }<a name="line.1090"></a>
-<span class="sourceLineNo">1091</span>      }<a name="line.1091"></a>
-<span class="sourceLineNo">1092</span>    }<a name="line.1092"></a>
-<span class="sourceLineNo">1093</span>    return assignments;<a name="line.1093"></a>
-<span class="sourceLineNo">1094</span>  }<a name="line.1094"></a>
-<span class="sourceLineNo">1095</span><a name="line.1095"></a>
-<span class="sourceLineNo">1096</span>  @Override<a name="line.1096"></a>
-<span class="sourceLineNo">1097</span>  public Configuration getConf() {<a name="line.1097"></a>
-<span class="sourceLineNo">1098</span>    return this.config;<a name="line.1098"></a>
-<span class="sourceLineNo">1099</span>  }<a name="line.1099"></a>
-<span class="sourceLineNo">1100</span><a name="line.1100"></a>
-<span class="sourceLineNo">1101</span>  @Override<a name="line.1101"></a>
-<span class="sourceLineNo">1102</span>  public synchronized void setClusterStatus(ClusterStatus st) {<a name="line.1102"></a>
-<span class="sourceLineNo">1103</span>    this.clusterStatus = st;<a name="line.1103"></a>
-<span class="sourceLineNo">1104</span>    regionFinder.setClusterStatus(st);<a name="line.1104"></a>
-<span class="sourceLineNo">1105</span>  }<a name="line.1105"></a>
-<span class="sourceLineNo">1106</span><a name="line.1106"></a>
-<span class="sourceLineNo">1107</span>  @Override<a name="line.1107"></a>
-<span class="sourceLineNo">1108</span>  public void setMasterServices(MasterServices masterServices) {<a name="line.1108"></a>
-<span class="sourceLineNo">1109</span>    masterServerName = masterServices.getServerName();<a name="line.1109"></a>
-<span class="sourceLineNo">1110</span>    this.services = masterServices;<a name="line.1110"></a>
-<span class="sourceLineNo">1111</span>    this.regionFinder.setServices(masterServices);<a name="line.1111"></a>
-<span class="sourceLineNo">1112</span>  }<a name="line.1112"></a>
-<span class="sourceLineNo">1113</span><a name="line.1113"></a>
-<span class="sourceLineNo">1114</span>  public void setRackManager(RackManager rackManager) {<a name="line.1114"></a>
-<span class="sourceLineNo">1115</span>    this.rackManager = rackManager;<a name="line.1115"></a>
+<span class="sourceLineNo">1016</span>  protected void setSlop(Configuration conf) {<a name="line.1016"></a>
+<span class="sourceLineNo">1017</span>    this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2);<a name="line.1017"></a>
+<span class="sourceLineNo">1018</span>  }<a name="line.1018"></a>
+<span class="sourceLineNo">1019</span><a name="line.1019"></a>
+<span class="sourceLineNo">1020</span>  /**<a name="line.1020"></a>
+<span class="sourceLineNo">1021</span>   * Check if a region belongs to some small system table.<a name="line.1021"></a>
+<span class="sourceLineNo">1022</span>   * If so, the primary replica may be expected to be put on the master regionserver.<a name="line.1022"></a>
+<span class="sourceLineNo">1023</span>   */<a name="line.1023"></a>
+<span class="sourceLineNo">1024</span>  public boolean shouldBeOnMaster(HRegionInfo region) {<a name="line.1024"></a>
+<span class="sourceLineNo">1025</span>    return tablesOnMaster.contains(region.getTable().getNameAsString())<a name="line.1025"></a>
+<span class="sourceLineNo">1026</span>        &amp;&amp; region.getReplicaId() == HRegionInfo.DEFAULT_REPLICA_ID;<a name="line.1026"></a>
+<span class="sourceLineNo">1027</span>  }<a name="line.1027"></a>
+<span class="sourceLineNo">1028</span><a name="line.1028"></a>
+<span class="sourceLineNo">1029</span>  /**<a name="line.1029"></a>
+<span class="sourceLineNo">1030</span>   * Balance the regions that should be on master regionserver.<a name="line.1030"></a>
+<span class="sourceLineNo">1031</span>   */<a name="line.1031"></a>
+<span class="sourceLineNo">1032</span>  protected List&lt;RegionPlan&gt; balanceMasterRegions(<a name="line.1032"></a>
+<span class="sourceLineNo">1033</span>      Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; clusterMap) {<a name="line.1033"></a>
+<span class="sourceLineNo">1034</span>    if (masterServerName == null<a name="line.1034"></a>
+<span class="sourceLineNo">1035</span>        || clusterMap == null || clusterMap.size() &lt;= 1) return null;<a name="line.1035"></a>
+<span class="sourceLineNo">1036</span>    List&lt;RegionPlan&gt; plans = null;<a name="line.1036"></a>
+<span class="sourceLineNo">1037</span>    List&lt;HRegionInfo&gt; regions = clusterMap.get(masterServerName);<a name="line.1037"></a>
+<span class="sourceLineNo">1038</span>    if (regions != null) {<a name="line.1038"></a>
+<span class="sourceLineNo">1039</span>      Iterator&lt;ServerName&gt; keyIt = null;<a name="line.1039"></a>
+<span class="sourceLineNo">1040</span>      for (HRegionInfo region: regions) {<a name="line.1040"></a>
+<span class="sourceLineNo">1041</span>        if (shouldBeOnMaster(region)) continue;<a name="line.1041"></a>
+<span class="sourceLineNo">1042</span><a name="line.1042"></a>
+<span class="sourceLineNo">1043</span>        // Find a non-master regionserver to host the region<a name="line.1043"></a>
+<span class="sourceLineNo">1044</span>        if (keyIt == null || !keyIt.hasNext()) {<a name="line.1044"></a>
+<span class="sourceLineNo">1045</span>          keyIt = clusterMap.keySet().iterator();<a name="line.1045"></a>
+<span class="sourceLineNo">1046</span>        }<a name="line.1046"></a>
+<span class="sourceLineNo">1047</span>        ServerName dest = keyIt.next();<a name="line.1047"></a>
+<span class="sourceLineNo">1048</span>        if (masterServerName.equals(dest)) {<a name="line.1048"></a>
+<span class="sourceLineNo">1049</span>          if (!keyIt.hasNext()) {<a name="line.1049"></a>
+<span class="sourceLineNo">1050</span>            keyIt = clusterMap.keySet().iterator();<a name="line.1050"></a>
+<span class="sourceLineNo">1051</span>          }<a name="line.1051"></a>
+<span class="sourceLineNo">1052</span>          dest = keyIt.next();<a name="line.1052"></a>
+<span class="sourceLineNo">1053</span>        }<a name="line.1053"></a>
+<span class="sourceLineNo">1054</span><a name="line.1054"></a>
+<span class="sourceLineNo">1055</span>        // Move this region away from the master regionserver<a name="line.1055"></a>
+<span class="sourceLineNo">1056</span>        RegionPlan plan = new RegionPlan(region, masterServerName, dest);<a name="line.1056"></a>
+<span class="sourceLineNo">1057</span>        if (plans == null) {<a name="line.1057"></a>
+<span class="sourceLineNo">1058</span>          plans = new ArrayList&lt;RegionPlan&gt;();<a name="line.1058"></a>
+<span class="sourceLineNo">1059</span>        }<a name="line.1059"></a>
+<span class="sourceLineNo">1060</span>        plans.add(plan);<a name="line.1060"></a>
+<span class="sourceLineNo">1061</span>      }<a name="line.1061"></a>
+<span class="sourceLineNo">1062</span>    }<a name="line.1062"></a>
+<span class="sourceLineNo">1063</span>    for (Map.Entry&lt;ServerName, List&lt;HRegionInfo&gt;&gt; server: clusterMap.entrySet()) {<a name="line.1063"></a>
+<span class="sourceLineNo">1064</span>      if (masterServerName.equals(server.getKey())) continue;<a name="line.1064"></a>
+<span class="sourceLineNo">1065</span>      for (HRegionInfo region: server.getValue()) {<a name="line.1065"></a>
+<span class="sourceLineNo">1066</span>        if (!shouldBeOnMaster(region)) continue;<a name="line.1066"></a>
+<span class="sourceLineNo">1067</span><a name="line.1067"></a>
+<span class="sourceLineNo">1068</span>        // Move this region to the master regionserver<a name="line.1068"></a>
+<span class="sourceLineNo">1069</span>        RegionPlan plan = new RegionPlan(region, server.getKey(), masterServerName);<a name="line.1069"></a>
+<span class="sourceLineNo">1070</span>        if (plans == null) {<a name="line.1070"></a>
+<span class="sourceLineNo">1071</span>          plans = new ArrayList&lt;RegionPlan&gt;();<a name="line.1071"></a>
+<span class="sourceLineNo">1072</span>        }<a name="line.1072"></a>
+<span class="sourceLineNo">1073</span>        plans.add(plan);<a name="line.1073"></a>
+<span class="sourceLineNo">1074</span>      }<a name="line.1074"></a>
+<span class="sourceLineNo">1075</span>    }<a name="line.1075"></a>
+<span class="sourceLineNo">1076</span>    return plans;<a name="line.1076"></a>
+<span class="sourceLineNo">1077</span>  }<a name="line.1077"></a>
+<span class="sourceLineNo">1078</span><a name="line.1078"></a>
+<span class="sourceLineNo">1079</span>  /**<a name="line.1079"></a>
+<span class="sourceLineNo">1080</span>   * Assign the regions that should be on master regionserver.<a name="line.1080"></a>
+<span class="sourceLineNo">1081</span>   */<a name="line.1081"></a>
+<span class="sourceLineNo">1082</span>  protected Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignMasterRegions(<a name="line.1082"></a>
+<span class="sourceLineNo">1083</span>      Collection&lt;HRegionInfo&gt; regions, List&lt;ServerName&gt; servers) {<a name="line.1083"></a>
+<span class="sourceLineNo">1084</span>    if (servers == null || regions == null || regions.isEmpty()) {<a name="line.1084"></a>
+<span class="sourceLineNo">1085</span>      return null;<a name="line.1085"></a>
+<span class="sourceLineNo">1086</span>    }<a name="line.1086"></a>
+<span class="sourceLineNo">1087</span>    Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignments<a name="line.1087"></a>
+<span class="sourceLineNo">1088</span>      = new TreeMap&lt;ServerName, List&lt;HRegionInfo&gt;&gt;();<a name="line.1088"></a>
+<span class="sourceLineNo">1089</span>    if (masterServerName != null &amp;&amp; servers.contains(masterServerName)) {<a name="line.1089"></a>
+<span class="sourceLineNo">1090</span>      assignments.put(masterServerName, new ArrayList&lt;HRegionInfo&gt;());<a name="line.1090"></a>
+<span class="sourceLineNo">1091</span>      for (HRegionInfo region: regions) {<a name="line.1091"></a>
+<span class="sourceLineNo">1092</span>        if (shouldBeOnMaster(region)) {<a name="line.1092"></a>
+<span class="sourceLineNo">1093</span>          assignments.get(masterServerName).add(region);<a name="line.1093"></a>
+<span class="sourceLineNo">1094</span>        }<a name="line.1094"></a>
+<span class="sourceLineNo">1095</span>      }<a name="line.1095"></a>
+<span class="sourceLineNo">1096</span>    }<a name="line.1096"></a>
+<span class="sourceLineNo">1097</span>    return assignments;<a name="line.1097"></a>
+<span class="sourceLineNo">1098</span>  }<a name="line.1098"></a>
+<span class="sourceLineNo">1099</span><a name="line.1099"></a>
+<span class="sourceLineNo">1100</span>  @Override<a name="line.1100"></a>
+<span class="sourceLineNo">1101</span>  public Configuration getConf() {<a name="line.1101"></a>
+<span class="sourceLineNo">1102</span>    return this.config;<a name="line.1102"></a>
+<span class="sourceLineNo">1103</span>  }<a name="line.1103"></a>
+<span class="sourceLineNo">1104</span><a name="line.1104"></a>
+<span class="sourceLineNo">1105</span>  @Override<a name="line.1105"></a>
+<span class="sourceLineNo">1106</span>  public synchronized void setClusterStatus(ClusterStatus st) {<a name="line.1106"></a>
+<span class="sourceLineNo">1107</span>    this.clusterStatus = st;<a name="line.1107"></a>
+<span class="sourceLineNo">1108</span>    regionFinder.setClusterStatus(st);<a name="line.1108"></a>
+<span class="sourceLineNo">1109</span>  }<a name="line.1109"></a>
+<span class="sourceLineNo">1110</span><a name="line.1110"></a>
+<span class="sourceLineNo">1111</span>  @Override<a name="line.1111"></a>
+<span class="sourceLineNo">1112</span>  public void setMasterServices(MasterServices masterServices) {<a name="line.1112"></a>
+<span class="sourceLineNo">1113</span>    masterServerName = masterServices.getServerName();<a name="line.1113"></a>
+<span class="sourceLineNo">1114</span>    this.services = masterServices;<a name="line.1114"></a>
+<span class="sourceLineNo">1115</span>    this.regionFinder.setServices(masterServices);<a name="line.1115"></a>
 <span class="sourceLineNo">1116</span>  }<a name="line.1116"></a>
 <span class="sourceLineNo">1117</span><a name="line.1117"></a>
-<span class="sourceLineNo">1118</span>  protected boolean needsBalance(Cluster c) {<a name="line.1118"></a>
-<span class="sourceLineNo">1119</span>    ClusterLoadState cs = new ClusterLoadState(c.clusterState);<a name="line.1119"></a>
-<span class="sourceLineNo">1120</span>    if (cs.getNumServers() &lt; MIN_SERVER_BALANCE) {<a name="line.1120"></a>
-<span class="sourceLineNo">1121</span>      if (LOG.isDebugEnabled()) {<a name="line.1121"></a>
-<span class="sourceLineNo">1122</span>        LOG.debug("Not running balancer because only " + cs.getNumServers()<a name="line.1122"></a>
-<span class="sourceLineNo">1123</span>            + " active regionserver(s)");<a name="line.1123"></a>
-<span class="sourceLineNo">1124</span>      }<a name="line.1124"></a>
-<span class="sourceLineNo">1125</span>      return false;<a name="line.1125"></a>
-<span class="sourceLineNo">1126</span>    }<a name="line.1126"></a>
-<span class="sourceLineNo">1127</span>    if(areSomeRegionReplicasColocated(c)) return true;<a name="line.1127"></a>
-<span class="sourceLineNo">1128</span>    // Check if we even need to do any load balancing<a name="line.1128"></a>
-<span class="sourceLineNo">1129</span>    // HBASE-3681 check sloppiness first<a name="line.1129"></a>
-<span class="sourceLineNo">1130</span>    float average = cs.getLoadAverage(); // for logging<a name="line.1130"></a>
-<span class="sourceLineNo">1131</span>    int floor = (int) Math.floor(average * (1 - slop));<a name="line.1131"></a>
-<span class="sourceLineNo">1132</span>    int ceiling = (int) Math.ceil(average * (1 + slop));<a name="line.1132"></a>
-<span class="sourceLineNo">1133</span>    if (!(cs.getMaxLoad() &gt; ceiling || cs.getMinLoad() &lt; floor)) {<a name="line.1133"></a>
-<span class="sourceLineNo">1134</span>      NavigableMap&lt;ServerAndLoad, List&lt;HRegionInfo&gt;&gt; serversByLoad = cs.getServersByLoad();<a name="line.1134"></a>
-<span class="sourceLineNo">1135</span>      if (LOG.isTraceEnabled()) {<a name="line.1135"></a>
-<span class="sourceLineNo">1136</span>        // If nothing to balance, then don't say anything unless trace-level logging.<a name="line.1136"></a>
-<span class="sourceLineNo">1137</span>        LOG.trace("Skipping load balancing because balanced cluster; " +<a name="line.1137"></a>
-<span class="sourceLineNo">1138</span>          "servers=" + cs.getNumServers() +<a name="line.1138"></a>
-<span class="sourceLineNo">1139</span>          " regions=" + cs.getNumRegions() + " average=" + average +<a name="line.1139"></a>
-<span class="sourceLineNo">1140</span>          " mostloaded=" + serversByLoad.lastKey().getLoad() +<a name="line.1140"></a>
-<span class="sourceLineNo">1141</span>          " leastloaded=" + serversByLoad.firstKey().getLoad());<a name="line.1141"></a>
-<span class="sourceLineNo">1142</span>      }<a name="line.1142"></a>
-<span class="sourceLineNo">1143</span>      return false;<a name="line.1143"></a>
-<span class="sourceLineNo">1144</span>    }<a name="line.1144"></a>
-<span class="sourceLineNo">1145</span>    return true;<a name="line.1145"></a>
-<span class="sourceLineNo">1146</span>  }<a name="line.1146"></a>
-<span class="sourceLineNo">1147</span><a name="line.1147"></a>
-<span class="sourceLineNo">1148</span>  /**<a name="line.1148"></a>
-<span class="sourceLineNo">1149</span>   * Subclasses should implement this to return true if the cluster has nodes that hosts<a name="line.1149"></a>
-<span class="sourceLineNo">1150</span>   * multiple replicas for the same region, or, if there are multiple racks and the same<a name="line.1150"></a>
-<span class="sourceLineNo">1151</span>   * rack hosts replicas of the same region<a name="line.1151"></a>
-<span class="sourceLineNo">1152</span>   * @param c Cluster information<a name="line.1152"></a>
-<span class="sourceLineNo">1153</span>   * @return whether region replicas are currently co-located<a name="line.1153"></a>
-<span class="sourceLineNo">1154</span>   */<a name="line.1154"></a>
-<span class="sourceLineNo">1155</span>  protected boolean areSomeRegionReplicasColocated(Cluster c) {<a name="line.1155"></a>
-<span class="sourceLineNo">1156</span>    return false;<a name="line.1156"></a>
-<span class="sourceLineNo">1157</span>  }<a name="line.1157"></a>
-<span class="sourceLineNo">1158</span><a name="line.1158"></a>
-<span class="sourceLineNo">1159</span>  /**<a name="line.1159"></a>
-<span class="sourceLineNo">1160</span>   * Generates a bulk assignment plan to be used on cluster startup using a<a name="line.1160"></a>
-<span class="sourceLineNo">1161</span>   * simple round-robin assignment.<a name="line.1161"></a>
-<span class="sourceLineNo">1162</span>   * &lt;p&gt;<a name="line.1162"></a>
-<span class="sourceLineNo">1163</span>   * Takes a list of all the regions and all the servers in the cluster and<a name="line.1163"></a>
-<span class="sourceLineNo">1164</span>   * returns a map of each server to the regions that it should be assigned.<a name="line.1164"></a>
-<span class="sourceLineNo">1165</span>   * &lt;p&gt;<a name="line.1165"></a>
-<span class="sourceLineNo">1166</span>   * Currently implemented as a round-robin assignment. Same invariant as load<a name="line.1166"></a>
-<span class="sourceLineNo">1167</span>   * balancing, all servers holding floor(avg) or ceiling(avg).<a name="line.1167"></a>
-<span class="sourceLineNo">1168</span>   *<a name="line.1168"></a>
-<span class="sourceLineNo">1169</span>   * TODO: Use block locations from HDFS to place regions with their blocks<a name="line.1169"></a>
-<span class="sourceLineNo">1170</span>   *<a name="line.1170"></a>
-<span class="sourceLineNo">1171</span>   * @param regions all regions<a name="line.1171"></a>
-<span class="sourceLineNo">1172</span>   * @param servers all servers<a name="line.1172"></a>
-<span class="sourceLineNo">1173</span>   * @return map of server to the regions it should take, or null if no<a name="line.1173"></a>
-<span class="sourceLineNo">1174</span>   *         assignment is possible (ie. no regions or no servers)<a name="line.1174"></a>
-<span class="sourceLineNo">1175</span>   */<a name="line.1175"></a>
-<span class="sourceLineNo">1176</span>  @Override<a name="line.1176"></a>
-<span class="sourceLineNo">1177</span>  public Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; roundRobinAssignment(List&lt;HRegionInfo&gt; regions,<a name="line.1177"></a>
-<span class="sourceLineNo">1178</span>      List&lt;ServerName&gt; servers) {<a name="line.1178"></a>
-<span class="sourceLineNo">1179</span>    metricsBalancer.incrMiscInvocations();<a name="line.1179"></a>
-<span class="sourceLineNo">1180</span>    Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignments = assignMasterRegions(regions, servers);<a name="line.1180"></a>
-<span class="sourceLineNo">1181</span>    if (assignments != null &amp;&amp; !assignments.isEmpty()) {<a name="line.1181"></a>
-<span class="sourceLineNo">1182</span>      servers = new ArrayList&lt;ServerName&gt;(servers);<a name="line.1182"></a>
-<span class="sourceLineNo">1183</span>      // Guarantee not to put other regions on master<a name="line.1183"></a>
-<span class="sourceLineNo">1184</span>      servers.remove(masterServerName);<a name="line.1184"></a>
-<span class="sourceLineNo">1185</span>      List&lt;HRegionInfo&gt; masterRegions = assignments.get(masterServerName);<a name="line.1185"></a>
-<span class="sourceLineNo">1186</span>      if (!masterRegions.isEmpty()) {<a name="line.1186"></a>
-<span class="sourceLineNo">1187</span>        regions = new ArrayList&lt;HRegionInfo&gt;(regions);<a name="line.1187"></a>
-<span class="sourceLineNo">1188</span>        for (HRegionInfo region: masterRegions) {<a name="line.1188"></a>
-<span class="sourceLineNo">1189</span>          regions.remove(region);<a name="line.1189"></a>
-<span class="sourceLineNo">1190</span>        }<a name="line.1190"></a>
-<span class="sourceLineNo">1191</span>      }<a name="line.1191"></a>
-<span class="sourceLineNo">1192</span>    }<a name="line.1192"></a>
-<span class="sourceLineNo">1193</span>    if (regions == null || regions.isEmpty()) {<a name="line.1193"></a>
-<span class="sourceLineNo">1194</span>      return assignments;<a name="line.1194"></a>
-<span class="sourceLineNo">1195</span>    }<a name="line.1195"></a>
-<span class="sourceLineNo">1196</span><a name="line.1196"></a>
-<span class="sourceLineNo">1197</span>    int numServers = servers == null ? 0 : servers.size();<a name="line.1197"></a>
-<span class="sourceLineNo">1198</span>    if (numServers == 0) {<a name="line.1198"></a>
-<span class="sourceLineNo">1199</span>      LOG.warn("Wanted to do round robin assignment but no servers to assign to");<a name="line.1199"></a>
-<span class="sourceLineNo">1200</span>      return null;<a name="line.1200"></a>
-<span class="sourceLineNo">1201</span>    }<a name="line.1201"></a>
-<span class="sourceLineNo">1202</span><a name="line.1202"></a>
-<span class="sourceLineNo">1203</span>    // TODO: instead of retainAssignment() and roundRobinAssignment(), we should just run the<a name="line.1203"></a>
-<span class="sourceLineNo">1204</span>    // normal LB.balancerCluster() with unassignedRegions. We only need to have a candidate<a name="line.1204"></a>
-<span class="sourceLineNo">1205</span>    // generator for AssignRegionAction. The LB will ensure the regions are mostly local<a name="line.1205"></a>
-<span class="sourceLineNo">1206</span>    // and balanced. This should also run fast with fewer number of iterations.<a name="line.1206"></a>
-<span class="sourceLineNo">1207</span><a name="line.1207"></a>
-<span class="sourceLineNo">1208</span>    if (numServers == 1) { // Only one server, nothing fancy we can do here<a name="line.1208"></a>
-<span class="sourceLineNo">1209</span>      ServerName server = servers.get(0);<a name="line.1209"></a>
-<span class="sourceLineNo">1210</span>      assignments.put(server, new ArrayList&lt;HRegionInfo&gt;(regions));<a name="line.1210"></a>
-<span class="sourceLineNo">1211</span>      return assignments;<a name="line.1211"></a>
-<span class="sourceLineNo">1212</span>    }<a name="line.1212"></a>
-<span class="sourceLineNo">1213</span><a name="line.1213"></a>
-<span class="sourceLineNo">1214</span>    Cluster cluster = createCluster(servers, regions);<a name="line.1214"></a>
-<span class="sourceLineNo">1215</span>    List&lt;HRegionInfo&gt; unassignedRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1215"></a>
-<span class="sourceLineNo">1216</span><a name="line.1216"></a>
-<span class="sourceLineNo">1217</span>    roundRobinAssignment(cluster, regions, unassignedRegions,<a name="line.1217"></a>
-<span class="sourceLineNo">1218</span>      servers, assignments);<a name="line.1218"></a>
-<span class="sourceLineNo">1219</span><a name="line.1219"></a>
-<span class="sourceLineNo">1220</span>    List&lt;HRegionInfo&gt; lastFewRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1220"></a>
-<span class="sourceLineNo">1221</span>    // assign the remaining by going through the list and try to assign to servers one-by-one<a name="line.1221"></a>
-<span class="sourceLineNo">1222</span>    int serverIdx = RANDOM.nextInt(numServers);<a name="line.1222"></a>
-<span class="sourceLineNo">1223</span>    for (HRegionInfo region : unassignedRegions) {<a name="line.1223"></a>
-<span class="sourceLineNo">1224</span>      boolean assigned = false;<a name="line.1224"></a>
-<span class="sourceLineNo">1225</span>      for (int j = 0; j &lt; numServers; j++) { // try all servers one by one<a name="line.1225"></a>
-<span class="sourceLineNo">1226</span>        ServerName serverName = servers.get((j + serverIdx) % numServers);<a name="line.1226"></a>
-<span class="sourceLineNo">1227</span>        if (!cluster.wouldLowerAvailability(region, serverName)) {<a name="line.1227"></a>
-<span class="sourceLineNo">1228</span>          List&lt;HRegionInfo&gt; serverRegions = assignments.get(serverName);<a name="line.1228"></a>
-<span class="sourceLineNo">1229</span>          if (serverRegions == null) {<a name="line.1229"></a>
-<span class="sourceLineNo">1230</span>            serverRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1230"></a>
-<span class="sourceLineNo">1231</span>            assignments.put(serverName, serverRegions);<a name="line.1231"></a>
-<span class="sourceLineNo">1232</span>          }<a name="line.1232"></a>
-<span class="sourceLineNo">1233</span>          serverRegions.add(region);<a name="line.1233"></a>
-<span class="sourceLineNo">1234</span>          cluster.doAssignRegion(region, serverName);<a name="line.1234"></a>
-<span class="sourceLineNo">1235</span>          serverIdx = (j + serverIdx + 1) % numServers; //remain from next server<a name="line.1235"></a>
-<span class="sourceLineNo">1236</span>          assigned = true;<a name="line.1236"></a>
-<span class="sourceLineNo">1237</span>          break;<a name="line.1237"></a>
-<span class="sourceLineNo">1238</span>        }<a name="line.1238"></a>
-<span class="sourceLineNo">1239</span>      }<a name="line.1239"></a>
-<span class="sourceLineNo">1240</span>      if (!assigned) {<a name="line.1240"></a>
-<span class="sourceLineNo">1241</span>        lastFewRegions.add(region);<a name="line.1241"></a>
-<span class="sourceLineNo">1242</span>      }<a name="line.1242"></a>
-<span class="sourceLineNo">1243</span>    }<a name="line.1243"></a>
-<span class="sourceLineNo">1244</span>    // just sprinkle the rest of the regions on random regionservers. The balanceCluster will<a name="line.1244"></a>
-<span class="sourceLineNo">1245</span>    // make it optimal later. we can end up with this if numReplicas &gt; numServers.<a name="line.1245"></a>
-<span class="sourceLineNo">1246</span>    for (HRegionInfo region : lastFewRegions) {<a name="line.1246"></a>
-<span class="sourceLineNo">1247</span>      int i = RANDOM.nextInt(numServers);<a name="line.1247"></a>
-<span class="sourceLineNo">1248</span>      ServerName server = servers.get(i);<a name="line.1248"></a>
-<span class="sourceLineNo">1249</span>      List&lt;HRegionInfo&gt; serverRegions = assignments.get(server);<a name="line.1249"></a>
-<span class="sourceLineNo">1250</span>      if (serverRegions == null) {<a name="line.1250"></a>
-<span class="sourceLineNo">1251</span>        serverRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1251"></a>
-<span class="sourceLineNo">1252</span>        assignments.put(server, serverRegions);<a name="line.1252"></a>
-<span class="sourceLineNo">1253</span>      }<a name="line.1253"></a>
-<span class="sourceLineNo">1254</span>      serverRegions.add(region);<a name="line.1254"></a>
-<span class="sourceLineNo">1255</span>      cluster.doAssignRegion(region, server);<a name="line.1255"></a>
-<span class="sourceLineNo">1256</span>    }<a name="line.1256"></a>
-<span class="sourceLineNo">1257</span>    return assignments;<a name="line.1257"></a>
-<span class="sourceLineNo">1258</span>  }<a name="line.1258"></a>
-<span class="sourceLineNo">1259</span><a name="line.1259"></a>
-<span class="sourceLineNo">1260</span>  protected Cluster createCluster(List&lt;ServerName&gt; servers,<a name="line.1260"></a>
-<span class="sourceLineNo">1261</span>      Collection&lt;HRegionInfo&gt; regions) {<a name="line.1261"></a>
-<span class="sourceLineNo">1262</span>    // Get the snapshot of the current assignments for the regions in question, and then create<a name="line.1262"></a>
-<span class="sourceLineNo">1263</span>    // a cluster out of it. Note that we might have replicas already assigned to some servers<a name="line.1263"></a>
-<span class="sourceLineNo">1264</span>    // earlier. So we want to get the snapshot to see those assignments, but this will only contain<a name="line.1264"></a>
-<span class="sourceLineNo">1265</span>    // replicas of the regions that are passed (for performance).<a name="line.1265"></a>
-<span class="sourceLineNo">1266</span>    Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; clusterState = getRegionAssignmentsByServer(regions);<a name="line.1266"></a>
-<span class="sourceLineNo">1267</span><a name="line.1267"></a>
-<span class="sourceLineNo">1268</span>    for (ServerName server : servers) {<a name="line.1268"></a>
-<span class="sourceLineNo">1269</span>      if (!clusterState.containsKey(server)) {<a name="line.1269"></a>
-<span class="sourceLineNo">1270</span>        clusterState.put(server, EMPTY_REGION_LIST);<a name="line.1270"></a>
-<span class="sourceLineNo">1271</span>      }<a name="line.1271"></a>
-<span class="sourceLineNo">1272</span>    }<a name="line.1272"></a>
-<span class="sourceLineNo">1273</span>    return new Cluster(regions, clusterState, null, this.regionFinder,<a name="line.1273"></a>
-<span class="sourceLineNo">1274</span>      rackManager);<a name="line.1274"></a>
-<span class="sourceLineNo">1275</span>  }<a name="line.1275"></a>
-<span class="sourceLineNo">1276</span><a name="line.1276"></a>
-<span class="sourceLineNo">1277</span>  /**<a name="line.1277"></a>
-<span class="sourceLineNo">1278</span>   * Generates an immediate assignment plan to be used by a new master for<a name="line.1278"></a>
-<span class="sourceLineNo">1279</span>   * regions in transition that do not have an already known destination.<a name="line.1279"></a>
-<span class="sourceLineNo">1280</span>   *<a name="line.1280"></a>
-<span class="sourceLineNo">1281</span>   * Takes a list of regions that need immediate assignment and a list of all<a name="line.1281"></a>
-<span class="sourceLineNo">1282</span>   * available servers. Returns a map of regions to the server they should be<a name="line.1282"></a>
-<span class="sourceLineNo">1283</span>   * assigned to.<a name="line.1283"></a>
+<span class="sourceLineNo">1118</span>  public void setRackManager(RackManager rackManager) {<a name="line.1118"></a>
+<span class="sourceLineNo">1119</span>    this.rackManager = rackManager;<a name="line.1119"></a>
+<span class="sourceLineNo">1120</span>  }<a name="line.1120"></a>
+<span class="sourceLineNo">1121</span><a name="line.1121"></a>
+<span class="sourceLineNo">1122</span>  protected boolean needsBalance(Cluster c) {<a name="line.1122"></a>
+<span class="sourceLineNo">1123</span>    ClusterLoadState cs = new ClusterLoadState(c.clusterState);<a name="line.1123"></a>
+<span class="sourceLineNo">1124</span>    if (cs.getNumServers() &lt; MIN_SERVER_BALANCE) {<a name="line.1124"></a>
+<span class="sourceLineNo">1125</span>      if (LOG.isDebugEnabled()) {<a name="line.1125"></a>
+<span class="sourceLineNo">1126</span>        LOG.debug("Not running balancer because only " + cs.getNumServers()<a name="line.1126"></a>
+<span class="sourceLineNo">1127</span>            + " active regionserver(s)");<a name="line.1127"></a>
+<span class="sourceLineNo">1128</span>      }<a name="line.1128"></a>
+<span class="sourceLineNo">1129</span>      return false;<a name="line.1129"></a>
+<span class="sourceLineNo">1130</span>    }<a name="line.1130"></a>
+<span class="sourceLineNo">1131</span>    if(areSomeRegionReplicasColocated(c)) return true;<a name="line.1131"></a>
+<span class="sourceLineNo">1132</span>    // Check if we even need to do any load balancing<a name="line.1132"></a>
+<span class="sourceLineNo">1133</span>    // HBASE-3681 check sloppiness first<a name="line.1133"></a>
+<span class="sourceLineNo">1134</span>    float average = cs.getLoadAverage(); // for logging<a name="line.1134"></a>
+<span class="sourceLineNo">1135</span>    int floor = (int) Math.floor(average * (1 - slop));<a name="line.1135"></a>
+<span class="sourceLineNo">1136</span>    int ceiling = (int) Math.ceil(average * (1 + slop));<a name="line.1136"></a>
+<span class="sourceLineNo">1137</span>    if (!(cs.getMaxLoad() &gt; ceiling || cs.getMinLoad() &lt; floor)) {<a name="line.1137"></a>
+<span class="sourceLineNo">1138</span>      NavigableMap&lt;ServerAndLoad, List&lt;HRegionInfo&gt;&gt; serversByLoad = cs.getServersByLoad();<a name="line.1138"></a>
+<span class="sourceLineNo">1139</span>      if (LOG.isTraceEnabled()) {<a name="line.1139"></a>
+<span class="sourceLineNo">1140</span>        // If nothing to balance, then don't say anything unless trace-level logging.<a name="line.1140"></a>
+<span class="sourceLineNo">1141</span>        LOG.trace("Skipping load balancing because balanced cluster; " +<a name="line.1141"></a>
+<span class="sourceLineNo">1142</span>          "servers=" + cs.getNumServers() +<a name="line.1142"></a>
+<span class="sourceLineNo">1143</span>          " regions=" + cs.getNumRegions() + " average=" + average +<a name="line.1143"></a>
+<span class="sourceLineNo">1144</span>          " mostloaded=" + serversByLoad.lastKey().getLoad() +<a name="line.1144"></a>
+<span class="sourceLineNo">1145</span>          " leastloaded=" + serversByLoad.firstKey().getLoad());<a name="line.1145"></a>
+<span class="sourceLineNo">1146</span>      }<a name="line.1146"></a>
+<span class="sourceLineNo">1147</span>      return false;<a name="line.1147"></a>
+<span class="sourceLineNo">1148</span>    }<a name="line.1148"></a>
+<span class="sourceLineNo">1149</span>    return true;<a name="line.1149"></a>
+<span class="sourceLineNo">1150</span>  }<a name="line.1150"></a>
+<span class="sourceLineNo">1151</span><a name="line.1151"></a>
+<span class="sourceLineNo">1152</span>  /**<a name="line.1152"></a>
+<span class="sourceLineNo">1153</span>   * Subclasses should implement this to return true if the cluster has nodes that hosts<a name="line.1153"></a>
+<span class="sourceLineNo">1154</span>   * multiple replicas for the same region, or, if there are multiple racks and the same<a name="line.1154"></a>
+<span class="sourceLineNo">1155</span>   * rack hosts replicas of the same region<a name="line.1155"></a>
+<span class="sourceLineNo">1156</span>   * @param c Cluster information<a name="line.1156"></a>
+<span class="sourceLineNo">1157</span>   * @return whether region replicas are currently co-located<a name="line.1157"></a>
+<span class="sourceLineNo">1158</span>   */<a name="line.1158"></a>
+<span class="sourceLineNo">1159</span>  protected boolean areSomeRegionReplicasColocated(Cluster c) {<a name="line.1159"></a>
+<span class="sourceLineNo">1160</span>    return false;<a name="line.1160"></a>
+<span class="sourceLineNo">1161</span>  }<a name="line.1161"></a>
+<span class="sourceLineNo">1162</span><a name="line.1162"></a>
+<span class="sourceLineNo">1163</span>  /**<a name="line.1163"></a>
+<span class="sourceLineNo">1164</span>   * Generates a bulk assignment plan to be used on cluster startup using a<a name="line.1164"></a>
+<span class="sourceLineNo">1165</span>   * simple round-robin assignment.<a name="line.1165"></a>
+<span class="sourceLineNo">1166</span>   * &lt;p&gt;<a name="line.1166"></a>
+<span class="sourceLineNo">1167</span>   * Takes a list of all the regions and all the servers in the cluster and<a name="line.1167"></a>
+<span class="sourceLineNo">1168</span>   * returns a map of each server to the regions that it should be assigned.<a name="line.1168"></a>
+<span class="sourceLineNo">1169</span>   * &lt;p&gt;<a name="line.1169"></a>
+<span class="sourceLineNo">1170</span>   * Currently implemented as a round-robin assignment. Same invariant as load<a name="line.1170"></a>
+<span class="sourceLineNo">1171</span>   * balancing, all servers holding floor(avg) or ceiling(avg).<a name="line.1171"></a>
+<span class="sourceLineNo">1172</span>   *<a name="line.1172"></a>
+<span class="sourceLineNo">1173</span>   * TODO: Use block locations from HDFS to place regions with their blocks<a name="line.1173"></a>
+<span class="sourceLineNo">1174</span>   *<a name="line.1174"></a>
+<span class="sourceLineNo">1175</span>   * @param regions all regions<a name="line.1175"></a>
+<span class="sourceLineNo">1176</span>   * @param servers all servers<a name="line.1176"></a>
+<span class="sourceLineNo">1177</span>   * @return map of server to the regions it should take, or null if no<a name="line.1177"></a>
+<span class="sourceLineNo">1178</span>   *         assignment is possible (ie. no regions or no servers)<a name="line.1178"></a>
+<span class="sourceLineNo">1179</span>   */<a name="line.1179"></a>
+<span class="sourceLineNo">1180</span>  @Override<a name="line.1180"></a>
+<span class="sourceLineNo">1181</span>  public Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; roundRobinAssignment(List&lt;HRegionInfo&gt; regions,<a name="line.1181"></a>
+<span class="sourceLineNo">1182</span>      List&lt;ServerName&gt; servers) {<a name="line.1182"></a>
+<span class="sourceLineNo">1183</span>    metricsBalancer.incrMiscInvocations();<a name="line.1183"></a>
+<span class="sourceLineNo">1184</span>    Map&lt;ServerName, List&lt;HRegionInfo&gt;&gt; assignments = assignMasterRegions(regions, servers);<a name="line.1184"></a>
+<span class="sourceLineNo">1185</span>    if (assignments != null &amp;&amp; !assignments.isEmpty()) {<a name="line.1185"></a>
+<span class="sourceLineNo">1186</span>      servers = new ArrayList&lt;ServerName&gt;(servers);<a name="line.1186"></a>
+<span class="sourceLineNo">1187</span>      // Guarantee not to put other regions on master<a name="line.1187"></a>
+<span class="sourceLineNo">1188</span>      servers.remove(masterServerName);<a name="line.1188"></a>
+<span class="sourceLineNo">1189</span>      List&lt;HRegionInfo&gt; masterRegions = assignments.get(masterServerName);<a name="line.1189"></a>
+<span class="sourceLineNo">1190</span>      if (!masterRegions.isEmpty()) {<a name="line.1190"></a>
+<span class="sourceLineNo">1191</span>        regions = new ArrayList&lt;HRegionInfo&gt;(regions);<a name="line.1191"></a>
+<span class="sourceLineNo">1192</span>        for (HRegionInfo region: masterRegions) {<a name="line.1192"></a>
+<span class="sourceLineNo">1193</span>          regions.remove(region);<a name="line.1193"></a>
+<span class="sourceLineNo">1194</span>        }<a name="line.1194"></a>
+<span class="sourceLineNo">1195</span>      }<a name="line.1195"></a>
+<span class="sourceLineNo">1196</span>    }<a name="line.1196"></a>
+<span class="sourceLineNo">1197</span>    if (regions == null || regions.isEmpty()) {<a name="line.1197"></a>
+<span class="sourceLineNo">1198</span>      return assignments;<a name="line.1198"></a>
+<span class="sourceLineNo">1199</span>    }<a name="line.1199"></a>
+<span class="sourceLineNo">1200</span><a name="line.1200"></a>
+<span class="sourceLineNo">1201</span>    int numServers = servers == null ? 0 : servers.size();<a name="line.1201"></a>
+<span class="sourceLineNo">1202</span>    if (numServers == 0) {<a name="line.1202"></a>
+<span class="sourceLineNo">1203</span>      LOG.warn("Wanted to do round robin assignment but no servers to assign to");<a name="line.1203"></a>
+<span class="sourceLineNo">1204</span>      return null;<a name="line.1204"></a>
+<span class="sourceLineNo">1205</span>    }<a name="line.1205"></a>
+<span class="sourceLineNo">1206</span><a name="line.1206"></a>
+<span class="sourceLineNo">1207</span>    // TODO: instead of retainAssignment() and roundRobinAssignment(), we should just run the<a name="line.1207"></a>
+<span class="sourceLineNo">1208</span>    // normal LB.balancerCluster() with unassignedRegions. We only need to have a candidate<a name="line.1208"></a>
+<span class="sourceLineNo">1209</span>    // generator for AssignRegionAction. The LB will ensure the regions are mostly local<a name="line.1209"></a>
+<span class="sourceLineNo">1210</span>    // and balanced. This should also run fast with fewer number of iterations.<a name="line.1210"></a>
+<span class="sourceLineNo">1211</span><a name="line.1211"></a>
+<span class="sourceLineNo">1212</span>    if (numServers == 1) { // Only one server, nothing fancy we can do here<a name="line.1212"></a>
+<span class="sourceLineNo">1213</span>      ServerName server = servers.get(0);<a name="line.1213"></a>
+<span class="sourceLineNo">1214</span>      assignments.put(server, new ArrayList&lt;HRegionInfo&gt;(regions));<a name="line.1214"></a>
+<span class="sourceLineNo">1215</span>      return assignments;<a name="line.1215"></a>
+<span class="sourceLineNo">1216</span>    }<a name="line.1216"></a>
+<span class="sourceLineNo">1217</span><a name="line.1217"></a>
+<span class="sourceLineNo">1218</span>    Cluster cluster = createCluster(servers, regions);<a name="line.1218"></a>
+<span class="sourceLineNo">1219</span>    List&lt;HRegionInfo&gt; unassignedRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1219"></a>
+<span class="sourceLineNo">1220</span><a name="line.1220"></a>
+<span class="sourceLineNo">1221</span>    roundRobinAssignment(cluster, regions, unassignedRegions,<a name="line.1221"></a>
+<span class="sourceLineNo">1222</span>      servers, assignments);<a name="line.1222"></a>
+<span class="sourceLineNo">1223</span><a name="line.1223"></a>
+<span class="sourceLineNo">1224</span>    List&lt;HRegionInfo&gt; lastFewRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1224"></a>
+<span class="sourceLineNo">1225</span>    // assign the remaining by going through the list and try to assign to servers one-by-one<a name="line.1225"></a>
+<span class="sourceLineNo">1226</span>    int serverIdx = RANDOM.nextInt(numServers);<a name="line.1226"></a>
+<span class="sourceLineNo">1227</span>    for (HRegionInfo region : unassignedRegions) {<a name="line.1227"></a>
+<span class="sourceLineNo">1228</span>      boolean assigned = false;<a name="line.1228"></a>
+<span class="sourceLineNo">1229</span>      for (int j = 0; j &lt; numServers; j++) { // try all servers one by one<a name="line.1229"></a>
+<span class="sourceLineNo">1230</span>        ServerName serverName = servers.get((j + serverIdx) % numServers);<a name="line.1230"></a>
+<span class="sourceLineNo">1231</span>        if (!cluster.wouldLowerAvailability(region, serverName)) {<a name="line.1231"></a>
+<span class="sourceLineNo">1232</span>          List&lt;HRegionInfo&gt; serverRegions = assignments.get(serverName);<a name="line.1232"></a>
+<span class="sourceLineNo">1233</span>          if (serverRegions == null) {<a name="line.1233"></a>
+<span class="sourceLineNo">1234</span>            serverRegions = new ArrayList&lt;HRegionInfo&gt;();<a name="line.1234"></a>
+<span class="sourceLineNo">1235</span>            assignments.put(serverName, serverRegions);<a name="line.1235"></a>
+<span class="sourceLineNo">1236</span>          }<a name="line.1236"></a>
+<span class="sourceLineNo">1237</span>          serverRegions.add(region);<a name="line.1237"></a>
+<span class="sourceLineNo">1238</span>          cluster.doAssignRegion(region, serverName);<a name="line.1238"></a>
+<span class="sourceLineNo">1239</span>          serverIdx = (j + serverIdx + 1) % numServers; //remain from next server<a name="line.1239"></a>
+<span class="sourceLineNo">1240</span>          assigned = true;<a name="line.1240"></a>
+<span class="sourceLineNo">1241</span>          break;<a name="line.1241"></a>
+<span class="sourceLineNo">1242</span>        }<a name="line.1242"></a>
+<span class="sourceLineNo">1243</span>      }

<TRUNCATED>

Mime
View raw message