hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apurt...@apache.org
Subject [4/6] hbase git commit: Amend HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname
Date Fri, 05 Feb 2016 01:51:25 GMT
Amend HBASE-15200 ZooKeeper znode ACL checks should only compare the shortname

Fixes for newly introduced FindBugs warnings


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1b420be5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1b420be5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1b420be5

Branch: refs/heads/branch-1
Commit: 1b420be56a530e5b07ed8f478d5aa4916abeb438
Parents: 846a2f3
Author: Andrew Purtell <apurtell@apache.org>
Authored: Thu Feb 4 16:17:41 2016 -0800
Committer: Andrew Purtell <apurtell@apache.org>
Committed: Thu Feb 4 17:33:29 2016 -0800

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/1b420be5/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
b/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
index c4e8990f..5b6385f 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
@@ -306,7 +306,7 @@ public class ZooKeeperWatcher implements Watcher, Abortable, Closeable
{
       if (Ids.ANYONE_ID_UNSAFE.equals(id)) {
         if (perms != Perms.READ) {
           if (LOG.isDebugEnabled()) {
-            LOG.debug(String.format("permissions for '%s' are not correct: have %0x, want
%0x",
+            LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want
0x%x",
               id, perms, Perms.READ));
           }
           return false;
@@ -314,7 +314,7 @@ public class ZooKeeperWatcher implements Watcher, Abortable, Closeable
{
       } else if (superUsers != null && isSuperUserId(superUsers, id)) {
         if (perms != Perms.ALL) {
           if (LOG.isDebugEnabled()) {
-            LOG.debug(String.format("permissions for '%s' are not correct: have %0x, want
%0x",
+            LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want
0x%x",
               id, perms, Perms.ALL));
           }
           return false;
@@ -329,7 +329,7 @@ public class ZooKeeperWatcher implements Watcher, Abortable, Closeable
{
         if (name.equals(hbaseUser)) {
           if (perms != Perms.ALL) {
             if (LOG.isDebugEnabled()) {
-              LOG.debug(String.format("permissions for '%s' are not correct: have %0x, want
%0x",
+              LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want
0x%x",
                 id, perms, Perms.ALL));
             }
             return false;
@@ -365,7 +365,7 @@ public class ZooKeeperWatcher implements Watcher, Abortable, Closeable
{
             } else {
               if (LOG.isDebugEnabled()) {
                 LOG.debug(String.format(
-                  "superuser '%s' does not have correct permissions: have %0x, want %0x",
+                  "superuser '%s' does not have correct permissions: have 0x%x, want 0x%x",
                   acl.getId().getId(), acl.getPerms(), Perms.ALL));
               }
             }


Mime
View raw message