Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DCEC218AF7 for ; Fri, 27 Nov 2015 23:32:48 +0000 (UTC) Received: (qmail 7950 invoked by uid 500); 27 Nov 2015 23:32:48 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 7906 invoked by uid 500); 27 Nov 2015 23:32:48 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 7897 invoked by uid 99); 27 Nov 2015 23:32:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Nov 2015 23:32:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 914F4E0414; Fri, 27 Nov 2015 23:32:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tedyu@apache.org To: commits@hbase.apache.org Message-Id: <73d59fa874a64acc856e2d116a0424bb@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-14893 Race between mutation on region and region closing operation leads to NotServingRegionException Date: Fri, 27 Nov 2015 23:32:48 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/branch-1 9a11c025f -> 9de4691a0 HBASE-14893 Race between mutation on region and region closing operation leads to NotServingRegionException Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/9de4691a Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/9de4691a Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/9de4691a Branch: refs/heads/branch-1 Commit: 9de4691a0a1bf6030fd2521659694cbeb09cc8ce Parents: 9a11c02 Author: tedyu Authored: Fri Nov 27 15:32:42 2015 -0800 Committer: tedyu Committed: Fri Nov 27 15:32:42 2015 -0800 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/regionserver/HRegion.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/9de4691a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java index 3c84b54..3d1d717 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -1403,10 +1403,10 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi } } - this.closing.set(true); - status.setStatus("Disabling writes for close"); // block waiting for the lock for closing lock.writeLock().lock(); + this.closing.set(true); + status.setStatus("Disabling writes for close"); try { if (this.isClosed()) { status.abort("Already got closed by another process");