hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apurt...@apache.org
Subject [1/4] hbase git commit: HBASE-14862 Add support for reporting p90 for histogram metrics Signed-off-by: Andrew Purtell <apurtell@apache.org>
Date Tue, 24 Nov 2015 00:29:11 GMT
Repository: hbase
Updated Branches:
  refs/heads/0.98 a4f126fc7 -> 6c67c2e0f
  refs/heads/branch-1 b71e1bce8 -> 2ce27951b
  refs/heads/branch-1.2 b4e64c845 -> 4916e3805
  refs/heads/master f553bcf46 -> 6b11adbfa


HBASE-14862 Add support for reporting p90 for histogram metrics
Signed-off-by: Andrew Purtell <apurtell@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6b11adbf
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6b11adbf
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6b11adbf

Branch: refs/heads/master
Commit: 6b11adbfa4aa565eff1bb141170c8e183aed3e4b
Parents: f553bcf
Author: Sanjeev Lakshmanan <slakshmanan@salesforce.com>
Authored: Thu Nov 19 16:02:08 2015 -0800
Committer: Andrew Purtell <apurtell@apache.org>
Committed: Mon Nov 23 15:55:45 2015 -0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java  | 1 +
 .../org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java     | 1 +
 .../main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java | 2 ++
 3 files changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/6b11adbf/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java
----------------------------------------------------------------------
diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java
b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java
index 93ff5ba..b759efb 100644
--- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java
+++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/MetricHistogram.java
@@ -31,6 +31,7 @@ public interface MetricHistogram {
   String MEAN_METRIC_NAME = "_mean";
   String MEDIAN_METRIC_NAME = "_median";
   String SEVENTY_FIFTH_PERCENTILE_METRIC_NAME = "_75th_percentile";
+  String NINETIETH_PERCENTILE_METRIC_NAME = "_90th_percentile";
   String NINETY_FIFTH_PERCENTILE_METRIC_NAME = "_95th_percentile";
   String NINETY_NINETH_PERCENTILE_METRIC_NAME = "_99th_percentile";
 

http://git-wip-us.apache.org/repos/asf/hbase/blob/6b11adbf/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java
----------------------------------------------------------------------
diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java
b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java
index ee2745d..d491236 100644
--- a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java
+++ b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java
@@ -60,6 +60,7 @@ public class DynamicMetricsRegistry {
       "_max",
       "_median",
       "_75th_percentile",
+      "_90th_percentile",
       "_95th_percentile",
       "_99th_percentile"};
 

http://git-wip-us.apache.org/repos/asf/hbase/blob/6b11adbf/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
----------------------------------------------------------------------
diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
index 381dbbb..6d85542 100644
--- a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
+++ b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
@@ -126,6 +126,8 @@ public class MutableHistogram extends MutableMetric implements MetricHistogram
{
       metricsRecordBuilder.addGauge(Interns.info(name + MEDIAN_METRIC_NAME, desc), s.getMedian());
       metricsRecordBuilder.addGauge(Interns.info(name + SEVENTY_FIFTH_PERCENTILE_METRIC_NAME,
desc),
           s.get75thPercentile());
+      metricsRecordBuilder.addGauge(Interns.info(name + NINETIETH_PERCENTILE_METRIC_NAME,
desc),
+          s.getValue(0.90));
       metricsRecordBuilder.addGauge(Interns.info(name + NINETY_FIFTH_PERCENTILE_METRIC_NAME,
desc),
           s.get95thPercentile());
       metricsRecordBuilder.addGauge(Interns.info(name + NINETY_NINETH_PERCENTILE_METRIC_NAME,
desc),


Mime
View raw message