hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syuanji...@apache.org
Subject [04/24] hbase git commit: HBASE-14829 Add more checkstyles (appy)
Date Tue, 24 Nov 2015 22:29:41 GMT
HBASE-14829 Add more checkstyles (appy)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/62aba61b
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/62aba61b
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/62aba61b

Branch: refs/heads/hbase-12439
Commit: 62aba61beae7768880d98d2afd9d8f1a9030177e
Parents: ea48ef8
Author: stack <stack@apache.org>
Authored: Thu Nov 19 21:33:14 2015 -0800
Committer: stack <stack@apache.org>
Committed: Thu Nov 19 21:33:14 2015 -0800

----------------------------------------------------------------------
 .../src/main/resources/hbase/checkstyle.xml     | 76 +++++++++++++++-----
 pom.xml                                         |  4 +-
 2 files changed, 61 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/62aba61b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
----------------------------------------------------------------------
diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
index bf84931..685e892 100644
--- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
+++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
@@ -32,34 +32,76 @@
 <module name="Checker">
   <module name="FileTabCharacter"/>
   <module name="TreeWalker">
+
+    <!-- Annotations Checks
+    http://checkstyle.sourceforge.net/config_annotation.html -->
+    <module name="MissingDeprecated"/>
+
+    <!-- Block Checks
+    http://checkstyle.sourceforge.net/config_blocks.html -->
+    <module name="EmptyBlock"/>
+    <module name="LeftCurly"/>
+    <module name="NeedBraces"/>
+
+    <!-- Class Design Checks
+    http://checkstyle.sourceforge.net/config_design.html -->
+    <module name="FinalClass"/>
+    <module name="HideUtilityClassConstructor"/>
+    <module name="InterfaceIsType"/>
+    <module name="VisibilityModifier">
+      <property name="packageAllowed" value="true"/>
+      <property name="protectedAllowed" value="true"/>
+    </module>
+
+    <!-- Coding Checks
+    http://checkstyle.sourceforge.net/config_coding.html -->
+    <module name="ArrayTypeStyle"/>
+    <module name="EmptyStatement"/>
+    <module name="EqualsHashCode"/>
+    <module name="IllegalInstantiation"/>
+    <module name="InnerAssignment"/>
+    <module name="MissingSwitchDefault"/>
+    <module name="NoFinalizer"/>
+
+    <!-- Import Checks
+    http://checkstyle.sourceforge.net/config_imports.html -->
     <module name="AvoidStarImport"/>
+    <module name="ImportOrder">
+      <property name="groups" value="*,javax,java"/>
+      <property name="ordered" value="true"/>
+      <property name="separated" value="true"/>
+      <property name="option" value="bottom"/>
+      <property name="sortStaticImportsAlphabetically" value="true"/>
+    </module>
     <module name="RedundantImport"/>
     <module name="UnusedImports">
       <property name="processJavadoc" value="true"/>
     </module>
+
+    <!-- Javadoc Checks
+    http://checkstyle.sourceforge.net/config_javadoc.html -->
+    <module name="JavadocTagContinuationIndentation"/>
+    <module name="NonEmptyAtclauseDescription"/>
+
+    <!-- Miscellaneous Checks
+    http://checkstyle.sourceforge.net/config_misc.html -->
+    <module name="UpperEll"/>
+    <module name="Indentation">
+      <property name="basicOffset" value="2"/>
+      <property name="caseIndent" value="2"/>
+    </module>
+
+    <!-- Size Violation Checks
+    http://checkstyle.sourceforge.net/config_sizes.html -->
     <module name="LineLength">
       <property name="max" value="100"/>
       <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|org.apache.thrift.|com.google.protobuf.|hbase.protobuf.generated"/>
     </module>
     <module name="MethodLength"/>
+
+    <!-- Whitespace Checks
+    http://checkstyle.sourceforge.net/config_whitespace.html -->
     <module name="MethodParamPad"/>
     <module name="ParenPad"/>
-    <module name="EmptyStatement"/>
-    <module name="EmptyBlock"/>
-    <module name="EqualsHashCode"/>
-    <module name="IllegalInstantiation"/>
-    <module name="InnerAssignment"/>
-    <module name="MissingSwitchDefault"/>
-    <module name="FinalClass"/>
-    <module name="HideUtilityClassConstructor"/>
-    <module name="InterfaceIsType"/>
-    <module name="VisibilityModifier">
-      <property name="packageAllowed" value="true"/>
-      <property name="protectedAllowed" value="true"/>
-    </module>
-    <module name="ArrayTypeStyle"/>
-    <module name="UpperEll"/>
-    <module name="NoFinalizer"/>
-    <module name="MissingDeprecated"/>
   </module>
 </module>

http://git-wip-us.apache.org/repos/asf/hbase/blob/62aba61b/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index fa7400e..9cfb311 100644
--- a/pom.xml
+++ b/pom.xml
@@ -846,7 +846,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.16</version>
+          <version>2.17</version>
           <dependencies>
             <dependency>
               <groupId>org.apache.hbase</groupId>
@@ -2987,7 +2987,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.16</version>
+        <version>2.17</version>
         <configuration>
           <excludes>target/**</excludes>
           <configLocation>hbase/checkstyle.xml</configLocation>


Mime
View raw message