Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C87B918DFD for ; Mon, 12 Oct 2015 19:48:32 +0000 (UTC) Received: (qmail 60053 invoked by uid 500); 12 Oct 2015 19:48:16 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 60015 invoked by uid 500); 12 Oct 2015 19:48:16 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 60006 invoked by uid 99); 12 Oct 2015 19:48:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 19:48:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BAEB7E03EC; Mon, 12 Oct 2015 19:48:16 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: stack@apache.org To: commits@hbase.apache.org Message-Id: <4cdc9dc281874341bbb0a9fed75bf874@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-14582 Regionserver status webpage bucketcache list can become huge Date: Mon, 12 Oct 2015 19:48:16 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/branch-1.0 e42f46ab8 -> f824f61ed HBASE-14582 Regionserver status webpage bucketcache list can become huge Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/f824f61e Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/f824f61e Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/f824f61e Branch: refs/heads/branch-1.0 Commit: f824f61ed15778a47e661839d5a44e2e6eba007f Parents: e42f46a Author: stack Authored: Mon Oct 12 12:45:40 2015 -0700 Committer: stack Committed: Mon Oct 12 12:48:11 2015 -0700 ---------------------------------------------------------------------- .../tmpl/regionserver/BlockCacheTmpl.jamon | 22 -------------------- 1 file changed, 22 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/f824f61e/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon index 08e889e..9883848 100644 --- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon +++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon @@ -296,12 +296,10 @@ are combined counts. Request count is sum of hits and misses.

boolean bucketCache = bc.getClass().getSimpleName().equals("BucketCache"); BucketCacheStats bucketCacheStats = null; BucketAllocator bucketAllocator = null; - Bucket [] buckets = null; if (bucketCache) { bucketCacheStats = (BucketCacheStats)bc.getStats(); bucketAllocator = ((BucketCache)bc).getAllocator(); - buckets = bucketAllocator.getBuckets(); } <%if cbsbf.isFull() %> @@ -365,26 +363,6 @@ are combined counts. Request count is sum of hits and misses.

<%doc>Call through to block cache Detail rendering template

View block cache as JSON | Block cache as JSON by file

-<%if bucketCache %> -

BucketCache does not discern between DATA and META blocks so we do not show DATA counts (If deploy is using CombinedBlockCache, BucketCache is only DATA blocks

-

BucketCache Buckets

- - - - - - - -<%for Bucket bucket: buckets %> - - - - - - - -
Bucket OffsetAllocation SizeFree BytesUsed Bytes
<% bucket.getBaseOffset() %><% bucket.getItemAllocationSize() %><% bucket.getFreeBytes() %><% bucket.getUsedBytes() %>
- <%java> cbsbf = null;