hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject hbase git commit: HBASE-14582 Regionserver status webpage bucketcache list can become huge
Date Mon, 12 Oct 2015 19:46:32 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1.2 7e250ad45 -> 3627a1c1f


HBASE-14582 Regionserver status webpage bucketcache list can become huge


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3627a1c1
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3627a1c1
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3627a1c1

Branch: refs/heads/branch-1.2
Commit: 3627a1c1f90a962a1b93d045698cf8c4a70674b5
Parents: 7e250ad
Author: stack <stack@apache.org>
Authored: Mon Oct 12 12:45:40 2015 -0700
Committer: stack <stack@apache.org>
Committed: Mon Oct 12 12:46:26 2015 -0700

----------------------------------------------------------------------
 .../tmpl/regionserver/BlockCacheTmpl.jamon      | 22 --------------------
 1 file changed, 22 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/3627a1c1/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
index b13a1d9..6986f12 100644
--- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
+++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
@@ -304,12 +304,10 @@ are combined counts. Request count is sum of hits and misses.</p>
   boolean bucketCache = bc.getClass().getSimpleName().equals("BucketCache");
   BucketCacheStats bucketCacheStats = null;
   BucketAllocator bucketAllocator = null;
-  Bucket [] buckets = null;
 
   if (bucketCache) {
     bucketCacheStats = (BucketCacheStats)bc.getStats();
     bucketAllocator = ((BucketCache)bc).getAllocator();
-    buckets = bucketAllocator.getBuckets();
   }
 </%java>
 <%if cbsbf.isFull() %>
@@ -375,26 +373,6 @@ are combined counts. Request count is sum of hits and misses.</p>
 </table>
 <%doc>Call through to block cache Detail rendering template</%doc>
 <p>View block cache <a href="?format=json&bcn=<% name %>">as JSON</a>
| Block cache <a href="?format=json&bcn=<% name %>&bcv=file">as JSON by
file</a></p>
-<%if bucketCache %>
-<p>BucketCache does not discern between DATA and META blocks so we do not show DATA
counts (If deploy is using CombinedBlockCache, BucketCache is only DATA blocks</p>
-<h3>BucketCache Buckets</h3>
-<table class="table table-striped">
-    <tr>
-        <th>Bucket Offset</th>
-        <th>Allocation Size</th>
-        <th>Free Bytes</th>
-        <th>Used Bytes</th>
-    </tr>
-<%for Bucket bucket: buckets %>
-    <tr>
-        <td><% bucket.getBaseOffset() %></td>
-        <td><% bucket.getItemAllocationSize() %></td>
-        <td><% bucket.getFreeBytes() %></td>
-        <td><% bucket.getUsedBytes() %></td>
-    </tr>
-</%for>
-</table>
-</%if>
 <%java>
 cbsbf = null;
 </%java>


Mime
View raw message