hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject hbase git commit: Revert "HBASE-14361 Investigate unused connection objects"
Date Thu, 10 Sep 2015 21:17:44 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1 6c16d244b -> 66ed39241


Revert "HBASE-14361 Investigate unused connection objects"

This reverts commit 6c16d244bbe26716c1b5af9877a74e63ef16a0cc.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/66ed3924
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/66ed3924
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/66ed3924

Branch: refs/heads/branch-1
Commit: 66ed392412f5f55958b478433f3d431b9aa36907
Parents: 6c16d24
Author: stack <stack@apache.org>
Authored: Thu Sep 10 14:17:32 2015 -0700
Committer: stack <stack@apache.org>
Committed: Thu Sep 10 14:17:32 2015 -0700

----------------------------------------------------------------------
 .../hbase/replication/regionserver/ReplicationSink.java   | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/66ed3924/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
index 11019f6..7d47677 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
@@ -72,7 +72,7 @@ public class ReplicationSink {
 
   private static final Log LOG = LogFactory.getLog(ReplicationSink.class);
   private final Configuration conf;
-  private Connection sharedHtableCon;
+  private final Connection sharedHtableCon;
   private final MetricsSink metrics;
   private final AtomicLong totalReplicatedEdits = new AtomicLong();
 
@@ -88,6 +88,7 @@ public class ReplicationSink {
     this.conf = HBaseConfiguration.create(conf);
     decorateConf();
     this.metrics = new MetricsSink();
+    this.sharedHtableCon = ConnectionFactory.createConnection(this.conf);
   }
 
   /**
@@ -212,9 +213,7 @@ public class ReplicationSink {
    */
   public void stopReplicationSinkServices() {
     try {
-      if (this.sharedHtableCon != null) {
-        this.sharedHtableCon.close();
-      }
+      this.sharedHtableCon.close();
     } catch (IOException e) {
       LOG.warn("IOException while closing the connection", e); // ignoring as we are closing.
     }
@@ -233,9 +232,6 @@ public class ReplicationSink {
     }
     Table table = null;
     try {
-      if (this.sharedHtableCon == null) {
-        this.sharedHtableCon = ConnectionFactory.createConnection(this.conf);
-      }
       table = this.sharedHtableCon.getTable(tableName);
       for (List<Row> rows : allRows) {
         table.batch(rows);


Mime
View raw message