hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apurt...@apache.org
Subject [4/6] hbase git commit: HBASE-10844 Coprocessor failure during batchmutation leaves the memstore datastructs in an inconsistent state
Date Fri, 14 Aug 2015 23:07:35 GMT
HBASE-10844 Coprocessor failure during batchmutation leaves the memstore datastructs in an
inconsistent state

Signed-off-by: Andrew Purtell <apurtell@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e585cd8e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e585cd8e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e585cd8e

Branch: refs/heads/branch-1.1
Commit: e585cd8e18dd8d7f6b738bbad490222c3ab4fcbc
Parents: cadf432
Author: Nick Dimiduk <ndimiduk@apache.org>
Authored: Thu Aug 13 16:19:26 2015 -0700
Committer: Andrew Purtell <apurtell@apache.org>
Committed: Fri Aug 14 15:56:02 2015 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/regionserver/HRegion.java  | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/e585cd8e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
index 66f52dc..1605c6f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
@@ -1437,7 +1437,14 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver,
Regi
 
         // close each store in parallel
         for (final Store store : stores.values()) {
-          assert abort || store.getFlushableSize() == 0 || writestate.readOnly;
+          long flushableSize = store.getFlushableSize();
+          if (!(abort || flushableSize == 0 || writestate.readOnly)) {
+            getRegionServerServices().abort("Assertion failed while closing store "
+                + getRegionInfo().getRegionNameAsString() + " " + store
+                + ". flushableSize expected=0, actual= " + flushableSize
+                + ". Current memstoreSize=" + getMemstoreSize() + ". Maybe a coprocessor
"
+                + "operation failed and left the memstore in a partially updated state.",
null);
+          }
           completionService
               .submit(new Callable<Pair<byte[], Collection<StoreFile>>>()
{
                 @Override


Mime
View raw message