hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From te...@apache.org
Subject hbase git commit: HBASE-14310 test-patch.sh should handle spurious non-zero exit code from maven
Date Wed, 26 Aug 2015 16:37:42 GMT
Repository: hbase
Updated Branches:
  refs/heads/master ff86749ca -> aca8c3b74


HBASE-14310 test-patch.sh should handle spurious non-zero exit code from maven


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/aca8c3b7
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/aca8c3b7
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/aca8c3b7

Branch: refs/heads/master
Commit: aca8c3b74b09646c72c4e0fe26a4b2103da0d288
Parents: ff86749
Author: tedyu <yuzhihong@gmail.com>
Authored: Wed Aug 26 09:37:41 2015 -0700
Committer: tedyu <yuzhihong@gmail.com>
Committed: Wed Aug 26 09:37:41 2015 -0700

----------------------------------------------------------------------
 dev-support/test-patch.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/aca8c3b7/dev-support/test-patch.sh
----------------------------------------------------------------------
diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh
index 0b534034..33f84c5 100755
--- a/dev-support/test-patch.sh
+++ b/dev-support/test-patch.sh
@@ -335,10 +335,13 @@ setup () {
   $MVN clean package checkstyle:checkstyle-aggregate findbugs:findbugs -DskipTests \
 	 -D${PROJECT_NAME}PatchProcess > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
   if [[ $? != 0 ]] ; then
+    echo "mvn exit code was $?"
     ERR=`$GREP -A 5 'Compilation failure' $PATCH_DIR/trunkJavacWarnings.txt`
-    echo "Trunk compilation is broken?
-    {code}$ERR{code}"
-    cleanupAndExit 1
+    if [[ ${#ERR} -ge 1 ]] ; then
+      echo "Trunk compilation is broken?
+      {code}$ERR{code}"
+      cleanupAndExit 1
+    fi
   fi
   mv target/checkstyle-result.xml $PATCH_DIR/trunkCheckstyle.xml
   collectFindbugsReports trunk $BASEDIR $PATCH_DIR


Mime
View raw message