Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC475174D0 for ; Wed, 22 Jul 2015 19:52:43 +0000 (UTC) Received: (qmail 11287 invoked by uid 500); 22 Jul 2015 19:52:20 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 10801 invoked by uid 500); 22 Jul 2015 19:52:20 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 10223 invoked by uid 99); 22 Jul 2015 19:52:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 19:52:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DECBEE01FB; Wed, 22 Jul 2015 19:52:19 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jmhsieh@apache.org To: commits@hbase.apache.org Date: Wed, 22 Jul 2015 19:52:22 -0000 Message-Id: <747755b860c64f1291e3cb9d5497a45b@git.apache.org> In-Reply-To: <050e2ac5b877409d8887a2750c63a417@git.apache.org> References: <050e2ac5b877409d8887a2750c63a417@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [04/50] [abbrv] hbase git commit: HBASE-13277 add mob_threshold option to load test tool HBASE-13277 add mob_threshold option to load test tool Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/753ceb6e Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/753ceb6e Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/753ceb6e Branch: refs/heads/master Commit: 753ceb6e7641d2b5b2e32d51742bc5246aa48b90 Parents: aedd0eb Author: Jonathan M Hsieh Authored: Fri Mar 20 09:48:04 2015 -0700 Committer: Jonathan M Hsieh Committed: Fri Mar 20 09:48:04 2015 -0700 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/util/LoadTestTool.java | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/753ceb6e/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java index 90e07b3..33efe86 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java @@ -169,6 +169,10 @@ public class LoadTestTool extends AbstractHBaseTool { protected static final String OPT_REGION_REPLICA_ID_USAGE = "Region replica id to do the reads from"; + public static final String OPT_MOB_THRESHOLD = "mob_threshold"; + protected static final String OPT_MOB_THRESHOLD_USAGE = + "Desired cell size to exceed in bytes that will use the MOB write path"; + protected static final long DEFAULT_START_KEY = 0; /** This will be removed as we factor out the dependency on command line */ @@ -221,6 +225,8 @@ public class LoadTestTool extends AbstractHBaseTool { private int regionReplication = -1; // not set private int regionReplicaId = -1; // not set + private int mobThreshold = -1; // not set + // TODO: refactor LoadTestToolImpl somewhere to make the usage from tests less bad, // console tool itself should only be used from console. protected boolean isSkipInit = false; @@ -281,6 +287,10 @@ public class LoadTestTool extends AbstractHBaseTool { User.getCurrent().getShortName(), new SecretKeySpec(keyBytes, cipher.getName()))); } + if (mobThreshold >= 0) { + columnDesc.setMobEnabled(true); + columnDesc.setMobThreshold(mobThreshold); + } if (isNewCf) { admin.addColumn(tableName, columnDesc); } else { @@ -343,6 +353,7 @@ public class LoadTestTool extends AbstractHBaseTool { addOptWithArg(OPT_NUM_REGIONS_PER_SERVER, OPT_NUM_REGIONS_PER_SERVER_USAGE); addOptWithArg(OPT_REGION_REPLICATION, OPT_REGION_REPLICATION_USAGE); addOptWithArg(OPT_REGION_REPLICA_ID, OPT_REGION_REPLICA_ID_USAGE); + addOptWithArg(OPT_MOB_THRESHOLD, OPT_MOB_THRESHOLD_USAGE); } @Override @@ -401,6 +412,11 @@ public class LoadTestTool extends AbstractHBaseTool { isMultiPut = cmd.hasOption(OPT_MULTIPUT); + mobThreshold = -1; + if (cmd.hasOption(OPT_MOB_THRESHOLD)) { + mobThreshold = Integer.parseInt(cmd.getOptionValue(OPT_MOB_THRESHOLD)); + } + System.out.println("Multi-puts: " + isMultiPut); System.out.println("Columns per key: " + minColsPerKey + ".." + maxColsPerKey);