hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apurt...@apache.org
Subject [6/6] hbase git commit: HBASE-14042 Fix FATAL level logging in FSHLog where logged for non fatal exceptions
Date Thu, 09 Jul 2015 00:48:11 GMT
HBASE-14042 Fix FATAL level logging in FSHLog where logged for non fatal exceptions


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b51f980e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b51f980e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b51f980e

Branch: refs/heads/0.98
Commit: b51f980ee870c397a76a2429dacc69018c5a95b9
Parents: 64b33b8
Author: Andrew Purtell <apurtell@apache.org>
Authored: Wed Jul 8 17:39:10 2015 -0700
Committer: Andrew Purtell <apurtell@apache.org>
Committed: Wed Jul 8 17:39:10 2015 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/b51f980e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
index fad4d29..8941523 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
@@ -1242,7 +1242,7 @@ class FSHLog implements HLog, Syncable {
               // we need fail all the writes with txid <= txidToSync to avoid
               // 'data loss' where user get successful write response but can't
               // read the writes!
-              LOG.fatal("should never happen: has unsynced writes but writer is null!");
+              LOG.error("should never happen: has unsynced writes but writer is null!");
               asyncIOE = new IOException("has unsynced writes but writer is null!");
               failedTxid.set(this.txidToSync);
             } else {
@@ -1252,7 +1252,7 @@ class FSHLog implements HLog, Syncable {
             }
             postSync();
           } catch (IOException e) {
-            LOG.fatal("Error while AsyncSyncer sync, request close of hlog ", e);
+            LOG.warn("Error while AsyncSyncer sync, request close of hlog ", e);
             requestLogRoll();
 
             asyncIOE = e;
@@ -1529,7 +1529,7 @@ class FSHLog implements HLog, Syncable {
       }
       this.metrics.finishAppend(took, len);
     } catch (IOException e) {
-      LOG.fatal("Could not append. Requesting close of hlog", e);
+      LOG.warn("Could not append. Requesting close of hlog", e);
       requestLogRoll();
       throw e;
     }


Mime
View raw message