Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8995417B20 for ; Tue, 16 Jun 2015 02:31:31 +0000 (UTC) Received: (qmail 99239 invoked by uid 500); 16 Jun 2015 02:31:31 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 99198 invoked by uid 500); 16 Jun 2015 02:31:31 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 99189 invoked by uid 99); 16 Jun 2015 02:31:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2015 02:31:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 43483E33CA; Tue, 16 Jun 2015 02:31:31 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ndimiduk@apache.org To: commits@hbase.apache.org Message-Id: <2d52a34ff8764c43bb58a5dbc60d5c06@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-13821 WARN if hbase.bucketcache.percentage.in.combinedcache is set Date: Tue, 16 Jun 2015 02:31:31 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/branch-1.0 dfc3b956c -> bedbf4279 HBASE-13821 WARN if hbase.bucketcache.percentage.in.combinedcache is set Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/bedbf427 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/bedbf427 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/bedbf427 Branch: refs/heads/branch-1.0 Commit: bedbf4279c99ae97cba1fedfecc8ed604b91d7c9 Parents: dfc3b95 Author: Nick Dimiduk Authored: Mon Jun 15 18:07:40 2015 -0700 Committer: Nick Dimiduk Committed: Mon Jun 15 18:13:49 2015 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/bedbf427/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java index f212f14..d7159ab 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java @@ -491,6 +491,10 @@ public class CacheConfig { throw new IllegalStateException("bucketCacheSize <= 0; Check " + BUCKET_CACHE_SIZE_KEY + " setting and/or server java heap size"); } + if (c.get("hbase.bucketcache.percentage.in.combinedcache") != null) { + LOG.warn("Configuration 'hbase.bucketcache.percentage.in.combinedcache' is no longer " + + "respected. See comments in http://hbase.apache.org/book.html#_changes_of_note"); + } int writerThreads = c.getInt(BUCKET_CACHE_WRITER_THREADS_KEY, DEFAULT_BUCKET_CACHE_WRITER_THREADS); int writerQueueLen = c.getInt(BUCKET_CACHE_WRITER_QUEUE_KEY,