hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mberto...@apache.org
Subject [35/50] [abbrv] hbase git commit: HBASE-13722 Avoid non static method from BloomFilterUtil.
Date Thu, 21 May 2015 16:43:18 GMT
HBASE-13722 Avoid non static method from BloomFilterUtil.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/88f19ab6
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/88f19ab6
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/88f19ab6

Branch: refs/heads/hbase-12439
Commit: 88f19ab6979c7012c3dd22b2f45db9f746c7736d
Parents: 1fbde3a
Author: anoopsjohn <anoopsamjohn@gmail.com>
Authored: Wed May 20 22:18:45 2015 +0530
Committer: anoopsjohn <anoopsamjohn@gmail.com>
Committed: Wed May 20 22:18:45 2015 +0530

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/util/BloomFilterUtil.java | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/88f19ab6/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
index 29b08d2..ff08f4b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterUtil.java
@@ -27,7 +27,7 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience;
  * Utility methods related to BloomFilters 
  */
 @InterfaceAudience.Private
-public class BloomFilterUtil {
+public final class BloomFilterUtil {
 
   /** Record separator for the Bloom filter statistics human-readable string */
   public static final String STATS_RECORD_SEP = "; ";
@@ -54,6 +54,13 @@ public class BloomFilterUtil {
     (byte) 0x40,
     (byte) 0x80
   };
+
+  /**
+   * Private constructor to keep this class from being instantiated.
+   */
+  private BloomFilterUtil() {
+  }
+
   /**
    * @param maxKeys
    * @param errorRate
@@ -190,11 +197,6 @@ public class BloomFilterUtil {
     return contains(buf, offset, length, bloom);
   }
 
-  /** Should only be used in tests */
-  boolean contains(byte[] buf, ByteBuffer bloom) {
-    return contains(buf, 0, buf.length, bloom);
-  }
-
   public static boolean contains(byte[] buf, int offset, int length,
       ByteBuffer bloomBuf, int bloomOffset, int bloomSize, Hash hash,
       int hashCount) {


Mime
View raw message