Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3ADF7182B5 for ; Fri, 24 Apr 2015 20:42:17 +0000 (UTC) Received: (qmail 22363 invoked by uid 500); 24 Apr 2015 20:42:17 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 22320 invoked by uid 500); 24 Apr 2015 20:42:17 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 22310 invoked by uid 99); 24 Apr 2015 20:42:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2015 20:42:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F052FE0979; Fri, 24 Apr 2015 20:42:16 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: stack@apache.org To: commits@hbase.apache.org Message-Id: <7c71a3659ec14601b2957db354c75d38@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-13552 ChoreService shutdown message could be more informative (Jonathan Lawlor) Date: Fri, 24 Apr 2015 20:42:16 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/master b5fb861f7 -> 0415649f3 HBASE-13552 ChoreService shutdown message could be more informative (Jonathan Lawlor) Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0415649f Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0415649f Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0415649f Branch: refs/heads/master Commit: 0415649f3dda70aef9d7196987d341d11c5c1973 Parents: b5fb861 Author: stack Authored: Fri Apr 24 13:42:03 2015 -0700 Committer: stack Committed: Fri Apr 24 13:42:03 2015 -0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/hbase/ChoreService.java | 6 +++--- .../src/main/java/org/apache/hadoop/hbase/ScheduledChore.java | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/0415649f/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java ---------------------------------------------------------------------- diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java index 5e2e43e..17c75f8 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java @@ -21,7 +21,6 @@ package org.apache.hadoop.hbase; import java.util.ArrayList; import java.util.HashMap; import java.util.LinkedHashMap; -import java.util.List; import java.util.Map.Entry; import java.util.concurrent.ScheduledFuture; import java.util.concurrent.ScheduledThreadPoolExecutor; @@ -298,9 +297,10 @@ public class ChoreService implements ChoreServicer { * after this method has been called (i.e. future scheduling attempts will fail). */ public void shutdown() { - List ongoing = scheduler.shutdownNow(); + scheduler.shutdownNow(); if (LOG.isInfoEnabled()) { - LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + ongoing + " on shutdown"); + LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + scheduledChores.keySet() + + " on shutdown"); } cancelAllChores(true); scheduledChores.clear(); http://git-wip-us.apache.org/repos/asf/hbase/blob/0415649f/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java ---------------------------------------------------------------------- diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java index 16d080b..8670d60 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java @@ -338,4 +338,10 @@ public abstract class ScheduledChore implements Runnable { */ protected synchronized void cleanup() { } + + @Override + public String toString() { + return "[ScheduledChore: Name: " + getName() + " Period: " + getPeriod() + " Unit: " + + getTimeUnit() + "]"; + } }