Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C35F1755F for ; Sat, 28 Mar 2015 05:26:38 +0000 (UTC) Received: (qmail 77386 invoked by uid 500); 28 Mar 2015 05:26:37 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 77334 invoked by uid 500); 28 Mar 2015 05:26:37 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 77324 invoked by uid 99); 28 Mar 2015 05:26:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Mar 2015 05:26:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 63962E1836; Sat, 28 Mar 2015 05:26:37 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: apurtell@apache.org To: commits@hbase.apache.org Date: Sat, 28 Mar 2015 05:26:37 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] hbase git commit: Amend HBASE-13303 Fix size calculation of results on the region server Repository: hbase Updated Branches: refs/heads/branch-1 4bda365ab -> 7da7a77ff refs/heads/master 0a500e5d3 -> 5038fc76c Amend HBASE-13303 Fix size calculation of results on the region server Signed-off-by: Andrew Purtell Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/5038fc76 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/5038fc76 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/5038fc76 Branch: refs/heads/master Commit: 5038fc76c950029c78681dff816d7465f6acbb91 Parents: 0a500e5 Author: Jonathan Lawlor Authored: Thu Mar 26 15:54:38 2015 -0700 Committer: Andrew Purtell Committed: Fri Mar 27 22:11:30 2015 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/regionserver/HRegion.java | 2 +- .../java/org/apache/hadoop/hbase/regionserver/StoreScanner.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/5038fc76/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java index e390d6b..bd25a82 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -5663,7 +5663,7 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver { // long size = 0; for (Cell c : results) { - size += CellUtil.estimatedHeapSizeOf(c); + size += CellUtil.estimatedHeapSizeOfWithoutTags(c); } return size; http://git-wip-us.apache.org/repos/asf/hbase/blob/5038fc76/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java index 7ce4e0b..298d5bc 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java @@ -544,7 +544,7 @@ public class StoreScanner extends NonReversedNonLazyKeyValueScanner outResult.add(cell); count++; totalBytesRead += CellUtil.estimatedSerializedSizeOf(cell); - totalHeapSize += CellUtil.estimatedHeapSizeOf(cell); + totalHeapSize += CellUtil.estimatedHeapSizeOfWithoutTags(cell); if (totalBytesRead > maxRowSize) { throw new RowTooBigException("Max row size allowed: " + maxRowSize + ", but the row is bigger than that.");