Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0DC4310586 for ; Wed, 21 Jan 2015 20:31:05 +0000 (UTC) Received: (qmail 56872 invoked by uid 500); 21 Jan 2015 20:31:04 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 56827 invoked by uid 500); 21 Jan 2015 20:31:04 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 56818 invoked by uid 99); 21 Jan 2015 20:31:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Jan 2015 20:31:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 79271E03AB; Wed, 21 Jan 2015 20:31:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tedyu@apache.org To: commits@hbase.apache.org Message-Id: <4636d4d68f6c4a97a13fe192997e44a5@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: hbase git commit: HBASE-12886 Correct tag option name in PerformanceEvaluation (Jerry He) Date: Wed, 21 Jan 2015 20:31:04 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/master 9bdb81f0a -> e87a69d9c HBASE-12886 Correct tag option name in PerformanceEvaluation (Jerry He) Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e87a69d9 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e87a69d9 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e87a69d9 Branch: refs/heads/master Commit: e87a69d9c0237fb8b1f5a1f22f699e4cc83c61c4 Parents: 9bdb81f Author: tedyu Authored: Wed Jan 21 12:30:51 2015 -0800 Committer: tedyu Committed: Wed Jan 21 12:30:51 2015 -0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/PerformanceEvaluation.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/e87a69d9/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java index 52424b3..193b4ee 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java @@ -1789,7 +1789,7 @@ public class PerformanceEvaluation extends Configured implements Tool { continue; } - final String noOfTags = "--nooftags="; + final String noOfTags = "--numoftags="; if (cmd.startsWith(noOfTags)) { opts.noOfTags = Integer.parseInt(cmd.substring(noOfTags.length())); continue; @@ -1879,6 +1879,11 @@ public class PerformanceEvaluation extends Configured implements Tool { opts = calculateRowsAndSize(opts); break; } + + // Not matching any option or command. + System.err.println("Error: Wrong option or command: " + cmd); + args.add(cmd); + break; } return opts; } @@ -1916,10 +1921,11 @@ public class PerformanceEvaluation extends Configured implements Tool { argv.addAll(Arrays.asList(args)); TestOptions opts = parseOpts(argv); - // args remainting, print help and exit + // args remaining, print help and exit if (!argv.isEmpty()) { errCode = 0; printUsage(); + return errCode; } // must run at least 1 client