hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apurt...@apache.org
Subject [2/3] hbase git commit: HBASE-12461 FSVisitor logging is excessive (Nick Dimiduk)
Date Wed, 12 Nov 2014 18:42:19 GMT
HBASE-12461 FSVisitor logging is excessive (Nick Dimiduk)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/17a816a0
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/17a816a0
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/17a816a0

Branch: refs/heads/branch-1
Commit: 17a816a0f977dae958a005d0a35cf7361d6a44d2
Parents: 16decdc
Author: Andrew Purtell <apurtell@apache.org>
Authored: Wed Nov 12 10:21:02 2014 -0800
Committer: Andrew Purtell <apurtell@apache.org>
Committed: Wed Nov 12 10:24:04 2014 -0800

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/util/FSVisitor.java | 28 +++++++++++++++-----
 1 file changed, 21 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/17a816a0/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java
index 718b1a4..5e14db6 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java
@@ -73,7 +73,9 @@ public final class FSVisitor {
       final RegionVisitor visitor) throws IOException {
     FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs));
     if (regions == null) {
-      LOG.info("No regions under directory:" + tableDir);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("No regions under directory:" + tableDir);
+      }
       return;
     }
 
@@ -94,7 +96,9 @@ public final class FSVisitor {
       final StoreFileVisitor visitor) throws IOException {
     FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs));
     if (regions == null) {
-      LOG.info("No regions under directory:" + tableDir);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("No regions under directory:" + tableDir);
+      }
       return;
     }
 
@@ -115,7 +119,9 @@ public final class FSVisitor {
       final StoreFileVisitor visitor) throws IOException {
     FileStatus[] families = FSUtils.listStatus(fs, regionDir, new FSUtils.FamilyDirFilter(fs));
     if (families == null) {
-      LOG.info("No families under region directory:" + regionDir);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("No families under region directory:" + regionDir);
+      }
       return;
     }
 
@@ -127,7 +133,9 @@ public final class FSVisitor {
       // get all the storeFiles in the family
       FileStatus[] storeFiles = FSUtils.listStatus(fs, familyDir, fileFilter);
       if (storeFiles == null) {
-        LOG.debug("No hfiles found for family: " + familyDir + ", skipping.");
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("No hfiles found for family: " + familyDir + ", skipping.");
+        }
         continue;
       }
 
@@ -150,7 +158,9 @@ public final class FSVisitor {
       final FSVisitor.RecoveredEditsVisitor visitor) throws IOException {
     FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs));
     if (regions == null) {
-      LOG.info("No recoveredEdits regions under directory:" + tableDir);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("No recoveredEdits regions under directory:" + tableDir);
+      }
       return;
     }
 
@@ -194,7 +204,9 @@ public final class FSVisitor {
     Path logsDir = new Path(rootDir, HConstants.HREGION_LOGDIR_NAME);
     FileStatus[] logServerDirs = FSUtils.listStatus(fs, logsDir);
     if (logServerDirs == null) {
-      LOG.info("No logs under directory:" + logsDir);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("No logs under directory:" + logsDir);
+      }
       return;
     }
 
@@ -203,7 +215,9 @@ public final class FSVisitor {
 
       FileStatus[] hlogs = FSUtils.listStatus(fs, serverLogs.getPath());
       if (hlogs == null) {
-        LOG.debug("No hfiles found for server: " + serverName + ", skipping.");
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("No hfiles found for server: " + serverName + ", skipping.");
+        }
         continue;
       }
 


Mime
View raw message