Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2824A172E9 for ; Wed, 1 Oct 2014 21:11:57 +0000 (UTC) Received: (qmail 43900 invoked by uid 500); 1 Oct 2014 21:11:57 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 43856 invoked by uid 500); 1 Oct 2014 21:11:57 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 43847 invoked by uid 99); 1 Oct 2014 21:11:56 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 21:11:56 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 9F4A29C32C4; Wed, 1 Oct 2014 21:11:56 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: stack@apache.org To: commits@hbase.apache.org Message-Id: <1479387e57e849ff8521a0f0afd53224@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: HBASE-12130 HBASE-11980 calls hflush and hsync doing near double the syncing work Date: Wed, 1 Oct 2014 21:11:56 +0000 (UTC) Repository: hbase Updated Branches: refs/heads/master 915b33863 -> 0d45272e4 HBASE-12130 HBASE-11980 calls hflush and hsync doing near double the syncing work Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0d45272e Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0d45272e Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0d45272e Branch: refs/heads/master Commit: 0d45272e40ac0a87f7875811d3923f16cc2446c4 Parents: 915b338 Author: stack Authored: Wed Oct 1 14:11:48 2014 -0700 Committer: stack Committed: Wed Oct 1 14:11:48 2014 -0700 ---------------------------------------------------------------------- .../apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/0d45272e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java index 14ffa45..fe2eac9 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java @@ -163,8 +163,11 @@ public class ProtobufLogWriter extends WriterBase { @Override public void sync() throws IOException { try { + // This looks to be a noop but its what we have always done. Leaving for now. + this.output.flush(); + // TODO: Add in option to call hsync. See HBASE-5954 Allow proper fsync support for HBase + // this.output.hflush(); - this.output.hsync(); } catch (NullPointerException npe) { // Concurrent close... throw new IOException(npe);