hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jxi...@apache.org
Subject git commit: TestRegionServerNoMaster#testMultipleOpen is flaky after HBASE-11760
Date Thu, 30 Oct 2014 20:39:26 GMT
Repository: hbase
Updated Branches:
  refs/heads/master 9f4b6ac06 -> 7886c0b82


TestRegionServerNoMaster#testMultipleOpen is flaky after HBASE-11760


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7886c0b8
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7886c0b8
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7886c0b8

Branch: refs/heads/master
Commit: 7886c0b82f0be9ef6536b6972e4487c232aaa1e3
Parents: 9f4b6ac
Author: Esteban Gutierrez <esteban@cloudera.com>
Authored: Thu Oct 30 10:45:04 2014 -0700
Committer: Jimmy Xiang <jxiang@cloudera.com>
Committed: Thu Oct 30 13:38:56 2014 -0700

----------------------------------------------------------------------
 .../regionserver/TestRegionServerNoMaster.java  | 34 --------------------
 1 file changed, 34 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/7886c0b8/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
index 24d9dd4..65aed5b 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
@@ -212,40 +212,6 @@ public class TestRegionServerNoMaster {
     openRegion(HTU, getRS(), hri);
   }
 
-  /**
-   * Test that we can send multiple openRegion to the region server.
-   * This is used when:
-   * - there is a SocketTimeout: in this case, the master does not know if the region server
-   * received the request before the timeout.
-   * - We have a socket error during the operation: same stuff: we don't know
-   * - a master failover: if we find a znode in thz M_ZK_REGION_OFFLINE, we don't know if
-   * the region server has received the query or not. Only solution to be efficient: re-ask
-   * immediately.
-   */
-  @Test(timeout = 60000)
-  public void testMultipleOpen() throws Exception {
-
-    // We close
-    closeRegionNoZK();
-    checkRegionIsClosed(HTU, getRS(), hri);
-
-    // We're sending multiple requests in a row. The region server must handle this nicely.
-    for (int i = 0; i < 10; i++) {
-      AdminProtos.OpenRegionRequest orr = RequestConverter.buildOpenRegionRequest(
-        getRS().getServerName(), hri, null, null);
-      AdminProtos.OpenRegionResponse responseOpen = getRS().rpcServices.openRegion(null,
orr);
-      Assert.assertTrue(responseOpen.getOpeningStateCount() == 1);
-
-      AdminProtos.OpenRegionResponse.RegionOpeningState ors = responseOpen.getOpeningState(0);
-      Assert.assertTrue("request " + i + " failed",
-          ors.equals(AdminProtos.OpenRegionResponse.RegionOpeningState.OPENED) ||
-              ors.equals(AdminProtos.OpenRegionResponse.RegionOpeningState.ALREADY_OPENED)
-      );
-    }
-
-    checkRegionIsOpened(HTU, getRS(), hri);
-  }
-
   @Test(timeout = 60000)
   public void testMultipleCloseFromMaster() throws Exception {
     for (int i = 0; i < 10; i++) {


Mime
View raw message